Re: [PR] Custom configuration property reader for segment metadata files [pinot]

2024-03-03 Thread via GitHub
abhioncbr commented on code in PR #12440: URL: https://github.com/apache/pinot/pull/12440#discussion_r1509441264 ## pinot-spi/src/main/java/org/apache/pinot/spi/env/CommonsConfigurationUtils.java: ## @@ -287,4 +321,35 @@ private static PropertiesConfiguration createPropertiesCo

Re: [I] Seems text_match() function doesn't support search with '#' character [pinot]

2024-03-03 Thread via GitHub
Betternan commented on issue #12262: URL: https://github.com/apache/pinot/issues/12262#issuecomment-1975549039 @Jackie-Jiang , yes, the "tags" column has configured with text index. I tried the same syntax with you before I propose this issue, but seems it doesn't work. -- This is an aut

Re: [PR] replaced getServer with getServers [pinot]

2024-03-03 Thread via GitHub
codecov-commenter commented on PR #12545: URL: https://github.com/apache/pinot/pull/12545#issuecomment-1975311917 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12545?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[PR] replaced getServer with getServers [pinot]

2024-03-03 Thread via GitHub
robertzych opened a new pull request, #12545: URL: https://github.com/apache/pinot/pull/12545 To address the exception detailed in #12535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Potential bug fix for partial-upsert with sorted-indexes [pinot]

2024-03-03 Thread via GitHub
tibrewalpratik17 commented on code in PR #12544: URL: https://github.com/apache/pinot/pull/12544#discussion_r1510236537 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ## @@ -640,7 +640,10 @@ protected static It