xiangfu0 commented on code in PR #12325:
URL: https://github.com/apache/pinot/pull/12325#discussion_r1470713932
##
pinot-common/src/main/java/org/apache/pinot/common/utils/TlsUtils.java:
##
@@ -322,6 +351,119 @@ public static SslContext buildServerContext(TlsConfig
tlsConfig) {
codecov-commenter commented on PR #12334:
URL: https://github.com/apache/pinot/pull/12334#issuecomment-1916196203
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12334?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
itschrispeck commented on PR #12339:
URL: https://github.com/apache/pinot/pull/12339#issuecomment-1916097175
@siddharthteotia I'd appreciate your thoughts/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 1a82ba6fc6 Add CPU metrics for minion purge task (#
jackjlli merged PR #12337:
URL: https://github.com/apache/pinot/pull/12337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
codecov-commenter commented on PR #12339:
URL: https://github.com/apache/pinot/pull/12339#issuecomment-1916047706
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12339?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
9aman commented on code in PR #12334:
URL: https://github.com/apache/pinot/pull/12334#discussion_r1470555734
##
pinot-controller/src/main/java/org/apache/pinot/controller/util/ServerSegmentMetadataReader.java:
##
@@ -140,16 +143,17 @@ public TableMetadataInfo
getAggregatedTable
codecov-commenter commented on PR #12338:
URL: https://github.com/apache/pinot/pull/12338#issuecomment-1916010575
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12338?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
itschrispeck opened a new pull request, #12339:
URL: https://github.com/apache/pinot/pull/12339
**Motivation:**
Query performance against the Lucene index suffers when chaining multiple
`text_match` predicates together. Our users often programmatically generate
their queries, which exac
abhioncbr opened a new pull request, #12338:
URL: https://github.com/apache/pinot/pull/12338
As per the [issue](https://github.com/apache/pinot/issues/12190), added
pinot-error-code header in query response
--
This is an automated message from the Apache Git Service.
To respond to the
klsince commented on code in PR #12334:
URL: https://github.com/apache/pinot/pull/12334#discussion_r1470354363
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/models/DummyTableUpsertMetadataManager.java:
##
@@ -72,6 +73,11 @@ public PartitionUpsertMet
ege-st commented on code in PR #12334:
URL: https://github.com/apache/pinot/pull/12334#discussion_r1470236803
##
pinot-controller/src/main/java/org/apache/pinot/controller/util/ServerSegmentMetadataReader.java:
##
@@ -140,16 +143,17 @@ public TableMetadataInfo
getAggregatedTabl
codecov-commenter commented on PR #12337:
URL: https://github.com/apache/pinot/pull/12337#issuecomment-1915582148
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12337?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
ege-st commented on code in PR #12334:
URL: https://github.com/apache/pinot/pull/12334#discussion_r1470170103
##
pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java:
##
@@ -283,9 +284,17 @@ public String getSegmentMetadata(
}
}
+
xiangfu0 commented on PR #12334:
URL: https://github.com/apache/pinot/pull/12334#issuecomment-1915532893
What if there is discrepancy for partitions with multiple replicas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
floren06 commented on code in PR #12337:
URL: https://github.com/apache/pinot/pull/12337#discussion_r1470147981
##
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/purge/PurgeTaskExecutor.java:
##
@@ -30,20 +35,29 @@
jackjlli commented on code in PR #12337:
URL: https://github.com/apache/pinot/pull/12337#discussion_r1470118619
##
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/purge/PurgeTaskExecutor.java:
##
@@ -30,20 +35,29 @@
floren06 opened a new pull request, #12337:
URL: https://github.com/apache/pinot/pull/12337
Add CPU and Memory metrics for minion purge task, i.e. threadCpuTime and
ThreadAllocatedBytes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
This is an automated email from the ASF dual-hosted git repository.
snlee pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 6cc1915140 Add HttpHeaders in broker event listener requestContext
(#12258)
add e1d20d75d5 Making taskManager reso
snleee merged PR #12335:
URL: https://github.com/apache/pinot/pull/12335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apach
lnbest0707-uber opened a new pull request, #12336:
URL: https://github.com/apache/pinot/pull/12336
Summary:
Add metrics to monitor any segments running with only one replica. This
could help monitor the reliability risk, especially during real world node
replacement.
Reasons for n
swaminathanmanish commented on PR #12335:
URL: https://github.com/apache/pinot/pull/12335#issuecomment-1915295858
@snleee - Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
swaminathanmanish opened a new pull request, #12335:
URL: https://github.com/apache/pinot/pull/12335
**What's in the PR:**
UpsertTableIntegrationTest is a public class which has been extended to
implement custom tests with its own setUp() methods. (outside OSS). Making
minion resource ha
9aman opened a new pull request, #12334:
URL: https://github.com/apache/pinot/pull/12334
## Scope of the PR
Enhance **server and controller API** to return **partition to primary key
count** for realtime tables that have **upsert** enabled:
1. Server API: returns the map for all the pa
aadilkhalifa commented on issue #12299:
URL: https://github.com/apache/pinot/issues/12299#issuecomment-1915176702
Hey @xiangfu0. Can I take this up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
aadilkhalifa commented on code in PR #12293:
URL: https://github.com/apache/pinot/pull/12293#discussion_r1469882734
##
pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java:
##
@@ -271,6 +271,7 @@ public enum TransformFunctionType {
Operan
vrajat commented on PR #12157:
URL: https://github.com/apache/pinot/pull/12157#issuecomment-1914824597
@Jackie-Jiang @ege-st Can you please re-review this PR? The major changes
since the last changes are:
1. Cleaned up the check in `RealtimeSegmentDataManager` to reuse member
objects to
ankitsultana commented on issue #12190:
URL: https://github.com/apache/pinot/issues/12190#issuecomment-1914406101
Good catch. I think the broader issue is that we have two kinds of errors:
1. Ones where a non-200 status code is returned.
2. Ones where a 200 Status Code is returned.
tibrewalpratik17 commented on code in PR #12320:
URL: https://github.com/apache/pinot/pull/12320#discussion_r1469350003
##
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/realtimetoofflinesegments/RealtimeToOfflineSegmentsTa
KKcorps opened a new pull request, #12332:
URL: https://github.com/apache/pinot/pull/12332
Scheme property already has a default value of `http` when initialised. This
leads to a bug where we always ignore when a scheme is set using properties.
--
This is an automated message from the Apa
30 matches
Mail list logo
