Re: [I] The EXPR_MIN / EXPR_MAX function does not work properly. [pinot]

2024-01-04 Thread via GitHub
minwoo-jung commented on issue #12224: URL: https://github.com/apache/pinot/issues/12224#issuecomment-1878229417 @somandal Thank you for your quick reply. :) I will try adding the settings. I have an additional question. - Is it an intended guide that requires users to add t

Re: [I] The EXPR_MIN / EXPR_MAX function does not work properly. [pinot]

2024-01-04 Thread via GitHub
somandal commented on issue #12224: URL: https://github.com/apache/pinot/issues/12224#issuecomment-1878168304 yes only the broker one is enough -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] The EXPR_MIN / EXPR_MAX function does not work properly. [pinot]

2024-01-04 Thread via GitHub
somandal commented on issue #12224: URL: https://github.com/apache/pinot/issues/12224#issuecomment-1878143487 can you set: "pinot.broker.result.rewriter.class.names" to the value "org.apache.pinot.core.query.utils.rewriter.ParentAggregationResultRewriter" and try again? -- This is an aut

[I] The EXPR_MIN / EXPR_MAX function does not work properly. [pinot]

2024-01-04 Thread via GitHub
minwoo-jung opened a new issue, #12224: URL: https://github.com/apache/pinot/issues/12224 Hi, I am an open source [APM pinpoint](https://github.com/pinpoint-apm/pinpoint) developer. We are applying pinot to pinpoint and using it well to analyze our monitoring data. We will continue to a

[PR] Reduce Heap Usage of OnHeapStringDictionary [pinot]

2024-01-04 Thread via GitHub
vvivekiyer opened a new pull request, #12223: URL: https://github.com/apache/pinot/pull/12223 This PR corresponds to issue [12078](https://github.com/apache/pinot/issues/12078) - This is disabled by default. It can be enabled by adding the following config ` "fieldConfigList"

Re: [PR] Maintain pool selection for the minimizeDataMovement instance partition assignment strategy [pinot]

2024-01-04 Thread via GitHub
somandal commented on code in PR #11953: URL: https://github.com/apache/pinot/pull/11953#discussion_r1442339107 ## pinot-spi/src/main/java/org/apache/pinot/spi/utils/Pairs.java: ## @@ -79,13 +83,26 @@ public boolean equals(Object obj) { } public static class AscendingInt

Re: [I] Remove BOOLEAN data-type field check for deleteRecordColumn [pinot]

2024-01-04 Thread via GitHub
ankitsultana commented on issue #12217: URL: https://github.com/apache/pinot/issues/12217#issuecomment-1877951051 For context, we have some customers internally whose Kafka topics have string and int columns for indicating the deleted column field. Changing topic schema isn't trivial. We co

Re: [I] Remove BOOLEAN data-type field check for deleteRecordColumn [pinot]

2024-01-04 Thread via GitHub
navina commented on issue #12217: URL: https://github.com/apache/pinot/issues/12217#issuecomment-1877936672 > what's the motivation behind removing this check? the deleteRecordColumn should be a "system managed" column and thus setting it as boolean should be reasonable. unless this field c

Re: [PR] [multistage][feature] function registry unification [pinot]

2024-01-04 Thread via GitHub
walterddr commented on code in PR #12163: URL: https://github.com/apache/pinot/pull/12163#discussion_r1442371361 ## pinot-common/src/main/java/org/apache/pinot/common/function/sql/PinotOperatorTable.java: ## @@ -0,0 +1,101 @@ +/** + * Licensed to the Apache Software Foundation (

Re: [PR] [multistage][feature] function registry unification [pinot]

2024-01-04 Thread via GitHub
walterddr commented on code in PR #12163: URL: https://github.com/apache/pinot/pull/12163#discussion_r1442370706 ## pinot-common/src/main/java/org/apache/pinot/common/function/sql/PinotFunctionRegistry.java: ## @@ -0,0 +1,237 @@ +/** + * Licensed to the Apache Software Foundatio

Re: [PR] [minor] Handle NPE in controller SQL Resource [pinot]

2024-01-04 Thread via GitHub
walterddr commented on code in PR #12211: URL: https://github.com/apache/pinot/pull/12211#discussion_r1442365260 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java: ## @@ -108,6 +108,9 @@ public class PinotQueryResource { publi

Re: [PR] Consistency in API response for live broker [pinot]

2024-01-04 Thread via GitHub
walterddr commented on code in PR #12201: URL: https://github.com/apache/pinot/pull/12201#discussion_r1442360960 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRunningQueryResource.java: ## @@ -153,7 +154,8 @@ public Map> getRunningQueries(

Re: [I] PinotS3 : Connection Pool Shutdown after one hour on EKS on release-1.0.0 [pinot]

2024-01-04 Thread via GitHub
klsince commented on issue #11761: URL: https://github.com/apache/pinot/issues/11761#issuecomment-1877892747 Thanks for the fix and tests @abhijeetkushe closing the issue for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [I] PinotS3 : Connection Pool Shutdown after one hour on EKS on release-1.0.0 [pinot]

2024-01-04 Thread via GitHub
klsince closed issue #11761: PinotS3 : Connection Pool Shutdown after one hour on EKS on release-1.0.0 URL: https://github.com/apache/pinot/issues/11761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] create new default credential as attempt to fix the conn shutdown issue [pinot]

2024-01-04 Thread via GitHub
klsince commented on PR #12063: URL: https://github.com/apache/pinot/pull/12063#issuecomment-1877891343 closing this one, as fix was included in https://github.com/apache/pinot/pull/12221 (merged) -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] create new default credential as attempt to fix the conn shutdown issue [pinot]

2024-01-04 Thread via GitHub
klsince closed pull request #12063: create new default credential as attempt to fix the conn shutdown issue URL: https://github.com/apache/pinot/pull/12063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] 11761 - fix for connection pool error [pinot]

2024-01-04 Thread via GitHub
klsince merged PR #12221: URL: https://github.com/apache/pinot/pull/12221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

(pinot) branch master updated (8f5fa804cd -> 298e8d9191)

2024-01-04 Thread xbli
This is an automated email from the ASF dual-hosted git repository. xbli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 8f5fa804cd Add a 'lastUsed' option for resumeConsumption.consumeFrom (#12200) add 298e8d9191 Fix connection pool er

Re: [I] Remove BOOLEAN data-type field check for deleteRecordColumn [pinot]

2024-01-04 Thread via GitHub
walterddr commented on issue #12217: URL: https://github.com/apache/pinot/issues/12217#issuecomment-1877884983 what's the motivation behind removing this check? the deleteRecordColumn should be a "system managed" column and thus setting it as boolean should be reasonable. unless this field

Re: [I] Controller host parameter isn't work [pinot]

2024-01-04 Thread via GitHub
walterddr commented on issue #12209: URL: https://github.com/apache/pinot/issues/12209#issuecomment-1877880727 can you share the full command you used? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] Pulsar OAuth configuration is not used [pinot]

2024-01-04 Thread via GitHub
walterddr closed issue #12196: Pulsar OAuth configuration is not used URL: https://github.com/apache/pinot/issues/12196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [I] Pulsar OAuth configuration is not used [pinot]

2024-01-04 Thread via GitHub
walterddr commented on issue #12196: URL: https://github.com/apache/pinot/issues/12196#issuecomment-1877879697 closed via #12195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Remove enforcement of BOOLEAN data type from deleteRecordColumn [pinot]

2024-01-04 Thread via GitHub
codecov-commenter commented on PR #1: URL: https://github.com/apache/pinot/pull/1#issuecomment-1877872097 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/1?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [PR] 11761 - fix for connection pool error [pinot]

2024-01-04 Thread via GitHub
codecov-commenter commented on PR #12221: URL: https://github.com/apache/pinot/pull/12221#issuecomment-1877835889 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12221?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[PR] Remove enforcement of BOOLEAN data type from deleteRecordColumn [pinot]

2024-01-04 Thread via GitHub
tibrewalpratik17 opened a new pull request, #1: URL: https://github.com/apache/pinot/pull/1 Relates to #12217. This patch removes the criteria that `deleteRecordColumn` field should be of BOOLEAN data type thus allowing String based "true"/"false"/"0"/"1" to work or int based

Re: [I] PinotS3 : Connection Pool Shutdown after one hour on EKS on release-1.0.0 [pinot]

2024-01-04 Thread via GitHub
abhijeetkushe commented on issue #11761: URL: https://github.com/apache/pinot/issues/11761#issuecomment-1877810338 @klsince @Jackie-Jiang I have opened this PR https://github.com/apache/pinot/pull/12221 -- This is an automated message from the Apache Git Service. To respond to the messag

[PR] 11761 - fix for connection pool error [pinot]

2024-01-04 Thread via GitHub
abhijeetkushe opened a new pull request, #12221: URL: https://github.com/apache/pinot/pull/12221 Instructions: 1. The PR has to be tagged with at least one of the following labels (*): 1. `feature` 2. `bugfix` 3. `performance` 4. `ui` 5. `backward-incompat`

Re: [PR] [Work in progress]Reduce disk footprint for segment processor framework [pinot]

2024-01-04 Thread via GitHub
codecov-commenter commented on PR #12220: URL: https://github.com/apache/pinot/pull/12220#issuecomment-1877702781 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12220?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [I] PinotS3 : Connection Pool Shutdown after one hour on EKS on release-1.0.0 [pinot]

2024-01-04 Thread via GitHub
abhijeetkushe commented on issue #11761: URL: https://github.com/apache/pinot/issues/11761#issuecomment-1877672106 @klsince Thanks I will add that fix for all the plugins where I can find and test it out -- This is an automated message from the Apache Git Service. To respond to the messa

[PR] [Work in progress]Reduce disk footprint for segment processor framework [pinot]

2024-01-04 Thread via GitHub
aishikbh opened a new pull request, #12220: URL: https://github.com/apache/pinot/pull/12220 [WIP] more info will be added later. This generates segments based on specified threshold for intermediate file size in segmentprocessorframework rather than doing it in one step taking up a l

Re: [I] PinotS3 : Connection Pool Shutdown after one hour on EKS on release-1.0.0 [pinot]

2024-01-04 Thread via GitHub
klsince commented on issue #11761: URL: https://github.com/apache/pinot/issues/11761#issuecomment-1877530069 thanks for testing it out. and good catch for the other places. As you have env to test those out, please open a new PR include all the fixes on DefaultCredentialsProvider, in

Re: [I] Fix Memory Leak in Long-Running JDBC Clients Post-Certificate Rotation [pinot]

2024-01-04 Thread via GitHub
kay-owolabi commented on issue #12100: URL: https://github.com/apache/pinot/issues/12100#issuecomment-1877472887 @walterddr and @Jackie-Jiang I think issue [12107](https://github.com/apache/pinot/issues/12107) is related -- This is an automated message from the Apache Git Service. To resp

Re: [I] Text search on the dimension in star-tree [pinot]

2024-01-04 Thread via GitHub
zhuangdaz commented on issue #12219: URL: https://github.com/apache/pinot/issues/12219#issuecomment-1877468776 related to: https://github.com/apache/pinot/issues/8863 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

(pinot) branch master updated (d1cc17c579 -> 8f5fa804cd)

2024-01-04 Thread rongr
This is an automated email from the ASF dual-hosted git repository. rongr pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from d1cc17c579 [multistage][hotfix] use UTF-8 as default CharSet, this is also true for v1 engine (#12213) add 8f5fa80

Re: [PR] Add a 'lastUsed' option for resumeConsumption.consumeFrom [pinot]

2024-01-04 Thread via GitHub
walterddr merged PR #12200: URL: https://github.com/apache/pinot/pull/12200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

Re: [I] PinotS3 : Connection Pool Shutdown after one hour on EKS on release-1.0.0 [pinot]

2024-01-04 Thread via GitHub
abhijeetkushe commented on issue #11761: URL: https://github.com/apache/pinot/issues/11761#issuecomment-1877259658 @Jackie-Jiang I was successfully able to test the fix.Although in my case I am also using Kinsesis so I had to make the same change at this location as well https://github.com

Re: [PR] Fluent test framework [pinot]

2024-01-04 Thread via GitHub
codecov-commenter commented on PR #12215: URL: https://github.com/apache/pinot/pull/12215#issuecomment-1877022671 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12215?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

Re: [PR] Add the possibility of configuring ForwardIndexes with compressionCodec [pinot]

2024-01-04 Thread via GitHub
codecov-commenter commented on PR #12218: URL: https://github.com/apache/pinot/pull/12218#issuecomment-1876855007 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12218?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[PR] Add the possibility of configuring ForwardIndexes with compressionCodec [pinot]

2024-01-04 Thread via GitHub
gortiz opened a new pull request, #12218: URL: https://github.com/apache/pinot/pull/12218 This is a continuation on top of https://github.com/apache/pinot/pull/11993, which added a new configuration for forward indexes called `dictIdCompressionType`. In order to have more coherence, this PR

Re: [PR] Add a new MV forward index to only store unique MV values [pinot]

2024-01-04 Thread via GitHub
gortiz commented on PR #11993: URL: https://github.com/apache/pinot/pull/11993#issuecomment-1876803035 I've opened https://github.com/apache/pinot/pull/12218 in order to add the option to use `compressionCodec` in ForwardIndexTypeConfig. -- This is an automated message from the Apache Git

Re: [PR] Add a new MV forward index to only store unique MV values [pinot]

2024-01-04 Thread via GitHub
gortiz commented on PR #11993: URL: https://github.com/apache/pinot/pull/11993#issuecomment-1876750417 For coherence, shouldn't be this property part of the dictionary type config instead of forward dictionary config? Also for coherence as well: When using the older config style, we c