gortiz commented on code in PR #11960:
URL: https://github.com/apache/pinot/pull/11960#discussion_r1389039129
##
pinot-query-planner/src/test/java/org/apache/pinot/query/queries/ResourceBasedQueryPlansTest.java:
##
@@ -81,7 +83,7 @@ public void testQueryExplainPlansWithException
gortiz commented on code in PR #11960:
URL: https://github.com/apache/pinot/pull/11960#discussion_r1389035140
##
pinot-query-planner/src/main/java/org/apache/pinot/query/type/TypeFactory.java:
##
@@ -45,20 +46,36 @@ public TypeFactory(RelDataTypeSystem typeSystem) {
public
gortiz commented on code in PR #11960:
URL: https://github.com/apache/pinot/pull/11960#discussion_r1389027448
##
pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java:
##
@@ -520,14 +535,60 @@ public SchemaBuilder setSchemaName(String schemaName) {
return this;
codecov-commenter commented on PR #11984:
URL: https://github.com/apache/pinot/pull/11984#issuecomment-1804999234
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11984?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
abhioncbr opened a new pull request, #11985:
URL: https://github.com/apache/pinot/pull/11985
As per the [issue](https://github.com/apache/pinot/issues/11085) and in
continuation of the previous work https://github.com/apache/pinot/pull/11792,
https://github.com/apache/pinot/pull/11868,
htt
vvivekiyer commented on PR #11958:
URL: https://github.com/apache/pinot/pull/11958#issuecomment-1804973022
Query option override PR - https://github.com/apache/pinot/pull/11984
cc: @Jackie-Jiang
--
This is an automated message from the Apache Git Service.
To respond to the message
vvivekiyer opened a new pull request, #11984:
URL: https://github.com/apache/pinot/pull/11984
1. Added a queryOption override `minBrokerGroupTrimSize` for config
`pinot.broker.min.group.trim.size`
2. Reused the generic queryOption override `groupTrimThreshold` at the
broker reduce stage
vvivekiyer commented on PR #11958:
URL: https://github.com/apache/pinot/pull/11958#issuecomment-1804921278
@Jackie-Jiang sure, I'll create a PR to add queryOptions for the following
configs:
1. pinot.server.query.executor.groupby.trim.threshold
2. pinot.broker.min.group.trim.size
3.
Jackie-Jiang commented on PR #11958:
URL: https://github.com/apache/pinot/pull/11958#issuecomment-1804919974
@vvivekiyer Thanks for adding the documentation! Seems we still have some
configs not able to be overridden by query option, including this new added
one. Do you want to help contrib
ankitsultana commented on code in PR #11976:
URL: https://github.com/apache/pinot/pull/11976#discussion_r1388733745
##
pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotRelDistributionTraitRule.java:
##
@@ -0,0 +1,178 @@
+/**
+ * Licensed to the Apache Software
Jackie-Jiang commented on code in PR #11960:
URL: https://github.com/apache/pinot/pull/11960#discussion_r1388499295
##
pinot-spi/src/main/java/org/apache/pinot/spi/data/FieldSpec.java:
##
@@ -99,6 +100,7 @@ public abstract class FieldSpec implements
Comparable, Serializable {
Jackie-Jiang closed pull request #11981: Bump swagger.version from 1.6.9 to
1.6.12
URL: https://github.com/apache/pinot/pull/11981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 2beb9a4938 Bump commons-net:commons-net from 3.1
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/commons-net-commons-net-3.10.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 5c8f967c31 Bump commons-net:commons-net from 3.1 to 3.10.0
The revisions
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/maven/swagger.version-1.6.12
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 8aab41b5c0 Bump swagger.version from 1.6.9 to 1.6.12
The revisions that were on t
dependabot[bot] commented on PR #11981:
URL: https://github.com/apache/pinot/pull/11981#issuecomment-1804458392
OK, I won't notify you again about this release, but will get in touch when
a new version is available. You can also ignore all major, minor, or patch
releases for a dependency by
Jackie-Jiang merged PR #11982:
URL: https://github.com/apache/pinot/pull/11982
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
cbalci commented on PR #11951:
URL: https://github.com/apache/pinot/pull/11951#issuecomment-1804346237
Thanks @Jackie-Jiang !
>Please take a look at the test failure.
Fixed the test case to reflect the updated URL size limit. Though, I'm not
sure if this test serves a meaningfu
This is an automated email from the ASF dual-hosted git repository.
siddteotia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new bb52625f8a instrument building datatable (#11
siddharthteotia merged PR #11942:
URL: https://github.com/apache/pinot/pull/11942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pi
SabrinaZhaozyf commented on PR #11942:
URL: https://github.com/apache/pinot/pull/11942#issuecomment-1804276003
> Could you take a look at the tests? They are failing and the log size
looks pretty large, Maybe set the log level to info in the new tests?
The failed tests were due to a flaky
Jackie-Jiang commented on PR #11877:
URL: https://github.com/apache/pinot/pull/11877#issuecomment-1804272117
@tibrewalpratik17 Yes, this is the proposal. `addRecord` always return
whether the record is out-of-order, and the caller can decide how to handle it.
IMO this is a cleaner abstracti
codecov-commenter commented on PR #11983:
URL: https://github.com/apache/pinot/pull/11983#issuecomment-1804213057
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
rohityadav1993 opened a new pull request, #11983:
URL: https://github.com/apache/pinot/pull/11983
Instructions:
1. The PR has to be tagged with at least one of the following labels (*):
1. `feature`
2. `bugfix`
3. `performance`
4. `ui`
5. `backward-incompat`
walterddr commented on code in PR #11937:
URL: https://github.com/apache/pinot/pull/11937#discussion_r1388238978
##
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/server/ServerOpChainExecutionContext.java:
##
@@ -0,0 +1,86 @@
+/**
+ * Licensed to the Apach
jadami10 commented on code in PR #11943:
URL: https://github.com/apache/pinot/pull/11943#discussion_r1387995741
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##
@@ -518,40 +523,56 @@ private void commitSegm
codecov-commenter commented on PR #11982:
URL: https://github.com/apache/pinot/pull/11982#issuecomment-1803772297
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11982?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
codecov-commenter commented on PR #11981:
URL: https://github.com/apache/pinot/pull/11981#issuecomment-1803743883
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11981?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/commons-net-commons-net-3.9.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was f2a7ee45e2 Bump commons-net from 3.1 to 3.9.0
The revisions that were on
dependabot[bot] commented on PR #9913:
URL: https://github.com/apache/pinot/pull/9913#issuecomment-1803713612
Superseded by #11982.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
dependabot[bot] closed pull request #9913: Bump commons-net from 3.1 to 3.9.0
URL: https://github.com/apache/pinot/pull/9913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/commons-net-commons-net-3.10.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 5c8f967c31 Bump commons-net:commons-net from 3.1 to 3.10.0
No new revisi
dependabot[bot] opened a new pull request, #11982:
URL: https://github.com/apache/pinot/pull/11982
Bumps commons-net:commons-net from 3.1 to 3.10.0.
[ were added to refs/heads/master by this push:
new 10afb1a89d [enhance]: Add cache for Bcrypt passw
tibrewalpratik17 commented on PR #11877:
URL: https://github.com/apache/pinot/pull/11877#issuecomment-1803556807
> we can add the column value in MutableSegmentImpl similar to how we not
ingest the record.
For this, we will have to initialise upsert-related config
`_outOfOrderRecordC
tibrewalpratik17 commented on issue #11914:
URL: https://github.com/apache/pinot/issues/11914#issuecomment-1803543634
> Yes. We should support data ingestion to upsert table
Is the expectation here that we will perform updates to the uploaded segment
and validDocIDs should be pre-buil
40 matches
Mail list logo
