[pinot] branch master updated: Add integration test for rebalance in upsert tables (#11568)

2023-10-08 Thread kharekartik
This is an automated email from the ASF dual-hosted git repository. kharekartik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 52d16f7668 Add integration test for rebalanc

Re: [PR] Add integration test for rebalance in upsert tables [pinot]

2023-10-08 Thread via GitHub
KKcorps merged PR #11568: URL: https://github.com/apache/pinot/pull/11568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

Re: [PR] Add support to read exact buffer byte ranges corresponding to a given forward index doc id [pinot]

2023-10-08 Thread via GitHub
saurabhd336 commented on code in PR #11729: URL: https://github.com/apache/pinot/pull/11729#discussion_r1349889744 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/ForwardIndexReader.java: ## @@ -916,4 +916,83 @@ default byte[][] getBytesMV(int docId,

Re: [PR] Add support to read exact buffer byte ranges corresponding to a given forward index doc id [pinot]

2023-10-08 Thread via GitHub
saurabhd336 commented on code in PR #11729: URL: https://github.com/apache/pinot/pull/11729#discussion_r1349889095 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/ForwardIndexReader.java: ## @@ -916,4 +916,83 @@ default byte[][] getBytesMV(int docId,

Re: [PR] Add support to read exact buffer byte ranges corresponding to a given forward index doc id [pinot]

2023-10-08 Thread via GitHub
saurabhd336 commented on code in PR #11729: URL: https://github.com/apache/pinot/pull/11729#discussion_r1349887740 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/forward/VarByteChunkForwardIndexReaderV4.java: ## @@ -330,14 +371,37 @@ pr

Re: [PR] Add support to read exact buffer byte ranges corresponding to a given forward index doc id [pinot]

2023-10-08 Thread via GitHub
saurabhd336 commented on code in PR #11729: URL: https://github.com/apache/pinot/pull/11729#discussion_r1349861403 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/forward/ChunkReaderContext.java: ## @@ -56,6 +62,14 @@ public void setChun

Re: [PR] Add support to read exact buffer byte ranges corresponding to a given forward index doc id [pinot]

2023-10-08 Thread via GitHub
saurabhd336 commented on code in PR #11729: URL: https://github.com/apache/pinot/pull/11729#discussion_r1349859892 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/ForwardIndexReader.java: ## @@ -916,4 +916,83 @@ default byte[][] getBytesMV(int docId,

Re: [PR] Add support to read exact buffer byte ranges corresponding to a given forward index doc id [pinot]

2023-10-08 Thread via GitHub
saurabhd336 commented on code in PR #11729: URL: https://github.com/apache/pinot/pull/11729#discussion_r1349857148 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/forward/VarByteChunkForwardIndexReaderV4.java: ## @@ -271,10 +302,21 @@ pu

Re: [PR] Add support to read exact buffer byte ranges corresponding to a given forward index doc id [pinot]

2023-10-08 Thread via GitHub
saurabhd336 commented on code in PR #11729: URL: https://github.com/apache/pinot/pull/11729#discussion_r1349856661 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/forward/VarByteChunkSVForwardIndexReader.java: ## @@ -195,4 +212,61 @@ pri

[pinot] branch master updated: Fix trivy CI issue (#11757)

2023-10-08 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new a0964ecba4 Fix trivy CI issue (#11757) a0964ecba4

Re: [PR] Fix trivy CI issue [pinot]

2023-10-08 Thread via GitHub
Jackie-Jiang merged PR #11757: URL: https://github.com/apache/pinot/pull/11757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[I] PinotS3 : Connection Pool Shutdown after one hour on EKS on release-1.0.0 [pinot]

2023-10-08 Thread via GitHub
piby180 opened a new issue, #11761: URL: https://github.com/apache/pinot/issues/11761 We are currently facing the following exception in the controller pod ok EKS. The minion job SegmentGenerationAndPush works for one hour after controller pod restart and after that it doesn't work anymore

[I] [flaky test] Controller TableViewsTest [pinot]

2023-10-08 Thread via GitHub
xiangfu0 opened a new issue, #11760: URL: https://github.com/apache/pinot/issues/11760 https://github.com/apache/pinot/actions/runs/6430745125/job/17462295524?pr=11672 ``` 2023-10-06T11:28:21.9700794Z [ERROR] org.apache.pinot.controller.api.TableViewsTest.setUp -- Time elapsed: 4.

Re: [PR] Java 21 pipeline [pinot]

2023-10-08 Thread via GitHub
xiangfu0 commented on PR #11672: URL: https://github.com/apache/pinot/pull/11672#issuecomment-1752183275 > > I think we can just test the default byteBuffer usage. > > For the others, if you have good tests, we can just write a test suite for testing different behaviors to ensure the cove

Re: [PR] Upgrading Apache Helix to 1.3.1 version [pinot]

2023-10-08 Thread via GitHub
Jackie-Jiang merged PR #11754: URL: https://github.com/apache/pinot/pull/11754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[pinot] branch master updated (13c2901978 -> 24dba83421)

2023-10-08 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 13c2901978 update lombok version and config (#11742) add 24dba83421 Upgrading Apache Helix to 1.3.1 version (#1175

Re: [PR] Upgrading Apache Helix to 1.3.1 version [pinot]

2023-10-08 Thread via GitHub
Jackie-Jiang commented on code in PR #11754: URL: https://github.com/apache/pinot/pull/11754#discussion_r1349770634 ## LICENSE-binary: ## @@ -404,11 +404,11 @@ org.apache.flink:flink-shaded-netty:4.1.49.Final-12.0 org.apache.flink:flink-shaded-zookeeper-3:3.4.14-12.0 org.apach

Re: [PR] Upgrading Apache Helix to 1.3.1 version [pinot]

2023-10-08 Thread via GitHub
soumitra-st commented on code in PR #11754: URL: https://github.com/apache/pinot/pull/11754#discussion_r1349705529 ## LICENSE-binary: ## @@ -404,8 +404,7 @@ org.apache.flink:flink-shaded-netty:4.1.49.Final-12.0 org.apache.flink:flink-shaded-zookeeper-3:3.4.14-12.0 org.apache.f

Re: [PR] Fix literal type handling to be SQL compatible [pinot]

2023-10-08 Thread via GitHub
Jackie-Jiang commented on PR #11749: URL: https://github.com/apache/pinot/pull/11749#issuecomment-1751949084 This PR has become too large. Breaking this PR into smaller PRs and keep it for future reference: 1. Literal type handling 2. Broker side handling on expression format change