This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 1b94818311 Simplify kafka build and remove old kafka 0.9 files (#11638)
add bc07eb8e7f update maven-jar-plugin an
xiangfu0 merged PR #11637:
URL: https://github.com/apache/pinot/pull/11637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 1b94818311 Simplify kafka build and remove old k
xiangfu0 merged PR #11638:
URL: https://github.com/apache/pinot/pull/11638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
siddharthteotia commented on PR #11575:
URL: https://github.com/apache/pinot/pull/11575#issuecomment-1728711178
It looks like the "periodic" update is now done when channel is initialized
? If so, that is not enough imo to see the trend line and may give an outdated
picture ?
Possi
yupeng9 commented on code in PR #11604:
URL: https://github.com/apache/pinot/pull/11604#discussion_r1332380087
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/json/MutableJsonIndexImpl.java:
##
@@ -106,8 +106,11 @@ private void addFlattenedRecor
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 09c138503b Fix NPE in SingleColumnKeySelector (#1
Jackie-Jiang merged PR #11644:
URL: https://github.com/apache/pinot/pull/11644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on PR #11635:
URL: https://github.com/apache/pinot/pull/11635#issuecomment-1728676673
Hmm, do you want to allow pushing segments to a different table?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Jackie-Jiang commented on issue #10697:
URL: https://github.com/apache/pinot/issues/10697#issuecomment-1728675910
I feel we should just reject `NaN` for now. Dictionary binary search might
also fail.
To reject it, we can add a check in `FieldSpec.getDefaultNullValue()`, and
in the record
codecov-commenter commented on PR #11644:
URL: https://github.com/apache/pinot/pull/11644#issuecomment-1728675862
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11644?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
Jackie-Jiang commented on issue #10712:
URL: https://github.com/apache/pinot/issues/10712#issuecomment-1728669933
@egalpin To achieve that, we need to introduce logical table concept, where
one logical table can point to multiple physical tables. It is no longer a
simple alias (alias is one
Jackie-Jiang commented on code in PR #11590:
URL: https://github.com/apache/pinot/pull/11590#discussion_r1332365316
##
pinot-common/src/main/java/org/apache/pinot/common/utils/SegmentName.java:
##
@@ -18,80 +18,16 @@
*/
package org.apache.pinot.common.utils;
-public abstrac
Jackie-Jiang commented on PR #11568:
URL: https://github.com/apache/pinot/pull/11568#issuecomment-1728665255
@klsince Can you help review this test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
Jackie-Jiang commented on issue #11631:
URL: https://github.com/apache/pinot/issues/11631#issuecomment-1728662826
@jasperjiaguo Can you help take a look? Seems we are mix-using them in a lot
of places, even in the code
--
This is an automated message from the Apache Git Service.
To respon
Jackie-Jiang commented on issue #11622:
URL: https://github.com/apache/pinot/issues/11622#issuecomment-1728660555
Thanks for reporting this! Do you want to help contribute a fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Jackie-Jiang commented on code in PR #11604:
URL: https://github.com/apache/pinot/pull/11604#discussion_r1332359396
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/json/MutableJsonIndexImpl.java:
##
@@ -106,8 +106,11 @@ private void addFlattened
Jackie-Jiang commented on issue #11629:
URL: https://github.com/apache/pinot/issues/11629#issuecomment-1728657739
That involves some implementation details. If the `CAST` is applied to a
column (not aggregate function), it will be solved with
`CastTransformFunction`, where the return type c
Jackie-Jiang commented on PR #11555:
URL: https://github.com/apache/pinot/pull/11555#issuecomment-1728655545
@xiangfu0 there are still pending comments
@wirybeaver Can you address the pending comments in a separate PR?
--
This is an automated message from the Apache Git Service.
To
Jackie-Jiang commented on issue #11543:
URL: https://github.com/apache/pinot/issues/11543#issuecomment-1728653363
> Uff that is a very misleading parsing, specially given the fact that the
server knows that this field is a string: shouldn't the schema play a role
here? If I am filtering on
Jackie-Jiang opened a new pull request, #11644:
URL: https://github.com/apache/pinot/pull/11644
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new a96e36eecd Simplify authrozation for table config
Jackie-Jiang merged PR #11640:
URL: https://github.com/apache/pinot/pull/11640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
swaminathanmanish commented on PR #11643:
URL: https://github.com/apache/pinot/pull/11643#issuecomment-1728597573
This was created by mistake. Closing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
swaminathanmanish closed pull request #11643: 0.13.0 st.98.5
URL: https://github.com/apache/pinot/pull/11643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
swaminathanmanish opened a new pull request, #11643:
URL: https://github.com/apache/pinot/pull/11643
Instructions:
1. The PR has to be tagged with at least one of the following labels (*):
1. `feature`
2. `bugfix`
3. `performance`
4. `ui`
5. `backward-incompat
xiangfu0 commented on PR #11591:
URL: https://github.com/apache/pinot/pull/11591#issuecomment-1728564842
> > > I have a more general question on this PR. Should this PR not include
places in pinot-spi where we can throw exception if a client tries to create a
table config that does not have
codecov-commenter commented on PR #11640:
URL: https://github.com/apache/pinot/pull/11640#issuecomment-1728556445
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11640?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
xiangfu0 closed pull request #11641: Find next available port when start test
servers in ClusterTest
URL: https://github.com/apache/pinot/pull/11641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
adriens opened a new issue, #11642:
URL: https://github.com/apache/pinot/issues/11642
# :grey_question: About
I'm a [`endoflife.date`](https://endoflife.date/) contributor, and I wold
like to add Apache Pinot next to [Apacke
Kafka](https://endoflife.date/apache-kafka) to manage its m
xiangfu0 opened a new pull request, #11641:
URL: https://github.com/apache/pinot/pull/11641
https://github.com/apache/pinot/actions/runs/6254563237/job/16982357903?pr=11638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
Jackie-Jiang opened a new pull request, #11640:
URL: https://github.com/apache/pinot/pull/11640
Minor improvement on top of #11621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
codecov-commenter commented on PR #11638:
URL: https://github.com/apache/pinot/pull/11638#issuecomment-1728520584
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11638?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
Ferix9288 opened a new issue, #11639:
URL: https://github.com/apache/pinot/issues/11639
For us, we utilize UUIDs as Pinot table names. V1 engine works and supports
it just fine but looks like V2 crashes and burns with the following error:
```
[
{
"message": "SQLParsingE
codecov-commenter commented on PR #11637:
URL: https://github.com/apache/pinot/pull/11637#issuecomment-1728513437
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11637?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
Jackie-Jiang commented on code in PR #11258:
URL: https://github.com/apache/pinot/pull/11258#discussion_r1332240656
##
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeFunctions.java:
##
@@ -491,7 +492,7 @@ public static String[] toDateTimeMV(long[] mil
Jackie-Jiang commented on code in PR #11258:
URL: https://github.com/apache/pinot/pull/11258#discussion_r1332240383
##
pinot-common/src/main/java/org/apache/pinot/common/function/DateTimePatternHandler.java:
##
@@ -35,15 +35,23 @@ private DateTimePatternHandler() {
*/
pub
Jackie-Jiang commented on issue #11626:
URL: https://github.com/apache/pinot/issues/11626#issuecomment-1728502838
Is this metric emitted by Pinot or Helix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
xiangfu0 opened a new pull request, #11638:
URL: https://github.com/apache/pinot/pull/11638
1. Directly set `kafka.version` to 2.0
2. Remove kafka 0.9 related files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
xiangfu0 opened a new pull request, #11637:
URL: https://github.com/apache/pinot/pull/11637
Update `maven-jar-plugin` and `maven-enforcer-plugin` version across all the
components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
codecov-commenter commented on PR #11462:
URL: https://github.com/apache/pinot/pull/11462#issuecomment-1728456609
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11462?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
xiangfu0 commented on PR #4567:
URL: https://github.com/apache/pinot/pull/4567#issuecomment-172871
@jackjlli any reason we put this test in `pinot-integration-tests` module
but a different package?
--
This is an automated message from the Apache Git Service.
To respond to the message,
egalpin commented on issue #11464:
URL: https://github.com/apache/pinot/issues/11464#issuecomment-1728415468
Before and after using the above technique for a workload where every query
uses a date range filter:
https://github.com/apache/pinot/assets/7582748/91d0b10a-a886-4926-b459-a6b
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/pinot-site.git
The following commit(s) were added to refs/heads/dev by this push:
new ed868851 fixing marks url (#87)
ed868851 is descr
xiangfu0 merged PR #87:
URL: https://github.com/apache/pinot-site/pull/87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
deemoliu commented on code in PR #11346:
URL: https://github.com/apache/pinot/pull/11346#discussion_r1332156424
##
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountHLLPlusAggregationFunction.java:
##
@@ -0,0 +1,469 @@
+/**
+ * Licensed to th
hdulay commented on PR #87:
URL: https://github.com/apache/pinot-site/pull/87#issuecomment-1728385625
@mayankshriv
Can you approve and merge? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
ankitsultana opened a new issue, #11636:
URL: https://github.com/apache/pinot/issues/11636
For two of our use-cases we started seeing weird segment in error state
issues recently and on debugging we found that it is because of the fact that
uploading offline table segments concurrently acro
walterddr commented on PR #11611:
URL: https://github.com/apache/pinot/pull/11611#issuecomment-1728373116
> > do i need to do something to enable this? i compiled with latest
pinot-controller module and it is still showing plain exception without the
toggle
>
> It should work, can yo
walterddr commented on code in PR #11630:
URL: https://github.com/apache/pinot/pull/11630#discussion_r1332130606
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/plannode/JoinNode.java:
##
@@ -94,24 +92,24 @@ public T visit(PlanNodeVisitor visitor, C
context
walterddr commented on code in PR #11630:
URL: https://github.com/apache/pinot/pull/11630#discussion_r1332130606
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/plannode/JoinNode.java:
##
@@ -94,24 +92,24 @@ public T visit(PlanNodeVisitor visitor, C
context
walterddr commented on code in PR #11630:
URL: https://github.com/apache/pinot/pull/11630#discussion_r1332128451
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/partitioning/KeySelectorFactory.java:
##
@@ -0,0 +1,42 @@
+/**
+ * Licensed to the Apache Software
walterddr commented on code in PR #11630:
URL: https://github.com/apache/pinot/pull/11630#discussion_r1332127248
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/physical/colocated/GreedyShuffleRewriteVisitor.java:
##
@@ -190,23 +191,24 @@ public Set
visitMai
ankitsultana commented on issue #11633:
URL: https://github.com/apache/pinot/issues/11633#issuecomment-1728340732
@snleee : We had hit this exact issue and we just recently did this:
https://github.com/apache/pinot/pull/10815
Here's the sort of design doc I had raised a while back
ht
ankitsultana commented on PR #11625:
URL: https://github.com/apache/pinot/pull/11625#issuecomment-1728331278
@Jackie-Jiang : can you help run unit-tests on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
codecov-commenter commented on PR #11634:
URL: https://github.com/apache/pinot/pull/11634#issuecomment-1728330093
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11634?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
This is an automated email from the ASF dual-hosted git repository.
siddteotia pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 9bcbef80cc Handle interrupt gracefully for Lu
siddharthteotia merged PR #11558:
URL: https://github.com/apache/pinot/pull/11558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pi
hdulay opened a new pull request, #87:
URL: https://github.com/apache/pinot-site/pull/87
All of Mark Needham's profile URLs are wrong.
https://www.linkedin.com/in/markhneedham/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
walterddr opened a new pull request, #11635:
URL: https://github.com/apache/pinot/pull/11635
table name should not be derived from SegmentName.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
xiangfu0 opened a new pull request, #11634:
URL: https://github.com/apache/pinot/pull/11634
Split integration tests into two suites: `integration-suite-1` and
`integration-suite-2`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
jvenant commented on issue #10697:
URL: https://github.com/apache/pinot/issues/10697#issuecomment-1728195024
I think this bug can be very dangerous. Maybe waiting for a good NaN
management, we could reject schemas in case on NaN default...?
--
This is an automated message from the Apache
Jackie-Jiang commented on code in PR #11630:
URL: https://github.com/apache/pinot/pull/11630#discussion_r1331949272
##
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/physical/colocated/GreedyShuffleRewriteVisitor.java:
##
@@ -190,23 +191,24 @@ public Set
visit
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new f6cb672980 Optimize group-by and join for single
Jackie-Jiang merged PR #11630:
URL: https://github.com/apache/pinot/pull/11630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
walterddr commented on code in PR #11457:
URL: https://github.com/apache/pinot/pull/11457#discussion_r1331946223
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java:
##
@@ -529,6 +529,28 @@ public void testBase64Func()
walterddr commented on code in PR #11457:
URL: https://github.com/apache/pinot/pull/11457#discussion_r1331946223
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineIntegrationTest.java:
##
@@ -529,6 +529,28 @@ public void testBase64Func()
egalpin commented on issue #10712:
URL: https://github.com/apache/pinot/issues/10712#issuecomment-1727999407
@Jackie-Jiang do you think that it would be possible to use aliases to
support a use case like:
- There are 3 tables, each with a **different schema**
- Table1 has fields:
walterddr commented on code in PR #11590:
URL: https://github.com/apache/pinot/pull/11590#discussion_r1331862403
##
pinot-common/src/main/java/org/apache/pinot/common/utils/SegmentName.java:
##
@@ -18,80 +18,16 @@
*/
package org.apache.pinot.common.utils;
-public abstract c
gortiz commented on PR #11575:
URL: https://github.com/apache/pinot/pull/11575#issuecomment-1727986828
I think the issues were addressed. Are you ok merging this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
gortiz closed pull request #11538: DO NOT MERGE: Change notSupportedInV2 to
fail in order to have the actual pass rate
URL: https://github.com/apache/pinot/pull/11538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
mcvsubbu commented on PR #11591:
URL: https://github.com/apache/pinot/pull/11591#issuecomment-1727841062
> > I have a more general question on this PR. Should this PR not include
places in pinot-spi where we can throw exception if a client tries to create a
table config that does not have a
snleee opened a new issue, #11632:
URL: https://github.com/apache/pinot/issues/11632
while debugging some issue, we have observed that we can potentially create
a lot of threads for `IngestionDelayTimerThread`. It would be better if we can
cap this number.
