[GitHub] [pinot] codecov-commenter commented on pull request #11438: [multistage] Evaluate literal expression during query parsing

2023-08-24 Thread via GitHub
codecov-commenter commented on PR #11438: URL: https://github.com/apache/pinot/pull/11438#issuecomment-1692611128 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11438?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] codecov-commenter commented on pull request #11439: [Multi-stage] Remove PhysicalPlanContext and clean up op-chain executor logic

2023-08-24 Thread via GitHub
codecov-commenter commented on PR #11439: URL: https://github.com/apache/pinot/pull/11439#issuecomment-1692610640 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11439?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] Jackie-Jiang opened a new pull request, #11439: [Multi-stage] Remove PhysicalPlanContext and clean up op-chain executor logic

2023-08-24 Thread via GitHub
Jackie-Jiang opened a new pull request, #11439: URL: https://github.com/apache/pinot/pull/11439 - Remove PhysicalPlanContext and use OpChainExecutionContext instead - Add request metadata in OpChainExecutionContext - Clean up unused fields -- This is an automated message from the Apa

[GitHub] [pinot] xiangfu0 opened a new pull request, #11438: Evaluate literal expression during query parsing

2023-08-24 Thread via GitHub
xiangfu0 opened a new pull request, #11438: URL: https://github.com/apache/pinot/pull/11438 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [pinot] egalpin commented on issue #10712: Add support for table alias for ease of replacing a table

2023-08-24 Thread via GitHub
egalpin commented on issue #10712: URL: https://github.com/apache/pinot/issues/10712#issuecomment-1692546878 >Are you suggesting that we somehow map one logical table to multiple physical tables at the same time (perhaps the phys table name somehow chosen during query time). Or, are we sayi

[GitHub] [pinot] codecov-commenter commented on pull request #11437: Add broker query event listener

2023-08-24 Thread via GitHub
codecov-commenter commented on PR #11437: URL: https://github.com/apache/pinot/pull/11437#issuecomment-1692528770 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11437?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] jadami10 commented on a diff in pull request #11421: [logging] fix consume rate logging bug to respect 1 minute threshold

2023-08-24 Thread via GitHub
jadami10 commented on code in PR #11421: URL: https://github.com/apache/pinot/pull/11421#discussion_r1304955886 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java: ## @@ -1648,12 +1648,13 @@ private void updateCurrentDocumen

[GitHub] [pinot] tibrewalpratik17 opened a new pull request, #11437: Add broker query event listener

2023-08-24 Thread via GitHub
tibrewalpratik17 opened a new pull request, #11437: URL: https://github.com/apache/pinot/pull/11437 labels: - feature In #10606 we discussed adding the support for pluggable query event listener. This PR scaffolds the logic for that and is first among series of PRs. In this

[pinot] branch master updated: Add SchemaConformingTransformer to transform records with varying keys to fit a table's schema without dropping fields. (#11210)

2023-08-24 Thread tingchen
This is an automated email from the ASF dual-hosted git repository. tingchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new d91e5db76c Add SchemaConformingTransformer to t

[GitHub] [pinot] chenboat merged pull request #11210: Add SchemaConformingTransformer to transform records with varying keys to fit a table's schema without dropping fields.

2023-08-24 Thread via GitHub
chenboat merged PR #11210: URL: https://github.com/apache/pinot/pull/11210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11421: [logging] fix consume rate logging bug to respect 1 minute threshold

2023-08-24 Thread via GitHub
Jackie-Jiang commented on code in PR #11421: URL: https://github.com/apache/pinot/pull/11421#discussion_r1304835090 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java: ## @@ -1648,12 +1648,13 @@ private void updateCurrentDoc

[pinot] branch master updated (11276c6cd8 -> 37e70ecb77)

2023-08-24 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 11276c6cd8 [Multi-stage] Limit groups for group-by executor (#11424) add 37e70ecb77 [Multi-stage] Fix minor indent

[GitHub] [pinot] Jackie-Jiang merged pull request #11423: [Multi-stage] Fix minor indentation error for physical plan

2023-08-24 Thread via GitHub
Jackie-Jiang merged PR #11423: URL: https://github.com/apache/pinot/pull/11423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[pinot] branch master updated (c092b105e1 -> 11276c6cd8)

2023-08-24 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from c092b105e1 Fix a bug in SortOperator that prevents error block to be propogated (#11425) add 11276c6cd8 [Multi-st

[GitHub] [pinot] Jackie-Jiang merged pull request #11424: [Multi-stage] Limit groups for group-by executor

2023-08-24 Thread via GitHub
Jackie-Jiang merged PR #11424: URL: https://github.com/apache/pinot/pull/11424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] shwin opened a new issue, #11436: TEXT_CONTAINS does not match results where argument is in upper case

2023-08-24 Thread via GitHub
shwin opened a new issue, #11436: URL: https://github.com/apache/pinot/issues/11436 Let's say you have the following data: ``` col1 A ``` TEXT_CONTAINS("col1", 'A') will return false for this row. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pinot] Jackie-Jiang opened a new issue, #11435: [Flaky-test] TableCacheTest.testTableCache

2023-08-24 Thread via GitHub
Jackie-Jiang opened a new issue, #11435: URL: https://github.com/apache/pinot/issues/11435 Error: org.apache.pinot.controller.helix.TableCacheTest.testTableCache[false](2) Time elapsed: 0.024 s <<< FAILURE! org.apache.pinot.controller.api.exception.TableAlreadyExistsException: Extern

[GitHub] [pinot] codecov-commenter commented on pull request #11424: [Multi-stage] Limit groups for group-by executor

2023-08-24 Thread via GitHub
codecov-commenter commented on PR #11424: URL: https://github.com/apache/pinot/pull/11424#issuecomment-1692186132 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11424?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[pinot] branch master updated: Fix a bug in SortOperator that prevents error block to be propogated (#11425)

2023-08-24 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new c092b105e1 Fix a bug in SortOperator that prevent

[GitHub] [pinot] Jackie-Jiang merged pull request #11425: Fix a bug in SortOperator that prevents error block to be propogated

2023-08-24 Thread via GitHub
Jackie-Jiang merged PR #11425: URL: https://github.com/apache/pinot/pull/11425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[pinot-site] branch dev updated: fixed broken link in footer (#82)

2023-08-24 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/pinot-site.git The following commit(s) were added to refs/heads/dev by this push: new 07fd740 fixed broken link in footer (#82) 07fd740

[GitHub] [pinot-site] Jackie-Jiang merged pull request #82: fixed broken link in footer

2023-08-24 Thread via GitHub
Jackie-Jiang merged PR #82: URL: https://github.com/apache/pinot-site/pull/82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.

[GitHub] [pinot] eaugene commented on issue #11433: mvn clean install -DskipTests -Pbin-dist

2023-08-24 Thread via GitHub
eaugene commented on issue #11433: URL: https://github.com/apache/pinot/issues/11433#issuecomment-1692112985 Can you share which test is failing & possibly the stack trace as well ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [pinot] snleee opened a new issue, #11434: Add Gzip compression codec

2023-08-24 Thread via GitHub
snleee opened a new issue, #11434: URL: https://github.com/apache/pinot/issues/11434 In certain scenarios, gzip can be more storage efficient than other compression codec. We can add the support of gzip for raw forward index. Reference: https://github.com/apache/pinot/pull/7035

[GitHub] [pinot] jadami-stripe commented on a diff in pull request #9201: Emit metrics for ratio of actual consumption rate to rate limit in realtime tables

2023-08-24 Thread via GitHub
jadami-stripe commented on code in PR #9201: URL: https://github.com/apache/pinot/pull/9201#discussion_r1304549833 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeConsumptionRateManager.java: ## @@ -126,14 +137,17 @@ public interface ConsumptionRa

[GitHub] [pinot] araghavendra16 opened a new issue, #11433: mvn clean install -DskipTests -Pbin-dist

2023-08-24 Thread via GitHub
araghavendra16 opened a new issue, #11433: URL: https://github.com/apache/pinot/issues/11433 ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test (default-test) on project pinot-spi: There are test failures. [ERROR] [ERROR] Please refer to /home/

[GitHub] [pinot] TanmayKedari commented on pull request #10230: Fix the issue with ADLSGen2 connector when writing a file

2023-08-24 Thread via GitHub
TanmayKedari commented on PR #10230: URL: https://github.com/apache/pinot/pull/10230#issuecomment-1691660686 In which Version was this issue fixed, started facing the issue again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [pinot] eaugene opened a new issue, #11432: mBean : AlreadyExistingInstance in kafka Consumer

2023-08-24 Thread via GitHub
eaugene opened a new issue, #11432: URL: https://github.com/apache/pinot/issues/11432 Happens in 2 places : 1. **Server :** We have 2 consumers ( each for different purpose ) created one after the another with the same client ID - [https://github.com/apache/pinot/blob/master/pinot-core/s

[GitHub] [pinot] codecov-commenter commented on pull request #11431: Replicate a test that fail with multistage

2023-08-24 Thread via GitHub
codecov-commenter commented on PR #11431: URL: https://github.com/apache/pinot/pull/11431#issuecomment-1691487818 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11431?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] gortiz opened a new pull request, #11431: Replicate a test that fail with multistage

2023-08-24 Thread via GitHub
gortiz opened a new pull request, #11431: URL: https://github.com/apache/pinot/pull/11431 This PR adds a new test method in OfflineClusterIntegrationTest that seems to find a bug in how schemes are resolved in multiStage -- This is an automated message from the Apache Git Service. To resp

[GitHub] [pinot] codecov-commenter commented on pull request #11430: Preload test fix

2023-08-24 Thread via GitHub
codecov-commenter commented on PR #11430: URL: https://github.com/apache/pinot/pull/11430#issuecomment-1691396086 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11430?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] codecov-commenter commented on pull request #11427: Test OfflineClusterIntegrationTest.testDistinctCountHll in both engines

2023-08-24 Thread via GitHub
codecov-commenter commented on PR #11427: URL: https://github.com/apache/pinot/pull/11427#issuecomment-1691394619 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11427?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] codecov-commenter commented on pull request #11429: Test OfflineClusterIntegrationTest.testStarTreeTriggering in both engines

2023-08-24 Thread via GitHub
codecov-commenter commented on PR #11429: URL: https://github.com/apache/pinot/pull/11429#issuecomment-1691392669 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11429?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] KKcorps opened a new pull request, #11430: Preload test fix

2023-08-24 Thread via GitHub
KKcorps opened a new pull request, #11430: URL: https://github.com/apache/pinot/pull/11430 Currently in the test we do not check if all segments even have a valid doc id or not and simply check that all segments should have a snapshot. This fixes the issue to only ensure the number of

[GitHub] [pinot] gortiz opened a new pull request, #11429: Test OfflineClusterIntegrationTest.testStarTreeTriggering in both engines

2023-08-24 Thread via GitHub
gortiz opened a new pull request, #11429: URL: https://github.com/apache/pinot/pull/11429 This PR executes OfflineClusterIntegrationTest.testStarTreeTriggering in both single and multi stage query engine. This test seems to be failing -- This is an automated message from the Apache

[GitHub] [pinot] floscha opened a new pull request, #11428: Use fromValue instead of valueOf to parse sse config

2023-08-24 Thread via GitHub
floscha opened a new pull request, #11428: URL: https://github.com/apache/pinot/pull/11428 This PR fixed the bug reported in https://github.com/apache/pinot/issues/7596 which prevents users from specifying `aws:kms` as an SSE option. -- This is an automated message from the Apache Git Se

[GitHub] [pinot] gortiz opened a new pull request, #11427: Test OfflineClusterIntegrationTest.testDistinctCountHll in both engines

2023-08-24 Thread via GitHub
gortiz opened a new pull request, #11427: URL: https://github.com/apache/pinot/pull/11427 This PR executes OfflineClusterIntegrationTest.testDistinctCountHll in both single and multi stage query engine. This test seems to be failing -- This is an automated message from the Apache

[GitHub] [pinot] codecov-commenter commented on pull request #11425: Fix a bug in SortOperator that prevents error block to be propogated

2023-08-24 Thread via GitHub
codecov-commenter commented on PR #11425: URL: https://github.com/apache/pinot/pull/11425#issuecomment-1691210026 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11425?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] Jackie-Jiang opened a new issue, #11426: [Flaky-test] QueryLoggerTest.shouldHandleRaceConditionsWithDroppedQueries

2023-08-24 Thread via GitHub
Jackie-Jiang opened a new issue, #11426: URL: https://github.com/apache/pinot/issues/11426 Error: Failures: Error:QueryLoggerTest.shouldHandleRaceConditionsWithDroppedQueries:239 expected [1] but found [2] -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [pinot] Jackie-Jiang opened a new pull request, #11425: Fix a bug in SortOperator that prevents error block to be propogated

2023-08-24 Thread via GitHub
Jackie-Jiang opened a new pull request, #11425: URL: https://github.com/apache/pinot/pull/11425 This bug will cause a new exception, thus overriding the original exception -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [pinot] Jackie-Jiang opened a new pull request, #11424: [Multi-stage] Limit groups for group-by executor

2023-08-24 Thread via GitHub
Jackie-Jiang opened a new pull request, #11424: URL: https://github.com/apache/pinot/pull/11424 - Fix the exception when intermediate group-by executor reaches the groups limit (100K currently) - Honor the groups limit and stop adding new keys when the limit is hit - Return an exceptio