[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11016: Rbac impl

Jackie-Jiang commented on code in PR #11016: URL: https://github.com/apache/pinot/pull/11016#discussion_r1273028597 ## pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerDebug.java: ## @@ -129,6 +134,7 @@ public Map>> getRoutingTable( @GET @Produc

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10990: Updated code for setting value of segment min/max property.

Jackie-Jiang commented on code in PR #10990: URL: https://github.com/apache/pinot/pull/10990#discussion_r1273020617 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java: ## @@ -619,4 +645,57 @@ public void clos

[pinot] branch master updated: Increment nextDocId even if geo indexing fails (#11158)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 7231ecfee8 Increment nextDocId even if geo indexi

[GitHub] [pinot] Jackie-Jiang merged pull request #11158: Increment nextDocId even if geo indexing fails

Jackie-Jiang merged PR #11158: URL: https://github.com/apache/pinot/pull/11158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] Jackie-Jiang commented on pull request #11160: Add Integration test for Upsert Preload

Jackie-Jiang commented on PR #11160: URL: https://github.com/apache/pinot/pull/11160#issuecomment-1649149047 Please take a look at the failed test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11017: Remove support for High level consumers in Apache Pinot

Jackie-Jiang commented on code in PR #11017: URL: https://github.com/apache/pinot/pull/11017#discussion_r1273003693 ## pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java: ## @@ -501,6 +494,28 @@ protected void configure() { LOGGER.info("

[pinot] branch master updated: Support sum precision (#11162)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new a7530255d4 Support sum precision (#11162) a75302

[GitHub] [pinot] xiangfu0 merged pull request #11162: [multistage] Support SumPrecision Aggregation function

xiangfu0 merged PR #11162: URL: https://github.com/apache/pinot/pull/11162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[GitHub] [pinot] robertzych commented on a diff in pull request #10463: Segment compaction for upsert real-time tables

robertzych commented on code in PR #10463: URL: https://github.com/apache/pinot/pull/10463#discussion_r1272974740 ## pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java: ## @@ -427,7 +427,7 @@ public Response downloadSegment( public Response d

[GitHub] [pinot] Jackie-Jiang commented on issue #11168: [multistage][agg] count(*) return final result on leaf causes compilation error

Jackie-Jiang commented on issue #11168: URL: https://github.com/apache/pinot/issues/11168#issuecomment-1649038335 In `RequestContextUtils` line 94-95 I can see a TODO to handle count without argument. I think we should just add the dummy `*` in leaf stage so that the format is the same as v

[GitHub] [pinot] walterddr commented on issue #11168: [multistage][agg] count(*) return final result on leaf causes compilation error

walterddr commented on issue #11168: URL: https://github.com/apache/pinot/issues/11168#issuecomment-1648998001 CC @Jackie-Jiang @shenyu0127 @vvivekiyer basically this unfortunate error only occurs if v2 engine compiles count(*) and at the same time order by (SortNode) gets push down to l

[GitHub] [pinot] walterddr opened a new issue, #11168: [multistage][agg] count(*) return final result on leaf causes compilation error

walterddr opened a new issue, #11168: URL: https://github.com/apache/pinot/issues/11168 ``` select /*+ aggOptions(is_partitioned_by_group_by_keys = 'true') */ AirlineID, count(*) from airlineStats group by 1 order by 2 ``` causes error b/c directly the `order by` operati

[GitHub] [pinot] walterddr opened a new issue, #11167: [multistage] physical plan compile error not piped back to broker

walterddr opened a new issue, #11167: URL: https://github.com/apache/pinot/issues/11167 see: https://github.com/apache/pinot/commit/5ee6e137c02e3e0a149a7c44dd6a9f5deb29cb5d#r122582307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [pinot] xiangfu0 commented on pull request #11117: [multistage] bridge v2 query engine for leaf stage v1 multi-value column

xiangfu0 commented on PR #7: URL: https://github.com/apache/pinot/pull/7#issuecomment-1648941009 rebase to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [pinot] INNOCENT-BOY commented on pull request #8314: Access Control management Development

INNOCENT-BOY commented on PR #8314: URL: https://github.com/apache/pinot/pull/8314#issuecomment-1648895474 Hi @Jackie-Jiang , I have written the document about ZKBasicAuthAccessControl and submitted a pull request https://github.com/pinot-contrib/pinot-docs/pull/221, Please to review it.

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11166: Fix the issue of consuming segment entering ERROR state due to stream connection errors

Jackie-Jiang commented on code in PR #11166: URL: https://github.com/apache/pinot/pull/11166#discussion_r1272916639 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java: ## @@ -234,7 +234,7 @@ public void deleteSegmentFile() {

[GitHub] [pinot] Jackie-Jiang commented on pull request #11163: Simplify compatibility verifier to avoid test against same commit hash

Jackie-Jiang commented on PR #11163: URL: https://github.com/apache/pinot/pull/11163#issuecomment-1648835505 Seems you also fixed the disk usage issue in this PR. Can you update the PR title and description to reflect that? -- This is an automated message from the Apache Git Service. To r

[GitHub] [pinot] codecov-commenter commented on pull request #11166: Fix the issue of consuming segment entering ERROR state due to stream connection errors

codecov-commenter commented on PR #11166: URL: https://github.com/apache/pinot/pull/11166#issuecomment-1648834252 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11166?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10463: Segment compaction for upsert real-time tables

Jackie-Jiang commented on code in PR #10463: URL: https://github.com/apache/pinot/pull/10463#discussion_r1272902685 ## pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompaction/UpsertCompactionTaskGenerator.java:

[pinot] branch master updated: Simplify compatible test to avoid test against itself (#11163)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 6fa8cab1e0 Simplify compatible test to avoid tes

[GitHub] [pinot] xiangfu0 merged pull request #11163: Simplify compatibility verifier to avoid test against same commit hash

xiangfu0 merged PR #11163: URL: https://github.com/apache/pinot/pull/11163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[pinot] branch master updated (06d8540378 -> 1d61fc2845)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 06d8540378 For table rebalance, check if instances are equal for NO_OP (#11073) add 1d61fc2845 Make interface me

[GitHub] [pinot] Jackie-Jiang merged pull request #11164: Make interface methods non private, for java 8 compatibility

Jackie-Jiang merged PR #11164: URL: https://github.com/apache/pinot/pull/11164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] Jackie-Jiang merged pull request #11073: For table rebalance, check if instances are equal for NO_OP

Jackie-Jiang merged PR #11073: URL: https://github.com/apache/pinot/pull/11073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[pinot] branch master updated: For table rebalance, check if instances are equal for NO_OP (#11073)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 06d8540378 For table rebalance, check if instance

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11073: For table rebalance, check if instances are equal for NO_OP

Jackie-Jiang commented on code in PR #11073: URL: https://github.com/apache/pinot/pull/11073#discussion_r1272896552 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancerClusterStatelessTest.java: ## @@ -246,19 +246,19 @@ public void t

[GitHub] [pinot] sajjad-moradi opened a new pull request, #11166: Fix the issue of consuming segment entering ERROR state due to stream connection errors

sajjad-moradi opened a new pull request, #11166: URL: https://github.com/apache/pinot/pull/11166 ## Description This PR fixes the issue described in #11165 by moving any stream interactions out of the OFFLINE to CONSUMING transition handling. ## Testing Done Ran an integrati

[GitHub] [pinot] sajjad-moradi opened a new issue, #11165: Consuming segment should not go to ERROR state in External View because of stream connection errors

sajjad-moradi opened a new issue, #11165: URL: https://github.com/apache/pinot/issues/11165 ## Background In the event of consumption issues, a consuming segment sends a "stopped consumption" message to the controller, which then marks that consuming segment as OFFLINE in the Ideal State

[GitHub] [pinot] codecov-commenter commented on pull request #11164: Make interface methods non private, for java 8 compatibility

codecov-commenter commented on PR #11164: URL: https://github.com/apache/pinot/pull/11164#issuecomment-1648804652 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11164?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] walterddr merged pull request #11143: [multistage] Register theta sketch aggregation functions in v2 query engine

walterddr merged PR #11143: URL: https://github.com/apache/pinot/pull/11143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

[pinot] branch master updated: [multistage] Register theta sketch aggregation functions in v2 query engine (#11143)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new ff6d527fbf [multistage] Register theta sketch aggr

[GitHub] [pinot] PrachiKhobragade opened a new pull request, #11164: Make interface methods non private, for java 8 compatibility

PrachiKhobragade opened a new pull request, #11164: URL: https://github.com/apache/pinot/pull/11164 Instructions: `backward-incompat` `bugfix` The private methods from PulsarMetadataExtractor cause java 8 build failures, removed the private modifier, and verified the build passes --

[pinot] branch master updated: [multistage] support physical plan in Explain queries (#11052)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 4135e07220 [multistage] support physical plan in E

[GitHub] [pinot] walterddr merged pull request #11052: [multistage] support physical plan in Explain queries

walterddr merged PR #11052: URL: https://github.com/apache/pinot/pull/11052 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

[GitHub] [pinot] codecov-commenter commented on pull request #11163: Simplify compatibility verifier to avoid test against same commit hash

codecov-commenter commented on PR #11163: URL: https://github.com/apache/pinot/pull/11163#issuecomment-1648690273 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11163?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] mayankshriv commented on issue #5246: Pagination Support

mayankshriv commented on issue #5246: URL: https://github.com/apache/pinot/issues/5246#issuecomment-1648623452 Hey @siddharthteotia any update on this feature? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [pinot] xiangfu0 opened a new pull request, #11163: Simplify compatibility verifier to avoid test against itself

xiangfu0 opened a new pull request, #11163: URL: https://github.com/apache/pinot/pull/11163 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [pinot] ankitsultana commented on issue #10392: [multistage] Filter Clause Not Pushed Down In Some Join Queries

ankitsultana commented on issue #10392: URL: https://github.com/apache/pinot/issues/10392#issuecomment-1648595685 This was fixed by #10409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [pinot] ankitsultana closed issue #10392: [multistage] Filter Clause Not Pushed Down In Some Join Queries

ankitsultana closed issue #10392: [multistage] Filter Clause Not Pushed Down In Some Join Queries URL: https://github.com/apache/pinot/issues/10392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [pinot] dario-liberman commented on a diff in pull request #11092: Funnel Count - Multiple Strategies (no partitioning requisites)

dario-liberman commented on code in PR #11092: URL: https://github.com/apache/pinot/pull/11092#discussion_r1272733046 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/FunnelCountAggregationFunction.java: ## @@ -239,48 +350,112 @@ Optional find(List e

[GitHub] [pinot] dario-liberman commented on a diff in pull request #11092: Funnel Count - Multiple Strategies (no partitioning requisites)

dario-liberman commented on code in PR #11092: URL: https://github.com/apache/pinot/pull/11092#discussion_r1272710739 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/FunnelCountAggregationFunction.java: ## @@ -198,27 +278,58 @@ private int[][] getSte

[GitHub] [pinot] cbalci commented on a diff in pull request #11092: Funnel Count - Multiple Strategies (no partitioning requisites)

cbalci commented on code in PR #11092: URL: https://github.com/apache/pinot/pull/11092#discussion_r1272489947 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/FunnelCountAggregationFunction.java: ## @@ -198,27 +278,58 @@ private int[][] getSteps(Map b

[GitHub] [pinot] Jackie-Jiang merged pull request #9713: Extract headers for Kinesis Connector

Jackie-Jiang merged PR #9713: URL: https://github.com/apache/pinot/pull/9713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.a

[pinot] branch master updated (41b3c70906 -> ea493a2532)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 41b3c70906 [multistage][hotfix] should never pull project up below sort (#11161) add ea493a2532 Extract headers f

[GitHub] [pinot] dario-liberman commented on a diff in pull request #11092: Funnel Count - Multiple Strategies (no partitioning requisites)

dario-liberman commented on code in PR #11092: URL: https://github.com/apache/pinot/pull/11092#discussion_r1272704204 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/FunnelCountAggregationFunction.java: ## @@ -180,8 +256,12 @@ public String toExplain

[GitHub] [pinot] dario-liberman commented on a diff in pull request #11092: Funnel Count - Multiple Strategies (no partitioning requisites)

dario-liberman commented on code in PR #11092: URL: https://github.com/apache/pinot/pull/11092#discussion_r1272703933 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/FunnelCountAggregationFunction.java: ## @@ -180,8 +256,12 @@ public String toExplain

[GitHub] [pinot] codecov-commenter commented on pull request #11162: [multistage] Support SumPrecision Aggregation function

codecov-commenter commented on PR #11162: URL: https://github.com/apache/pinot/pull/11162#issuecomment-1648525600 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11162?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] dario-liberman commented on a diff in pull request #11092: Funnel Count - Multiple Strategies (no partitioning requisites)

dario-liberman commented on code in PR #11092: URL: https://github.com/apache/pinot/pull/11092#discussion_r1272679653 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/FunnelCountAggregationFunction.java: ## @@ -109,47 +185,52 @@ public GroupByResultHo

[GitHub] [pinot] dario-liberman commented on a diff in pull request #11092: Funnel Count - Multiple Strategies (no partitioning requisites)

dario-liberman commented on code in PR #11092: URL: https://github.com/apache/pinot/pull/11092#discussion_r1272664595 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/FunnelCountAggregationFunction.java: ## @@ -35,46 +50,107 @@ import org.apache.pin

[GitHub] [pinot] xiangfu0 opened a new pull request, #11162: Support sum precision

xiangfu0 opened a new pull request, #11162: URL: https://github.com/apache/pinot/pull/11162 - Support sumPrecision in v2 - Add integration test for it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [pinot] dario-liberman commented on a diff in pull request #11092: Funnel Count - Multiple Strategies (no partitioning requisites)

dario-liberman commented on code in PR #11092: URL: https://github.com/apache/pinot/pull/11092#discussion_r1272661647 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/FunnelCountAggregationFunction.java: ## @@ -35,46 +50,107 @@ import org.apache.pin

[GitHub] [pinot] dario-liberman commented on pull request #11092: Funnel Count - Multiple Strategies (no partitioning requisites)

dario-liberman commented on PR #11092: URL: https://github.com/apache/pinot/pull/11092#issuecomment-1648468379 > Some tests are failing -- please check I believe these are flaky tests unrelated to this PR, is there a way to re-run the failed tests? -- This is an automated message f

[GitHub] [pinot] dario-liberman commented on a diff in pull request #11092: Funnel Count - Multiple Strategies (no partitioning requisites)

dario-liberman commented on code in PR #11092: URL: https://github.com/apache/pinot/pull/11092#discussion_r1272648479 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/FunnelCountAggregationFunction.java: ## @@ -198,27 +278,58 @@ private int[][] getSte

[GitHub] [pinot] dario-liberman commented on a diff in pull request #11092: Funnel Count - Multiple Strategies (no partitioning requisites)

dario-liberman commented on code in PR #11092: URL: https://github.com/apache/pinot/pull/11092#discussion_r1272643837 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/FunnelCountAggregationFunction.java: ## @@ -35,46 +50,107 @@ import org.apache.pin

[GitHub] [pinot] dario-liberman commented on a diff in pull request #11092: Funnel Count - Multiple Strategies (no partitioning requisites)

dario-liberman commented on code in PR #11092: URL: https://github.com/apache/pinot/pull/11092#discussion_r1272643837 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/FunnelCountAggregationFunction.java: ## @@ -35,46 +50,107 @@ import org.apache.pin

[GitHub] [pinot] walterddr commented on pull request #11153: add theta sketch scalar

walterddr commented on PR #11153: URL: https://github.com/apache/pinot/pull/11153#issuecomment-1648457978 ok so to summarize: - we should have a `getSketchEstimate` and `getSketchQuantile` method which should figure out if the sketch object allows such function (this can be done as a

[pinot] branch master updated: [multistage][hotfix] should never pull project up below sort (#11161)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 41b3c70906 [multistage][hotfix] should never pull

[GitHub] [pinot] walterddr commented on a diff in pull request #11161: [multistage][hotfix] should never pull project up below sort

walterddr commented on code in PR #11161: URL: https://github.com/apache/pinot/pull/11161#discussion_r1272640453 ## pinot-query-planner/src/test/resources/queries/BasicQueryPlans.json: ## @@ -37,10 +37,10 @@ "sql": "EXPLAIN PLAN FOR SELECT dateTrunc('DAY', ts) FROM a LI

[GitHub] [pinot] walterddr merged pull request #11161: [multistage][hotfix] should never pull project up below sort

walterddr merged PR #11161: URL: https://github.com/apache/pinot/pull/11161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

[GitHub] [pinot] atris commented on a diff in pull request #11092: Funnel Count - Multiple Strategies (no partitioning requisites)

atris commented on code in PR #11092: URL: https://github.com/apache/pinot/pull/11092#discussion_r1272617169 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/FunnelCountAggregationFunction.java: ## @@ -35,46 +50,107 @@ import org.apache.pinot.core.q

[GitHub] [pinot] codecov-commenter commented on pull request #11161: [multistage][hotfix] should never pull project up below sort

codecov-commenter commented on PR #11161: URL: https://github.com/apache/pinot/pull/11161#issuecomment-1648427122 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11161?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] summerhasama-stripe commented on a diff in pull request #11073: For table rebalance, check if instances are equal for NO_OP

summerhasama-stripe commented on code in PR #11073: URL: https://github.com/apache/pinot/pull/11073#discussion_r1272315952 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancerClusterStatelessTest.java: ## @@ -246,19 +246,19 @@ public

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #11161: [multistage][hotfix] should never pull project up below sort

xiangfu0 commented on code in PR #11161: URL: https://github.com/apache/pinot/pull/11161#discussion_r1272572932 ## pinot-query-planner/src/test/resources/queries/BasicQueryPlans.json: ## @@ -37,10 +37,10 @@ "sql": "EXPLAIN PLAN FOR SELECT dateTrunc('DAY', ts) FROM a LIM

[pinot] branch master updated (5eafe76ee8 -> 35fb1d0886)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 5eafe76ee8 [Upsert TTL] Add Watermark for each partitions for Primary key cleanup (#10915) add 35fb1d0886 Fix co

[GitHub] [pinot] xiangfu0 merged pull request #11156: Fix compatibility test

xiangfu0 merged PR #11156: URL: https://github.com/apache/pinot/pull/11156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[GitHub] [pinot] deemoliu closed pull request #10047: [POC] Add upsert ttl configs for Pinot upsert optimizations

deemoliu closed pull request #10047: [POC] Add upsert ttl configs for Pinot upsert optimizations URL: https://github.com/apache/pinot/pull/10047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [pinot] deemoliu commented on pull request #10047: [POC] Add upsert ttl configs for Pinot upsert optimizations

deemoliu commented on PR #10047: URL: https://github.com/apache/pinot/pull/10047#issuecomment-1648339857 The PR after cleanup and review was merged https://github.com/apache/pinot/pull/10915 thanks everyone for design discussion and review! -- This is an automated message from the Apac

[GitHub] [pinot] deemoliu commented on pull request #10915: [Upsert TTL] Add Watermark for each partitions for Primary key cleanup

deemoliu commented on PR #10915: URL: https://github.com/apache/pinot/pull/10915#issuecomment-1648338611 > @deemoliu can we also add docs for this in the pinot? Thanks for asking @KKcorps np, the doc is https://docs.google.com/document/d/1AhkZPkf4St3hj96IXyNs6NOiItxm3LXw3NAgNbG3oR

[GitHub] [pinot] walterddr commented on pull request #11153: add theta sketch scalar

walterddr commented on PR #11153: URL: https://github.com/apache/pinot/pull/11153#issuecomment-1648299309 > This is pretty cool, but I'd suggest we prefix the function names with sketch types, ie `THETA_SKETCH_GET_ESTIMATE`, since we use different sketches (KLL, Tuples etc.) and more coming

[GitHub] [pinot] cbalci commented on pull request #11153: add theta sketch scalar

cbalci commented on PR #11153: URL: https://github.com/apache/pinot/pull/11153#issuecomment-1648292426 This is pretty cool, but I'd suggest we prefix the function names with sketch types, ie `THETA_SKETCH_GET_ESTIMATE`, since we use different sketches (KLL, Tuples etc.) and more coming. -

[GitHub] [pinot] walterddr commented on pull request #11151: [multistage] [bugfix] Derive SUM return type

walterddr commented on PR #11151: URL: https://github.com/apache/pinot/pull/11151#issuecomment-1648288167 based on https://www.postgresql.org/docs/8.2/functions-aggregate.html and https://learn.microsoft.com/en-us/sql/t-sql/functions/sum-transact-sql?view=sql-server-ver16 it doesn't seem to

[GitHub] [pinot] walterddr commented on a diff in pull request #11052: [multistage] support physical plan in Explain queries

walterddr commented on code in PR #11052: URL: https://github.com/apache/pinot/pull/11052#discussion_r1272508665 ## pinot-common/src/main/java/org/apache/pinot/sql/parsers/parser/SqlPhysicalExplain.java: ## @@ -0,0 +1,32 @@ +/** + * Licensed to the Apache Software Foundation (AS

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #11117: [multistage] bridge v2 query engine for leaf stage v1 multi-value column

xiangfu0 commented on code in PR #7: URL: https://github.com/apache/pinot/pull/7#discussion_r1272525489 ## pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java: ## @@ -90,6 +90,11 @@ public enum TransformFunctionType { // date type co

[GitHub] [pinot] codecov-commenter commented on pull request #11153: add theta sketch scalar

codecov-commenter commented on PR #11153: URL: https://github.com/apache/pinot/pull/11153#issuecomment-1648269766 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11153?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] cbalci commented on a diff in pull request #11092: Funnel Count - Multiple Strategies (no partitioning requisites)

cbalci commented on code in PR #11092: URL: https://github.com/apache/pinot/pull/11092#discussion_r1272481992 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/FunnelCountAggregationFunction.java: ## @@ -35,46 +50,107 @@ import org.apache.pinot.core.

[GitHub] [pinot] walterddr opened a new pull request, #11161: [multistage][hotfix] should never pull project up below sort

walterddr opened a new pull request, #11161: URL: https://github.com/apache/pinot/pull/11161 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[GitHub] [pinot] robertzych commented on a diff in pull request #10463: Segment compaction for upsert real-time tables

robertzych commented on code in PR #10463: URL: https://github.com/apache/pinot/pull/10463#discussion_r1272419920 ## pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompaction/UpsertCompactionTaskGenerator.java: ##

[GitHub] [pinot] summerhasama-stripe commented on a diff in pull request #11073: For table rebalance, check if instances are equal for NO_OP

summerhasama-stripe commented on code in PR #11073: URL: https://github.com/apache/pinot/pull/11073#discussion_r1272344088 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -522,38 +550,44 @@ private InstancePartitions

[GitHub] [pinot] summerhasama-stripe commented on a diff in pull request #11073: For table rebalance, check if instances are equal for NO_OP

summerhasama-stripe commented on code in PR #11073: URL: https://github.com/apache/pinot/pull/11073#discussion_r1272315952 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancerClusterStatelessTest.java: ## @@ -246,19 +246,19 @@ public

[GitHub] [pinot] codecov-commenter commented on pull request #11160: Add Integration test for Upsert Preload

codecov-commenter commented on PR #11160: URL: https://github.com/apache/pinot/pull/11160#issuecomment-1647965815 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11160?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] KKcorps opened a new pull request, #11160: Add Integration test for Upsert Preload

KKcorps opened a new pull request, #11160: URL: https://github.com/apache/pinot/pull/11160 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[GitHub] [pinot] codecov-commenter commented on pull request #11158: Increment nextDocId even if geo indexing fails

codecov-commenter commented on PR #11158: URL: https://github.com/apache/pinot/pull/11158#issuecomment-1647851587 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11158?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] codecov-commenter commented on pull request #11159: Bump io.grpc:grpc-context from 1.14.0 to 1.56.1

codecov-commenter commented on PR #11159: URL: https://github.com/apache/pinot/pull/11159#issuecomment-1647843614 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11159?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] saurabhd336 commented on pull request #11158: Increment nextDocId even if geo indexing fails

saurabhd336 commented on PR #11158: URL: https://github.com/apache/pinot/pull/11158#issuecomment-1647784240 Issue reproducible with Schema ``` { "schemaName": "geoIndex", "dimensionFieldSpecs": [ { "name": "geoIndexCol", "dataType": "BYTES"

[pinot] branch dependabot/maven/io.grpc-grpc-context-1.56.1 created (now 0af1f2565c)

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/io.grpc-grpc-context-1.56.1 in repository https://gitbox.apache.org/repos/asf/pinot.git at 0af1f2565c Bump io.grpc:grpc-context from 1.14.0 to 1.56.1 No new revisions

[GitHub] [pinot] dependabot[bot] opened a new pull request, #11159: Bump io.grpc:grpc-context from 1.14.0 to 1.56.1

dependabot[bot] opened a new pull request, #11159: URL: https://github.com/apache/pinot/pull/11159 Bumps [io.grpc:grpc-context](https://github.com/grpc/grpc-java) from 1.14.0 to 1.56.1. Release notes Sourced from https://github.com/grpc/grpc-java/releases";>io.grpc:grpc-context's

[GitHub] [pinot] saurabhd336 opened a new pull request, #11158: Increment nextDocId even if geo indexing fails

saurabhd336 opened a new pull request, #11158: URL: https://github.com/apache/pinot/pull/11158 If geo indexing fails for any row in a consuming segment, wrong docIds are put into the index for all rows that follow. This fixes the behaviour. -- This is an automated message from the Apache

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #11156: Fix compatibility test

xiangfu0 commented on code in PR #11156: URL: https://github.com/apache/pinot/pull/11156#discussion_r1271882974 ## .github/workflows/scripts/.pinot_compatibility_verifier.sh: ## @@ -61,12 +61,12 @@ echo "">> ${SETTINGS_FILE} # PINOT_MAVEN_OPTS is used to provide additional mave

[GitHub] [pinot] xiangfu0 commented on pull request #11151: [multistage] [bugfix] Derive SUM return type

xiangfu0 commented on PR #11151: URL: https://github.com/apache/pinot/pull/11151#issuecomment-1647394691 We still need to find a way to solve this decimal type hoist problem. And for now we need to make sure the error message is clear and explicit type casting can be applied correctly.