[GitHub] [pinot] gortiz commented on a diff in pull request #10792: Add required JSON annotation in H3IndexResolution

gortiz commented on code in PR #10792: URL: https://github.com/apache/pinot/pull/10792#discussion_r1206309308 ## pinot-segment-spi/src/test/java/org/apache/pinot/segment/spi/index/creator/H3IndexConfigTest.java: ## @@ -84,4 +84,16 @@ public void withSomeData() Assert.assert

[GitHub] [pinot] mcvsubbu merged pull request #10804: Use min of (retry count, number of controller addresses) as retry count when fetch segment

mcvsubbu merged PR #10804: URL: https://github.com/apache/pinot/pull/10804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[pinot] branch master updated (434d9733c3 -> 2e6f1e63f0)

This is an automated email from the ASF dual-hosted git repository. mcvsubbu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 434d9733c3 Add a comment to and a unit test for the group by expressions deduplication logic (#10803) add 2e6f1

[GitHub] [pinot] codecov-commenter commented on pull request #10805: Parse nulls last/first.

codecov-commenter commented on PR #10805: URL: https://github.com/apache/pinot/pull/10805#issuecomment-1563592187 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10805?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10463: Segment compaction for upsert real-time tables

Jackie-Jiang commented on code in PR #10463: URL: https://github.com/apache/pinot/pull/10463#discussion_r1206053254 ## pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompaction/UpsertCompactionTaskExecutor.java: #

[GitHub] [pinot] egalpin commented on a diff in pull request #10704: Keeps nullness attributes of merged in comparison column values

egalpin commented on code in PR #10704: URL: https://github.com/apache/pinot/pull/10704#discussion_r1206053123 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ComparisonColumns.java: ## @@ -37,10 +38,45 @@ public int getComparableIndex() { return

[GitHub] [pinot] jasperjiaguo opened a new issue, #10807: Add a max retry time for ExponentialBackoffRetryPolicy

jasperjiaguo opened a new issue, #10807: URL: https://github.com/apache/pinot/issues/10807 https://github.com/apache/pinot/pull/10804. Currently the ExponentialBackoffRetryPolicy is not intuitive to use, e.g. with a (maxNumAttempts, initialDelayMs, delayScaleFactor) combination it is hard t

[GitHub] [pinot] Jackie-Jiang closed issue #10782: [multistage] group-by throws NPE when dealing with null values

Jackie-Jiang closed issue #10782: [multistage] group-by throws NPE when dealing with null values URL: https://github.com/apache/pinot/issues/10782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pinot] Jackie-Jiang commented on issue #10782: [multistage] group-by throws NPE when dealing with null values

Jackie-Jiang commented on issue #10782: URL: https://github.com/apache/pinot/issues/10782#issuecomment-1563558201 Fixed with #10799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [pinot] Jackie-Jiang closed issue #10769: Expire Keys from Upsert Metadata when a Segment is removed due to retention

Jackie-Jiang closed issue #10769: Expire Keys from Upsert Metadata when a Segment is removed due to retention URL: https://github.com/apache/pinot/issues/10769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [pinot] Jackie-Jiang closed issue #10205: [multistage] [debuggability] Return meaningful error msg for unsupported type

Jackie-Jiang closed issue #10205: [multistage] [debuggability] Return meaningful error msg for unsupported type URL: https://github.com/apache/pinot/issues/10205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10650: [bugfix] fix floating point and integral type backward incompatible issue

Jackie-Jiang commented on code in PR #10650: URL: https://github.com/apache/pinot/pull/10650#discussion_r1206034842 ## pinot-common/src/main/java/org/apache/pinot/common/request/context/LiteralContext.java: ## @@ -90,32 +90,55 @@ static Pair inferLiteralDataTypeAndValue(String

[GitHub] [pinot] jasperjiaguo opened a new issue, #10806: Stop retrying downloading if a segment if zk metadata is missing

jasperjiaguo opened a new issue, #10806: URL: https://github.com/apache/pinot/issues/10806 During the investigation described in https://github.com/apache/pinot/pull/10804, we found the download code in SegmentFetcher would still retry even if the segment metadata is missing. We should add

[GitHub] [pinot] mcvsubbu commented on pull request #10804: Use min of (retry count, number of controller addresses) as retry count when fetch segment

mcvsubbu commented on PR #10804: URL: https://github.com/apache/pinot/pull/10804#issuecomment-1563518940 Discussed offline, @jasperjiaguo will file issues for the other thoughts I added. This fix is good for us to get over the problem for now -- This is an automated message from th

[pinot] branch master updated: Add a comment to and a unit test for the group by expressions deduplication logic (#10803)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 434d9733c3 Add a comment to and a unit test for t

[GitHub] [pinot] Jackie-Jiang merged pull request #10803: Add a comment to and a unit test for the group by expressions deduplication logic.

Jackie-Jiang merged PR #10803: URL: https://github.com/apache/pinot/pull/10803 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] PeterCorless commented on issue #10786: [Release Notes] Add Dates and Link to Github

PeterCorless commented on issue #10786: URL: https://github.com/apache/pinot/issues/10786#issuecomment-1563467540 Unfortunately I do not have access to that; it's listed as private. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [pinot] shenyu0127 commented on a diff in pull request #10613: [feature] [null support # 10] Add null support in all transform function and pass the bitmap to upstream

shenyu0127 commented on code in PR #10613: URL: https://github.com/apache/pinot/pull/10613#discussion_r1201357156 ## pinot-core/src/main/java/org/apache/pinot/core/common/RowBasedBlockValueFetcher.java: ## Review Comment: optional: file an issue to create a unit test file f

[GitHub] [pinot] shenyu0127 opened a new pull request, #10805: Parse nulls last/first.

shenyu0127 opened a new pull request, #10805: URL: https://github.com/apache/pinot/pull/10805 Parse nulls last/first in the query and save the order in `OrderByExpressionContext`. This PR is a no-op. A follow up PR will make use of the nulls last/first in the `OrderByExpressionContex

[GitHub] [pinot] codecov-commenter commented on pull request #10804: Use min of (retry count, number of controller addresses) as retry count when fetch segment

codecov-commenter commented on PR #10804: URL: https://github.com/apache/pinot/pull/10804#issuecomment-1563389930 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10804?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R

[pinot] branch master updated: Integer Tuple Sketch support (#10427)

This is an automated email from the ASF dual-hosted git repository. mayanks pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new ded7e8f5ed Integer Tuple Sketch support (#10427)

[GitHub] [pinot] mayankshriv merged pull request #10427: Integer Tuple Sketch support

mayankshriv merged PR #10427: URL: https://github.com/apache/pinot/pull/10427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.

[GitHub] [pinot] jasperjiaguo opened a new pull request, #10804: Use min of (retry count, number of controller addresses) as retry count when fetch segment

jasperjiaguo opened a new pull request, #10804: URL: https://github.com/apache/pinot/pull/10804 Thanks @mcvsubbu for rc-ing this see [PR#8845](https://github.com/apache/pinot/pull/8845) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[pinot] branch master updated: [Multi-stage] Support null in aggregate and filter (#10799)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new fcaebab69a [Multi-stage] Support null in aggregat

[GitHub] [pinot] Jackie-Jiang merged pull request #10799: [Multi-stage] Support null in aggregate and filter

Jackie-Jiang merged PR #10799: URL: https://github.com/apache/pinot/pull/10799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] walterddr commented on a diff in pull request #10792: Add required JSON annotation in H3IndexResolution

walterddr commented on code in PR #10792: URL: https://github.com/apache/pinot/pull/10792#discussion_r1205738972 ## pinot-segment-spi/src/test/java/org/apache/pinot/segment/spi/index/creator/H3IndexConfigTest.java: ## @@ -84,4 +84,16 @@ public void withSomeData() Assert.ass

[GitHub] [pinot] walterddr commented on a diff in pull request #10792: Add required JSON annotation in H3IndexResolution

walterddr commented on code in PR #10792: URL: https://github.com/apache/pinot/pull/10792#discussion_r1205737889 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/H3IndexResolution.java: ## @@ -91,4 +94,11 @@ public boolean equals(Object o) { public

[GitHub] [pinot] walterddr commented on a diff in pull request #10791: [multistage] Refactor StageMetadata from pinot-query-planner to pinot-query-runner module

walterddr commented on code in PR #10791: URL: https://github.com/apache/pinot/pull/10791#discussion_r1205686194 ## pinot-common/src/main/proto/worker.proto: ## @@ -70,14 +70,15 @@ message QueryResponse { message StagePlan { int32 stageId = 1; - string virtualAddress = 2;

[GitHub] [pinot] walterddr commented on a diff in pull request #10791: [multistage] Refactor StageMetadata from pinot-query-planner to pinot-query-runner module

walterddr commented on code in PR #10791: URL: https://github.com/apache/pinot/pull/10791#discussion_r1205665086 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/QueryDispatcher.java: ## @@ -139,22 +140,24 @@ int submit(long requestId, DispatchableSub

[GitHub] [pinot] walterddr commented on a diff in pull request #10791: [multistage] Refactor StageMetadata from pinot-query-planner to pinot-query-runner module

walterddr commented on code in PR #10791: URL: https://github.com/apache/pinot/pull/10791#discussion_r1205665086 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/QueryDispatcher.java: ## @@ -139,22 +140,24 @@ int submit(long requestId, DispatchableSub

[GitHub] [pinot] codecov-commenter commented on pull request #10803: Add a comment to and a unit test for the group by expressions deduplication logic.

codecov-commenter commented on PR #10803: URL: https://github.com/apache/pinot/pull/10803#issuecomment-1562395285 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10803?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) R