[GitHub] [pinot] 61yao commented on a diff in pull request #10514: [WIP]: 10513 - Null support in Case/When queries.

2023-04-08 Thread via GitHub
61yao commented on code in PR #10514: URL: https://github.com/apache/pinot/pull/10514#discussion_r1161179130 ## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/logical/RexExpression.java: ## @@ -49,6 +50,10 @@ static RexExpression toRexExpression(RexNode rexNode

[GitHub] [pinot] pjpringle commented on pull request #9890: enable MergeRollupTask on realtime tables

2023-04-08 Thread via GitHub
pjpringle commented on PR #9890: URL: https://github.com/apache/pinot/pull/9890#issuecomment-1501010991 is there a missing doc update for realtime support here https://docs.pinot.apache.org/operators/operating-pinot/minion-merge-rollup-task Also doc says multilevel supported but no ex

[GitHub] [pinot] codecov-commenter commented on pull request #10583: Fix DataTableV3 serde bug for empty array

2023-04-08 Thread via GitHub
codecov-commenter commented on PR #10583: URL: https://github.com/apache/pinot/pull/10583#issuecomment-1500972985 ## [Codecov](https://codecov.io/gh/apache/pinot/pull/10583?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Sof

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #10583: Fix DataTableV3 serde bug for empty array

2023-04-08 Thread via GitHub
xiangfu0 commented on code in PR #10583: URL: https://github.com/apache/pinot/pull/10583#discussion_r1161151724 ## pinot-core/src/test/java/org/apache/pinot/core/common/datatable/DataTableSerDeTest.java: ## @@ -123,36 +123,142 @@ public void testException(int dataTableVersion)

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #10583: Fix DataTableV3 serde bug for empty array

2023-04-08 Thread via GitHub
xiangfu0 commented on code in PR #10583: URL: https://github.com/apache/pinot/pull/10583#discussion_r1161151652 ## pinot-core/src/test/java/org/apache/pinot/core/common/datatable/DataTableSerDeTest.java: ## @@ -123,36 +123,142 @@ public void testException(int dataTableVersion)

[pinot] branch master updated: Remove stack trace from logs for multiget calls for getting table size (#10568)

2023-04-08 Thread sajjad
This is an automated email from the ASF dual-hosted git repository. sajjad pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new ea63617018 Remove stack trace from logs for multi

[GitHub] [pinot] sajjad-moradi merged pull request #10568: Remove Multiget stack trace from table size logs

2023-04-08 Thread via GitHub
sajjad-moradi merged PR #10568: URL: https://github.com/apache/pinot/pull/10568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pino

[GitHub] [pinot] walterddr commented on a diff in pull request #10583: Fix DataTableV3 serde bug for empty array

2023-04-08 Thread via GitHub
walterddr commented on code in PR #10583: URL: https://github.com/apache/pinot/pull/10583#discussion_r1161121341 ## pinot-core/src/test/java/org/apache/pinot/core/common/datatable/DataTableSerDeTest.java: ## @@ -123,36 +123,142 @@ public void testException(int dataTableVersion)

[GitHub] [pinot] walterddr commented on pull request #10546: [multistage] fix tenant detection issues

2023-04-08 Thread via GitHub
walterddr commented on PR #10546: URL: https://github.com/apache/pinot/pull/10546#issuecomment-1500903679 Another issue to follow up with this @ankitsultana and @tibrewalpratik17 is that after this fix the error message for multi-stage query for `select * from non_exist_tbl` will return non

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #10561: 10459: Change H2 __MV columns to Array DataType

2023-04-08 Thread via GitHub
xiangfu0 commented on code in PR #10561: URL: https://github.com/apache/pinot/pull/10561#discussion_r1161101305 ## pinot-integration-tests/src/test/resources/On_Time_On_Time_Performance_2014_100k_subset.test_queries_200.sql: ## @@ -117,54 +117,54 @@ {"sql":"SELECT WheelsOn, Ori

[GitHub] [pinot] abhioncbr commented on a diff in pull request #10561: 10459: Change H2 __MV columns to Array DataType

2023-04-08 Thread via GitHub
abhioncbr commented on code in PR #10561: URL: https://github.com/apache/pinot/pull/10561#discussion_r1161098389 ## pinot-integration-tests/src/test/resources/On_Time_On_Time_Performance_2014_100k_subset.test_queries_200.sql: ## @@ -117,54 +117,54 @@ {"sql":"SELECT WheelsOn, Or