[GitHub] [pinot] walterddr commented on a diff in pull request #10451: Moving Zk updates for reload, force_commit to their own Znodes which …

2023-03-31 Thread via GitHub
walterddr commented on code in PR #10451: URL: https://github.com/apache/pinot/pull/10451#discussion_r1155062405 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java: ## @@ -635,8 +635,8 @@ public ServerReloadControllerJobS

[GitHub] [pinot] walterddr commented on a diff in pull request #10451: Moving Zk updates for reload, force_commit to their own Znodes which …

2023-03-31 Thread via GitHub
walterddr commented on code in PR #10451: URL: https://github.com/apache/pinot/pull/10451#discussion_r1155062021 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -255,6 +255,8 @@ public PinotHelixResourceManager(Contr

[GitHub] [pinot] walterddr commented on a diff in pull request #10384: Refactor: Simplify Execution Stats Aggregator

2023-03-31 Thread via GitHub
walterddr commented on code in PR #10384: URL: https://github.com/apache/pinot/pull/10384#discussion_r1155060974 ## pinot-common/src/main/java/org/apache/pinot/common/datatable/DataTable.java: ## @@ -137,6 +137,7 @@ enum MetadataKey { // We keep this constant to track the m

[GitHub] [pinot] walterddr commented on a diff in pull request #10473: Do not serialize metrics in each Operator

2023-03-31 Thread via GitHub
walterddr commented on code in PR #10473: URL: https://github.com/apache/pinot/pull/10473#discussion_r1155060568 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MailboxSendOperator.java: ## @@ -151,10 +152,20 @@ protected TransferableBlock getNextBlo

[pinot] branch master updated: Fix ramping delay caused by long lasting sequence of unfiltered messa… (#10418)

2023-03-31 Thread sajjad
This is an automated email from the ASF dual-hosted git repository. sajjad pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new d7411c5d38 Fix ramping delay caused by long lasti

[GitHub] [pinot] sajjad-moradi merged pull request #10418: Fix ramping delay caused by long lasting sequence of unfiltered messa…

2023-03-31 Thread via GitHub
sajjad-moradi merged PR #10418: URL: https://github.com/apache/pinot/pull/10418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pino

[pinot] branch master updated (60ee5eb0e8 -> 7a89a4d13b)

2023-03-31 Thread rongr
This is an automated email from the ASF dual-hosted git repository. rongr pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 60ee5eb0e8 Allow ValueBlock length to increase in TransformFunction (#10515) add 7a89a4d13b Fix shading in spark2

[GitHub] [pinot] walterddr merged pull request #10490: Fix shading in spark2 connector pom file

2023-03-31 Thread via GitHub
walterddr merged PR #10490: URL: https://github.com/apache/pinot/pull/10490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

[GitHub] [pinot] jugomezv commented on pull request #10418: Fix ramping delay caused by long lasting sequence of unfiltered messa…

2023-03-31 Thread via GitHub
jugomezv commented on PR #10418: URL: https://github.com/apache/pinot/pull/10418#issuecomment-1492733456 failing integration test passing on my env, forced committed to rerun tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [pinot] abhioncbr commented on issue #10252: [Feature] Null support in Pinot

2023-03-31 Thread via GitHub
abhioncbr commented on issue #10252: URL: https://github.com/apache/pinot/issues/10252#issuecomment-1492695625 Hi @61yao, Can I pick up the work for Null support in the conditional operator? I would like to give it a try, It's related to 1053 -- This is an automated message from the Apach

[pinot] branch master updated: Allow ValueBlock length to increase in TransformFunction (#10515)

2023-03-31 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 60ee5eb0e8 Allow ValueBlock length to increase in

[GitHub] [pinot] Jackie-Jiang merged pull request #10515: Allow ValueBlock length to increase in TransformFunction

2023-03-31 Thread via GitHub
Jackie-Jiang merged PR #10515: URL: https://github.com/apache/pinot/pull/10515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] jugomezv commented on a diff in pull request #10418: Fix ramping delay caused by long lasting sequence of unfiltered messa…

2023-03-31 Thread via GitHub
jugomezv commented on code in PR #10418: URL: https://github.com/apache/pinot/pull/10418#discussion_r1154955282 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java: ## @@ -527,9 +527,12 @@ private boolean processStreamEvents(

[GitHub] [pinot] jugomezv commented on a diff in pull request #10418: Fix ramping delay caused by long lasting sequence of unfiltered messa…

2023-03-31 Thread via GitHub
jugomezv commented on code in PR #10418: URL: https://github.com/apache/pinot/pull/10418#discussion_r1154950496 ## pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java: ## @@ -618,14 +618,18 @@ private boolean processStreamEvents

[pinot] branch master updated (26a6c50180 -> 32eda70f6e)

2023-03-31 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 26a6c50180 Use string as default compatible type for coalesce (#10516) add 32eda70f6e Use threadlocal variable for

[GitHub] [pinot] Jackie-Jiang merged pull request #10502: Use genericRow from the caller to update lookup table results

2023-03-31 Thread via GitHub
Jackie-Jiang merged PR #10502: URL: https://github.com/apache/pinot/pull/10502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[pinot] branch master updated (f69557e325 -> 26a6c50180)

2023-03-31 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from f69557e325 Complete index spi (#10184) add 26a6c50180 Use string as default compatible type for coalesce (#10516)

[GitHub] [pinot] Jackie-Jiang merged pull request #10516: [enhancement] Use string as default compatible type for coalesce

2023-03-31 Thread via GitHub
Jackie-Jiang merged PR #10516: URL: https://github.com/apache/pinot/pull/10516 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

[GitHub] [pinot] walterddr commented on issue #10498: [Performance] Group By Optimization

2023-03-31 Thread via GitHub
walterddr commented on issue #10498: URL: https://github.com/apache/pinot/issues/10498#issuecomment-1492648937 Do we have any detailed SQL and data example on the problem statement of this optimization. Specifically, for "large group-by": Are we specifically targeting high cardinality group

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10515: Allow ValueBlock length to increase in TransformFunction

2023-03-31 Thread via GitHub
Jackie-Jiang commented on code in PR #10515: URL: https://github.com/apache/pinot/pull/10515#discussion_r1154927319 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/GroovyTransformFunction.java: ## @@ -429,13 +408,11 @@ public double[][] transformToD

[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #10515: Allow ValueBlock length to increase in TransformFunction

2023-03-31 Thread via GitHub
Jackie-Jiang commented on code in PR #10515: URL: https://github.com/apache/pinot/pull/10515#discussion_r1154925954 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/BaseTransformFunction.java: ## @@ -122,12 +121,16 @@ public int[][] transformToDictId

[GitHub] [pinot] jugomezv commented on a diff in pull request #10418: Fix ramping delay caused by long lasting sequence of unfiltered messa…

2023-03-31 Thread via GitHub
jugomezv commented on code in PR #10418: URL: https://github.com/apache/pinot/pull/10418#discussion_r1154923326 ## pinot-spi/src/main/java/org/apache/pinot/spi/stream/MessageBatch.java: ## @@ -116,4 +116,14 @@ default StreamPartitionMsgOffset getOffsetOfNextBatch() { default

[GitHub] [pinot] npawar merged pull request #10184: Complete index spi

2023-03-31 Thread via GitHub
npawar merged PR #10184: URL: https://github.com/apache/pinot/pull/10184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

[GitHub] [pinot] npawar commented on a diff in pull request #10184: Complete index spi

2023-03-31 Thread via GitHub
npawar commented on code in PR #10184: URL: https://github.com/apache/pinot/pull/10184#discussion_r1153911248 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/inv/BitSlicedRangeIndexCreator.java: ## @@ -40,12 +40,15 @@ public class BitSlic

[GitHub] [pinot] klsince commented on a diff in pull request #10184: Complete index spi

2023-03-31 Thread via GitHub
klsince commented on code in PR #10184: URL: https://github.com/apache/pinot/pull/10184#discussion_r1154757602 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/bloomfilter/BloomFilterHandler.java: ## @@ -264,51 +265,42 @@ private void cre

[pinot] branch master updated: Allow empty segmentsTo for segment replacement protocol (#10511)

2023-03-31 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 6e9bfb18b3 Allow empty segmentsTo for segment repl

[GitHub] [pinot] snleee merged pull request #10511: Allow empty segmentsTo for segment replacement protocol

2023-03-31 Thread via GitHub
snleee merged PR #10511: URL: https://github.com/apache/pinot/pull/10511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

[GitHub] [pinot] xiangfu0 merged pull request #10517: Bump redis from 4.5.3 to 4.5.4 in /docker/images/pinot-superset

2023-03-31 Thread via GitHub
xiangfu0 merged PR #10517: URL: https://github.com/apache/pinot/pull/10517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[pinot] branch master updated (660d3fd02f -> acb452ab72)

2023-03-31 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 660d3fd02f [multistage] Initial (phase 1) Query runtime for window functions with ORDER BY within the OVER() clause (

[GitHub] [pinot] Jayesh-Asrani commented on issue #10518: Pinot Controler UI : If the table name is large the name is not aligned on query console

2023-03-31 Thread via GitHub
Jayesh-Asrani commented on issue #10518: URL: https://github.com/apache/pinot/issues/10518#issuecomment-1492138500 @npawar / @jayeshchoudhary Small UI issue on Query Console -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pinot] Jayesh-Asrani opened a new issue, #10518: Pinot Controler UI : If the table name is large the name is not aligned on query console

2023-03-31 Thread via GitHub
Jayesh-Asrani opened a new issue, #10518: URL: https://github.com/apache/pinot/issues/10518 Pinot Controler UI : If the table name is large the name is not aligned on query console. We loose the search column functionality as a result of this ![image](https://user-images.githubuserco

[pinot] branch master updated: [multistage] Initial (phase 1) Query runtime for window functions with ORDER BY within the OVER() clause (#10449)

2023-03-31 Thread rongr
This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 660d3fd02f [multistage] Initial (phase 1) Query ru

[GitHub] [pinot] walterddr merged pull request #10449: [multistage] Initial (phase 1) Query runtime for window functions with ORDER BY within the OVER() clause

2023-03-31 Thread via GitHub
walterddr merged PR #10449: URL: https://github.com/apache/pinot/pull/10449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

[pinot] branch master updated: create segment zk metadata cache (#10455)

2023-03-31 Thread rongr
This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 48deafdf94 create segment zk metadata cache (#1045

[GitHub] [pinot] walterddr merged pull request #10455: create segment zk metadata cache

2023-03-31 Thread via GitHub
walterddr merged PR #10455: URL: https://github.com/apache/pinot/pull/10455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

[GitHub] [pinot] walterddr commented on issue #10499: Partitioned Distinct/DistinctCount

2023-03-31 Thread via GitHub
walterddr commented on issue #10499: URL: https://github.com/apache/pinot/issues/10499#issuecomment-1492023817 as a longer-term solution we are also planning to change the dispatch mechanism in routing manager to include partition to segment list mapping so this decision can be made on serv

[pinot] branch dependabot/pip/docker/images/pinot-superset/redis-4.5.4 created (now d838215f08)

2023-03-31 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/pip/docker/images/pinot-superset/redis-4.5.4 in repository https://gitbox.apache.org/repos/asf/pinot.git at d838215f08 Bump redis from 4.5.3 to 4.5.4 in /docker/images/pino

[GitHub] [pinot] dependabot[bot] opened a new pull request, #10517: Bump redis from 4.5.3 to 4.5.4 in /docker/images/pinot-superset

2023-03-31 Thread via GitHub
dependabot[bot] opened a new pull request, #10517: URL: https://github.com/apache/pinot/pull/10517 Bumps [redis](https://github.com/redis/redis-py) from 4.5.3 to 4.5.4. Release notes Sourced from https://github.com/redis/redis-py/releases";>redis's releases. 4.5.4 Changes

[GitHub] [pinot] abhioncbr commented on issue #10513: [multistage] returning empty string('') instead of null for Case/When

2023-03-31 Thread via GitHub
abhioncbr commented on issue #10513: URL: https://github.com/apache/pinot/issues/10513#issuecomment-1491672075 Thanks, @61yao for the information and for sharing the design doc. Let me know, if I can pick/contribute some work. Thanks -- This is an automated message from the Apache Git Ser

[GitHub] [pinot] KKcorps commented on a diff in pull request #10473: Do not serialize metrics in each Operator

2023-03-31 Thread via GitHub
KKcorps commented on code in PR #10473: URL: https://github.com/apache/pinot/pull/10473#discussion_r1154199486 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/MultiStageOperator.java: ## @@ -39,21 +35,18 @@ public abstract class MultiStageOperator im

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #10515: Allow ValueBlock length to increase in TransformFunction

2023-03-31 Thread via GitHub
xiangfu0 commented on code in PR #10515: URL: https://github.com/apache/pinot/pull/10515#discussion_r1154111743 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/InTransformFunction.java: ## @@ -139,13 +139,11 @@ public TransformResultMetadata getResu

[GitHub] [pinot] xiangfu0 commented on a diff in pull request #10515: Allow ValueBlock length to increase in TransformFunction

2023-03-31 Thread via GitHub
xiangfu0 commented on code in PR #10515: URL: https://github.com/apache/pinot/pull/10515#discussion_r1154094318 ## pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/GroovyTransformFunction.java: ## @@ -429,13 +408,11 @@ public double[][] transformToDoubl