[GitHub] [pinot] yaostartree commented on pull request #9245: [Feature] List files from inputDir with recursive option based on inputFilePatterns in IngestionJobLauncher

2022-08-20 Thread GitBox
yaostartree commented on PR #9245: URL: https://github.com/apache/pinot/pull/9245#issuecomment-1221470816 As discussed, the new implementation also adds the behavior that when input file pattern is null, we also do recursive search in root dir since there are unit test that covers this so I

[GitHub] [pinot] yaostartree commented on a diff in pull request #9245: [Feature] List files from inputDir with recursive option based on inputFilePatterns in IngestionJobLauncher

2022-08-20 Thread GitBox
yaostartree commented on code in PR #9245: URL: https://github.com/apache/pinot/pull/9245#discussion_r950788258 ## pinot-spi/src/main/java/org/apache/pinot/spi/filesystem/PinotFSFactory.java: ## @@ -37,6 +37,7 @@ private PinotFSFactory() { } public static final String LO

[GitHub] [pinot] yaostartree commented on a diff in pull request #9245: [Feature] List files from inputDir with recursive option based on inputFilePatterns in IngestionJobLauncher

2022-08-20 Thread GitBox
yaostartree commented on code in PR #9245: URL: https://github.com/apache/pinot/pull/9245#discussion_r950788194 ## pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-standalone/src/main/java/org/apache/pinot/plugin/ingestion/batch/standalone/SegmentGenerationJobRunner.java: #

[GitHub] [pinot] codecov-commenter commented on pull request #9258: Add metrics to track controller segment download and upload requests in progress

2022-08-20 Thread GitBox
codecov-commenter commented on PR #9258: URL: https://github.com/apache/pinot/pull/9258#issuecomment-1221420391 # [Codecov](https://codecov.io/gh/apache/pinot/pull/9258?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar

[GitHub] [pinot] gviedma opened a new pull request, #9258: Collect in progress segment download and upload gauges for controller

2022-08-20 Thread GitBox
gviedma opened a new pull request, #9258: URL: https://github.com/apache/pinot/pull/9258 Instructions: 1. The PR has to be tagged with at least one of the following labels (*): 1. `feature` 2. `bugfix` 3. `performance` 4. `ui` 5. `backward-incompat` 6. `

[GitHub] [pinot] tanmesh commented on issue #9183: Handle change in default groupId behavior in kafka consumer

2022-08-20 Thread GitBox
tanmesh commented on issue #9183: URL: https://github.com/apache/pinot/issues/9183#issuecomment-1221392038 I am planning to pick this task. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [pinot] tanmesh commented on issue #8842: Table selector won't work if table name is null

2022-08-20 Thread GitBox
tanmesh commented on issue #8842: URL: https://github.com/apache/pinot/issues/8842#issuecomment-1221390826 I am planning to pick up this task. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[pinot] branch master updated: Don't throw exception if partition count can't be fetched (#9249)

2022-08-20 Thread sajjad
This is an automated email from the ASF dual-hosted git repository. sajjad pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 718f41f411 Don't throw exception if partition cou

[GitHub] [pinot] sajjad-moradi merged pull request #9249: Gracefully handle problem in fetching stream partition count for consumption rate limiter

2022-08-20 Thread GitBox
sajjad-moradi merged PR #9249: URL: https://github.com/apache/pinot/pull/9249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.