suddendust commented on issue #9218:
URL: https://github.com/apache/pinot/issues/9218#issuecomment-1220263320
@Jackie-Jiang I can pick this up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
codecov-commenter commented on PR #9247:
URL: https://github.com/apache/pinot/pull/9247#issuecomment-1220220474
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/9247?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
abhs50 opened a new pull request, #9247:
URL: https://github.com/apache/pinot/pull/9247
This PR refactors code to not assume RequestIdentity of type
HttpRequestIdentity only. Moving `getClientIp` to `RequestIdentity` forces all
subclasses to have its own overridden implementation or rely o
codecov-commenter commented on PR #9246:
URL: https://github.com/apache/pinot/pull/9246#issuecomment-1220139475
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/9246?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
mcvsubbu commented on code in PR #9245:
URL: https://github.com/apache/pinot/pull/9245#discussion_r949709164
##
pinot-spi/src/main/java/org/apache/pinot/spi/filesystem/PinotFS.java:
##
@@ -144,6 +143,22 @@ boolean exists(URI fileUri)
long length(URI fileUri)
throws IOE
mcvsubbu commented on code in PR #9245:
URL: https://github.com/apache/pinot/pull/9245#discussion_r949709634
##
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-standalone/src/main/java/org/apache/pinot/plugin/ingestion/batch/standalone/SegmentGenerationJobRunner.java:
xiangfu0 opened a new pull request, #9246:
URL: https://github.com/apache/pinot/pull/9246
Instructions:
1. The PR has to be tagged with at least one of the following labels (*):
1. `feature`
2. `bugfix`
3. `performance`
4. `ui`
5. `backward-incompat`
6.
navina commented on PR #9224:
URL: https://github.com/apache/pinot/pull/9224#issuecomment-1220098245
Let's continue any design related discussions in the [design
doc](https://docs.google.com/document/d/1kTUfBud1SBSh_703mvu6ybkbIwiKKH9eXpdcpEmhC2E/edit)
Thanks!
--
This is an automated
codecov-commenter commented on PR #9242:
URL: https://github.com/apache/pinot/pull/9242#issuecomment-1220088805
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/9242?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
walterddr commented on code in PR #9245:
URL: https://github.com/apache/pinot/pull/9245#discussion_r949679994
##
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-standalone/src/main/java/org/apache/pinot/plugin/ingestion/batch/standalone/SegmentGenerationJobRunner.java:
###
navina commented on PR #9244:
URL: https://github.com/apache/pinot/pull/9244#issuecomment-1220074413
@jadami10 Iiuc, this check basically happens during server startup, but
pertains to a table catching up with some point in its source. This approach
tightly couples table query readiness and
yaostartree opened a new pull request, #9245:
URL: https://github.com/apache/pinot/pull/9245
Instructions:
1. The PR has to be tagged with at least one of the following labels (*):
1. `feature`
2. `bugfix`
3. `performance`
4. `ui`
5. `backward-incompat`
walterddr commented on code in PR #9221:
URL: https://github.com/apache/pinot/pull/9221#discussion_r949660491
##
pom.xml:
##
@@ -136,7 +136,7 @@
4.6
2.7.0
2.3.2
-1.29.0
+1.31.0
Review Comment:
calcite has new javacc/fmpp codegen plugin mojo that we nee
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 6c5d85ef7e Allow explicit partition for real-time segment assignment
(#9225)
add f473bf656e [Refactor] Extract co
Jackie-Jiang merged PR #9243:
URL: https://github.com/apache/pinot/pull/9243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.a
jadami10 opened a new pull request, #9244:
URL: https://github.com/apache/pinot/pull/9244
This is a new `feature` to allow setting a freshness threshold for servers
to catch up to before going healthy and serving queries.
- This will supercede the offset based checker if that is set
navina commented on PR #9224:
URL: https://github.com/apache/pinot/pull/9224#issuecomment-1219953283
> if the header is broken but somehow the payload is ok. what's the behavior
before/after this change
Not sure if I follow what you mean by " header is broken "? Today, if a
record ca
codecov-commenter commented on PR #9243:
URL: https://github.com/apache/pinot/pull/9243#issuecomment-1219841297
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/9243?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softwar
walterddr commented on PR #9224:
URL: https://github.com/apache/pinot/pull/9224#issuecomment-1219819416
is there a backward compatibility story for this change.
- if the header is broken but somehow the payload is ok. what's the behavior
before/after this change
- if header doesn't ag
siddharthteotia commented on PR #9225:
URL: https://github.com/apache/pinot/pull/9225#issuecomment-1219797221
Tagging related PR for reference https://github.com/apache/pinot/pull/9178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
This is an automated email from the ASF dual-hosted git repository.
siddteotia pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from bf66f4 add-table refactor of auth (#9228)
add 6c5d85ef7e Allow explicit partition for real-time segment as
siddharthteotia merged PR #9225:
URL: https://github.com/apache/pinot/pull/9225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pino
klsince opened a new pull request, #9242:
URL: https://github.com/apache/pinot/pull/9242
This PR mainly refines the query cancel resp msg, by defining some explicit
query cancel error code and msg, instead of bubbling up the Executor's
CancellationException.
Also moves the query tra
walterddr closed issue #9155: Remove duplicate query parsing
URL: https://github.com/apache/pinot/issues/9155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
walterddr commented on issue #9155:
URL: https://github.com/apache/pinot/issues/9155#issuecomment-1219781607
closing since it has been addressed in #9202 and #9237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
walterddr closed issue #9026: [multistage] engine cleanup for operator on
intermediate stage
URL: https://github.com/apache/pinot/issues/9026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
walterddr commented on issue #9026:
URL: https://github.com/apache/pinot/issues/9026#issuecomment-1219773491
closing this one as all tickets are addressed (except for cancellation,
which will continue in a separate issue since we already support this in normal
broker request handler)
--
walterddr opened a new issue, #9241:
URL: https://github.com/apache/pinot/issues/9241
https://github.com/apache/pinot/pull/9171 added support for query cancelation
This is a bit more complex in multi-stage engine as there are multiple stage
in various distributed machines.
Thi
Jackie-Jiang commented on code in PR #9184:
URL: https://github.com/apache/pinot/pull/9184#discussion_r949416462
##
pinot-common/src/main/java/org/apache/pinot/common/request/Expression.java:
##
@@ -729,5 +729,4 @@ public void read(org.apache.thrift.protocol.TProtocol prot,
Exp
joshigaurava commented on PR #9161:
URL: https://github.com/apache/pinot/pull/9161#issuecomment-1219735878
@satishwaghela can you please post an updated screenshot? For a UI change,
it helps in correlating code with the output.
--
This is an automated message from the Apache Git Service.
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new bf66f4 add-table refactor of auth (#9228)
bf
apucher merged PR #9228:
URL: https://github.com/apache/pinot/pull/9228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache
siddharthteotia commented on issue #7395:
URL: https://github.com/apache/pinot/issues/7395#issuecomment-1219659071
Did a brief sync up with @atris yesterday. We would like to try this out for
functional and perf testing on our prod use case as soon as the phrase and term
search part is comp
walterddr commented on issue #9240:
URL: https://github.com/apache/pinot/issues/9240#issuecomment-1219521619
CC @KKcorps ^ since we recently also added the schema registry in protobuf
test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
walterddr opened a new issue, #9240:
URL: https://github.com/apache/pinot/issues/9240
https://github.com/apache/pinot/runs/7890686433?check_suite_focus=true
```
2022-08-18T02:12:33.6547446Z [INFO] Running
org.apache.pinot.integration.tests.KafkaConfluentSchemaRegistryAvroMessageDecoder
35 matches
Mail list logo
