[GitHub] [pinot] KKcorps edited a comment on issue #8234: Dependency isolation in Integration Tests

2022-03-10 Thread GitBox
KKcorps edited a comment on issue #8234: URL: https://github.com/apache/pinot/issues/8234#issuecomment-1064820481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [pinot] KKcorps commented on issue #8234: Dependency isolation in Integration Tests

2022-03-10 Thread GitBox
KKcorps commented on issue #8234: URL: https://github.com/apache/pinot/issues/8234#issuecomment-1064820481 @mayankshriv mentioned a good point. What if an integration test wants to use dependency from other modules? e.g. KafkaIntegrationTest using AvroDecoder? -- This is an automated mes

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8273: Add prefixesToRename config for renaming fields upon ingestion

2022-03-10 Thread GitBox
codecov-commenter edited a comment on pull request #8273: URL: https://github.com/apache/pinot/pull/8273#issuecomment-1057399488 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8273?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8273: Add prefixesToRename config for renaming fields upon ingestion

2022-03-10 Thread GitBox
codecov-commenter edited a comment on pull request #8273: URL: https://github.com/apache/pinot/pull/8273#issuecomment-1057399488 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8273?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] yupeng9 commented on a change in pull request #8273: Add prefixesToRename config for renaming fields upon ingestion

2022-03-10 Thread GitBox
yupeng9 commented on a change in pull request #8273: URL: https://github.com/apache/pinot/pull/8273#discussion_r824367859 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformer.java ## @@ -279,6 +295,28 @@ protec

[pinot] branch master updated (9ed08dc -> 262dc50)

2022-03-10 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 9ed08dc Update license & notice for release 0.10.0 (#8330) add 262dc50 Add `less` command to Pinot Docker imag

[GitHub] [pinot] xiangfu0 merged pull request #8336: Add `less` command to Pinot Docker image.

2022-03-10 Thread GitBox
xiangfu0 merged pull request #8336: URL: https://github.com/apache/pinot/pull/8336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8336: Add `less` command to Pinot Docker image.

2022-03-10 Thread GitBox
codecov-commenter edited a comment on pull request #8336: URL: https://github.com/apache/pinot/pull/8336#issuecomment-1064695910 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8336?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8335: [WIP] refactor streaming ingestion transformation code so it can be reused

2022-03-10 Thread GitBox
codecov-commenter edited a comment on pull request #8335: URL: https://github.com/apache/pinot/pull/8335#issuecomment-1064687462 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8335?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter commented on pull request #8336: Add `less` command to Pinot Docker image.

2022-03-10 Thread GitBox
codecov-commenter commented on pull request #8336: URL: https://github.com/apache/pinot/pull/8336#issuecomment-1064695910 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8336?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] jeffreyliu34 commented on pull request #8273: Add prefixesToRename config for renaming fields upon ingestion

2022-03-10 Thread GitBox
jeffreyliu34 commented on pull request #8273: URL: https://github.com/apache/pinot/pull/8273#issuecomment-1064690713 Thanks @yupeng9 , I've updated based on your suggestion and added validation -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8335: [WIP] refactor streaming ingestion transformation code so it can be reused

2022-03-10 Thread GitBox
codecov-commenter edited a comment on pull request #8335: URL: https://github.com/apache/pinot/pull/8335#issuecomment-1064687462 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8335?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter commented on pull request #8335: [WIP] refactor streaming ingestion transformation code so it can be reused

2022-03-10 Thread GitBox
codecov-commenter commented on pull request #8335: URL: https://github.com/apache/pinot/pull/8335#issuecomment-1064687462 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8335?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[pinot] branch helix-1.0 updated (26c052c -> bf3f61e)

2022-03-10 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch helix-1.0 in repository https://gitbox.apache.org/repos/asf/pinot.git. discard 26c052c Upgrade Helix to 1.0.2 add bf3f61e Upgrade Helix to 1.0.2 This update added new revisions after undoi

[GitHub] [pinot] mayankshriv opened a new pull request #8336: Add `less` command to Pinot Docker image.

2022-03-10 Thread GitBox
mayankshriv opened a new pull request #8336: URL: https://github.com/apache/pinot/pull/8336 ## Description - Add the `less` command to Pinot Docker image. ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

[pinot] branch release-0.10.0-rc updated: [maven-release-plugin] prepare for next development iteration

2022-03-10 Thread sajjad
This is an automated email from the ASF dual-hosted git repository. sajjad pushed a commit to branch release-0.10.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/release-0.10.0-rc by this push: new e403377 [maven-release-plu

[pinot] annotated tag release-0.10.0-rc updated (8dbf61e -> e86543f)

2022-03-10 Thread sajjad
This is an automated email from the ASF dual-hosted git repository. sajjad pushed a change to annotated tag release-0.10.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git. *** WARNING: tag release-0.10.0-rc was modified! *** from 8dbf61e (commit) to e86543f (tag) tag

[pinot] branch release-0.10.0-rc updated (08d0db1 -> 8dbf61e)

2022-03-10 Thread sajjad
This is an automated email from the ASF dual-hosted git repository. sajjad pushed a change to branch release-0.10.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git. from 08d0db1 Update the end date in notice file add 8dbf61e [maven-release-plugin] prepare release releas

[GitHub] [pinot] dongxiaoman opened a new pull request #8335: [WIP] refactor streaming ingestion transformation code so it can be reused

2022-03-10 Thread GitBox
dongxiaoman opened a new pull request #8335: URL: https://github.com/apache/pinot/pull/8335 ## Description ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) * [ ] Yes (Please label as **backward-incompat**

[pinot] 02/02: Update the end date in notice file

2022-03-10 Thread sajjad
This is an automated email from the ASF dual-hosted git repository. sajjad pushed a commit to branch release-0.10.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git commit 08d0db1169c5d6466fdb9e769bc4c2a6ed456b59 Author: Sajjad Moradi AuthorDate: Thu Mar 10 11:38:56 2022 -0800

[pinot] 01/02: Update license & notice for release 0.10.0

2022-03-10 Thread sajjad
This is an automated email from the ASF dual-hosted git repository. sajjad pushed a commit to branch release-0.10.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git commit ac2c9a0362f481829772bede6fff43f4681be357 Author: Sajjad Moradi AuthorDate: Wed Mar 9 15:28:59 2022 -0800

[pinot] branch release-0.10.0-rc created (now 08d0db1)

2022-03-10 Thread sajjad
This is an automated email from the ASF dual-hosted git repository. sajjad pushed a change to branch release-0.10.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git. at 08d0db1 Update the end date in notice file This branch includes the following new commits: new ac2c

[GitHub] [pinot] richardstartin commented on issue #8334: Add support for building bloom filters in batch jobs for offline segments

2022-03-10 Thread GitBox
richardstartin commented on issue #8334: URL: https://github.com/apache/pinot/issues/8334#issuecomment-1064630939 Do you have any profiles you could share? We shouldn't rule out making it much faster to build bloom filters. -- This is an automated message from the Apache Git Service. To

[GitHub] [pinot] dang-stripe opened a new issue #8334: Add support for building bloom filters in batch jobs for offline segments

2022-03-10 Thread GitBox
dang-stripe opened a new issue #8334: URL: https://github.com/apache/pinot/issues/8334 We're noticing that building bloom filters takes a considerable amount of time when loading segments on offline Pinot servers, specifically in rebalancing and replacing servers. We'd ideally like to perf

[pinot] branch master updated (8ef4dba -> 9ed08dc)

2022-03-10 Thread sajjad
This is an automated email from the ASF dual-hosted git repository. sajjad pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 8ef4dba Add tlsPort into InstanceConfig so Pinot can start both HTTP and HTTPS ports (#8313) add 9ed08dc Updat

[GitHub] [pinot] sajjad-moradi merged pull request #8330: Update license & notice for release 0.10.0

2022-03-10 Thread GitBox
sajjad-moradi merged pull request #8330: URL: https://github.com/apache/pinot/pull/8330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [pinot] mathieudruart commented on pull request #8017: Fetch Pulsar offsets from Consumer interface instead of Reader

2022-03-10 Thread GitBox
mathieudruart commented on pull request #8017: URL: https://github.com/apache/pinot/pull/8017#issuecomment-1064593993 With the latest version of this patch, we have no more issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[pinot] branch helix-1.0 updated (1cb12fa -> 26c052c)

2022-03-10 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch helix-1.0 in repository https://gitbox.apache.org/repos/asf/pinot.git. discard 1cb12fa Upgrade Helix to 1.0.2 add 53fa9a5 Always handle null time values (#8310) add 4e98070 Fix redire

[GitHub] [pinot] mayankshriv commented on pull request #8017: Fetch Pulsar offsets from Consumer interface instead of Reader

2022-03-10 Thread GitBox
mayankshriv commented on pull request #8017: URL: https://github.com/apache/pinot/pull/8017#issuecomment-1064591050 @npawar @navina please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[pinot] branch release-0.10.0-rc created (now 333eed0)

2022-03-10 Thread sajjad
This is an automated email from the ASF dual-hosted git repository. sajjad pushed a change to branch release-0.10.0-rc in repository https://gitbox.apache.org/repos/asf/pinot.git. at 333eed0 Update the end date in notice file No new revisions were added by this update. -

[GitHub] [pinot] tuor713 commented on issue #7849: Inconsistent Row Counts from Upsert Tables

2022-03-10 Thread GitBox
tuor713 commented on issue #7849: URL: https://github.com/apache/pinot/issues/7849#issuecomment-1064581249 Hm that is not what I saw on (at least on mid-Dec snapshot of 0.10) - on the broker side during query routing there were multiple consuming segments. I presume that is because the new

[GitHub] [pinot] npawar commented on pull request #8309: KafkaConsumer to reset offset to earliest when fetch position out of range

2022-03-10 Thread GitBox
npawar commented on pull request #8309: URL: https://github.com/apache/pinot/pull/8309#issuecomment-1064565659 > Thinking more about the other scenario we discussed offline (OOR due to broker trim, such that startOffset > latest). This patch will result in 1. going to earliest 2. possibly

[GitHub] [pinot] npawar commented on issue #8247: Big increase in latency around the time the new server joins the cluster and starts serving queries

2022-03-10 Thread GitBox
npawar commented on issue #8247: URL: https://github.com/apache/pinot/issues/8247#issuecomment-1064563608 Hey @hristo-stripe , could you share a few more details? 1) Does this always happen, or was this a one off? 2) Which metrics are these exactly - server side (for the exact serv

[GitHub] [pinot] navina commented on a change in pull request #8333: Add support for Kinesis datasource in Github Events recipe

2022-03-10 Thread GitBox
navina commented on a change in pull request #8333: URL: https://github.com/apache/pinot/pull/8333#discussion_r824215855 ## File path: pinot-plugins/pinot-stream-ingestion/pinot-kinesis/pom.xml ## @@ -39,6 +39,7 @@ 2.14.28 4.2 1.0.2 +0.2.19 Review comment:

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8330: Update license & notice for release 0.10.0

2022-03-10 Thread GitBox
codecov-commenter edited a comment on pull request #8330: URL: https://github.com/apache/pinot/pull/8330#issuecomment-1064474229 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8330?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8329: using HttpClient

2022-03-10 Thread GitBox
codecov-commenter edited a comment on pull request #8329: URL: https://github.com/apache/pinot/pull/8329#issuecomment-1063683490 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8329?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter commented on pull request #8330: Update license & notice for release 0.10.0

2022-03-10 Thread GitBox
codecov-commenter commented on pull request #8330: URL: https://github.com/apache/pinot/pull/8330#issuecomment-1064474229 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8330?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8329: using HttpClient

2022-03-10 Thread GitBox
codecov-commenter edited a comment on pull request #8329: URL: https://github.com/apache/pinot/pull/8329#issuecomment-1063683490 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8329?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[pinot] branch update-license-notice-0.10.0 updated (333eed0 -> 39986d5)

2022-03-10 Thread sajjad
This is an automated email from the ASF dual-hosted git repository. sajjad pushed a change to branch update-license-notice-0.10.0 in repository https://gitbox.apache.org/repos/asf/pinot.git. from 333eed0 Update the end date in notice file add 70155ec move memory manager to segment-spi

[pinot] branch update-license-notice-0.10.0 updated (872d1c6 -> 333eed0)

2022-03-10 Thread sajjad
This is an automated email from the ASF dual-hosted git repository. sajjad pushed a change to branch update-license-notice-0.10.0 in repository https://gitbox.apache.org/repos/asf/pinot.git. from 872d1c6 Update license & notice for release 0.10.0 add 333eed0 Update the end date in not

[GitHub] [pinot] sajjad-moradi commented on a change in pull request #8330: Update license & notice for release 0.10.0

2022-03-10 Thread GitBox
sajjad-moradi commented on a change in pull request #8330: URL: https://github.com/apache/pinot/pull/8330#discussion_r824089383 ## File path: NOTICE-binary ## @@ -55,16 +55,16 @@ This product includes software from the Spring Framework, under the Apache License 2.0 (see: Strin

[GitHub] [pinot] KKcorps commented on a change in pull request #8333: Add support for Kinesis datasource in Github Events recipe

2022-03-10 Thread GitBox
KKcorps commented on a change in pull request #8333: URL: https://github.com/apache/pinot/pull/8333#discussion_r824084184 ## File path: pinot-tools/src/main/resources/examples/stream/githubEvents/pullRequestMergedEvents_kinesis_realtime_table_config.json ## @@ -0,0 +1,39 @@ +{

[GitHub] [pinot] siddharthteotia commented on issue #8260: Add support for JOIN - Multi-stage execution query engine

2022-03-10 Thread GitBox
siddharthteotia commented on issue #8260: URL: https://github.com/apache/pinot/issues/8260#issuecomment-1064414242 Linking related old issue for reference - https://github.com/apache/pinot/issues/5664 This one should be used and the 5664 can remain open or be closed -- This is an

[GitHub] [pinot] codecov-commenter edited a comment on pull request #8329: using HttpClient

2022-03-10 Thread GitBox
codecov-commenter edited a comment on pull request #8329: URL: https://github.com/apache/pinot/pull/8329#issuecomment-1063683490 # [Codecov](https://codecov.io/gh/apache/pinot/pull/8329?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[pinot] branch sajjad-test created (now 872d1c6)

2022-03-10 Thread sajjad
This is an automated email from the ASF dual-hosted git repository. sajjad pushed a change to branch sajjad-test in repository https://gitbox.apache.org/repos/asf/pinot.git. at 872d1c6 Update license & notice for release 0.10.0 No new revisions were added by this update. ---

[GitHub] [pinot] mayankshriv commented on issue #8260: Add support for JOIN - Multi-stage execution query engine

2022-03-10 Thread GitBox
mayankshriv commented on issue #8260: URL: https://github.com/apache/pinot/issues/8260#issuecomment-1064396466 Lets knock this down. +1 With all the +1's above, and no -1, I think it is safe to conclude that we can move ahead with detailed design+impl phase @walterddr. -- This is

[GitHub] [pinot] xiangfu0 commented on issue #8260: Add support for JOIN - Multi-stage execution query engine

2022-03-10 Thread GitBox
xiangfu0 commented on issue #8260: URL: https://github.com/apache/pinot/issues/8260#issuecomment-1064394783 +1000! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [pinot] siddharthteotia commented on issue #8260: Add support for JOIN - Multi-stage execution query engine

2022-03-10 Thread GitBox
siddharthteotia commented on issue #8260: URL: https://github.com/apache/pinot/issues/8260#issuecomment-1064394083 +1 on this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[pinot] branch helix-1.0 updated (a902732 -> 1cb12fa)

2022-03-10 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch helix-1.0 in repository https://gitbox.apache.org/repos/asf/pinot.git. omit a902732 Upgrade Helix to 1.0.2 add 1cb12fa Upgrade Helix to 1.0.2 This update added new revisions after undoi

[GitHub] [pinot] xiangfu0 commented on a change in pull request #8330: Update license & notice for release 0.10.0

2022-03-10 Thread GitBox
xiangfu0 commented on a change in pull request #8330: URL: https://github.com/apache/pinot/pull/8330#discussion_r824023690 ## File path: NOTICE-binary ## @@ -55,16 +55,16 @@ This product includes software from the Spring Framework, under the Apache License 2.0 (see: StringUtil

[GitHub] [pinot] xiangfu0 commented on pull request #8313: Add tlsPort into InstanceConfig so Pinot can start both HTTP and HTTPS ports

2022-03-10 Thread GitBox
xiangfu0 commented on pull request #8313: URL: https://github.com/apache/pinot/pull/8313#issuecomment-1064360584 > > Unrelated to this but while you are changing this, Can we also have external host name and internal host name similar to Kafkas advertised id > > Good idea; we need to

[pinot] branch master updated: Add tlsPort into InstanceConfig so Pinot can start both HTTP and HTTPS ports (#8313)

2022-03-10 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 8ef4dba Add tlsPort into InstanceConfig so Pino

[GitHub] [pinot] xiangfu0 merged pull request #8313: Add tlsPort into InstanceConfig so Pinot can start both HTTP and HTTPS ports

2022-03-10 Thread GitBox
xiangfu0 merged pull request #8313: URL: https://github.com/apache/pinot/pull/8313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[pinot] branch master updated: Fix segment status checker to skip push in-progress segments (#8323)

2022-03-10 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new e87c055 Fix segment status checker to skip push in

[GitHub] [pinot] jackjlli merged pull request #8323: Fix segment status checker to skip push in-progress segments

2022-03-10 Thread GitBox
jackjlli merged pull request #8323: URL: https://github.com/apache/pinot/pull/8323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [pinot] KKcorps commented on a change in pull request #8333: Add support for Kinesis datasource in Github Events recipe

2022-03-10 Thread GitBox
KKcorps commented on a change in pull request #8333: URL: https://github.com/apache/pinot/pull/8333#discussion_r823648416 ## File path: pinot-tools/src/main/resources/examples/stream/githubEvents/pullRequestMergedEvents_kinesis_realtime_table_config.json ## @@ -0,0 +1,39 @@ +{

[GitHub] [pinot] KKcorps commented on a change in pull request #8333: Add support for Kinesis datasource in Github Events recipe

2022-03-10 Thread GitBox
KKcorps commented on a change in pull request #8333: URL: https://github.com/apache/pinot/pull/8333#discussion_r823648112 ## File path: pinot-plugins/pinot-stream-ingestion/pinot-kinesis/pom.xml ## @@ -39,6 +39,7 @@ 2.14.28 4.2 1.0.2 +0.2.19 Review comment: