[GitHub] [pinot] codecov-commenter edited a comment on pull request #7982: Remove duplicate code when validate controller aggregated metadata response

codecov-commenter edited a comment on pull request #7982: URL: https://github.com/apache/pinot/pull/7982#issuecomment-1007881824 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7982?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7982: Remove duplicate code when validate controller aggregated metadata response

codecov-commenter edited a comment on pull request #7982: URL: https://github.com/apache/pinot/pull/7982#issuecomment-1007881824 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7982?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7982: Remove duplicate code when validate controller aggregated metadata response

codecov-commenter edited a comment on pull request #7982: URL: https://github.com/apache/pinot/pull/7982#issuecomment-1007881824 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7982?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter commented on pull request #7982: Remove duplicate code when validate controller aggregated metadata response

codecov-commenter commented on pull request #7982: URL: https://github.com/apache/pinot/pull/7982#issuecomment-1007881824 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7982?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] mqliang opened a new pull request #7982: Remove duplicate code when validate controller aggregated metadata response

mqliang opened a new pull request #7982: URL: https://github.com/apache/pinot/pull/7982 …sponse ## Description ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) * [ ] Yes (Please label as **backward

[GitHub] [pinot] joshigaurava commented on pull request #7981: make query stats always show even there's error

joshigaurava commented on pull request #7981: URL: https://github.com/apache/pinot/pull/7981#issuecomment-1007875967 Looks good. 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [pinot] klsince commented on a change in pull request #7969: refactor segment loading logic in BaseTableDataManager to decouple it with local segment directory

klsince commented on a change in pull request #7969: URL: https://github.com/apache/pinot/pull/7969#discussion_r780612465 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java ## @@ -335,26 +327,19 @@ public void reloadSegment(Stri

[GitHub] [pinot] klsince commented on a change in pull request #7969: refactor segment loading logic in BaseTableDataManager to decouple it with local segment directory

klsince commented on a change in pull request #7969: URL: https://github.com/apache/pinot/pull/7969#discussion_r780609866 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java ## @@ -277,49 +282,36 @@ public void addSegmentError(St

[GitHub] [pinot] mcvsubbu commented on a change in pull request #7969: refactor segment loading logic in BaseTableDataManager to decouple it with local segment directory

mcvsubbu commented on a change in pull request #7969: URL: https://github.com/apache/pinot/pull/7969#discussion_r780606167 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java ## @@ -335,26 +327,19 @@ public void reloadSegment(Str

[GitHub] [pinot] siddharthteotia commented on a change in pull request #7959: [WIP] [7867] Handle Select * with Extra Columns

siddharthteotia commented on a change in pull request #7959: URL: https://github.com/apache/pinot/pull/7959#discussion_r780601346 ## File path: pinot-broker/src/test/java/org/apache/pinot/broker/requesthandler/SelectStarWithOtherColsRewriteTest.java ## @@ -0,0 +1,90 @@ +/** +

[pinot] branch master updated: Fix ByteArray datatype column metadata getMaxValue NPE bug and expose maxNumMultiValues (#7918)

This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 06888d8 Fix ByteArray datatype column metada

[GitHub] [pinot] siddharthteotia merged pull request #7918: Fix column metadata getMaxValue NPE bug and expose maxNumMultiValues

siddharthteotia merged pull request #7918: URL: https://github.com/apache/pinot/pull/7918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

[GitHub] [pinot] mcvsubbu commented on a change in pull request #7969: refactor segment loading logic in BaseTableDataManager to decouple it with local segment directory

mcvsubbu commented on a change in pull request #7969: URL: https://github.com/apache/pinot/pull/7969#discussion_r780595425 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java ## @@ -480,12 +426,138 @@ File getSegmentDataDir(Strin

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7969: refactor segment loading logic in BaseTableDataManager to decouple it with local segment directory

codecov-commenter edited a comment on pull request #7969: URL: https://github.com/apache/pinot/pull/7969#issuecomment-1002909897 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7969?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7969: refactor segment loading logic in BaseTableDataManager to decouple it with local segment directory

codecov-commenter edited a comment on pull request #7969: URL: https://github.com/apache/pinot/pull/7969#issuecomment-1002909897 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7969?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7981: make query stats always show even there's error

codecov-commenter edited a comment on pull request #7981: URL: https://github.com/apache/pinot/pull/7981#issuecomment-1007672527 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7981?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7981: make query stats always show even there's error

codecov-commenter edited a comment on pull request #7981: URL: https://github.com/apache/pinot/pull/7981#issuecomment-1007672527 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7981?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] mapshen edited a comment on issue #7850: Segment replicas leading to split query views

mapshen edited a comment on issue #7850: URL: https://github.com/apache/pinot/issues/7850#issuecomment-1007809860 The issue also manifests when a segment is flushed and built. Since sync the built segment to the non-committer servers may take some time and the committer server will first s

[GitHub] [pinot] mapshen commented on issue #7850: Segment replicas leading to split query views

mapshen commented on issue #7850: URL: https://github.com/apache/pinot/issues/7850#issuecomment-1007809860 The issue also manifest when a segment is flushed and built. Since sync the built segment to the non-committer servers may take some time and the committer server will first start con

[GitHub] [pinot] klsince commented on a change in pull request #7969: refactor segment loading logic in BaseTableDataManager to decouple it with local segment directory

klsince commented on a change in pull request #7969: URL: https://github.com/apache/pinot/pull/7969#discussion_r780565301 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java ## @@ -480,12 +426,138 @@ File getSegmentDataDir(String

[GitHub] [pinot] klsince commented on a change in pull request #7969: refactor segment loading logic in BaseTableDataManager to decouple it with local segment directory

klsince commented on a change in pull request #7969: URL: https://github.com/apache/pinot/pull/7969#discussion_r780564787 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java ## @@ -480,12 +426,138 @@ File getSegmentDataDir(String

[GitHub] [pinot] joshigaurava commented on a change in pull request #7981: make query stats always show even there's error

joshigaurava commented on a change in pull request #7981: URL: https://github.com/apache/pinot/pull/7981#discussion_r780557066 ## File path: pinot-controller/src/main/resources/app/pages/Query.tsx ## @@ -473,106 +473,106 @@ const QueryPage = () => { {queryLoader ?

[GitHub] [pinot] joshigaurava commented on a change in pull request #7981: make query stats always show even there's error

joshigaurava commented on a change in pull request #7981: URL: https://github.com/apache/pinot/pull/7981#discussion_r780552843 ## File path: pinot-controller/src/main/resources/app/utils/PinotMethodUtils.ts ## @@ -228,57 +228,60 @@ const getQueryResults = (params, url, checkedO

[GitHub] [pinot] klsince commented on a change in pull request #7969: refactor segment loading logic in BaseTableDataManager to decouple it with local segment directory

klsince commented on a change in pull request #7969: URL: https://github.com/apache/pinot/pull/7969#discussion_r780532850 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java ## @@ -277,49 +282,36 @@ public void addSegmentError(St

[GitHub] [pinot] chenboat merged pull request #7979: Fix the issue that Pinot upsert table's uploaded segments get deleted when server restarts.

chenboat merged pull request #7979: URL: https://github.com/apache/pinot/pull/7979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[pinot] branch master updated (4bae48b -> 0874f5d)

This is an automated email from the ASF dual-hosted git repository. tingchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 4bae48b Re-enable kinesis test (#7960) add 0874f5d Fix the issues that Pinot upsert table's uploaded segments

[GitHub] [pinot] klsince commented on a change in pull request #7969: refactor segment loading logic in BaseTableDataManager to decouple it with local segment directory

klsince commented on a change in pull request #7969: URL: https://github.com/apache/pinot/pull/7969#discussion_r780526797 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java ## @@ -480,12 +426,138 @@ File getSegmentDataDir(String

[GitHub] [pinot] klsince commented on a change in pull request #7969: refactor segment loading logic in BaseTableDataManager to decouple it with local segment directory

klsince commented on a change in pull request #7969: URL: https://github.com/apache/pinot/pull/7969#discussion_r780526138 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java ## @@ -335,26 +327,17 @@ public void reloadSegment(Stri

[GitHub] [pinot] mcvsubbu commented on a change in pull request #7969: refactor segment loading logic in BaseTableDataManager to decouple it with local segment directory

mcvsubbu commented on a change in pull request #7969: URL: https://github.com/apache/pinot/pull/7969#discussion_r780493752 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java ## @@ -335,26 +327,17 @@ public void reloadSegment(Str

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7918: Fix column metadata getMaxValue NPE bug and expose maxNumMultiValues

codecov-commenter edited a comment on pull request #7918: URL: https://github.com/apache/pinot/pull/7918#issuecomment-996234697 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7918?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] mcvsubbu commented on a change in pull request #7969: refactor segment loading logic in BaseTableDataManager to decouple it with local segment directory

mcvsubbu commented on a change in pull request #7969: URL: https://github.com/apache/pinot/pull/7969#discussion_r780490610 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java ## @@ -277,49 +282,36 @@ public void addSegmentError(S

[GitHub] [pinot] mcvsubbu commented on a change in pull request #7969: refactor segment loading logic in BaseTableDataManager to decouple it with local segment directory

mcvsubbu commented on a change in pull request #7969: URL: https://github.com/apache/pinot/pull/7969#discussion_r780490610 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java ## @@ -277,49 +282,36 @@ public void addSegmentError(S

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7981: make query stats always show even there's error

codecov-commenter edited a comment on pull request #7981: URL: https://github.com/apache/pinot/pull/7981#issuecomment-1007672527 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7981?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7981: make query stats always show even there's error

codecov-commenter edited a comment on pull request #7981: URL: https://github.com/apache/pinot/pull/7981#issuecomment-1007672527 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7981?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=

[GitHub] [pinot] codecov-commenter commented on pull request #7981: make query stats always show even there's error

codecov-commenter commented on pull request #7981: URL: https://github.com/apache/pinot/pull/7981#issuecomment-1007672527 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7981?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apa

[GitHub] [pinot] siddharthteotia commented on a change in pull request #7972: Broker Side validation for the query with aggregation and col but without group by

siddharthteotia commented on a change in pull request #7972: URL: https://github.com/apache/pinot/pull/7972#discussion_r780454060 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -147,6 +147,9 @@ static void validate(PinotQuery

[GitHub] [pinot] siddharthteotia commented on a change in pull request #7959: [WIP] [7867] Handle Select * with Extra Columns

siddharthteotia commented on a change in pull request #7959: URL: https://github.com/apache/pinot/pull/7959#discussion_r780460346 ## File path: pinot-broker/src/test/java/org/apache/pinot/broker/requesthandler/SelectStarWithOtherColsRewriteTest.java ## @@ -0,0 +1,90 @@ +/** +

[GitHub] [pinot] siddharthteotia commented on a change in pull request #7959: [WIP] [7867] Handle Select * with Extra Columns

siddharthteotia commented on a change in pull request #7959: URL: https://github.com/apache/pinot/pull/7959#discussion_r780460346 ## File path: pinot-broker/src/test/java/org/apache/pinot/broker/requesthandler/SelectStarWithOtherColsRewriteTest.java ## @@ -0,0 +1,90 @@ +/** +

[GitHub] [pinot] walterddr opened a new pull request #7981: make query stats always show even there's error

walterddr opened a new pull request #7981: URL: https://github.com/apache/pinot/pull/7981 fix the issue that currently if there's an error in the result, query stats are not shown on UI. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [pinot] siddharthteotia commented on a change in pull request #7972: Broker Side validation for the query with aggregation and col but without group by

siddharthteotia commented on a change in pull request #7972: URL: https://github.com/apache/pinot/pull/7972#discussion_r780454060 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -147,6 +147,9 @@ static void validate(PinotQuery

[GitHub] [pinot] PrachiPrakash commented on a change in pull request #7972: Broker Side validation for the query with aggregation and col but without group by

PrachiPrakash commented on a change in pull request #7972: URL: https://github.com/apache/pinot/pull/7972#discussion_r780347555 ## File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java ## @@ -147,6 +147,9 @@ static void validate(PinotQuery pi

[GitHub] [pinot] richardstartin opened a new issue #7980: `InIdSetTransformFunction` is inefficient

richardstartin opened a new issue #7980: URL: https://github.com/apache/pinot/issues/7980 `InIdSetTransfomFunction.transformToIntValuesSV` works by expanding a set into an inflated bitmap using 32 bits per docId by checking if each dictId is in the `IdSet` or not: ```java c