jackjlli commented on a change in pull request #7824:
URL: https://github.com/apache/pinot/pull/7824#discussion_r761672549
##
File path:
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/PinotDriver.java
##
@@ -68,6 +69,9 @@ public Connection connect(String
codecov-commenter edited a comment on pull request #7861:
URL: https://github.com/apache/pinot/pull/7861#issuecomment-985233905
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7861?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
shahsank3t commented on pull request #7857:
URL: https://github.com/apache/pinot/pull/7857#issuecomment-985242988
Thank you @jadami10 for this enhancement.
+1, Changes look good to me.
Just one nitpick: should we move the `Wrap lines` toggle on the right-hand
side instead of the left?
codecov-commenter edited a comment on pull request #7861:
URL: https://github.com/apache/pinot/pull/7861#issuecomment-985233905
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7861?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter commented on pull request #7861:
URL: https://github.com/apache/pinot/pull/7861#issuecomment-985233905
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7861?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
atris edited a comment on issue #5246:
URL: https://github.com/apache/pinot/issues/5246#issuecomment-985227111
@kishoreg as discussed offline, I will take this up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
atris commented on issue #5246:
URL: https://github.com/apache/pinot/issues/5246#issuecomment-985227111
@kishoreg as discussed offline, I wj take this up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
Manis99803 opened a new pull request #7861:
URL: https://github.com/apache/pinot/pull/7861
## Description
Currently if we have a semicolon in the query, Pinot throws exception.
However, semicolon are used in the SQL query to mark the termination of the
query, and if a semicolon is prese
codecov-commenter edited a comment on pull request #7860:
URL: https://github.com/apache/pinot/pull/7860#issuecomment-985170169
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7860?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7860:
URL: https://github.com/apache/pinot/pull/7860#issuecomment-985170169
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7860?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7860:
URL: https://github.com/apache/pinot/pull/7860#issuecomment-985170169
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7860?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter commented on pull request #7860:
URL: https://github.com/apache/pinot/pull/7860#issuecomment-985170169
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7860?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git.
from 5b9b836 Add Post-Aggregation Gapfilling functionality. (#7781)
add e572ea0 generator.sh - gracefully handle upp
Jackie-Jiang merged pull request #7858:
URL: https://github.com/apache/pinot/pull/7858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
Jackie-Jiang commented on pull request #7857:
URL: https://github.com/apache/pinot/pull/7857#issuecomment-985157332
@shahsank3t Can you please help take a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Jackie-Jiang commented on a change in pull request #7804:
URL: https://github.com/apache/pinot/pull/7804#discussion_r761600020
##
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/data/DateTimeFormatPatternSpec.java
##
@@ -52,7 +66,28 @@ public DateTimeFormatPatternSpec(
Jackie-Jiang commented on issue #7856:
URL: https://github.com/apache/pinot/issues/7856#issuecomment-985155322
The issue is that `schemaName` is not configured within the offline table
config, so the time boundary manager is not able to find it
--
This is an automated message from the Ap
Jackie-Jiang commented on pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#issuecomment-985152221
> Could this be handled differently without the cache by reordering the
execution graph to deduplicate common subexpressions?
I agree. Ideally we should deduplicate the
Jackie-Jiang edited a comment on issue #7213:
URL: https://github.com/apache/pinot/issues/7213#issuecomment-985134802
@jackjlli Weixiang (@weixiangsun) is working on the gapfill function (#7422)
which is quite similar to the window function. Both features require reading
the results from p
Jackie-Jiang commented on issue #7213:
URL: https://github.com/apache/pinot/issues/7213#issuecomment-985134802
@jackjlli Weixiang (@weixiangsun) is working on the gapfill function which
is quite similar to the window function. Both features require reading the
results from previous rows. C
Jackie-Jiang commented on issue #7422:
URL: https://github.com/apache/pinot/issues/7422#issuecomment-985131404
Related to #7213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
Jackie-Jiang merged pull request #7781:
URL: https://github.com/apache/pinot/pull/7781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 5b9b836 Add Post-Aggregation Gapfilling function
Jackie-Jiang opened a new pull request #7860:
URL: https://github.com/apache/pinot/pull/7860
We should index the record before updating the upsert metadata (updating the
validDocIds) so that when the new record is validated, it immediately becomes
queryable. This can address the off-by-one
mqliang closed pull request #7859:
URL: https://github.com/apache/pinot/pull/7859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
mqliang opened a new pull request #7859:
URL: https://github.com/apache/pinot/pull/7859
## Description
This PR address https://github.com/apache/pinot/issues/6732, removing
DataTable V2 code after 0.8.0 release
## Upgrade Notes
Does this PR prevent a zero down-time upg
codecov-commenter edited a comment on pull request #7858:
URL: https://github.com/apache/pinot/pull/7858#issuecomment-985114530
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7858?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter commented on pull request #7858:
URL: https://github.com/apache/pinot/pull/7858#issuecomment-985114530
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7858?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
asockalingam commented on issue #5246:
URL: https://github.com/apache/pinot/issues/5246#issuecomment-985110285
> Yes, it's a bit challenging but we have received this request multiple
times. Please consider upvoting the feature
where do we upvote?
--
This is an automated message
apucher opened a new pull request #7858:
URL: https://github.com/apache/pinot/pull/7858
## Description
another fix for the recent cli parser change. gracefully handle uppercase
format in the `GenerateData` command.
## Upgrade Notes
Does this PR prevent a zero down-time upgrade?
sajjad-moradi commented on issue #7850:
URL: https://github.com/apache/pinot/issues/7850#issuecomment-985083275
@mcvsubbu did we have any other reason for not chasing the moving target for
consumption?
--
This is an automated message from the Apache Git Service.
To respond to the message
sajjad-moradi commented on issue #7850:
URL: https://github.com/apache/pinot/issues/7850#issuecomment-985082915
@mapshen if the behaviour of offset based status checker is still not
desirable for your use case, you can disable it and use the consumption
catch-up wait time. If you do that,
xiangfu0 commented on a change in pull request #7838:
URL: https://github.com/apache/pinot/pull/7838#discussion_r759690586
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java
##
@@ -235,14 +236,21 @@ public void start()
//
sajjad-moradi commented on issue #7850:
URL: https://github.com/apache/pinot/issues/7850#issuecomment-985080568
We have seen some use cases for which the stream has a bursty traffic
pattern. Let's say we wanted to fetch the latest stream offset on every status
call. If every time when the
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a change to branch generator-sh-gracefully-handle-uppercase
in repository https://gitbox.apache.org/repos/asf/pinot.git.
at 96ba6b6 generator.sh - gracefully handle uppercase format
This branch includes th
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a commit to branch generator-sh-gracefully-handle-uppercase
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit 96ba6b68f1f78ec283770e4eb4289f3d24efd33b
Author: Alexander Pucher
AuthorDate: Thu Dec
codecov-commenter edited a comment on pull request #7838:
URL: https://github.com/apache/pinot/pull/7838#issuecomment-982162356
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7838?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7838:
URL: https://github.com/apache/pinot/pull/7838#issuecomment-982162356
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7838?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 5006bbc Clean up deprecated fields from segment
Jackie-Jiang merged pull request #7853:
URL: https://github.com/apache/pinot/pull/7853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
codecov-commenter commented on pull request #7857:
URL: https://github.com/apache/pinot/pull/7857#issuecomment-984994027
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7857?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
codecov-commenter edited a comment on pull request #7853:
URL: https://github.com/apache/pinot/pull/7853#issuecomment-984216830
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7853?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7804:
URL: https://github.com/apache/pinot/pull/7804#issuecomment-974570171
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7804?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7853:
URL: https://github.com/apache/pinot/pull/7853#issuecomment-984216830
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7853?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
jadami10 opened a new pull request #7857:
URL: https://github.com/apache/pinot/pull/7857
## Description
- Adds a toggle to wrap lines for the CustomCodeMirror
- uses it in the zk browser
Note: i had to test with material-ui: 4.12.3 becuase the zookeeper browser
is refusing
codecov-commenter edited a comment on pull request #7804:
URL: https://github.com/apache/pinot/pull/7804#issuecomment-974570171
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7804?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git.
from 1baad80 Tune local kafka cluster config to be more stable (#7854)
add 38da86d Remove deprecated method from Str
Jackie-Jiang merged pull request #7852:
URL: https://github.com/apache/pinot/pull/7852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
walterddr commented on a change in pull request #7804:
URL: https://github.com/apache/pinot/pull/7804#discussion_r761377818
##
File path:
pinot-spi/src/main/java/org/apache/pinot/spi/data/DateTimeFormatPatternSpec.java
##
@@ -52,7 +66,28 @@ public DateTimeFormatPatternSpec(Str
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git.
from 41c98d7 replication factor to be obtained from tenant configuration
in case of dimension table (#7848)
add 1baa
Jackie-Jiang merged pull request #7854:
URL: https://github.com/apache/pinot/pull/7854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
Jackie-Jiang closed issue #7843:
URL: https://github.com/apache/pinot/issues/7843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 41c98d7 replication factor to be obtained from t
Jackie-Jiang merged pull request #7848:
URL: https://github.com/apache/pinot/pull/7848
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
mapshen commented on issue #7850:
URL: https://github.com/apache/pinot/issues/7850#issuecomment-984757847
@sajjad-moradi It seems the latest offset is only fetched once when the
segment starts to consume. However, in cases where it takes quite a while for a
segment to catch, this approach
"tableIndexConfig": {
"loadMode": "MMAP",
"streamConfigs": {
"streamType": "kafka",
"stream.kafka.consumer.type": "lowlevel",
richardstartin commented on pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#issuecomment-984548475
@Jackie-Jiang to demonstrate an open mind, I've implemented your suggestion
here:
https://github.com/apache/pinot/pull/7820/commits/f75135887001394abb4097a9ddae486e5cea1c48
richardstartin commented on pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#issuecomment-984389687
@Jackie-Jiang the reason I bypassed the cache is because the cache would
need a composite key to avoid different JSON path transformations sharing
results spuriously. It’s
58 matches
Mail list logo
