amrishlal commented on a change in pull request #7568:
URL: https://github.com/apache/pinot/pull/7568#discussion_r759008622
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/predicate/PredicateEvaluator.java
##
@@ -28,6 +28,16 @@
* APIs for both
amrishlal commented on a change in pull request #7568:
URL: https://github.com/apache/pinot/pull/7568#discussion_r759008062
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/request/context/utils/QueryContextUtils.java
##
@@ -52,4 +58,79 @@ public static boole
siddharthteotia commented on pull request #7830:
URL: https://github.com/apache/pinot/pull/7830#issuecomment-982323715
Reviewed the design doc. Will review the PR tomorrow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
weixiangsun edited a comment on issue #7835:
URL: https://github.com/apache/pinot/issues/7835#issuecomment-982291784
Does the index here mean IndexSegment? @atris
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
weixiangsun commented on issue #7835:
URL: https://github.com/apache/pinot/issues/7835#issuecomment-982291784
Does the index here mean IndexSegment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
atris commented on issue #7835:
URL: https://github.com/apache/pinot/issues/7835#issuecomment-982279802
Well, I am working on adding multiple predicate evaluation within a single
query, where each predicate can be evaluated using an index.
CASE can be modified to use this mechanism
weixiangsun commented on issue #7835:
URL: https://github.com/apache/pinot/issues/7835#issuecomment-982277821
What @atris is working on is to implement filter clause instead of case when
clause. His work item does not add general index access support to case
transform function.
@atr
Jackie-Jiang commented on issue #7835:
URL: https://github.com/apache/pinot/issues/7835#issuecomment-982273185
I believe @atris is working on that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Jackie-Jiang commented on a change in pull request #7568:
URL: https://github.com/apache/pinot/pull/7568#discussion_r758918478
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/request/context/utils/QueryContextUtils.java
##
@@ -52,4 +58,79 @@ public static bo
codecov-commenter edited a comment on pull request #7840:
URL: https://github.com/apache/pinot/pull/7840#issuecomment-982256775
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7840?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7841:
URL: https://github.com/apache/pinot/pull/7841#issuecomment-982256884
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7841?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter commented on pull request #7841:
URL: https://github.com/apache/pinot/pull/7841#issuecomment-982256884
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7841?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
codecov-commenter commented on pull request #7840:
URL: https://github.com/apache/pinot/pull/7840#issuecomment-982256775
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7840?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
codecov-commenter edited a comment on pull request #7568:
URL: https://github.com/apache/pinot/pull/7568#issuecomment-941686660
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7568?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
siddharthteotia commented on a change in pull request #7840:
URL: https://github.com/apache/pinot/pull/7840#discussion_r758906121
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/predicate/BasePredicateEvaluator.java
##
@@ -18,7 +18,25 @@
*/
pack
jadami10 opened a new pull request #7841:
URL: https://github.com/apache/pinot/pull/7841
## Description
I had some extra time, and this has been bothering me, so I decided to add
it. Doing `cmd + /` in the query console now will add/remove `-- ` before the
lines.
A video is
weixiangsun commented on issue #7835:
URL: https://github.com/apache/pinot/issues/7835#issuecomment-982233908
adding general index access support to case transform function via
BlockValSet or some other way?
--
This is an automated message from the Apache Git Service.
To respond to the
Jackie-Jiang opened a new pull request #7840:
URL: https://github.com/apache/pinot/pull/7840
Add `getPredicate()` to `PredicateEvaluator` interface for query explanation
purpose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
Jackie-Jiang commented on issue #7835:
URL: https://github.com/apache/pinot/issues/7835#issuecomment-982220389
Understood. In order to solve `IS NULL` and `IS NOT NULL`, we need to access
the `NullValueVector` index. Currently case transform function does not support
accessing index, so I'
weixiangsun commented on issue #7835:
URL: https://github.com/apache/pinot/issues/7835#issuecomment-982217470
Is Null, Is Not Null checking are not only for case transform function. It
might be for If function even though it is not supported by pinot yet.
--
This is an automated message
Jackie-Jiang commented on issue #7835:
URL: https://github.com/apache/pinot/issues/7835#issuecomment-982211557
The ask itself is different, but in order to solve the issue, we need to
access the index within the case transform function. We should try to solve
these 2 issues together by all
codecov-commenter edited a comment on pull request #7568:
URL: https://github.com/apache/pinot/pull/7568#issuecomment-941686660
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7568?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
weixiangsun edited a comment on issue #7835:
URL: https://github.com/apache/pinot/issues/7835#issuecomment-982207016
They are different. Please reference to
https://github.com/apache/pinot/issues/7691#issuecomment-982199086
@Jackie-Jiang
--
This is an automated message from the Apach
weixiangsun commented on issue #7835:
URL: https://github.com/apache/pinot/issues/7835#issuecomment-982207016
They are different. Please reference to
https://github.com/apache/pinot/issues/7691#issuecomment-982199086
--
This is an automated message from the Apache Git Service.
To respond
codecov-commenter edited a comment on pull request #7568:
URL: https://github.com/apache/pinot/pull/7568#issuecomment-941686660
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7568?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
weixiangsun commented on issue #7691:
URL: https://github.com/apache/pinot/issues/7691#issuecomment-982199086
I see. This is used to reduce the data set for aggregation. My use case is:
select case
when timeStamp IS NULL then now()
else timestamp
end
from meetupRsvp
htt
codecov-commenter edited a comment on pull request #7839:
URL: https://github.com/apache/pinot/pull/7839#issuecomment-982180134
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7839?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter commented on pull request #7839:
URL: https://github.com/apache/pinot/pull/7839#issuecomment-982180134
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7839?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
codecov-commenter commented on pull request #7838:
URL: https://github.com/apache/pinot/pull/7838#issuecomment-982162356
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7838?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
walterddr opened a new pull request #7839:
URL: https://github.com/apache/pinot/pull/7839
Currently GRPCServer only support selection-only queries.
This PR adds support for streaming back all other types of query response
from server to broker.
This makes possible for the next s
richardstartin commented on pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#issuecomment-982151840
> Conceptually, we are moving from a Column to Column + path but modelling
the path as an evaluator. But the query layer is deciding the evaluator instead
of the storage la
amrishlal commented on a change in pull request #7568:
URL: https://github.com/apache/pinot/pull/7568#discussion_r758831328
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##
@@ -225,7 +225,13 @@ private BrokerRespo
codecov-commenter edited a comment on pull request #7568:
URL: https://github.com/apache/pinot/pull/7568#issuecomment-941686660
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7568?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
atris commented on issue #7691:
URL: https://github.com/apache/pinot/issues/7691#issuecomment-982145872
No, a single scan with multiple predicate evaluations along the way. Please
see:
https://github.com/apache/pinot/pull/7830
--
This is an automated message from the Apache Git Se
richardstartin edited a comment on pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#issuecomment-982140750
> Conceptually, we are moving from a Column to Column + path but modelling
the path as an evaluator. But the query layer is deciding the evaluator instead
of the sto
richardstartin edited a comment on pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#issuecomment-982140750
> Conceptually, we are moving from a Column to Column + path but modelling
the path as an evaluator. But the query layer is deciding the evaluator instead
of the sto
This is an automated email from the ASF dual-hosted git repository.
mcvsubbu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git.
from 9ba03e4 Fix thread safety issue and add cache to EmptySegmentPruner
(#7828)
add dfb7fee Make split commit th
mcvsubbu merged pull request #7780:
URL: https://github.com/apache/pinot/pull/7780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubsc
richardstartin edited a comment on pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#issuecomment-982140750
> Conceptually, we are moving from a Column to Column + path but modelling
the path as an evaluator. But the query layer is deciding the evaluator instead
of the sto
xiangfu0 commented on issue #7837:
URL: https://github.com/apache/pinot/issues/7837#issuecomment-982141908
cc @elonazoulay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
mcvsubbu commented on pull request #7780:
URL: https://github.com/apache/pinot/pull/7780#issuecomment-982141873
> > Why do we have this config on both controller and server?
> > Seems the controller one is for allowing split commit from servers.
Should we consider removing this controlle
richardstartin edited a comment on pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#issuecomment-982140750
> Conceptually, we are moving from a Column to Column + path but modelling
the path as an evaluator. But the query layer is deciding the evaluator instead
of the sto
richardstartin commented on pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#issuecomment-982140750
> Conceptually, we are moving from a Column to Column + path but modelling
the path as an evaluator. But the query layer is deciding the evaluator instead
of the storage la
amrishlal commented on a change in pull request #7568:
URL: https://github.com/apache/pinot/pull/7568#discussion_r758809059
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##
@@ -519,6 +543,18 @@ private BrokerRespo
walterddr opened a new pull request #7838:
URL: https://github.com/apache/pinot/pull/7838
Currently there's no way to use the GRPC server request from broker side.
Adding a framework of `GRPCBrokerResponseHandler` parallel to the
`SingleConnectionBrokerRequestHandler`
This ha
weixiangsun commented on issue #7691:
URL: https://github.com/apache/pinot/issues/7691#issuecomment-982131963
Are we going to run multiple queries corresponding to each condition inside
the CaseTransform? @atris
--
This is an automated message from the Apache Git Service.
To respond to
Jackie-Jiang commented on issue #7835:
URL: https://github.com/apache/pinot/issues/7835#issuecomment-982128869
Same as #7691 where we need to access the null vector index within case
statement
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dongxiaoman opened a new issue #7837:
URL: https://github.com/apache/pinot/issues/7837
If the Pinot cluster adopts https://github.com/apache/pinot/pull/7064 to
update its Helix hostname to Pinot Helix Instance, the PrestoDB/Trino connector
will not be able to connect to Pinot any more.
amrishlal commented on a change in pull request #7568:
URL: https://github.com/apache/pinot/pull/7568#discussion_r758809219
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/operator/InstanceResponseOperator.java
##
@@ -113,9 +116,34 @@ private IntermediateResultsBl
amrishlal commented on a change in pull request #7568:
URL: https://github.com/apache/pinot/pull/7568#discussion_r758809059
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##
@@ -519,6 +543,18 @@ private BrokerRespo
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git.
from 1e25962 return exception when unavailable segments on empty broker
response (#7823)
add 9ba03e4 Fix thread saf
Jackie-Jiang merged pull request #7828:
URL: https://github.com/apache/pinot/pull/7828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
codecov-commenter edited a comment on pull request #7828:
URL: https://github.com/apache/pinot/pull/7828#issuecomment-978626493
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7828?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7828:
URL: https://github.com/apache/pinot/pull/7828#issuecomment-978626493
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7828?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7828:
URL: https://github.com/apache/pinot/pull/7828#issuecomment-978626493
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7828?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter edited a comment on pull request #7828:
URL: https://github.com/apache/pinot/pull/7828#issuecomment-978626493
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7828?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
kishoreg commented on pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#issuecomment-982088481
I like the concept of the pushdown evaluator. Few thoughts/concerns
- Some methods added to projectionBlock seem to be specific to
projectionBlock and is deviating from the blo
Jackie-Jiang commented on pull request #7828:
URL: https://github.com/apache/pinot/pull/7828#issuecomment-982064831
@richardstartin I didn't think from the readability perspective. I agree
there is no clear evidence on the optimization. Changed it to use the
concurrent set.
--
This is a
Jackie-Jiang commented on a change in pull request #7828:
URL: https://github.com/apache/pinot/pull/7828#discussion_r758768399
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentpruner/EmptySegmentPruner.java
##
@@ -69,66 +68,99 @@ public void init
richardstartin commented on a change in pull request #7828:
URL: https://github.com/apache/pinot/pull/7828#discussion_r758729883
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentpruner/EmptySegmentPruner.java
##
@@ -69,66 +68,99 @@ public void in
richardstartin commented on a change in pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#discussion_r758722103
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/DataBlockCache.java
##
@@ -120,6 +121,17 @@ public int getNumDocs() {
retur
jackjlli commented on a change in pull request #7828:
URL: https://github.com/apache/pinot/pull/7828#discussion_r758711587
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentpruner/EmptySegmentPruner.java
##
@@ -69,66 +68,99 @@ public void init(Ide
codecov-commenter edited a comment on pull request #7827:
URL: https://github.com/apache/pinot/pull/7827#issuecomment-978182588
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7827?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
mayankshriv commented on a change in pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#discussion_r758704062
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/DataBlockCache.java
##
@@ -120,6 +121,17 @@ public int getNumDocs() {
return i
mayankshriv commented on a change in pull request #7820:
URL: https://github.com/apache/pinot/pull/7820#discussion_r758704062
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/common/DataBlockCache.java
##
@@ -120,6 +121,17 @@ public int getNumDocs() {
return i
mayankshriv commented on issue #7831:
URL: https://github.com/apache/pinot/issues/7831#issuecomment-981977108
Thanks @atris for creating this PEP request. The overall design doc looks
good to me. +1 on the feature implementation.
--
This is an automated message from the Apache Git Servic
jtao15 commented on a change in pull request #7827:
URL: https://github.com/apache/pinot/pull/7827#discussion_r758685802
##
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.ja
jtao15 commented on a change in pull request #7827:
URL: https://github.com/apache/pinot/pull/7827#discussion_r758685536
##
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.ja
jtao15 commented on a change in pull request #7827:
URL: https://github.com/apache/pinot/pull/7827#discussion_r758681392
##
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.ja
codecov-commenter edited a comment on pull request #7827:
URL: https://github.com/apache/pinot/pull/7827#issuecomment-978182588
#
[Codecov](https://codecov.io/gh/apache/pinot/pull/7827?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
richardstartin commented on issue #7836:
URL: https://github.com/apache/pinot/issues/7836#issuecomment-981955434
I am interested in picking this up in early 2022 cc @mayankshriv
@Jackie-Jiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please
xiangfu0 commented on issue #7834:
URL: https://github.com/apache/pinot/issues/7834#issuecomment-981953079
Do you want to file a PR to test the version upgrade?
https://github.com/apache/pinot/blob/master/pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/pom.xml
--
This is an autom
xiangfu0 commented on issue #7834:
URL: https://github.com/apache/pinot/issues/7834#issuecomment-981952144
From this wiki:
https://cwiki.apache.org/confluence/display/KAFKA/Compatibility+Matrix
Seems that we can safely upgrade kafka consumer to consume older broker
verisons.
--
T
lakshmanan-v opened a new issue #7836:
URL: https://github.com/apache/pinot/issues/7836
Currently MAX()/MIN() are supported in aggregate functions. But in non
aggregate situations, we need to use complex Switch case statements to find
MIN/MAX.
It would be great if we can support th
xiangfu0 commented on issue #7834:
URL: https://github.com/apache/pinot/issues/7834#issuecomment-981950234
Thanks for bringing this up!
Just wanna check the compatibility of using Kafka 2.4 consumer to consume
Kafka broker from 2.0+.
If things are fine, we can safely just bump
snleee commented on a change in pull request #7827:
URL: https://github.com/apache/pinot/pull/7827#discussion_r758668575
##
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.ja
jtao15 commented on a change in pull request #7827:
URL: https://github.com/apache/pinot/pull/7827#discussion_r758638441
##
File path:
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.ja
weixiangsun opened a new issue #7835:
URL: https://github.com/apache/pinot/issues/7835
Currently, null checking is only supported inside filtering. I want to
support the following use case:
select case
when timeStamp IS NULL then now()
else timestamp
end
from meetup
mapshen opened a new issue #7834:
URL: https://github.com/apache/pinot/issues/7834
Currently, Pinot is built using 2.0 by default. One feature we are looking
at with 2.4+ is the capability to consume from follower replicas of a topic
instead of the leader one. Are we considering an upgrade
yeongjukang opened a new pull request #7833:
URL: https://github.com/apache/pinot/pull/7833
## Description
- There was no way to inject env var like TZ to presto container on presto's
helm chart.
- I added extraEnv, envFrom to presto helm template, and initialized those
values with e
80 matches
Mail list logo
