[GitHub] [pinot] shreelakshmijoshi commented on issue #7338: Allow reloading segments with multiple threads

2021-08-25 Thread GitBox
shreelakshmijoshi commented on issue #7338: URL: https://github.com/apache/pinot/issues/7338#issuecomment-906050797 Hey @Jackie-Jiang ! I am trying to run pinot locally, but `git status ` shows that there are many files which deleted and not staged and some files are not tracked. I ha

[GitHub] [pinot] siddharthteotia merged pull request #7282: Add "num rows in segments" and "num segments queried per host" to the output of Realtime Provisioning Rule

2021-08-25 Thread GitBox
siddharthteotia merged pull request #7282: URL: https://github.com/apache/pinot/pull/7282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-

[pinot] branch master updated: Add "num rows in segments" and "num segments queried per host" to the output of Realtime Provisioning Rule (#7282)

2021-08-25 Thread siddteotia
This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 3892812 Add "num rows in segments" and "num

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7282: Add "num rows in segments" and "num segments queried per host" to the output of Realtime Provisioning Rule

2021-08-25 Thread GitBox
codecov-commenter edited a comment on pull request #7282: URL: https://github.com/apache/pinot/pull/7282#issuecomment-896455835 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7282?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7286: Remove obsolete indices during segment reloading for V3 format (wrap up)

2021-08-25 Thread GitBox
Jackie-Jiang commented on a change in pull request #7286: URL: https://github.com/apache/pinot/pull/7286#discussion_r696206001 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentLoader.java ## @@ -57,55 +57,59

[pinot] branch master updated: Fix misleading error msg for missing URI (#7367)

2021-08-25 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new c5e8ddf Fix misleading error msg for missing URI

[GitHub] [pinot] Jackie-Jiang merged pull request #7367: Fix misleading error msg for missing URI

2021-08-25 Thread GitBox
Jackie-Jiang merged pull request #7367: URL: https://github.com/apache/pinot/pull/7367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] codecov-commenter commented on pull request #7367: Fix misleading error msg for missing URI

2021-08-25 Thread GitBox
codecov-commenter commented on pull request #7367: URL: https://github.com/apache/pinot/pull/7367#issuecomment-905943565 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7367?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [pinot] kkrugler opened a new pull request #7367: Fix misleading error msg for missing URI

2021-08-25 Thread GitBox
kkrugler opened a new pull request #7367: URL: https://github.com/apache/pinot/pull/7367 ## Description When running a Hadoop job to build segments, if (for example) the `inputDirURI` is incorrect, the error message you get is `Caused by: java.lang.IllegalArgumentException: segmentUri i

[pinot] branch master updated: Bug fix: make currentOffset in consuming segment volatile (#7365)

2021-08-25 Thread mcvsubbu
This is an automated email from the ASF dual-hosted git repository. mcvsubbu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 0681e4b Bug fix: make currentOffset in consumi

[GitHub] [pinot] mcvsubbu merged pull request #7365: Bug fix: make currentOffset volatile in consuming segments

2021-08-25 Thread GitBox
mcvsubbu merged pull request #7365: URL: https://github.com/apache/pinot/pull/7365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [pinot] Jackie-Jiang commented on issue #7337: [Pinot-Admin][JsonToPinotSchema] "-timeColumnName" is not a valid option

2021-08-25 Thread GitBox
Jackie-Jiang commented on issue #7337: URL: https://github.com/apache/pinot/issues/7337#issuecomment-905851041 Made a change to the `JsonToPinotSchema` tool to take `-timeColumnName` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [pinot] Jackie-Jiang closed issue #7337: [Pinot-Admin][JsonToPinotSchema] "-timeColumnName" is not a valid option

2021-08-25 Thread GitBox
Jackie-Jiang closed issue #7337: URL: https://github.com/apache/pinot/issues/7337 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[pinot] branch master updated: Make JsonToPinotSchema consistent with AvroSchemaToPinotSchema (#7366)

2021-08-25 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 004c8af Make JsonToPinotSchema consistent with

[GitHub] [pinot] Jackie-Jiang merged pull request #7366: Make JsonToPinotSchema consistent with AvroSchemaToPinotSchema

2021-08-25 Thread GitBox
Jackie-Jiang merged pull request #7366: URL: https://github.com/apache/pinot/pull/7366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7366: Make JsonToPinotSchema consistent with AvroSchemaToPinotSchema

2021-08-25 Thread GitBox
codecov-commenter edited a comment on pull request #7366: URL: https://github.com/apache/pinot/pull/7366#issuecomment-905809940 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7366?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7366: Make JsonToPinotSchema consistent with AvroSchemaToPinotSchema

2021-08-25 Thread GitBox
codecov-commenter edited a comment on pull request #7366: URL: https://github.com/apache/pinot/pull/7366#issuecomment-905809940 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7366?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter commented on pull request #7366: Make JsonToPinotSchema consistent with AvroSchemaToPinotSchema

2021-08-25 Thread GitBox
codecov-commenter commented on pull request #7366: URL: https://github.com/apache/pinot/pull/7366#issuecomment-905809940 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7366?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [pinot] Jackie-Jiang commented on issue #7337: [Pinot-Admin][JsonToPinotSchema] "-timeColumnName" is not a valid option

2021-08-25 Thread GitBox
Jackie-Jiang commented on issue #7337: URL: https://github.com/apache/pinot/issues/7337#issuecomment-905774838 @yupeng9 Please take a look at this PR which changes the option name for `JsonToPinotSchema` tool: #7366 -- This is an automated message from the Apache Git Service. To respond

[GitHub] [pinot] Jackie-Jiang commented on issue #7337: [Pinot-Admin][JsonToPinotSchema] "-timeColumnName" is not a valid option

2021-08-25 Thread GitBox
Jackie-Jiang commented on issue #7337: URL: https://github.com/apache/pinot/issues/7337#issuecomment-905763271 Actually, we should probably rename the option to make it consistent with `AvroSchemaToPinotSchema` -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [pinot] Jackie-Jiang commented on issue #7337: [Pinot-Admin][JsonToPinotSchema] "-timeColumnName" is not a valid option

2021-08-25 Thread GitBox
Jackie-Jiang commented on issue #7337: URL: https://github.com/apache/pinot/issues/7337#issuecomment-905761348 @singh-abhijeet The error message is correct because `-timeColumnName` is not a valid option, and you should use `-dateTimeColumnName` instead -- This is an automated message fr

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7364: support large payload in zk put API

2021-08-25 Thread GitBox
Jackie-Jiang commented on a change in pull request #7364: URL: https://github.com/apache/pinot/pull/7364#discussion_r695979676 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/ZookeeperResource.java ## @@ -139,7 +140,17 @@ public SuccessRe

[pinot] branch master updated: Fix metric method for ONLINE_MINION_INSTANCES metric (#7363)

2021-08-25 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 93f2efb Fix metric method for ONLINE_MINION_INST

[GitHub] [pinot] Jackie-Jiang merged pull request #7363: Fix metric method for ONLINE_MINION_INSTANCES metric

2021-08-25 Thread GitBox
Jackie-Jiang merged pull request #7363: URL: https://github.com/apache/pinot/pull/7363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7365: Bug fix: make currentOffset volatile in consuming segments

2021-08-25 Thread GitBox
codecov-commenter edited a comment on pull request #7365: URL: https://github.com/apache/pinot/pull/7365#issuecomment-905728374 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7365?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] Jackie-Jiang closed issue #7313: segments with 2 replications status should be good when one is online and another is consuming

2021-08-25 Thread GitBox
Jackie-Jiang closed issue #7313: URL: https://github.com/apache/pinot/issues/7313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[pinot] branch master updated (7016d03 -> 70efd03)

2021-08-25 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from 7016d03 Cmd+enter shortcut to run query in query console (#7359) add 70efd03 Fix task scheduling on table updat

[GitHub] [pinot] Jackie-Jiang merged pull request #7362: Fix task scheduling on table update

2021-08-25 Thread GitBox
Jackie-Jiang merged pull request #7362: URL: https://github.com/apache/pinot/pull/7362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [pinot] jackjlli commented on a change in pull request #7350: Increase code coverage for pinot-java-client - ConnectionFactory

2021-08-25 Thread GitBox
jackjlli commented on a change in pull request #7350: URL: https://github.com/apache/pinot/pull/7350#discussion_r695962142 ## File path: pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/Connection.java ## @@ -46,6 +47,8 @@ Connection(BrokerSelector brok

[GitHub] [pinot] codecov-commenter commented on pull request #7365: Bug fix: make currentOffset volatile in consuming segments

2021-08-25 Thread GitBox
codecov-commenter commented on pull request #7365: URL: https://github.com/apache/pinot/pull/7365#issuecomment-905728374 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7365?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac

[GitHub] [pinot] jackjlli closed issue #7360: Cmd + Enter shortcut for data explorer query console

2021-08-25 Thread GitBox
jackjlli closed issue #7360: URL: https://github.com/apache/pinot/issues/7360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

[pinot] branch master updated (a5f8cf4 -> 7016d03)

2021-08-25 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git. from a5f8cf4 fix upload LLC segment endpoint truncated download URL (#7361) add 7016d03 Cmd+enter shortcut to run quer

[GitHub] [pinot] jackjlli merged pull request #7359: Cmd+enter shortcut to run query in Pinot data explorer query console

2021-08-25 Thread GitBox
jackjlli merged pull request #7359: URL: https://github.com/apache/pinot/pull/7359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [pinot] shahsank3t commented on issue #7313: segments with 2 replications status should be good when one is online and another is consuming

2021-08-25 Thread GitBox
shahsank3t commented on issue #7313: URL: https://github.com/apache/pinot/issues/7313#issuecomment-905726890 @xiangfu0 this fix has been merged to the master branch so you can mark this closed. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [pinot] sajjad-moradi commented on a change in pull request #7267: Offset based realtime consumption status checker

2021-08-25 Thread GitBox
sajjad-moradi commented on a change in pull request #7267: URL: https://github.com/apache/pinot/pull/7267#discussion_r695935215 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java ## @@ -227,7 +228,7 @@ public vo

[GitHub] [pinot] sajjad-moradi opened a new pull request #7365: Bug fix: make currentOffset volatile in consuming segments

2021-08-25 Thread GitBox
sajjad-moradi opened a new pull request #7365: URL: https://github.com/apache/pinot/pull/7365 `currentOffset` object is being set in consumingLoop thread, but it's also being accessed by other threads. Making it volatile makes the writes to this object go to actual memory instead of cache

[GitHub] [pinot] priyen commented on pull request #7359: Cmd+enter shortcut to run query in Pinot data explorer query console

2021-08-25 Thread GitBox
priyen commented on pull request #7359: URL: https://github.com/apache/pinot/pull/7359#issuecomment-905480742 Thanks @jackjlli - can you merge this in? (and also look at the documentation PR https://github.com/pinot-contrib/pinot-docs/pull/58 if you have time) -- This is an automated me

[GitHub] [pinot] singh-abhijeet commented on issue #7337: [Pinot-Admin][JsonToPinotSchema] "-timeColumnName" is not a valid option

2021-08-25 Thread GitBox
singh-abhijeet commented on issue #7337: URL: https://github.com/apache/pinot/issues/7337#issuecomment-905441562 Please update pinot-admin CLI error message as well, it still errors `Error: "-timeColumnName" is not a valid option` -- This is an automated message from the Apache Git Servi

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7363: Fix metric method for ONLINE_MINION_INSTANCES metric

2021-08-25 Thread GitBox
codecov-commenter edited a comment on pull request #7363: URL: https://github.com/apache/pinot/pull/7363#issuecomment-905248716 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7363?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] xiangfu0 commented on pull request #7364: support large payload in zk put API

2021-08-25 Thread GitBox
xiangfu0 commented on pull request #7364: URL: https://github.com/apache/pinot/pull/7364#issuecomment-905257989 Thanks for adding this! Can you add a test for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7363: Fix metric method for ONLINE_MINION_INSTANCES metric

2021-08-25 Thread GitBox
codecov-commenter edited a comment on pull request #7363: URL: https://github.com/apache/pinot/pull/7363#issuecomment-905248716 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7363?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter edited a comment on pull request #7363: Fix metric method for ONLINE_MINION_INSTANCES metric

2021-08-25 Thread GitBox
codecov-commenter edited a comment on pull request #7363: URL: https://github.com/apache/pinot/pull/7363#issuecomment-905248716 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7363?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [pinot] codecov-commenter commented on pull request #7363: Fix metric method for ONLINE_MINION_INSTANCES metric

2021-08-25 Thread GitBox
codecov-commenter commented on pull request #7363: URL: https://github.com/apache/pinot/pull/7363#issuecomment-905248716 # [Codecov](https://codecov.io/gh/apache/pinot/pull/7363?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac