[GitHub] [incubator-pinot] siddharthteotia commented on issue #5664: Join and subquery support

2021-07-12 Thread GitBox
siddharthteotia commented on issue #5664: URL: https://github.com/apache/incubator-pinot/issues/5664#issuecomment-878821631 I don't completely follow that. Can you give an example ? Also, are you approaching this from making subqueries work for a particular scenario ? -- This is an auto

[GitHub] [incubator-pinot] atris commented on issue #5664: Join and subquery support

2021-07-12 Thread GitBox
atris commented on issue #5664: URL: https://github.com/apache/incubator-pinot/issues/5664#issuecomment-878820183 If the outer query is being executed on a broker node, on top of the result of the underlying topmost Combine operator, would this still be a problem? -- This is an automat

[GitHub] [incubator-pinot] siddharthteotia commented on issue #5664: Join and subquery support

2021-07-12 Thread GitBox
siddharthteotia commented on issue #5664: URL: https://github.com/apache/incubator-pinot/issues/5664#issuecomment-878819171 @atris, Subqueries can broadly be divided into two categories - inner query (and there could be multiple of these) referring to same table as outer query -

[GitHub] [incubator-pinot] cxing closed issue #7159: Pinot retention failed when integrate with HDFS

2021-07-12 Thread GitBox
cxing closed issue #7159: URL: https://github.com/apache/incubator-pinot/issues/7159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [incubator-pinot] cxing commented on issue #7159: Pinot retention failed when integrate with HDFS

2021-07-12 Thread GitBox
cxing commented on issue #7159: URL: https://github.com/apache/incubator-pinot/issues/7159#issuecomment-878801729 > I think this is already fixed by #7027 > > Can you confirm? Yes it's already fixed in #7027 i will close this issue, thx -- This is an automated message from

[GitHub] [incubator-pinot] xiangfu0 commented on issue #7159: Pinot retention failed when integrate with HDFS

2021-07-12 Thread GitBox
xiangfu0 commented on issue #7159: URL: https://github.com/apache/incubator-pinot/issues/7159#issuecomment-878795638 I think this is already fixed by https://github.com/apache/incubator-pinot/pull/7027 Can you confirm? -- This is an automated message from the Apache Git Servi

[GitHub] [incubator-pinot] atris commented on issue #7043: Support query result post-aggregation / nested query

2021-07-12 Thread GitBox
atris commented on issue #7043: URL: https://github.com/apache/incubator-pinot/issues/7043#issuecomment-878786588 @siddharthteotia Thats great to hear. I am already working on this feature, since its crucial for our evaluation of Pinot. I would request your inputs and feedback on the prop

[GitHub] [incubator-pinot] RuslanTM edited a comment on issue #7153: New data keep saving in old format after changing schema

2021-07-12 Thread GitBox
RuslanTM edited a comment on issue #7153: URL: https://github.com/apache/incubator-pinot/issues/7153#issuecomment-878752747 @Jackie-Jiang the first approach is more preferable. Is it supported in the last version of pinot? -- This is an automated message from the Apache Git Service. To

[GitHub] [incubator-pinot] RuslanTM commented on issue #7153: New data keep saving in old format after changing schema

2021-07-12 Thread GitBox
RuslanTM commented on issue #7153: URL: https://github.com/apache/incubator-pinot/issues/7153#issuecomment-878752747 @Jackie-Jiang first approach is more preferable. Is it supported in the last version of pinot? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-pinot] atris commented on issue #5664: Join and subquery support

2021-07-12 Thread GitBox
atris commented on issue #5664: URL: https://github.com/apache/incubator-pinot/issues/5664#issuecomment-878751583 Great to see this. I am excited about this feature - but I don't see a strict need for subqueries to be designed in conjunction with joins. IMO subqueries are simpler and have

[GitHub] [incubator-pinot] cxing opened a new issue #7159: Pinot retention failed when integrate with HDFS

2021-07-12 Thread GitBox
cxing opened a new issue #7159: URL: https://github.com/apache/incubator-pinot/issues/7159 1. Realtime table can't be retention and fund exceptions in leader controller log 2021-07-11 03:08:50.378 ERROR [ControllerPeriodicTask] [pool-12-thread-4] Caught exception while running task: Ret

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7113: High Cardinality Order by Optimization

2021-07-12 Thread GitBox
codecov-commenter edited a comment on pull request #7113: URL: https://github.com/apache/incubator-pinot/pull/7113#issuecomment-873230145 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7113?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7142: Added a query param to /tables for getting sorted table names based on time metadata

2021-07-12 Thread GitBox
codecov-commenter edited a comment on pull request #7142: URL: https://github.com/apache/incubator-pinot/pull/7142#issuecomment-876860754 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7142?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7142: Added a query param to /tables for getting sorted table names based on time metadata

2021-07-12 Thread GitBox
codecov-commenter edited a comment on pull request #7142: URL: https://github.com/apache/incubator-pinot/pull/7142#issuecomment-876860754 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7142?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] mcvsubbu commented on issue #6679: Admin command to recover from deleted CONSUMING segment case

2021-07-12 Thread GitBox
mcvsubbu commented on issue #6679: URL: https://github.com/apache/incubator-pinot/issues/6679#issuecomment-878692920 @Jackie-Jiang if that is the case (i.e. it fetches latest on new partitions) then we have a bug. I know for certain it was not the case when we first coded it up (at the ti

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7158: Extract time handling for SegmentProcessorFramework

2021-07-12 Thread GitBox
codecov-commenter edited a comment on pull request #7158: URL: https://github.com/apache/incubator-pinot/pull/7158#issuecomment-878690453 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7158?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] mqliang commented on pull request #7142: Added a query param to /tables for getting sorted table names based on time metadata

2021-07-12 Thread GitBox
mqliang commented on pull request #7142: URL: https://github.com/apache/incubator-pinot/pull/7142#issuecomment-878691836 > Are you suggesting calling /tables first, then loop over all the tables and get stats for each individual table, then sort on the client side? This could translate to

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #7158: Extract time handling for SegmentProcessorFramework

2021-07-12 Thread GitBox
codecov-commenter commented on pull request #7158: URL: https://github.com/apache/incubator-pinot/pull/7158#issuecomment-878690453 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7158?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #7142: Added a query param to /tables for getting sorted table names based on time metadata

2021-07-12 Thread GitBox
Jackie-Jiang commented on pull request #7142: URL: https://github.com/apache/incubator-pinot/pull/7142#issuecomment-878688927 I still don't see why adding sort type a bad thing to the list table api. If not provided, it will just work as is. Adding it can save lots of effort on the user si

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #7142: Added a query param to /tables for getting sorted table names based on time metadata

2021-07-12 Thread GitBox
Jackie-Jiang commented on pull request #7142: URL: https://github.com/apache/incubator-pinot/pull/7142#issuecomment-878688331 @mcvsubbu @mqliang Are you suggesting calling `/tables` first, then loop over all the tables and get stats for each individual table, then sort on the client side?

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #6679: Admin command to recover from deleted CONSUMING segment case

2021-07-12 Thread GitBox
Jackie-Jiang commented on issue #6679: URL: https://github.com/apache/incubator-pinot/issues/6679#issuecomment-878687725 @mcvsubbu I don't think that the case at least based on my reading. Once controller detects a new partition, it will fetch the partition offset based on the offset crit

[GitHub] [incubator-pinot] mqliang commented on pull request #7142: Added a query param to /tables for getting sorted table names based on time metadata

2021-07-12 Thread GitBox
mqliang commented on pull request #7142: URL: https://github.com/apache/incubator-pinot/pull/7142#issuecomment-878681829 > A combination of jq and sort, for instance. You can sort/massage/filter data to your heart's content I agree: * For sorting by name, client can use the `@

[GitHub] [incubator-pinot] mcvsubbu commented on issue #6679: Admin command to recover from deleted CONSUMING segment case

2021-07-12 Thread GitBox
mcvsubbu commented on issue #6679: URL: https://github.com/apache/incubator-pinot/issues/6679#issuecomment-878680382 @Jackie-Jiang the user need not change back. They can keep it at LATEST. New partitions will always consume as they are detected (and therefore earliest). Like I mentioned

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #6679: Admin command to recover from deleted CONSUMING segment case

2021-07-12 Thread GitBox
Jackie-Jiang commented on issue #6679: URL: https://github.com/apache/incubator-pinot/issues/6679#issuecomment-878679396 @mcvsubbu Forcing the user to change their table config in order to fix a segment does not seem correct to me. For example, user is using EARLIEST for all the new parti

[GitHub] [incubator-pinot] mcvsubbu commented on pull request #7142: Added a query param to /tables for getting sorted table names based on time metadata

2021-07-12 Thread GitBox
mcvsubbu commented on pull request #7142: URL: https://github.com/apache/incubator-pinot/pull/7142#issuecomment-878678074 > @mcvsubbu What external tool are you referring to? IMO listing tables in a cluster sorted with creation time/last modified time is quite common request, and currently

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #7142: Added a query param to /tables for getting sorted table names based on time metadata

2021-07-12 Thread GitBox
Jackie-Jiang commented on pull request #7142: URL: https://github.com/apache/incubator-pinot/pull/7142#issuecomment-878677140 @mcvsubbu What external tool are you referring to? IMO listing tables in a cluster sorted with creation time/last modified time is quite common request, and current

[GitHub] [incubator-pinot] siddharthteotia edited a comment on issue #7043: Support query result post-aggregation / nested query

2021-07-12 Thread GitBox
siddharthteotia edited a comment on issue #7043: URL: https://github.com/apache/incubator-pinot/issues/7043#issuecomment-878661085 At LinkedIn, we are exploring a combined design for subqueries and distributed joins since design / architecture wise there might be overlap and it is good to

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #7158: Extract time handling for SegmentProcessorFramework

2021-07-12 Thread GitBox
Jackie-Jiang opened a new pull request #7158: URL: https://github.com/apache/incubator-pinot/pull/7158 ## Description Currently within `SegmentProcessorFramework`, time handling is modeled as separate general filter/transform/partition function within the processor config, which is quit

[GitHub] [incubator-pinot] siddharthteotia commented on issue #7043: Support query result post-aggregation / nested query

2021-07-12 Thread GitBox
siddharthteotia commented on issue #7043: URL: https://github.com/apache/incubator-pinot/issues/7043#issuecomment-878664620 https://github.com/apache/incubator-pinot/issues/5664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [incubator-pinot] siddharthteotia commented on issue #5664: Join and subquery support

2021-07-12 Thread GitBox
siddharthteotia commented on issue #5664: URL: https://github.com/apache/incubator-pinot/issues/5664#issuecomment-878664475 At LinkedIn, we are exploring a combined design for subqueries and distributed joins since design / architecture wise there might be overlap and it is good to think

[GitHub] [incubator-pinot] siddharthteotia edited a comment on issue #7043: Support query result post-aggregation / nested query

2021-07-12 Thread GitBox
siddharthteotia edited a comment on issue #7043: URL: https://github.com/apache/incubator-pinot/issues/7043#issuecomment-878661085 At LinkedIn, we are exploring a combined design for subqueries and distributed joins since design / architecture wise there might be overlap and it is good to

[GitHub] [incubator-pinot] siddharthteotia edited a comment on issue #7043: Support query result post-aggregation / nested query

2021-07-12 Thread GitBox
siddharthteotia edited a comment on issue #7043: URL: https://github.com/apache/incubator-pinot/issues/7043#issuecomment-878661085 At LinkedIn, we will be exploring a combined design for subqueries and distributed joins since design / architecture wise there might be overlap and it is goo

[GitHub] [incubator-pinot] siddharthteotia commented on issue #7043: Support query result post-aggregation / nested query

2021-07-12 Thread GitBox
siddharthteotia commented on issue #7043: URL: https://github.com/apache/incubator-pinot/issues/7043#issuecomment-878661085 At LinkedIn, we will be exploring a combined design for subqueries and distributed joins since design / architecture wise there might be overlap and it is good to th

[incubator-pinot] branch master updated (db5dfd7 -> de2f0e0)

2021-07-12 Thread mcvsubbu
This is an automated email from the ASF dual-hosted git repository. mcvsubbu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from db5dfd7 Fix race condition in MinionInstancesCleanupTask (#7122) add de2f0e0 Enable parallel builds

[GitHub] [incubator-pinot] mcvsubbu merged pull request #7149: Enable parallel builds for compat checker

2021-07-12 Thread GitBox
mcvsubbu merged pull request #7149: URL: https://github.com/apache/incubator-pinot/pull/7149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [incubator-pinot] mqliang commented on pull request #7157: Improve the segment aggregated metadata controller/server API

2021-07-12 Thread GitBox
mqliang commented on pull request #7157: URL: https://github.com/apache/incubator-pinot/pull/7157#issuecomment-878651270 test failed due to flaky issue. close and re-open to trigger a re-run -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-pinot] mqliang closed pull request #7157: Improve the segment aggregated metadata controller/server API

2021-07-12 Thread GitBox
mqliang closed pull request #7157: URL: https://github.com/apache/incubator-pinot/pull/7157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [incubator-pinot] mqliang opened a new pull request #7157: Improve the segment aggregated metadata controller/server API

2021-07-12 Thread GitBox
mqliang opened a new pull request #7157: URL: https://github.com/apache/incubator-pinot/pull/7157 ## Description This is a follow-up PR of https://github.com/apache/incubator-pinot/pull/7102, which: * Add more detailed java docs for TableMetadataInfo class. * move the `getE

[incubator-pinot] branch master updated (1ef50f7 -> db5dfd7)

2021-07-12 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 1ef50f7 Add controller/server API to fetch aggregated segment metadata (#7102) add db5dfd7 Fix race co

[GitHub] [incubator-pinot] jackjlli merged pull request #7122: Fix race condition in MinionInstancesCleanupTask

2021-07-12 Thread GitBox
jackjlli merged pull request #7122: URL: https://github.com/apache/incubator-pinot/pull/7122 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7149: Enable parallel builds for compat checker

2021-07-12 Thread GitBox
codecov-commenter edited a comment on pull request #7149: URL: https://github.com/apache/incubator-pinot/pull/7149#issuecomment-877709544 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7149?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[incubator-pinot] branch master updated (e17029f -> 1ef50f7)

2021-07-12 Thread siddteotia
This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from e17029f Wire TaskMetricsEmitter to controller starter (#7126) add 1ef50f7 Add controller/server A

[GitHub] [incubator-pinot] siddharthteotia merged pull request #7102: Add controller/server API to fetch aggregated segment metadata

2021-07-12 Thread GitBox
siddharthteotia merged pull request #7102: URL: https://github.com/apache/incubator-pinot/pull/7102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #7122: Fix race condition in MinionInstancesCleanupTask

2021-07-12 Thread GitBox
jackjlli commented on a change in pull request #7122: URL: https://github.com/apache/incubator-pinot/pull/7122#discussion_r668265229 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java ## @@ -146,6 +149,7 @@ private static long getRando

[GitHub] [incubator-pinot] jackjlli opened a new issue #7156: Make configs for controller periodic tasks human readable

2021-07-12 Thread GitBox
jackjlli opened a new issue #7156: URL: https://github.com/apache/incubator-pinot/issues/7156 The current configs for controller periodic tasks have to use number in seconds, which is not convenient. We can introduce a new set of configs to make them human readable, like `2h30m`. --

[incubator-pinot] branch fix-MinionInstancesCleanupTask updated (b27fc13 -> 0d9db6d)

2021-07-12 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch fix-MinionInstancesCleanupTask in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard b27fc13 Fix race condition in MinionInstancesCleanupTask add 0d9db6d Fix race c

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7102: Add controller/server API to fetch aggregated segment metadata

2021-07-12 Thread GitBox
codecov-commenter edited a comment on pull request #7102: URL: https://github.com/apache/incubator-pinot/pull/7102#issuecomment-870233688 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7102?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #7122: Fix race condition in MinionInstancesCleanupTask

2021-07-12 Thread GitBox
mcvsubbu commented on a change in pull request #7122: URL: https://github.com/apache/incubator-pinot/pull/7122#discussion_r668223484 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java ## @@ -461,6 +462,34 @@ publi

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #7149: Enable parallel builds for compat checker

2021-07-12 Thread GitBox
mcvsubbu commented on a change in pull request #7149: URL: https://github.com/apache/incubator-pinot/pull/7149#discussion_r668214495 ## File path: compatibility-verifier/checkoutAndBuild.sh ## @@ -86,67 +100,145 @@ while [ "$1" != "" ]; do shift done -if [ -z "$olderCommi

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7113: High Cardinality Order by Optimization

2021-07-12 Thread GitBox
codecov-commenter edited a comment on pull request #7113: URL: https://github.com/apache/incubator-pinot/pull/7113#issuecomment-873230145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [incubator-pinot] amrishlal opened a new issue #7155: Manually trigger periodic task using controller api.

2021-07-12 Thread GitBox
amrishlal opened a new issue #7155: URL: https://github.com/apache/incubator-pinot/issues/7155 I discussed this with @mcvsubbu a bit. Setup controller api to allow for manually triggering a periodic task. When the controller gets a request to manually execute a periodic task, it will send

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #7154: Fix the exception message for segment reset

2021-07-12 Thread GitBox
Jackie-Jiang opened a new pull request #7154: URL: https://github.com/apache/incubator-pinot/pull/7154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #7154: Fix the exception message for segment reset

2021-07-12 Thread GitBox
Jackie-Jiang merged pull request #7154: URL: https://github.com/apache/incubator-pinot/pull/7154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: c

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #7153: New data keep saving in old format after changing schema

2021-07-12 Thread GitBox
Jackie-Jiang commented on issue #7153: URL: https://github.com/apache/incubator-pinot/issues/7153#issuecomment-878412701 There are 2 ways of handling the schema change with new columns within consuming segment: 1. (Supported) Keep the already consumed records and add new columns as def

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #7149: Enable parallel builds for compat checker

2021-07-12 Thread GitBox
jackjlli commented on a change in pull request #7149: URL: https://github.com/apache/incubator-pinot/pull/7149#discussion_r668121403 ## File path: compatibility-verifier/checkoutAndBuild.sh ## @@ -41,20 +41,34 @@ function usage() { } # This function builds Pinot given a spe

[GitHub] [incubator-pinot] RuslanTM commented on issue #7153: New data keep saving in old format after changing schema

2021-07-12 Thread GitBox
RuslanTM commented on issue #7153: URL: https://github.com/apache/incubator-pinot/issues/7153#issuecomment-878344359 @xiangfu0 I set this property and everything the same: https://user-images.githubusercontent.com/11804145/125307988-5c485600-e352-11eb-80b8-548a3dee8462.png";> In k

[GitHub] [incubator-pinot] wuwenw commented on a change in pull request #7113: High Cardinality Order by Optimization

2021-07-12 Thread GitBox
wuwenw commented on a change in pull request #7113: URL: https://github.com/apache/incubator-pinot/pull/7113#discussion_r668111237 ## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/AggregationGroupByOrderByPlanNode.java ## @@ -97,14 +116,38 @@ public Aggregatio

[GitHub] [incubator-pinot] jackjlli merged pull request #7111: Upgrade avro-mapred to 1.9.2 so that all avro dependencies are 1.9.2.

2021-07-12 Thread GitBox
jackjlli merged pull request #7111: URL: https://github.com/apache/incubator-pinot/pull/7111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [incubator-pinot] jackjlli merged pull request #7126: Wire TaskMetricsEmitter to controller starter

2021-07-12 Thread GitBox
jackjlli merged pull request #7126: URL: https://github.com/apache/incubator-pinot/pull/7126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7102: Add controller/server API to fetch aggregated segment metadata

2021-07-12 Thread GitBox
codecov-commenter edited a comment on pull request #7102: URL: https://github.com/apache/incubator-pinot/pull/7102#issuecomment-870233688 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7102?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] kkrugler commented on issue #7090: SegmentNameGenerator: Extend interface to accept input file name

2021-07-12 Thread GitBox
kkrugler commented on issue #7090: URL: https://github.com/apache/incubator-pinot/issues/7090#issuecomment-878261884 @troywinter - Yes, I've started some work (see above for my comments on why it's a bit harder than I was expecting) -- This is an automated message from the Apache Git Se

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #7102: Add controller/server API to fetch aggregated segment metadata

2021-07-12 Thread GitBox
siddharthteotia commented on a change in pull request #7102: URL: https://github.com/apache/incubator-pinot/pull/7102#discussion_r668180843 ## File path: pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java ## @@ -117,6 +126,103 @@ public String

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #7149: Enable parallel builds for compat checker

2021-07-12 Thread GitBox
mqliang commented on a change in pull request #7149: URL: https://github.com/apache/incubator-pinot/pull/7149#discussion_r668121696 ## File path: compatibility-verifier/checkoutAndBuild.sh ## @@ -41,20 +41,34 @@ function usage() { } # This function builds Pinot given a spec

[incubator-pinot] branch fix-MinionInstancesCleanupTask updated (da65fca -> b27fc13)

2021-07-12 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch fix-MinionInstancesCleanupTask in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard da65fca Fix race condition in MinionInstancesCleanupTask add b27fc13 Fix race c

[incubator-pinot] branch master updated (f04078e -> e17029f)

2021-07-12 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from f04078e Upgrade avro-mapred to 1.9.2 so that all avro dependencies are 1.9.2. (#7111) add e17029f Wire

[incubator-pinot] branch master updated (0447e74 -> f04078e)

2021-07-12 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 0447e74 Fix the exception message for segment reset (#7154) add f04078e Upgrade avro-mapred to 1.9.2 so

[incubator-pinot] branch master updated (7233e2c -> 0447e74)

2021-07-12 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 7233e2c Support Dictionary Based Plan For DISTINCT (#7141) add 0447e74 Fix the exception message for

[GitHub] [incubator-pinot] atris commented on issue #7060: Optimize DISTINCT + ORDER BY

2021-07-12 Thread GitBox
atris commented on issue #7060: URL: https://github.com/apache/incubator-pinot/issues/7060#issuecomment-878104243 I would say that we document this behaviour and make users aware of this scenario. WDYT? -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-pinot] MrNeocore commented on issue #7060: Optimize DISTINCT + ORDER BY

2021-07-12 Thread GitBox
MrNeocore commented on issue #7060: URL: https://github.com/apache/incubator-pinot/issues/7060#issuecomment-878101573 This issue is not impacting my use cases much at all, but should "technically understandable" be considered "expected behavior" (from a user perspective) ? Of cours

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #7111: Upgrade avro-mapred to 1.9.2 so that all avro dependencies are 1.9.2.

2021-07-12 Thread GitBox
codecov-commenter edited a comment on pull request #7111: URL: https://github.com/apache/incubator-pinot/pull/7111#issuecomment-878092225 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7111?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #7111: Upgrade avro-mapred to 1.9.2 so that all avro dependencies are 1.9.2.

2021-07-12 Thread GitBox
codecov-commenter commented on pull request #7111: URL: https://github.com/apache/incubator-pinot/pull/7111#issuecomment-878092225 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/7111?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] troywinter commented on issue #7090: SegmentNameGenerator: Extend interface to accept input file name

2021-07-12 Thread GitBox
troywinter commented on issue #7090: URL: https://github.com/apache/incubator-pinot/issues/7090#issuecomment-878047071 May I ask anyone is working on this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [incubator-pinot] LiranBri commented on issue #7152: storing json in a columnar format

2021-07-12 Thread GitBox
LiranBri commented on issue #7152: URL: https://github.com/apache/incubator-pinot/issues/7152#issuecomment-878029883 actually @kishoreg asked me to open this issue so he can document and explain the work in progress for this issue -- This is an automated message from the Apache Git Serv

[GitHub] [incubator-pinot] xiangfu0 edited a comment on issue #7153: New data keep saving in old format after changing schema

2021-07-12 Thread GitBox
xiangfu0 edited a comment on issue #7153: URL: https://github.com/apache/incubator-pinot/issues/7153#issuecomment-878024929 Please this this doc: https://docs.pinot.apache.org/users/tutorials/schema-evolution#update-the-schema ``` Real-Time Pinot table: In case of real-time tables, m

[GitHub] [incubator-pinot] xiangfu0 edited a comment on issue #7153: New data keep saving in old format after changing schema

2021-07-12 Thread GitBox
xiangfu0 edited a comment on issue #7153: URL: https://github.com/apache/incubator-pinot/issues/7153#issuecomment-878024929 Please this this doc: https://docs.pinot.apache.org/users/tutorials/schema-evolution#update-the-schema ``` Real-Time Pinot table: In case of real-time tables, m

[GitHub] [incubator-pinot] xiangfu0 commented on issue #7153: New data keep saving in old format after changing schema

2021-07-12 Thread GitBox
xiangfu0 commented on issue #7153: URL: https://github.com/apache/incubator-pinot/issues/7153#issuecomment-878024929 Please this this doc: https://docs.pinot.apache.org/users/tutorials/schema-evolution#update-the-schema ``` Real-Time Pinot table: In case of real-time tables, make sur

[GitHub] [incubator-pinot] xiangfu0 commented on issue #7152: storing json in a columnar format

2021-07-12 Thread GitBox
xiangfu0 commented on issue #7152: URL: https://github.com/apache/incubator-pinot/issues/7152#issuecomment-878023721 Pinot data are stored in columnar format and have multiple index supports. Please see: https://docs.pinot.apache.org/basics/indexing -- This is an automated message fro