[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6424: Use java11

codecov-commenter edited a comment on pull request #6424: URL: https://github.com/apache/incubator-pinot/pull/6424#issuecomment-828596486 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6424?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6925: Update time boundary only when segment is available on server

codecov-commenter edited a comment on pull request #6925: URL: https://github.com/apache/incubator-pinot/pull/6925#issuecomment-841559834 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6925?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6918: Convert collections not unnested to json

yupeng9 commented on a change in pull request #6918: URL: https://github.com/apache/incubator-pinot/pull/6918#discussion_r632873961 ## File path: pinot-segment-local/src/test/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformerTest.java ## @@ -237,4 +23

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6925: Update time boundary only when segment is available on server

codecov-commenter edited a comment on pull request #6925: URL: https://github.com/apache/incubator-pinot/pull/6925#issuecomment-841559834 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6925?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6918: Convert collections not unnested to json

yupeng9 commented on a change in pull request #6918: URL: https://github.com/apache/incubator-pinot/pull/6918#discussion_r632867121 ## File path: pinot-segment-local/src/test/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformerTest.java ## @@ -237,4 +23

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6926: Clean up generated files for recommendation engine in case of failure

codecov-commenter edited a comment on pull request #6926: URL: https://github.com/apache/incubator-pinot/pull/6926#issuecomment-841561386 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6926?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6925: Update time boundary only when segment is available on server

codecov-commenter edited a comment on pull request #6925: URL: https://github.com/apache/incubator-pinot/pull/6925#issuecomment-841559834 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6925?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6925: Update time boundary only when segment is available on server

Jackie-Jiang commented on a change in pull request #6925: URL: https://github.com/apache/incubator-pinot/pull/6925#discussion_r632865077 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/timeboundary/TimeBoundaryManager.java ## @@ -159,15 +160,20 @@ priv

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6925: Update time boundary only when segment is available on server

mcvsubbu commented on a change in pull request #6925: URL: https://github.com/apache/incubator-pinot/pull/6925#discussion_r632864795 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/timeboundary/TimeBoundaryManager.java ## @@ -159,15 +160,20 @@ private

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6926: Clean up generated files for recommendation engine in case of failure

codecov-commenter commented on pull request #6926: URL: https://github.com/apache/incubator-pinot/pull/6926#issuecomment-841561386 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6926?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] deemoliu commented on pull request #6924: Implement getRecord for immutableSegmentImpl

deemoliu commented on pull request #6924: URL: https://github.com/apache/incubator-pinot/pull/6924#issuecomment-841560016 Per offline discussion with @Jackie-Jiang 1. Need to wait https://github.com/apache/incubator-pinot/pull/6922 and resolve conflict. 2. If the segmentMetadata

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6925: Update time boundary only when segment is available on server

codecov-commenter commented on pull request #6925: URL: https://github.com/apache/incubator-pinot/pull/6925#issuecomment-841559834 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6925?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #6920: [BUG] Pinot print many error log 'Grpc/Admin port is not set for instance' in controller

Jackie-Jiang commented on issue #6920: URL: https://github.com/apache/incubator-pinot/issues/6920#issuecomment-841554172 Solved in #6632 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [incubator-pinot] Jackie-Jiang closed issue #6920: [BUG] Pinot print many error log 'Grpc/Admin port is not set for instance' in controller

Jackie-Jiang closed issue #6920: URL: https://github.com/apache/incubator-pinot/issues/6920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #6924: Implement getRecord for immutableSegmentImpl

Jackie-Jiang commented on pull request #6924: URL: https://github.com/apache/incubator-pinot/pull/6924#issuecomment-841553639 @siddharthteotia This is for the partial upsert feature where we need to do point record read on each segment -- This is an automated message from the Apache Git

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6924: Implement getRecord for immutableSegmentImpl

siddharthteotia commented on a change in pull request #6924: URL: https://github.com/apache/incubator-pinot/pull/6924#discussion_r632858728 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentImpl.java ## @@ -17

[GitHub] [incubator-pinot] siddharthteotia commented on pull request #6924: Implement getRecord for immutableSegmentImpl

siddharthteotia commented on pull request #6924: URL: https://github.com/apache/incubator-pinot/pull/6924#issuecomment-841550664 This doesn't look like a correct implementation. In fact, it is not needed. If we already have an ImmutableSegment, why not directly use the PinotSegmentRecordRe

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6918: Convert collections not unnested to json

siddharthteotia commented on a change in pull request #6918: URL: https://github.com/apache/incubator-pinot/pull/6918#discussion_r632854615 ## File path: pinot-segment-local/src/test/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformerTest.java ## @@ -2

[GitHub] [incubator-pinot] sajjad-moradi opened a new pull request #6926: Clean up generated files/directories for recommendation engine in case of failure

sajjad-moradi opened a new pull request #6926: URL: https://github.com/apache/incubator-pinot/pull/6926 ## Description In this PR, Recommendation Engine remove all temporary generated files and directories even in case of failure. ## Testing Done Locally modified the input json

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6918: Convert collections not unnested to json

siddharthteotia commented on a change in pull request #6918: URL: https://github.com/apache/incubator-pinot/pull/6918#discussion_r632854615 ## File path: pinot-segment-local/src/test/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformerTest.java ## @@ -2

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6918: Convert collections not unnested to json

siddharthteotia commented on a change in pull request #6918: URL: https://github.com/apache/incubator-pinot/pull/6918#discussion_r632854615 ## File path: pinot-segment-local/src/test/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformerTest.java ## @@ -2

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #6925: Update time boundary only when segment is available on server

Jackie-Jiang opened a new pull request #6925: URL: https://github.com/apache/incubator-pinot/pull/6925 ## Description In `TimeBoundaryManager`, only update the segment end time when there are ONLINE/CONSUMING instances in the external view to prevent moving the time boundary before the

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6922: Enhance PinotSegmentRecordReader to preserve null values

Jackie-Jiang commented on a change in pull request #6922: URL: https://github.com/apache/incubator-pinot/pull/6922#discussion_r632848808 ## File path: pinot-core/src/main/java/org/apache/pinot/core/minion/SegmentPurger.java ## @@ -165,6 +160,7 @@ public boolean hasNext() {

[GitHub] [incubator-pinot] deemoliu opened a new pull request #6924: Implement getRecord for immutableSegmentImpl

deemoliu opened a new pull request #6924: URL: https://github.com/apache/incubator-pinot/pull/6924 ## Description ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) * [ ] Yes (Please label as **backward-inc

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6918: Convert collections not unnested to json

yupeng9 commented on a change in pull request #6918: URL: https://github.com/apache/incubator-pinot/pull/6918#discussion_r632827760 ## File path: pinot-segment-local/src/test/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformerTest.java ## @@ -237,4 +23

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6918: Convert collections not unnested to json

siddharthteotia commented on a change in pull request #6918: URL: https://github.com/apache/incubator-pinot/pull/6918#discussion_r632814695 ## File path: pinot-segment-local/src/test/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformerTest.java ## @@ -2

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6918: Convert collections not unnested to json

siddharthteotia commented on a change in pull request #6918: URL: https://github.com/apache/incubator-pinot/pull/6918#discussion_r632813843 ## File path: pinot-segment-local/src/test/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformerTest.java ## @@ -2

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6918: Convert collections not unnested to json

yupeng9 commented on a change in pull request #6918: URL: https://github.com/apache/incubator-pinot/pull/6918#discussion_r632813364 ## File path: pinot-segment-local/src/test/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformerTest.java ## @@ -237,4 +23

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6918: Convert collections not unnested to json

siddharthteotia commented on a change in pull request #6918: URL: https://github.com/apache/incubator-pinot/pull/6918#discussion_r632812214 ## File path: pinot-segment-local/src/test/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformerTest.java ## @@ -2

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6918: Convert collections not unnested to json

siddharthteotia commented on a change in pull request #6918: URL: https://github.com/apache/incubator-pinot/pull/6918#discussion_r632812214 ## File path: pinot-segment-local/src/test/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformerTest.java ## @@ -2

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6922: Enhance PinotSegmentRecordReader to preserve null values

codecov-commenter edited a comment on pull request #6922: URL: https://github.com/apache/incubator-pinot/pull/6922#issuecomment-841033710 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6922?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[incubator-pinot] branch master updated: Mitigate calcite NPE bug. (#6908)

This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 59e342d Mitigate calcite NPE bug.

[GitHub] [incubator-pinot] siddharthteotia merged pull request #6908: Mitigate calcite NPE bug.

siddharthteotia merged pull request #6908: URL: https://github.com/apache/incubator-pinot/pull/6908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [incubator-pinot] mcvsubbu commented on pull request #6916: Add test suite for real time compatibility testing(#6787)

mcvsubbu commented on pull request #6916: URL: https://github.com/apache/incubator-pinot/pull/6916#issuecomment-841441251 @GSharayu thanks. Merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[incubator-pinot] branch master updated (1a38329 -> e379292)

This is an automated email from the ASF dual-hosted git repository. mcvsubbu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 1a38329 Add complex-type transformation to offline segment creation (#6914) add e379292 Add correc

[GitHub] [incubator-pinot] mcvsubbu merged pull request #6916: Add test suite for real time compatibility testing(#6787)

mcvsubbu merged pull request #6916: URL: https://github.com/apache/incubator-pinot/pull/6916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6916: Add test suite for real time compatibility testing(#6787)

codecov-commenter edited a comment on pull request #6916: URL: https://github.com/apache/incubator-pinot/pull/6916#issuecomment-840921230 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6916?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[incubator-pinot-site] branch asf-site updated: Update Pinot Site from dev branch b24070be709fbea681cb94a364eaea010a5e34d6

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pinot-site.git The following commit(s) were added to refs/heads/asf-site by this push: new bc0cae2 Update Pinot Site

[incubator-pinot-site] 01/01: Merge pull request #45 from apache/meta-tags

This is an automated email from the ASF dual-hosted git repository. mayanks pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-pinot-site.git commit b24070be709fbea681cb94a364eaea010a5e34d6 Merge: 1c8b8cd 08e4d58 Author: Mayank Shrivastava AuthorDate: Fri M

[incubator-pinot-site] branch dev updated (1c8b8cd -> b24070b)

This is an automated email from the ASF dual-hosted git repository. mayanks pushed a change to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-pinot-site.git. from 1c8b8cd Add new meta-tags for the website. add 08e4d58 Added `Fast Analytics` meta-tag. new b

[GitHub] [incubator-pinot-site] mayankshriv merged pull request #45: Added `Fast Analytics` meta-tag.

mayankshriv merged pull request #45: URL: https://github.com/apache/incubator-pinot-site/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [incubator-pinot-site] mayankshriv opened a new pull request #45: Added `Fast Analytics` meta-tag.

mayankshriv opened a new pull request #45: URL: https://github.com/apache/incubator-pinot-site/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about t

[incubator-pinot-site] 01/01: Added `Fast Analytics` meta-tag.

This is an automated email from the ASF dual-hosted git repository. mayanks pushed a commit to branch meta-tags in repository https://gitbox.apache.org/repos/asf/incubator-pinot-site.git commit 08e4d58a21ac4c37317aae0434af1d51cd3f3c31 Author: Mayank Shrivastava AuthorDate: Fri May 14 11:38:21 20

[incubator-pinot-site] branch meta-tags created (now 08e4d58)

This is an automated email from the ASF dual-hosted git repository. mayanks pushed a change to branch meta-tags in repository https://gitbox.apache.org/repos/asf/incubator-pinot-site.git. at 08e4d58 Added `Fast Analytics` meta-tag. This branch includes the following new commits: ne

[GitHub] [incubator-pinot] yupeng9 commented on pull request #6918: Convert collections not unnested to json

yupeng9 commented on pull request #6918: URL: https://github.com/apache/incubator-pinot/pull/6918#issuecomment-841425693 > Maybe add a enum config and have `NONE`, `NON_PRIMITIVE` and `ALL`? Default can be `NON_PRIMITIVE` if that is the most common case Sounds good to me. -- This

svn commit: r47706 - /release/incubator/pinot/KEYS

Author: snlee Date: Fri May 14 18:30:56 2021 New Revision: 47706 Log: Update Pinot KEYS file for 7199AF89 Modified: release/incubator/pinot/KEYS Modified: release/incubator/pinot/KEYS == --- release/incubator/pinot/K

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #6918: Convert collections not unnested to json

Jackie-Jiang commented on pull request #6918: URL: https://github.com/apache/incubator-pinot/pull/6918#issuecomment-841423135 Maybe add a enum config and have `NONE`, `NON_PRIMITIVE` and `ALL`? Default can be `NON_PRIMITIVE` if that is the most common case -- This is an automated message

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6922: Enhance PinotSegmentRecordReader to preserve null values

mayankshriv commented on a change in pull request #6922: URL: https://github.com/apache/incubator-pinot/pull/6922#discussion_r632712429 ## File path: pinot-core/src/main/java/org/apache/pinot/core/minion/SegmentPurger.java ## @@ -165,6 +160,7 @@ public boolean hasNext() {

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6908: Mitigate calcite NPE bug.

amrishlal commented on a change in pull request #6908: URL: https://github.com/apache/incubator-pinot/pull/6908#discussion_r632708438 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java ## @@ -107,7 +107,11 @@ public static Expressi

[incubator-pinot-site] branch asf-site updated: Update Pinot Site from dev branch 1c8b8cd46b673c0485a097af1d2135acf255ac38

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-pinot-site.git The following commit(s) were added to refs/heads/asf-site by this push: new 545f2d4 Update Pinot Site

[incubator-pinot-site] branch dev updated: Add new meta-tags for the website.

This is an automated email from the ASF dual-hosted git repository. mayanks pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-pinot-site.git The following commit(s) were added to refs/heads/dev by this push: new 1c8b8cd Add new meta-tags for the webs

[GitHub] [incubator-pinot] yupeng9 merged pull request #6914: Add complex-type transformation to offline segment creation

yupeng9 merged pull request #6914: URL: https://github.com/apache/incubator-pinot/pull/6914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6914: Add complex-type transformation to offline segment creation

codecov-commenter edited a comment on pull request #6914: URL: https://github.com/apache/incubator-pinot/pull/6914#issuecomment-840866102 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6914?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] GSharayu commented on a change in pull request #6916: Add test suite for real time compatibility testing(#6787)

GSharayu commented on a change in pull request #6916: URL: https://github.com/apache/incubator-pinot/pull/6916#discussion_r632688187 ## File path: compatibility-verifier/sample-test-suite/config/feature-test-2-realtime.json ## @@ -41,7 +41,7 @@ "sortedColumn": [], "s

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6916: Add test suite for real time compatibility testing(#6787)

mcvsubbu commented on a change in pull request #6916: URL: https://github.com/apache/incubator-pinot/pull/6916#discussion_r632676675 ## File path: compatibility-verifier/sample-test-suite/config/feature-test-2-realtime.json ## @@ -41,7 +41,7 @@ "sortedColumn": [], "s

[incubator-pinot] branch master updated: Compare state of rate limiting with ignoring cases (#6917)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new e1d6ca4 Compare state of rate limiting w

[GitHub] [incubator-pinot] jackjlli merged pull request #6917: Compare state of rate limiting with ignoring cases

jackjlli merged pull request #6917: URL: https://github.com/apache/incubator-pinot/pull/6917 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6914: Add complex-type transformation to offline segment creation

yupeng9 commented on a change in pull request #6914: URL: https://github.com/apache/incubator-pinot/pull/6914#discussion_r632643415 ## File path: pinot-tools/src/main/resources/examples/batch/githubEvents/githubEvents_offline_complexTypeHandling_table_config.json ## @@ -0,0 +1

[GitHub] [incubator-pinot] pedro93 opened a new issue #6923: Change zookeeper helm chart dependency

pedro93 opened a new issue #6923: URL: https://github.com/apache/incubator-pinot/issues/6923 The current zookeeper helm chart component of Pinot's Kubernetes deployment is [deprecated](https://github.com/helm/charts/tree/master/incubator/zookeeper) as of Nov 13, 2020. Consider changing