[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6820: Add ago() scalar transform function

2021-05-10 Thread GitBox
codecov-commenter edited a comment on pull request #6820: URL: https://github.com/apache/incubator-pinot/pull/6820#issuecomment-823812089 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6820?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6820: Add ago() scalar transform function

2021-05-10 Thread GitBox
mqliang commented on a change in pull request #6820: URL: https://github.com/apache/incubator-pinot/pull/6820#discussion_r629839329 ## File path: pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeFunctions.java ## @@ -261,6 +262,15 @@ public static lon

[incubator-pinot] branch master updated: Add debug endpoint for tables. (#6897)

2021-05-10 Thread mayanks
This is an automated email from the ASF dual-hosted git repository. mayanks pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new ff8700f Add debug endpoint for tables

[GitHub] [incubator-pinot] mayankshriv merged pull request #6897: Add debug endpoint for tables.

2021-05-10 Thread GitBox
mayankshriv merged pull request #6897: URL: https://github.com/apache/incubator-pinot/pull/6897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6842: Core Pinot Environment Provider Implementation Logic to fetch Failure…

2021-05-10 Thread GitBox
mcvsubbu commented on a change in pull request #6842: URL: https://github.com/apache/incubator-pinot/pull/6842#discussion_r629786020 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/environmentprovider/PinotEnvironmentProviderFactory.java ## @@ -0,0 +1,82 @@ +/** + *

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6897: Add debug endpoint for tables.

2021-05-10 Thread GitBox
mayankshriv commented on a change in pull request #6897: URL: https://github.com/apache/incubator-pinot/pull/6897#discussion_r629791019 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableDebugResource.java ## @@ -0,0 +1,251 @@ +/** + *

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6897: Add debug endpoint for tables.

2021-05-10 Thread GitBox
Jackie-Jiang commented on a change in pull request #6897: URL: https://github.com/apache/incubator-pinot/pull/6897#discussion_r629781413 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableDebugResource.java ## @@ -0,0 +1,267 @@ +/** + *

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6877: Enhance JSON index to support nested array

2021-05-10 Thread GitBox
Jackie-Jiang commented on a change in pull request #6877: URL: https://github.com/apache/incubator-pinot/pull/6877#discussion_r629778303 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/json/MutableJsonIndex.java ## @@ -186,43 +186,5

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6886: Adjust threadCpuTime calculation

2021-05-10 Thread GitBox
siddharthteotia commented on a change in pull request #6886: URL: https://github.com/apache/incubator-pinot/pull/6886#discussion_r629775907 ## File path: pinot-core/src/test/java/org/apache/pinot/core/operator/ThreadCpuTimeMeasurementTest.java ## @@ -0,0 +1,65 @@ +/** + * Lice

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6886: Adjust threadCpuTime calculation

2021-05-10 Thread GitBox
siddharthteotia commented on a change in pull request #6886: URL: https://github.com/apache/incubator-pinot/pull/6886#discussion_r629773754 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/InstanceResponseOperator.java ## @@ -45,8 +46,39 @@ protected Insta

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6886: Adjust threadCpuTime calculation

2021-05-10 Thread GitBox
siddharthteotia commented on a change in pull request #6886: URL: https://github.com/apache/incubator-pinot/pull/6886#discussion_r629764516 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseCombineOperator.java ## @@ -127,7 +127,7 @@ public void

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6886: Adjust threadCpuTime calculation

2021-05-10 Thread GitBox
siddharthteotia commented on a change in pull request #6886: URL: https://github.com/apache/incubator-pinot/pull/6886#discussion_r629764516 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseCombineOperator.java ## @@ -127,7 +127,7 @@ public void

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6886: Adjust threadCpuTime calculation

2021-05-10 Thread GitBox
siddharthteotia commented on a change in pull request #6886: URL: https://github.com/apache/incubator-pinot/pull/6886#discussion_r629764516 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseCombineOperator.java ## @@ -127,7 +127,7 @@ public void

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6886: Adjust threadCpuTime calculation

2021-05-10 Thread GitBox
siddharthteotia commented on a change in pull request #6886: URL: https://github.com/apache/incubator-pinot/pull/6886#discussion_r629762731 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/InstanceResponseOperator.java ## @@ -37,21 +36,51 @@ public Instanc

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6886: Adjust threadCpuTime calculation

2021-05-10 Thread GitBox
siddharthteotia commented on a change in pull request #6886: URL: https://github.com/apache/incubator-pinot/pull/6886#discussion_r629762731 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/InstanceResponseOperator.java ## @@ -37,21 +36,51 @@ public Instanc

[incubator-pinot] branch master updated (d83f188 -> f09600d)

2021-05-10 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from d83f188 Allow multiple alias for the same selection column. (#6891) add f09600d Remove realtime segment

[GitHub] [incubator-pinot] jackjlli merged pull request #6887: Remove realtime segment metrics if it's destroyed

2021-05-10 Thread GitBox
jackjlli merged pull request #6887: URL: https://github.com/apache/incubator-pinot/pull/6887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [incubator-pinot] richardstartin commented on a change in pull request #6877: Enhance JSON index to support nested array

2021-05-10 Thread GitBox
richardstartin commented on a change in pull request #6877: URL: https://github.com/apache/incubator-pinot/pull/6877#discussion_r629683586 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/json/MutableJsonIndex.java ## @@ -186,43 +186

[GitHub] [incubator-pinot] mqliang commented on pull request #6886: Adjust threadCpuTime calculation

2021-05-10 Thread GitBox
mqliang commented on pull request #6886: URL: https://github.com/apache/incubator-pinot/pull/6886#issuecomment-837288857 integration-test failed due to flaky issue, close&re-open PR to trigger a re-run. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-pinot] mqliang closed pull request #6886: Adjust threadCpuTime calculation

2021-05-10 Thread GitBox
mqliang closed pull request #6886: URL: https://github.com/apache/incubator-pinot/pull/6886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6845: Add the complex data type transformer for complex type handling

2021-05-10 Thread GitBox
yupeng9 commented on a change in pull request #6845: URL: https://github.com/apache/incubator-pinot/pull/6845#discussion_r629582155 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformer.java ## @@ -0,0 +1,184 @@

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6897: Add debug endpoint for tables.

2021-05-10 Thread GitBox
codecov-commenter edited a comment on pull request #6897: URL: https://github.com/apache/incubator-pinot/pull/6897#issuecomment-835921970 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6897?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] deemoliu opened a new pull request #6899: Add partial upsert config and mergers (WIP)

2021-05-10 Thread GitBox
deemoliu opened a new pull request #6899: URL: https://github.com/apache/incubator-pinot/pull/6899 ## Description ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion) * [ ] Yes (Please label as **backward-inc

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6897: Add debug endpoint for tables.

2021-05-10 Thread GitBox
codecov-commenter edited a comment on pull request #6897: URL: https://github.com/apache/incubator-pinot/pull/6897#issuecomment-835921970 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6897?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter edited a comment on pull request #6898: Move maxBurstQps broker metric in createRateLimiter method

2021-05-10 Thread GitBox
codecov-commenter edited a comment on pull request #6898: URL: https://github.com/apache/incubator-pinot/pull/6898#issuecomment-837137097 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6898?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

[GitHub] [incubator-pinot] codecov-commenter commented on pull request #6898: Move maxBurstQps broker metric in createRateLimiter method

2021-05-10 Thread GitBox
codecov-commenter commented on pull request #6898: URL: https://github.com/apache/incubator-pinot/pull/6898#issuecomment-837137097 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6898?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+commen

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #6887: Remove realtime segment metrics if it's destroyed

2021-05-10 Thread GitBox
jackjlli commented on a change in pull request #6887: URL: https://github.com/apache/incubator-pinot/pull/6887#discussion_r629580781 ## File path: pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java ## @@ -462,16 +463,48 @@ public void addCallbackGa

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6897: Add debug endpoint for tables.

2021-05-10 Thread GitBox
mayankshriv commented on a change in pull request #6897: URL: https://github.com/apache/incubator-pinot/pull/6897#discussion_r629580203 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableDebugResource.java ## @@ -0,0 +1,267 @@ +/** + *

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6897: Add debug endpoint for tables.

2021-05-10 Thread GitBox
mayankshriv commented on a change in pull request #6897: URL: https://github.com/apache/incubator-pinot/pull/6897#discussion_r629578230 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableDebugResource.java ## @@ -0,0 +1,267 @@ +/** + *

[GitHub] [incubator-pinot] jackjlli commented on pull request #6887: Remove realtime segment metrics if it's destroyed

2021-05-10 Thread GitBox
jackjlli commented on pull request #6887: URL: https://github.com/apache/incubator-pinot/pull/6887#issuecomment-837094283 > 1. I assume YammerMetrics works correctly when metrics are added or remove at the same time. It is possible that the destroy() method is called even as a new consumi

[incubator-pinot] branch cleanup-realtime-segment-metric updated (d136011 -> 5f6960b)

2021-05-10 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch cleanup-realtime-segment-metric in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from d136011 Remove realtime metrics if it's destroyed add 5f6960b Address PR comme

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6845: Add the complex data type transformer for complex type handling

2021-05-10 Thread GitBox
yupeng9 commented on a change in pull request #6845: URL: https://github.com/apache/incubator-pinot/pull/6845#discussion_r629575024 ## File path: pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/ComplexTypeTransformer.java ## @@ -0,0 +1,229 @@

[GitHub] [incubator-pinot] snleee merged pull request #6891: Allow multiple alias for the same selection column.

2021-05-10 Thread GitBox
snleee merged pull request #6891: URL: https://github.com/apache/incubator-pinot/pull/6891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[incubator-pinot] branch master updated (d2961e7 -> d83f188)

2021-05-10 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from d2961e7 [fix] update table config show error msg on exception (#6895) add d83f188 Allow multiple alias

[GitHub] [incubator-pinot] jackjlli opened a new pull request #6898: Move maxBurstQps broker metric in createRateLimiter method

2021-05-10 Thread GitBox
jackjlli opened a new pull request #6898: URL: https://github.com/apache/incubator-pinot/pull/6898 ## Description Currently when a quota config gets updated, `RefreshTableConfigMessageHandler` will trigger the `initOrUpdateTableQueryQuota` method, which will create a new QueryQuotaEntit

[incubator-pinot] branch fix-max-burst-qps updated (d3f89b6 -> 1f49d14)

2021-05-10 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch fix-max-burst-qps in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard d3f89b6 Move maxBurstQps broker metric in createRateLimiter method new 1f49d14 Move maxBurst

[incubator-pinot] 01/01: Move maxBurstQps broker metric in createRateLimiter method

2021-05-10 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch fix-max-burst-qps in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 1f49d149800931efd2b7b27764ad60be0754933a Author: Jack Li(Analytics Engineering) AuthorDate: Mon May 10

[incubator-pinot] 01/01: Move maxBurstQps broker metric in createRateLimiter method

2021-05-10 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch fix-max-burst-qps in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit d3f89b6aa14976ce01a46912a78d15393628d85f Author: Jack Li(Analytics Engineering) AuthorDate: Mon May 10

[incubator-pinot] branch fix-max-burst-qps updated (08db875 -> d3f89b6)

2021-05-10 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch fix-max-burst-qps in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 08db875 Move maxBurstQps broker metric in createRateLimiter method new d3f89b6 Move maxBurst

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6897: Add debug endpoint for tables.

2021-05-10 Thread GitBox
Jackie-Jiang commented on a change in pull request #6897: URL: https://github.com/apache/incubator-pinot/pull/6897#discussion_r629546398 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/debug/TableDebugInfo.java ## @@ -0,0 +1,212 @@ +/** + * License

[incubator-pinot] 01/01: Move maxBurstQps broker metric in createRateLimiter method

2021-05-10 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch fix-max-burst-qps in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 08db87567a3de64a0e07b466b6151d83a8161199 Author: Jack Li(Analytics Engineering) AuthorDate: Mon May 10

[incubator-pinot] branch fix-max-burst-qps created (now 08db875)

2021-05-10 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch fix-max-burst-qps in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 08db875 Move maxBurstQps broker metric in createRateLimiter method This branch includes the follo

[incubator-pinot] branch master updated: [fix] update table config show error msg on exception (#6895)

2021-05-10 Thread mayanks
This is an automated email from the ASF dual-hosted git repository. mayanks pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new d2961e7 [fix] update table config sho

[GitHub] [incubator-pinot] mayankshriv merged pull request #6895: [fix] update table config show error msg on exception

2021-05-10 Thread GitBox
mayankshriv merged pull request #6895: URL: https://github.com/apache/incubator-pinot/pull/6895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser