[incubator-pinot] branch master updated: Fix an issue with datetime column in Rule Engine (#6731)

This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 56ef680 Fix an issue with datetime

[GitHub] [incubator-pinot] siddharthteotia merged pull request #6731: Fix an issue with datetime column in Rule Engine

siddharthteotia merged pull request #6731: URL: https://github.com/apache/incubator-pinot/pull/6731 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [incubator-pinot] sajjad-moradi commented on a change in pull request #6731: Fix an issue with datetime column in Rule Engine

sajjad-moradi commented on a change in pull request #6731: URL: https://github.com/apache/incubator-pinot/pull/6731#discussion_r605379645 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/io/InputManager.java ## @@ -181,15 +182,19 @@ private

[incubator-pinot] branch upgrade_jdk_11 updated (2da40d8 -> b39e075)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch upgrade_jdk_11 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 2da40d8 move http requests in ControlerTest to use apache http client lib add b39e075 move

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6731: Fix an issue with datetime column in Rule Engine

siddharthteotia commented on a change in pull request #6731: URL: https://github.com/apache/incubator-pinot/pull/6731#discussion_r605341158 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/io/InputManager.java ## @@ -181,15 +182,19 @@ privat

[GitHub] [incubator-pinot] sajjad-moradi commented on a change in pull request #6731: Fix an issue with datetime column in Rule Engine

sajjad-moradi commented on a change in pull request #6731: URL: https://github.com/apache/incubator-pinot/pull/6731#discussion_r605339518 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/io/InputManager.java ## @@ -181,15 +182,19 @@ private

[incubator-pinot] branch master updated: Throw exception and give error message when creating schema with spaces in column name (#6735)

This is an automated email from the ASF dual-hosted git repository. siddteotia pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 20c17f6 Throw exception and give e

[GitHub] [incubator-pinot] siddharthteotia merged pull request #6735: Throw exception and give error message when creating schema with spaces in column name

siddharthteotia merged pull request #6735: URL: https://github.com/apache/incubator-pinot/pull/6735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

amrishlal commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r605325603 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableImplV3.java ## @@ -0,0 +1,399 @@ +/** + * Licensed to th

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

amrishlal commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r605325492 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableImplV2.java ## @@ -50,51 +46,19 @@ // VARIABLE_SIZE_D

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

amrishlal commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r605325369 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/BaseDataTable.java ## @@ -0,0 +1,284 @@ +/** + * Licensed to the

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

amrishlal commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r605325237 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java ## @@ -80,4 +85,85 @@ double[] getDoubleArray(int rowI

[GitHub] [incubator-pinot] amrishlal commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

amrishlal commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r605324977 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java ## @@ -80,4 +85,85 @@ double[] getDoubleArray(int rowI

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #5829: Pinot Query Console loosing Long granularity in results.

Jackie-Jiang commented on issue #5829: URL: https://github.com/apache/incubator-pinot/issues/5829#issuecomment-811534840 UI result (lose precision): ![Screen Shot 2021-03-31 at 3 55 46 PM](https://user-images.githubusercontent.com/1751/113224244-df301f80-923f-11eb-99d3-6c5094f64a5f.

[GitHub] [incubator-pinot] mr-agrwal opened a new issue #5829: Pinot Query Console loosing Long granularity in results.

mr-agrwal opened a new issue #5829: URL: https://github.com/apache/incubator-pinot/issues/5829 I am querying a table using the Pinot Query Console with id = 2140008726127. The response returns with id = 2140008726130. The same if I do through a broker, it is working fine.

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #5829: Pinot Query Console loosing Long granularity in results.

Jackie-Jiang commented on issue #5829: URL: https://github.com/apache/incubator-pinot/issues/5829#issuecomment-811533898 Reopen this issue as we should show long values correctly in Pinot Query Console -- This is an automated message from the Apache Git Service. To respond to the messag

[incubator-pinot] branch upgrade_jdk_11 updated (8d42d4e -> 2da40d8)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch upgrade_jdk_11 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 8d42d4e move http requests in ControlerTest to use apache http client lib add 2da40d8 move

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

siddharthteotia commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r605260402 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java ## @@ -80,4 +85,87 @@ double[] getDoubleArray(in

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6731: Fix an issue with datetime column in Rule Engine

siddharthteotia commented on a change in pull request #6731: URL: https://github.com/apache/incubator-pinot/pull/6731#discussion_r605235846 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/io/InputManager.java ## @@ -181,15 +182,19 @@ privat

[incubator-pinot] branch upgrade_jdk_11 updated (65f97ad -> 8d42d4e)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch upgrade_jdk_11 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 65f97ad move http requests in ControlerTest to use apache http client lib add 8d42d4e move

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r605222747 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java ## @@ -80,4 +85,87 @@ double[] getDoubleArray(int rowId,

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r605222747 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java ## @@ -80,4 +85,87 @@ double[] getDoubleArray(int rowId,

[GitHub] [incubator-pinot] fx19880617 closed pull request #6736: Fixing the issue that multi-get doesn't release the http connection

fx19880617 closed pull request #6736: URL: https://github.com/apache/incubator-pinot/pull/6736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this serv

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6735: Throw exception and give error message when creating schema with spaces in column name

siddharthteotia commented on a change in pull request #6735: URL: https://github.com/apache/incubator-pinot/pull/6735#discussion_r605221551 ## File path: pinot-core/src/test/java/org/apache/pinot/core/util/SchemaUtilsTest.java ## @@ -313,6 +315,42 @@ public void testDateTimeFi

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r604531296 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java ## @@ -80,4 +85,87 @@ double[] getDoubleArray(int rowId,

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r605219147 ## File path: pinot-core/src/test/java/org/apache/pinot/core/common/datatable/DataTableSerDeTest.java ## @@ -96,22 +99,130 @@ public void testAll

[GitHub] [incubator-pinot] mqliang commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mqliang commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r605218640 ## File path: pinot-core/src/main/java/org/apache/pinot/core/common/datatable/DataTableBuilder.java ## @@ -91,11 +94,16 @@ private ByteBuffer

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #6736: Fixing the issue that multi-get doesn't release the http connection

fx19880617 opened a new pull request #6736: URL: https://github.com/apache/incubator-pinot/pull/6736 ## Description Per: https://hc.apache.org/httpclient-legacy/threading.html, we need to release the connection for get method. This sometimes failed the tests in JDK 11. ## U

[incubator-pinot] branch fixing_http_connection_not_released_issue created (now 7013b8a)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch fixing_http_connection_not_released_issue in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 7013b8a Fixing the issue that multi-get doesn't release the http conne

[incubator-pinot] 01/01: Fixing the issue that multi-get doesn't release the http connection

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch fixing_http_connection_not_released_issue in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 7013b8a9d617c5dd8aebf6587345231ee3e6ebf4 Author: Xiang Fu AuthorDate: Wed M

[incubator-pinot] branch upgrade_jdk_11 updated (0fe2e96 -> 65f97ad)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch upgrade_jdk_11 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 0fe2e96 move http requests in ControlerTest to use apache http client lib add 65f97ad move

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6735: Throw exception and give error message when creating schema with spaces in column name

siddharthteotia commented on a change in pull request #6735: URL: https://github.com/apache/incubator-pinot/pull/6735#discussion_r605206152 ## File path: pinot-core/src/test/java/org/apache/pinot/core/util/SchemaUtilsTest.java ## @@ -313,6 +315,24 @@ public void testDateTimeFi

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6735: Throw exception and give error message when creating schema with spaces in column name

siddharthteotia commented on a change in pull request #6735: URL: https://github.com/apache/incubator-pinot/pull/6735#discussion_r605205074 ## File path: pinot-core/src/main/java/org/apache/pinot/core/util/SchemaUtils.java ## @@ -79,6 +81,8 @@ public static void validate(Schema

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6735: Throw exception and give error message when creating schema with spaces in column name

siddharthteotia commented on a change in pull request #6735: URL: https://github.com/apache/incubator-pinot/pull/6735#discussion_r605203813 ## File path: pinot-core/src/test/java/org/apache/pinot/core/util/SchemaUtilsTest.java ## @@ -313,6 +315,24 @@ public void testDateTimeFi

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6721: WIP: Pinot SPI refactor (no functionality change)

mayankshriv commented on a change in pull request #6721: URL: https://github.com/apache/incubator-pinot/pull/6721#discussion_r605190270 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/pruner/PartitionZKMetadataPruner.java ## @@ -26,7 +26,7 @@ import org.apach

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6728: Unify data type conversion and formatting

Jackie-Jiang commented on a change in pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r605186834 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/JsonExtractScalarTransformFunction.java ## @@ -84,4

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mcvsubbu commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r605166183 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataTable.java ## @@ -80,4 +85,87 @@ double[] getDoubleArray(int rowId

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6710: DataTable V3 implementation and measure data table serialization cost on server

mcvsubbu commented on a change in pull request #6710: URL: https://github.com/apache/incubator-pinot/pull/6710#discussion_r605165539 ## File path: pinot-core/src/test/java/org/apache/pinot/core/common/datatable/DataTableSerDeTest.java ## @@ -96,22 +99,130 @@ public void testAl

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #6728: Unify data type conversion and formatting

Jackie-Jiang commented on pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#issuecomment-811347857 > High level question - can we consider merging these different specifications of data types. The DataType captured in the schema has both SV and MV for primitives

[incubator-pinot] branch upgrade_jdk_11 updated (c03bef5 -> 0fe2e96)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch upgrade_jdk_11 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard c03bef5 move http requests in ControlerTest to use apache http client lib add 0fe2e96 move

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6728: Unify data type conversion and formatting

Jackie-Jiang commented on a change in pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r605139108 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/FieldSpec.java ## @@ -398,6 +390,58 @@ public boolean isFixedWidth() { p

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6728: Unify data type conversion and formatting

Jackie-Jiang commented on a change in pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r605137900 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/selection/SelectionOperatorUtils.java ## @@ -490,82 +491,13 @@ public sta

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6728: Unify data type conversion and formatting

Jackie-Jiang commented on a change in pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r605137651 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java ## @@ -127,62 +126,41 @@ public static Expr

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6728: Unify data type conversion and formatting

Jackie-Jiang commented on a change in pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r605136714 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java ## @@ -127,62 +126,41 @@ public static Expr

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6728: Unify data type conversion and formatting

Jackie-Jiang commented on a change in pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r605135579 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java ## @@ -127,62 +126,41 @@ public static Expr

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6728: Unify data type conversion and formatting

Jackie-Jiang commented on a change in pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r605133627 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java ## @@ -127,62 +126,41 @@ public static Expr

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6728: Unify data type conversion and formatting

Jackie-Jiang commented on a change in pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r605132173 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java ## @@ -634,7 +754,7 @@ public PinotDataType getSin

[GitHub] [incubator-pinot] mqliang commented on pull request #6735: Throw exception and give error message when creating schema with spaces in column name

mqliang commented on pull request #6735: URL: https://github.com/apache/incubator-pinot/pull/6735#issuecomment-811313963 cc @fx19880617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [incubator-pinot] mqliang opened a new pull request #6735: Throw exception and give error message when creating schema with spaces in column name

mqliang opened a new pull request #6735: URL: https://github.com/apache/incubator-pinot/pull/6735 ## Description Throw exception and give error message when creating schema with spaces in column name ## Upgrade Notes Does this PR prevent a zero down-time upgrade? (Assum

[GitHub] [incubator-pinot] dongxiaoman opened a new pull request #6734: Fix broken timer properly

dongxiaoman opened a new pull request #6734: URL: https://github.com/apache/incubator-pinot/pull/6734 ## Description Currently the timer metric in Pinot is missing values (all zero). It is because we forgot to update the value. This PR fixes the bug. ## Upgrade Notes Does this P

[GitHub] [incubator-pinot] dongxiaoman closed pull request #6733: Fix the pinot timer missing bug

dongxiaoman closed pull request #6733: URL: https://github.com/apache/incubator-pinot/pull/6733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this ser

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6728: Unify data type conversion and formatting

Jackie-Jiang commented on a change in pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r605099417 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java ## @@ -439,27 +440,55 @@ public String toString(Ob

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6728: Unify data type conversion and formatting

Jackie-Jiang commented on a change in pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r605099417 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java ## @@ -439,27 +440,55 @@ public String toString(Ob

[GitHub] [incubator-pinot] dongxiaoman opened a new pull request #6733: Fix the pinot timer missing bug

dongxiaoman opened a new pull request #6733: URL: https://github.com/apache/incubator-pinot/pull/6733 ## Description Currently the timer metric in Pinot is missing values (all zero). It is because we forgot to update the value. This PR fixes the bug. ## Upgrade Notes Does this P

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6728: Unify data type conversion and formatting

Jackie-Jiang commented on a change in pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r605096611 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataSchema.java ## @@ -241,11 +244,179 @@ public boolean isCompatible

[incubator-pinot] branch master updated: Explicitly enable lead controller resource (#6725)

This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new e8ef1de Explicitly enable lead controlle

[GitHub] [incubator-pinot] jackjlli merged pull request #6725: Explicitly enable lead controller resource

jackjlli merged pull request #6725: URL: https://github.com/apache/incubator-pinot/pull/6725 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[GitHub] [incubator-pinot] jackjlli closed issue #6730: Remove config of enabling lead controller resource

jackjlli closed issue #6730: URL: https://github.com/apache/incubator-pinot/issues/6730 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pl

[GitHub] [incubator-pinot] chenboat merged pull request #6653: add uploadLLCSegment endpoint in TableResource

chenboat merged pull request #6653: URL: https://github.com/apache/incubator-pinot/pull/6653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this servic

[incubator-pinot] branch master updated: add uploadLLCSegment endpoint in TableResource (#6653)

This is an automated email from the ASF dual-hosted git repository. tingchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 6c6d08e add uploadLLCSegment endpoin

[GitHub] [incubator-pinot] siddharthteotia edited a comment on pull request #6728: Unify data type conversion and formatting

siddharthteotia edited a comment on pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#issuecomment-810954992 High level question - can we consider merging these different specifications of data types. The DataType captured in the schema has both SV and MV for pri

[GitHub] [incubator-pinot] siddharthteotia commented on pull request #6728: Unify data type conversion and formatting

siddharthteotia commented on pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#issuecomment-810954992 High level question - can we consider merging these different specifications of data types. The DataType captured in the schema has both SV and MV for primitives

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6728: Unify data type conversion and formatting

siddharthteotia commented on a change in pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r604762376 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/FieldSpec.java ## @@ -398,6 +390,58 @@ public boolean isFixedWidth() {

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6728: Unify data type conversion and formatting

siddharthteotia commented on a change in pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r604762020 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java ## @@ -634,7 +754,7 @@ public PinotDataType get

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6728: Unify data type conversion and formatting

siddharthteotia commented on a change in pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r604761829 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/PinotDataType.java ## @@ -439,27 +440,55 @@ public String toString

[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6728: Unify data type conversion and formatting

siddharthteotia commented on a change in pull request #6728: URL: https://github.com/apache/incubator-pinot/pull/6728#discussion_r604761571 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/DataSchema.java ## @@ -241,11 +244,179 @@ public boolean isCompati

[incubator-pinot] branch upgrade_jdk_11 updated (18e8403 -> c03bef5)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch upgrade_jdk_11 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 18e8403 move http requests in ControlerTest to use apache http client lib add c03bef5 move

[incubator-pinot] branch upgrade_jdk_11 updated (dad26bd -> 18e8403)

This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch upgrade_jdk_11 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard dad26bd move http requests in ControlerTest to use apache http client lib add 18e8403 move