codecov-io removed a comment on pull request #6558:
URL: https://github.com/apache/incubator-pinot/pull/6558#issuecomment-775850103
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6558?src=pr&el=h1)
Report
> Merging
[#6558](https://codecov.io/gh/apache/incubator-pinot/pul
fx19880617 commented on issue #6557:
URL:
https://github.com/apache/incubator-pinot/issues/6557#issuecomment-776509406
@KKcorps ^^
This is an automated message from the Apache Git Service.
To respond to the message, please l
siddharthteotia commented on a change in pull request #6559:
URL: https://github.com/apache/incubator-pinot/pull/6559#discussion_r573484761
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java
##
@@ -108,3
siddharthteotia commented on a change in pull request #6559:
URL: https://github.com/apache/incubator-pinot/pull/6559#discussion_r573484428
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java
##
@@ -61,8
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch upgrade_zk_version
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard b773e81 Upgrade zookeeper version
add ea0d605 Upgrade zookeeper version
This update add
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new a6196ba Adding metrics for minion tas
fx19880617 closed issue #6527:
URL: https://github.com/apache/incubator-pinot/issues/6527
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
fx19880617 merged pull request #6549:
URL: https://github.com/apache/incubator-pinot/pull/6549
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
fx19880617 merged pull request #6560:
URL: https://github.com/apache/incubator-pinot/pull/6560
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 8013a2d Use minion data directory as
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch upgrade_zk_version
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 782f965 Upgrade zookeeper version
add b773e81 Upgrade zookeeper version
This update add
snleee commented on pull request #6567:
URL: https://github.com/apache/incubator-pinot/pull/6567#issuecomment-776427097
@chenboat Can you open up the access for the linked design doc?
This is an automated message from the Apa
snleee commented on a change in pull request #6531:
URL: https://github.com/apache/incubator-pinot/pull/6531#discussion_r573430961
##
File path:
pinot-plugins/pinot-file-system/pinot-adls/src/main/java/org/apache/pinot/plugin/filesystem/ADLSGen2PinotFS.java
##
@@ -106,24 +118,
snleee commented on a change in pull request #6531:
URL: https://github.com/apache/incubator-pinot/pull/6531#discussion_r573430961
##
File path:
pinot-plugins/pinot-file-system/pinot-adls/src/main/java/org/apache/pinot/plugin/filesystem/ADLSGen2PinotFS.java
##
@@ -106,24 +118,
snleee commented on a change in pull request #6531:
URL: https://github.com/apache/incubator-pinot/pull/6531#discussion_r573430961
##
File path:
pinot-plugins/pinot-file-system/pinot-adls/src/main/java/org/apache/pinot/plugin/filesystem/ADLSGen2PinotFS.java
##
@@ -106,24 +118,
snleee commented on a change in pull request #6531:
URL: https://github.com/apache/incubator-pinot/pull/6531#discussion_r573430961
##
File path:
pinot-plugins/pinot-file-system/pinot-adls/src/main/java/org/apache/pinot/plugin/filesystem/ADLSGen2PinotFS.java
##
@@ -106,24 +118,
snleee commented on a change in pull request #6531:
URL: https://github.com/apache/incubator-pinot/pull/6531#discussion_r573430961
##
File path:
pinot-plugins/pinot-file-system/pinot-adls/src/main/java/org/apache/pinot/plugin/filesystem/ADLSGen2PinotFS.java
##
@@ -106,24 +118,
This is an automated email from the ASF dual-hosted git repository.
jihao pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from d03629e add optional http basic auth to pinot broker (#6552)
add 2ee498c [TE] escape Pinot timespect S
jihaozh merged pull request #6566:
URL: https://github.com/apache/incubator-pinot/pull/6566
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
rkanumul commented on a change in pull request #6531:
URL: https://github.com/apache/incubator-pinot/pull/6531#discussion_r573410217
##
File path:
pinot-plugins/pinot-file-system/pinot-adls/src/main/java/org/apache/pinot/plugin/filesystem/ADLSGen2PinotFS.java
##
@@ -106,24 +11
Jackie-Jiang commented on a change in pull request #6567:
URL: https://github.com/apache/incubator-pinot/pull/6567#discussion_r573404392
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java
##
@@
siddharthteotia commented on pull request #6566:
URL: https://github.com/apache/incubator-pinot/pull/6566#issuecomment-776397737
@jihaozh , I am assuming this is related to the increasing error rate we saw
earlier today on the SQL endpoint. Can you please make sure all reserved
keywords ar
Jackie-Jiang commented on a change in pull request #6549:
URL: https://github.com/apache/incubator-pinot/pull/6549#discussion_r573393642
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java
##
@@ -478,4 +489,34 @@ pub
Jackie-Jiang opened a new pull request #6569:
URL: https://github.com/apache/incubator-pinot/pull/6569
## Description
Enhance the StarTreeIndexViewers to support:
- Visualize multiple star-trees
- Include dimension name in the node
- Fix a bug of miscounting the top nodes
-
Jackie-Jiang commented on a change in pull request #6559:
URL: https://github.com/apache/incubator-pinot/pull/6559#discussion_r573385797
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java
##
@@ -831,6 +7
Jackie-Jiang commented on a change in pull request #6559:
URL: https://github.com/apache/incubator-pinot/pull/6559#discussion_r573385274
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java
##
@@ -108,35 +
Jackie-Jiang commented on a change in pull request #6559:
URL: https://github.com/apache/incubator-pinot/pull/6559#discussion_r573384919
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java
##
@@ -831,6 +7
Jackie-Jiang commented on a change in pull request #6559:
URL: https://github.com/apache/incubator-pinot/pull/6559#discussion_r573384462
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java
##
@@ -831,6 +7
snleee commented on a change in pull request #6531:
URL: https://github.com/apache/incubator-pinot/pull/6531#discussion_r573383802
##
File path:
pinot-plugins/pinot-file-system/pinot-adls/src/main/java/org/apache/pinot/plugin/filesystem/ADLSGen2PinotFS.java
##
@@ -106,24 +118,
Jackie-Jiang commented on a change in pull request #6559:
URL: https://github.com/apache/incubator-pinot/pull/6559#discussion_r573384195
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java
##
@@ -831,6 +7
Jackie-Jiang commented on a change in pull request #6559:
URL: https://github.com/apache/incubator-pinot/pull/6559#discussion_r573383852
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java
##
@@ -831,6 +7
snleee commented on a change in pull request #6531:
URL: https://github.com/apache/incubator-pinot/pull/6531#discussion_r573383802
##
File path:
pinot-plugins/pinot-file-system/pinot-adls/src/main/java/org/apache/pinot/plugin/filesystem/ADLSGen2PinotFS.java
##
@@ -106,24 +118,
Jackie-Jiang commented on a change in pull request #6559:
URL: https://github.com/apache/incubator-pinot/pull/6559#discussion_r573381665
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java
##
@@ -108,35 +
Jackie-Jiang commented on a change in pull request #6559:
URL: https://github.com/apache/incubator-pinot/pull/6559#discussion_r573380233
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java
##
@@ -61,8 +61
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch upgrade_zk_version
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 70599ee Upgrade zookeeper version
add 782f965 Upgrade zookeeper version
This update add
zhangloo333 opened a new pull request #6568:
URL: https://github.com/apache/incubator-pinot/pull/6568
## Description
Fix all eslint reported errors and warnings under app/pods/components
Test
Pass: yarn test
1..376
tests 376
pass 374
skip 2
fail 0
Pass: E2E
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch upgrade_zk_version
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 405435b Upgrade zookeeper version to 3.4.13
add 70599ee Upgrade zookeeper version
This
mcvsubbu commented on a change in pull request #6567:
URL: https://github.com/apache/incubator-pinot/pull/6567#discussion_r573367216
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java
##
@@ -245
codecov-io commented on pull request #6560:
URL: https://github.com/apache/incubator-pinot/pull/6560#issuecomment-776352333
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6560?src=pr&el=h1)
Report
> Merging
[#6560](https://codecov.io/gh/apache/incubator-pinot/pull/6560?s
codecov-io commented on pull request #6567:
URL: https://github.com/apache/incubator-pinot/pull/6567#issuecomment-776350585
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6567?src=pr&el=h1)
Report
> Merging
[#6567](https://codecov.io/gh/apache/incubator-pinot/pull/6567?s
chenboat opened a new pull request #6567:
URL: https://github.com/apache/incubator-pinot/pull/6567
## Description
Currently segment upload is only applicable for offline Pinot tables. This
PR opens the segment upload to Pinot realtime tables too. Segment upload to
realtime tables makes
jihaozh opened a new pull request #6566:
URL: https://github.com/apache/incubator-pinot/pull/6566
Escape the reserved keywords for Pinot timespec SQL query.
This is an automated message from the Apache Git Service.
To respond
This is an automated email from the ASF dual-hosted git repository.
jihao pushed a change to branch pinot-time-spec
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at b0a03fb [TE] escape Pinot timespect SQL query
This branch includes the following new commits:
This is an automated email from the ASF dual-hosted git repository.
jihao pushed a commit to branch pinot-time-spec
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit b0a03fba93fef7669df6c87738bc7099c415bd1a
Author: Jihao Zhang
AuthorDate: Tue Feb 9 15:46:44 2021 -0800
fx19880617 opened a new pull request #6565:
URL: https://github.com/apache/incubator-pinot/pull/6565
## Description
Per #6564 , support Server side encryption in S3PinotFS.
New configurations:
| Configuration | Description |
| --- | --- |
| serverS
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch s3-kms
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit 9561db08ce766f1b32d6c7521629fb58b1a4fa65
Author: Xiang Fu
AuthorDate: Tue Feb 9 15:12:19 2021 -0800
Suppo
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch s3-kms
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at 9561db0 Support S3 with server side encryption mode aws:kms
This branch includes the following new commit
siddharthteotia commented on a change in pull request #6559:
URL: https://github.com/apache/incubator-pinot/pull/6559#discussion_r573305843
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java
##
@@ -61,8
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new d03629e add optional http basic auth
apucher merged pull request #6552:
URL: https://github.com/apache/incubator-pinot/pull/6552
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
mikecdavis opened a new issue #6564:
URL: https://github.com/apache/incubator-pinot/issues/6564
The current S3PinotFS implementation does not support server-side
encryption, although it is supported via the underlying AWS SDK. Support can be
added by capturing the required parameters via c
icefury71 commented on a change in pull request #6541:
URL: https://github.com/apache/incubator-pinot/pull/6541#discussion_r573287248
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java
##
@@ -488,18 +527,37 @@ private static void validateFi
icefury71 commented on a change in pull request #6541:
URL: https://github.com/apache/incubator-pinot/pull/6541#discussion_r573286455
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/util/TableConfigUtils.java
##
@@ -488,18 +527,37 @@ private static void validateFi
apucher commented on a change in pull request #6552:
URL: https://github.com/apache/incubator-pinot/pull/6552#discussion_r573264456
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/broker/BasicAuthAccessControlFactory.java
##
@@ -0,0 +1,168 @@
+/**
+ * Licensed
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a change to branch basic-auth-broker
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 2e00b2c Update BasicAuthAccessControlFactory.java
add 03c6c08 Update BasicAuthAccessContr
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a change to branch basic-auth-broker
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 42c1393 Update
pinot-broker/src/main/java/org/apache/pinot/broker/broker/BasicAuthAccessContro
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a change to branch basic-auth-broker
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 79ba7fd review fixes 2
add 42c1393 Update
pinot-broker/src/main/java/org/apache/pinot/br
Jackie-Jiang commented on a change in pull request #6552:
URL: https://github.com/apache/incubator-pinot/pull/6552#discussion_r573240997
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/broker/BasicAuthAccessControlFactory.java
##
@@ -0,0 +1,170 @@
+/**
+ * Lic
Jackie-Jiang commented on a change in pull request #6552:
URL: https://github.com/apache/incubator-pinot/pull/6552#discussion_r573240061
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/broker/BasicAuthAccessControlFactory.java
##
@@ -0,0 +1,168 @@
+/**
+ * Lic
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a change to branch basic-auth-broker
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from d217688 review fixes 1
add 79ba7fd review fixes 2
No new revisions were added by this up
apucher commented on pull request #6552:
URL: https://github.com/apache/incubator-pinot/pull/6552#issuecomment-776178335
re the first comment (which I somehow can't respond to inline):
`.map(_principals::get)` is fine if the key, i.e. the token, is null.
There's even a unit tests for thi
apucher commented on a change in pull request #6552:
URL: https://github.com/apache/incubator-pinot/pull/6552#discussion_r573162893
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java
##
@@ -29,18 +29,22 @@
import jav
apucher commented on a change in pull request #6552:
URL: https://github.com/apache/incubator-pinot/pull/6552#discussion_r573162779
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/broker/BasicAuthAccessControlFactory.java
##
@@ -0,0 +1,168 @@
+/**
+ * Licensed
This is an automated email from the ASF dual-hosted git repository.
jihao pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from e62addb [TE]: fix eslint reported issue under the authenticators,
helpers, and mirage folder (#6551)
a
jihaozh merged pull request #6553:
URL: https://github.com/apache/incubator-pinot/pull/6553
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
Jackie-Jiang commented on a change in pull request #6552:
URL: https://github.com/apache/incubator-pinot/pull/6552#discussion_r573145470
##
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/broker/BasicAuthAccessControlFactory.java
##
@@ -0,0 +1,159 @@
+/**
+ * Lic
jihaozh opened a new pull request #6563:
URL: https://github.com/apache/incubator-pinot/pull/6563
Update the format to DateTime when sending a date to the Jira API.
Previously it was sent as `ComplexIssueInputFieldValue` which will get an error
response.
This is an automated email from the ASF dual-hosted git repository.
jihao pushed a change to branch jira-date-format
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at d1437ec [TE] update date format when send to Jira API
This branch includes the following new comm
This is an automated email from the ASF dual-hosted git repository.
jihao pushed a commit to branch jira-date-format
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit d1437ec9d848b3817b33720ef2faa70bbacfe221
Author: Jihao Zhang
AuthorDate: Tue Feb 9 09:42:28 2021 -0800
kishoreg commented on issue #6562:
URL:
https://github.com/apache/incubator-pinot/issues/6562#issuecomment-776101408
@sajjad-moradi awesome find
This is an automated message from the Apache Git Service.
To respond to the mes
sajjad-moradi opened a new issue #6562:
URL: https://github.com/apache/incubator-pinot/issues/6562
When a consuming segment completes, all the files in consuming directory are
supposed to be deleted. However, text index for real time tables does not clean
up all the files. For each segment
louisthomas opened a new issue #6561:
URL: https://github.com/apache/incubator-pinot/issues/6561
Why?
It will help to discover security vulnerabilities across your codebase.
Documentation: https://codeql.github.com/docs/
[Code codeql github action](https://github.com/git
codecov-io commented on pull request #6558:
URL: https://github.com/apache/incubator-pinot/pull/6558#issuecomment-775850103
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6558?src=pr&el=h1)
Report
> Merging
[#6558](https://codecov.io/gh/apache/incubator-pinot/pull/6558?s
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch upgrade_zk_version
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 5f9cca3 Upgrade zookeeper version to 3.4.13
add 405435b Upgrade zookeeper version to 3.4
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch upgrade_zk_version
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 376a899 Upgrade zookeeper version to 3.4.13
add 5f9cca3 Upgrade zookeeper version to 3.4
codecov-io removed a comment on pull request #6558:
URL: https://github.com/apache/incubator-pinot/pull/6558#issuecomment-775489197
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6558?src=pr&el=h1)
Report
> Merging
[#6558](https://codecov.io/gh/apache/incubator-pinot/pul
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch upgrade_zk_version
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard e7a5b4b Upgrade zookeeper version to 3.6.2
add 376a899 Upgrade zookeeper version to 3.4.
fx19880617 opened a new pull request #6560:
URL: https://github.com/apache/incubator-pinot/pull/6560
## Description
Use minion data directory instead of system temp directory as
SegmentGenerationAndPushTask tmp directory.
## Upgrade Notes
Does this PR prevent a zero down-time u
78 matches
Mail list logo
