[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6423: Replace BrokerRequestOptimizer with QueryOptimizer to also optimize the PinotQuery

codecov-io edited a comment on pull request #6423: URL: https://github.com/apache/incubator-pinot/pull/6423#issuecomment-756958910 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6423?src=pr&el=h1) Report > Merging [#6423](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6418: TLS-support for client-pinot and pinot-internode connections

codecov-io edited a comment on pull request #6418: URL: https://github.com/apache/incubator-pinot/pull/6418#issuecomment-755917563 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6418?src=pr&el=h1) Report > Merging [#6418](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] apucher commented on a change in pull request #6418: TLS-support for client-pinot and pinot-internode connections

apucher commented on a change in pull request #6418: URL: https://github.com/apache/incubator-pinot/pull/6418#discussion_r554279196 ## File path: pinot-core/src/main/java/org/apache/pinot/core/transport/TlsConfig.java ## @@ -0,0 +1,79 @@ +/** + * Licensed to the Apache Softwar

[incubator-pinot] branch pinot-internode-tls updated (ed6c724 -> b63ab5f)

This is an automated email from the ASF dual-hosted git repository. apucher pushed a change to branch pinot-internode-tls in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from ed6c724 add protocol param to admin commands add b63ab5f review fixes subbu 1 No new r

[incubator-pinot] branch sharded_consumer_type_support_with_kinesis updated: Cleanup, javadocs, comments

This is an automated email from the ASF dual-hosted git repository. nehapawar pushed a commit to branch sharded_consumer_type_support_with_kinesis in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/sharded_consumer_type_support

[GitHub] [incubator-pinot] mcvsubbu commented on pull request #6418: TLS-support for client-pinot and pinot-internode connections

mcvsubbu commented on pull request #6418: URL: https://github.com/apache/incubator-pinot/pull/6418#issuecomment-757074013 Can you add some comments in the checkin as to the tests you did? This is an automated message from the

[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6418: TLS-support for client-pinot and pinot-internode connections

mcvsubbu commented on a change in pull request #6418: URL: https://github.com/apache/incubator-pinot/pull/6418#discussion_r554246048 ## File path: pinot-core/src/main/java/org/apache/pinot/core/transport/TlsConfig.java ## @@ -0,0 +1,79 @@ +/** + * Licensed to the Apache Softwa

[GitHub] [incubator-pinot] fx19880617 commented on issue #6298: Support Describe Pinot table and schema

fx19880617 commented on issue #6298: URL: https://github.com/apache/incubator-pinot/issues/6298#issuecomment-757056076 > @fx19880617 Could you please review the above approach and let me know your thoughts. Thanks! Thanks! Will do! -

[GitHub] [incubator-pinot] codecov-io commented on pull request #6427: Update mysql version and fix thirdeye helm chart to work with current pinot version.

codecov-io commented on pull request #6427: URL: https://github.com/apache/incubator-pinot/pull/6427#issuecomment-757047829 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6427?src=pr&el=h1) Report > Merging [#6427](https://codecov.io/gh/apache/incubator-pinot/pull/6427?s

[GitHub] [incubator-pinot] jihaozh opened a new pull request #6428: [TE] suppress the anomaly if current value is NaN

jihaozh opened a new pull request #6428: URL: https://github.com/apache/incubator-pinot/pull/6428 This PR suppresses the anomaly if the current value is NaN. It will remove false alarms caused by such issue. This is an autom

[incubator-pinot] branch filter-nan-anomalies created (now efac5b4)

This is an automated email from the ASF dual-hosted git repository. jihao pushed a change to branch filter-nan-anomalies in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at efac5b4 [TE] suppress the anomaly if current value is NaN This branch includes the following

[incubator-pinot] 01/01: [TE] suppress the anomaly if current value is NaN

This is an automated email from the ASF dual-hosted git repository. jihao pushed a commit to branch filter-nan-anomalies in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit efac5b4a5f260bf63ecc85a04230d65f26c451d1 Author: Jihao Zhang AuthorDate: Fri Jan 8 14:37:38 2021 -

[GitHub] [incubator-pinot] thealmightygrant opened a new pull request #6427: Update mysql version and fix thirdeye helm chart to work with current pinot version.

thealmightygrant opened a new pull request #6427: URL: https://github.com/apache/incubator-pinot/pull/6427 ## Description The current implementation of thirdeye in `kubernetes/helm` does not work due to upstream changes. In particular, the logging setup changed and errors out immediatel

[GitHub] [incubator-pinot] jihaozh merged pull request #6421: [TE]frontend - Add support for Group Constituents and Entity Metric components

jihaozh merged pull request #6421: URL: https://github.com/apache/incubator-pinot/pull/6421 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6426: Fix gcs listFiles

Jackie-Jiang commented on a change in pull request #6426: URL: https://github.com/apache/incubator-pinot/pull/6426#discussion_r554173650 ## File path: pinot-plugins/pinot-file-system/pinot-gcs/src/main/java/org/apache/pinot/plugin/filesystem/GcsPinotFS.java ## @@ -204,7 +205,7

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #6425: Update groovy

Jackie-Jiang merged pull request #6425: URL: https://github.com/apache/incubator-pinot/pull/6425 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[incubator-pinot] branch master updated: Update groovy (#6425)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new a5c4ed2 Update groovy (#6425) a5c4ed2

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #6422: Allow segment generation with a bounded memory

Jackie-Jiang commented on issue #6422: URL: https://github.com/apache/incubator-pinot/issues/6422#issuecomment-756977627 I think you are referring to the hash-set for deduplicating the values? We also stores the values in an array for sorting purpose. We can use the off-heap data struct

[GitHub] [incubator-pinot] codecov-io commented on pull request #6423: Replace BrokerRequestOptimizer with QueryOptimizer to also optimize the PinotQuery

codecov-io commented on pull request #6423: URL: https://github.com/apache/incubator-pinot/pull/6423#issuecomment-756958910 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6423?src=pr&el=h1) Report > Merging [#6423](https://codecov.io/gh/apache/incubator-pinot/pull/6423?s

[incubator-pinot] branch master updated: Fix escape character in transform function literals (#6416)

This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new e018695 Fix escape character in transf

[GitHub] [incubator-pinot] Jackie-Jiang merged pull request #6416: Fix escape quotes in transform function literals

Jackie-Jiang merged pull request #6416: URL: https://github.com/apache/incubator-pinot/pull/6416 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [incubator-pinot] Jackie-Jiang closed issue #6412: Date formatting issue in WHERE clause

Jackie-Jiang closed issue #6412: URL: https://github.com/apache/incubator-pinot/issues/6412 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-pinot] ayushkul2910 commented on a change in pull request #6399: Added unit tests for pinot-controller classes

ayushkul2910 commented on a change in pull request #6399: URL: https://github.com/apache/incubator-pinot/pull/6399#discussion_r554137649 ## File path: pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceTagPoolSelectorTest.java ##

[GitHub] [incubator-pinot] ayushkul2910 commented on a change in pull request #6399: Added unit tests for pinot-controller classes

ayushkul2910 commented on a change in pull request #6399: URL: https://github.com/apache/incubator-pinot/pull/6399#discussion_r554137562 ## File path: pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceTagPoolSelectorTest.java ##

[incubator-pinot] branch master updated: [TE]frontend - Add support for Group Constituents and Entity Metric components (#6421)

This is an automated email from the ASF dual-hosted git repository. jihao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 3d4c98d [TE]frontend - Add support for

[GitHub] [incubator-pinot] tejasajmera commented on a change in pull request #6421: [TE]frontend - Add support for Group Constituents and Entity Metric components

tejasajmera commented on a change in pull request #6421: URL: https://github.com/apache/incubator-pinot/pull/6421#discussion_r554120212 ## File path: thirdeye/thirdeye-frontend/app/pods/components/composite-anomalies/entity-metrics-anomalies/template.hbs ## @@ -0,0 +1 @@ +{{co

[GitHub] [incubator-pinot] amarnathkarthik commented on issue #6298: Support Describe Pinot table and schema

amarnathkarthik commented on issue #6298: URL: https://github.com/apache/incubator-pinot/issues/6298#issuecomment-756919320 @fx19880617 Could you please review the above approach and let me know your thoughts. Thanks! This

[GitHub] [incubator-pinot] harleyjj commented on a change in pull request #6421: [TE]frontend - Add support for Group Constituents and Entity Metric components

harleyjj commented on a change in pull request #6421: URL: https://github.com/apache/incubator-pinot/pull/6421#discussion_r554070793 ## File path: thirdeye/thirdeye-frontend/app/pods/components/composite-anomalies/entity-metrics-anomalies/template.hbs ## @@ -0,0 +1 @@ +{{compo

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6399: Added unit tests for pinot-controller classes

codecov-io edited a comment on pull request #6399: URL: https://github.com/apache/incubator-pinot/pull/6399#issuecomment-753360784 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6399?src=pr&el=h1) Report > Merging [#6399](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6399: Added unit tests for pinot-controller classes

codecov-io edited a comment on pull request #6399: URL: https://github.com/apache/incubator-pinot/pull/6399#issuecomment-753360784 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6399?src=pr&el=h1) Report > Merging [#6399](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6399: Added unit tests for pinot-controller classes

codecov-io edited a comment on pull request #6399: URL: https://github.com/apache/incubator-pinot/pull/6399#issuecomment-753360784 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6399?src=pr&el=h1) Report > Merging [#6399](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6399: Added unit tests for pinot-controller classes

codecov-io edited a comment on pull request #6399: URL: https://github.com/apache/incubator-pinot/pull/6399#issuecomment-753360784 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6399?src=pr&el=h1) Report > Merging [#6399](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6426: Fix gcs listFiles

codecov-io edited a comment on pull request #6426: URL: https://github.com/apache/incubator-pinot/pull/6426#issuecomment-756705294 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6426?src=pr&el=h1) Report > Merging [#6426](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] codecov-io commented on pull request #6426: Fix gcs listFiles

codecov-io commented on pull request #6426: URL: https://github.com/apache/incubator-pinot/pull/6426#issuecomment-756705294 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6426?src=pr&el=h1) Report > Merging [#6426](https://codecov.io/gh/apache/incubator-pinot/pull/6426?s

[GitHub] [incubator-pinot] codecov-io commented on pull request #6425: Update groovy

codecov-io commented on pull request #6425: URL: https://github.com/apache/incubator-pinot/pull/6425#issuecomment-756682940 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6425?src=pr&el=h1) Report > Merging [#6425](https://codecov.io/gh/apache/incubator-pinot/pull/6425?s

[GitHub] [incubator-pinot] elonazoulay opened a new pull request #6426: Fix gcs listFiles

elonazoulay opened a new pull request #6426: URL: https://github.com/apache/incubator-pinot/pull/6426 ## Description Add a description of your PR here. A good description should include pointers to an issue or design document, etc. ## Upgrade Notes Does this PR prevent a zero do

[GitHub] [incubator-pinot] elonazoulay opened a new pull request #6425: Update groovy

elonazoulay opened a new pull request #6425: URL: https://github.com/apache/incubator-pinot/pull/6425 Fixes deadlock: https://issues.apache.org/jira/browse/GROOVY-8067 ## Description Add a description of your PR here. A good description should include pointers to an issue or des

[GitHub] [incubator-pinot] elonazoulay opened a new pull request #6424: Use java11

elonazoulay opened a new pull request #6424: URL: https://github.com/apache/incubator-pinot/pull/6424 ## Description Add a description of your PR here. A good description should include pointers to an issue or design document, etc. ## Upgrade Notes Does this PR prevent a zero do

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6418: TLS-support for client-pinot and pinot-internode connections

codecov-io edited a comment on pull request #6418: URL: https://github.com/apache/incubator-pinot/pull/6418#issuecomment-755917563 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6418?src=pr&el=h1) Report > Merging [#6418](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6418: TLS-support for client-pinot and pinot-internode connections

codecov-io edited a comment on pull request #6418: URL: https://github.com/apache/incubator-pinot/pull/6418#issuecomment-755917563 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6418?src=pr&el=h1) Report > Merging [#6418](https://codecov.io/gh/apache/incubator-pinot/pull