[GitHub] [incubator-pinot] npawar commented on a change in pull request #6336: Segment reset API

2020-12-29 Thread GitBox
npawar commented on a change in pull request #6336: URL: https://github.com/apache/incubator-pinot/pull/6336#discussion_r550008061 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java ## @@ -355,6 +355,67 @@ pu

[GitHub] [incubator-pinot] npawar commented on a change in pull request #6336: Segment reset API

2020-12-29 Thread GitBox
npawar commented on a change in pull request #6336: URL: https://github.com/apache/incubator-pinot/pull/6336#discussion_r550005832 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java ## @@ -355,6 +355,67 @@ pu

[GitHub] [incubator-pinot] amarnathkarthik commented on issue #6298: Support Describe Pinot table and schema

2020-12-29 Thread GitBox
amarnathkarthik commented on issue #6298: URL: https://github.com/apache/incubator-pinot/issues/6298#issuecomment-752363299 @fx19880617 Here is my initial analysis, correct me if I'm wrong. Calcite does not support `SHOW (databases | tables` kind of SQL, below are the available implemen

[GitHub] [incubator-pinot] codecov-io commented on pull request #6396: Adding ImportData sub command in pinot admin

2020-12-29 Thread GitBox
codecov-io commented on pull request #6396: URL: https://github.com/apache/incubator-pinot/pull/6396#issuecomment-752361098 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6396?src=pr&el=h1) Report > Merging [#6396](https://codecov.io/gh/apache/incubator-pinot/pull/6396?s

[incubator-pinot] branch adding_InsertData_sub_command updated (c3d16d1 -> 6905653)

2020-12-29 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch adding_InsertData_sub_command in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard c3d16d1 Adding ImportData sub command for pinot-admin add 6905653 Adding Impo

[incubator-pinot] branch adding_InsertData_sub_command updated (5985dc5 -> c3d16d1)

2020-12-29 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch adding_InsertData_sub_command in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 5985dc5 Adding InsertData sub command for pinot-admin add c3d16d1 Adding Impo

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #6396: Adding ImportData sub command in pinot admin

2020-12-29 Thread GitBox
fx19880617 opened a new pull request #6396: URL: https://github.com/apache/incubator-pinot/pull/6396 ## Description Adding a Pinot-Admin sub command: ImportData to help users import data into Pinot. Usage: ``` bin/pinot-admin.sh InsertData -dataFilePath /path/to/my-local-da

[incubator-pinot] 01/01: Adding InsertData sub command for pinot-admin

2020-12-29 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch adding_InsertData_sub_command in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 5985dc5c0eeaec0516cf8cd33b251c9617cd6540 Author: Xiang Fu AuthorDate: Tue Dec 29 16:21:

[incubator-pinot] branch adding_InsertData_sub_command created (now 5985dc5)

2020-12-29 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch adding_InsertData_sub_command in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 5985dc5 Adding InsertData sub command for pinot-admin This branch includes the fol

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #6336: Segment reset API

2020-12-29 Thread GitBox
kishoreg commented on a change in pull request #6336: URL: https://github.com/apache/incubator-pinot/pull/6336#discussion_r549953735 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java ## @@ -355,6 +355,67 @@

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6384: Make required interfaces or classes serializable for spark

2020-12-29 Thread GitBox
codecov-io edited a comment on pull request #6384: URL: https://github.com/apache/incubator-pinot/pull/6384#issuecomment-751206711 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6384?src=pr&el=h1) Report > Merging [#6384](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] jackjlli commented on pull request #6384: Make required interfaces or classes serializable for spark

2020-12-29 Thread GitBox
jackjlli commented on pull request #6384: URL: https://github.com/apache/incubator-pinot/pull/6384#issuecomment-752324033 > Thanks for making the changes! > > Is it possible to add a test to check if the given classes are Spark serializable? So we can ensure further changes won't bre

[incubator-pinot] branch make-objects-serializable updated (b3d225d -> 322676c)

2020-12-29 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch make-objects-serializable in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard b3d225d Make required interfaces or classes serializable for spark add 322676c Make

[incubator-pinot] branch h3-index updated (4259d1c -> 28f59ef)

2020-12-29 Thread kishoreg
This is an automated email from the ASF dual-hosted git repository. kishoreg pushed a change to branch h3-index in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 4259d1c revert changes on DataTypeTransformer add 28f59ef Added H3IndexFilterOperator (#6391) No

[GitHub] [incubator-pinot] kishoreg merged pull request #6391: Added H3IndexFilterOperator

2020-12-29 Thread GitBox
kishoreg merged pull request #6391: URL: https://github.com/apache/incubator-pinot/pull/6391 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6383: Introduce 'LOOKUP' Transform Function

2020-12-29 Thread GitBox
codecov-io edited a comment on pull request #6383: URL: https://github.com/apache/incubator-pinot/pull/6383#issuecomment-751136824 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6383?src=pr&el=h1) Report > Merging [#6383](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] cbalci commented on a change in pull request #6383: Introduce 'LOOKUP' Transform Function

2020-12-29 Thread GitBox
cbalci commented on a change in pull request #6383: URL: https://github.com/apache/incubator-pinot/pull/6383#discussion_r549913724 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/LookupTransformFunction.java ## @@ -0,0 +1,332 @@ +/** +

[GitHub] [incubator-pinot] cbalci commented on a change in pull request #6383: Introduce 'LOOKUP' Transform Function

2020-12-29 Thread GitBox
cbalci commented on a change in pull request #6383: URL: https://github.com/apache/incubator-pinot/pull/6383#discussion_r549913724 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/LookupTransformFunction.java ## @@ -0,0 +1,332 @@ +/** +

[GitHub] [incubator-pinot] cbalci commented on a change in pull request #6383: Introduce 'LOOKUP' Transform Function

2020-12-29 Thread GitBox
cbalci commented on a change in pull request #6383: URL: https://github.com/apache/incubator-pinot/pull/6383#discussion_r549912474 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/LookupTransformFunction.java ## @@ -0,0 +1,332 @@ +/** +

[GitHub] [incubator-pinot] fx19880617 merged pull request #6394: Fix remaining links to outdated helm chart repos.

2020-12-29 Thread GitBox
fx19880617 merged pull request #6394: URL: https://github.com/apache/incubator-pinot/pull/6394 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[incubator-pinot] branch master updated: Fix remaining links to outdated helm chart repos. (#6394)

2020-12-29 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 13bd443 Fix remaining links to outdat

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6383: Introduce 'LOOKUP' Transform Function

2020-12-29 Thread GitBox
codecov-io edited a comment on pull request #6383: URL: https://github.com/apache/incubator-pinot/pull/6383#issuecomment-751136824 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6383?src=pr&el=h1) Report > Merging [#6383](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6383: Introduce 'LOOKUP' Transform Function

2020-12-29 Thread GitBox
codecov-io edited a comment on pull request #6383: URL: https://github.com/apache/incubator-pinot/pull/6383#issuecomment-751136824 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6383?src=pr&el=h1) Report > Merging [#6383](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #6395: Make minion tasks pluggable via reflection

2020-12-29 Thread GitBox
Jackie-Jiang commented on pull request #6395: URL: https://github.com/apache/incubator-pinot/pull/6395#issuecomment-752282798 @snleee Please take a look and see if the interface change is okay for the LinkedIn internal tasks

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #6395: Make minion tasks pluggable via reflection

2020-12-29 Thread GitBox
Jackie-Jiang opened a new pull request #6395: URL: https://github.com/apache/incubator-pinot/pull/6395 ## Description Introduces 3 annotations to plugin minion components: - TaskGenerator: For task generators to be plugged on controller side - TaskExecutorFactory: For task executor

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6383: Introduce 'LOOKUP' Transform Function

2020-12-29 Thread GitBox
Jackie-Jiang commented on a change in pull request #6383: URL: https://github.com/apache/incubator-pinot/pull/6383#discussion_r549892297 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/LookupTransformFunction.java ## @@ -0,0 +1,332 @@ +

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6383: Introduce 'LOOKUP' Transform Function

2020-12-29 Thread GitBox
Jackie-Jiang commented on a change in pull request #6383: URL: https://github.com/apache/incubator-pinot/pull/6383#discussion_r549892016 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/LookupTransformFunction.java ## @@ -0,0 +1,332 @@ +

[GitHub] [incubator-pinot] cbalci commented on a change in pull request #6383: Introduce 'LOOKUP' Transform Function

2020-12-29 Thread GitBox
cbalci commented on a change in pull request #6383: URL: https://github.com/apache/incubator-pinot/pull/6383#discussion_r549888398 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/LookupTransformFunction.java ## @@ -0,0 +1,332 @@ +/** +

[GitHub] [incubator-pinot] cbalci commented on a change in pull request #6383: Introduce 'LOOKUP' Transform Function

2020-12-29 Thread GitBox
cbalci commented on a change in pull request #6383: URL: https://github.com/apache/incubator-pinot/pull/6383#discussion_r549888366 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/LookupTransformFunction.java ## @@ -0,0 +1,332 @@ +/** +

[GitHub] [incubator-pinot] cbalci commented on a change in pull request #6383: Introduce 'LOOKUP' Transform Function

2020-12-29 Thread GitBox
cbalci commented on a change in pull request #6383: URL: https://github.com/apache/incubator-pinot/pull/6383#discussion_r549888346 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/LookupTransformFunction.java ## @@ -0,0 +1,332 @@ +/** +

[GitHub] [incubator-pinot] cbalci commented on a change in pull request #6383: Introduce 'LOOKUP' Transform Function

2020-12-29 Thread GitBox
cbalci commented on a change in pull request #6383: URL: https://github.com/apache/incubator-pinot/pull/6383#discussion_r549888298 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java ## @@ -161,4 +168,8 @@ public Gen

[GitHub] [incubator-pinot] yupeng9 commented on pull request #6391: Added H3IndexFilterOperator

2020-12-29 Thread GitBox
yupeng9 commented on pull request #6391: URL: https://github.com/apache/incubator-pinot/pull/6391#issuecomment-752276590 @kishoreg comments addressed. PTAL This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6394: Fix remaining links to outdated helm chart repos.

2020-12-29 Thread GitBox
codecov-io edited a comment on pull request #6394: URL: https://github.com/apache/incubator-pinot/pull/6394#issuecomment-752247583 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6394?src=pr&el=h1) Report > Merging [#6394](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] codecov-io commented on pull request #6394: Fix remaining links to outdated helm chart repos.

2020-12-29 Thread GitBox
codecov-io commented on pull request #6394: URL: https://github.com/apache/incubator-pinot/pull/6394#issuecomment-752247583 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6394?src=pr&el=h1) Report > Merging [#6394](https://codecov.io/gh/apache/incubator-pinot/pull/6394?s

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6340: Adding Pinot minion segment generation and push task.

2020-12-29 Thread GitBox
codecov-io edited a comment on pull request #6340: URL: https://github.com/apache/incubator-pinot/pull/6340#issuecomment-741643136 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6340?src=pr&el=h1) Report > Merging [#6340](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] thealmightygrant opened a new pull request #6394: Fix remaining links to outdated helm chart repos.

2020-12-29 Thread GitBox
thealmightygrant opened a new pull request #6394: URL: https://github.com/apache/incubator-pinot/pull/6394 ## Description Related to #6381. I grepped through and fixed the rest of the repo to reference the new helm repo locations to match the locations in this [announcement](https://hel

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6340: Adding Pinot minion segment generation and push task.

2020-12-29 Thread GitBox
codecov-io edited a comment on pull request #6340: URL: https://github.com/apache/incubator-pinot/pull/6340#issuecomment-741643136 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6340?src=pr&el=h1) Report > Merging [#6340](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6383: Introduce 'LOOKUP' Transform Function

2020-12-29 Thread GitBox
Jackie-Jiang commented on a change in pull request #6383: URL: https://github.com/apache/incubator-pinot/pull/6383#discussion_r549831903 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java ## @@ -161,4 +168,8 @@ publ

[incubator-pinot] branch adding_pinot_minion_segment_creation_tasks_2 updated (9b3d2bf -> 3828dd5)

2020-12-29 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch adding_pinot_minion_segment_creation_tasks_2 in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 9b3d2bf Address comments add 3828dd5 Address comments This up

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6340: Adding Pinot minion segment generation and push task.

2020-12-29 Thread GitBox
codecov-io edited a comment on pull request #6340: URL: https://github.com/apache/incubator-pinot/pull/6340#issuecomment-741643136 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6340?src=pr&el=h1) Report > Merging [#6340](https://codecov.io/gh/apache/incubator-pinot/pull

[incubator-pinot] branch master updated: cleanup tar.gz segment files on job exit (#6385)

2020-12-29 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 6b43aef cleanup tar.gz segment files

[GitHub] [incubator-pinot] fx19880617 merged pull request #6385: cleanup tar.gz segment files on job exit

2020-12-29 Thread GitBox
fx19880617 merged pull request #6385: URL: https://github.com/apache/incubator-pinot/pull/6385 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[incubator-pinot] branch master updated: Update pinot realtime to match helm chart. (#6392)

2020-12-29 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new b936f90 Update pinot realtime to matc

[GitHub] [incubator-pinot] fx19880617 merged pull request #6392: Update k8s pinot realtime example to fix #2756 and match pinot versions

2020-12-29 Thread GitBox
fx19880617 merged pull request #6392: URL: https://github.com/apache/incubator-pinot/pull/6392 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #6393: ArrayIndexOutOfBoundsException from GroupByOrderByCombineOperator

2020-12-29 Thread GitBox
Jackie-Jiang commented on issue #6393: URL: https://github.com/apache/incubator-pinot/issues/6393#issuecomment-752219077 It might be related to the `\t` character within the string column. The [fix](https://github.com/apache/incubator-pinot/pull/5858) is included in the `0.6.0` release

[GitHub] [incubator-pinot] codecov-io edited a comment on pull request #6392: Update k8s pinot realtime example to fix #2756 and match pinot versions

2020-12-29 Thread GitBox
codecov-io edited a comment on pull request #6392: URL: https://github.com/apache/incubator-pinot/pull/6392#issuecomment-752194476 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6392?src=pr&el=h1) Report > Merging [#6392](https://codecov.io/gh/apache/incubator-pinot/pull

[GitHub] [incubator-pinot] chundongwang-css opened a new issue #6393: ArrayIndexOutOfBoundsException from GroupByOrderByCombineOperator

2020-12-29 Thread GitBox
chundongwang-css opened a new issue #6393: URL: https://github.com/apache/incubator-pinot/issues/6393 We're getting `QueryExecutionError:\njava.lang.ArrayIndexOutOfBoundsException` while executing below query: ```sql SELECT name as key_col, COUNT(*) as val_col FROM orders WHERE

[GitHub] [incubator-pinot] codecov-io commented on pull request #6392: Update k8s pinot realtime example to fix #2756 and match pinot versions

2020-12-29 Thread GitBox
codecov-io commented on pull request #6392: URL: https://github.com/apache/incubator-pinot/pull/6392#issuecomment-752194476 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6392?src=pr&el=h1) Report > Merging [#6392](https://codecov.io/gh/apache/incubator-pinot/pull/6392?s

[GitHub] [incubator-pinot] thealmightygrant opened a new pull request #6392: Update k8s pinot realtime example to fix #2756 and match pinot versions

2020-12-29 Thread GitBox
thealmightygrant opened a new pull request #6392: URL: https://github.com/apache/incubator-pinot/pull/6392 ## Description The quickstart had to be updated to work with [dateTimeFields](#2756) and to maintain the latest docker image (as is default for the helm chart). -

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6391: Added H3IndexFilterOperator

2020-12-29 Thread GitBox
yupeng9 commented on a change in pull request #6391: URL: https://github.com/apache/incubator-pinot/pull/6391#discussion_r549776108 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/filter/H3IndexFilterOperator.java ## @@ -69,30 +76,16 @@ public H3IndexFilt

[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #6391: Added H3IndexFilterOperator

2020-12-29 Thread GitBox
kishoreg commented on a change in pull request #6391: URL: https://github.com/apache/incubator-pinot/pull/6391#discussion_r549759907 ## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/filter/H3IndexFilterOperator.java ## @@ -69,30 +76,16 @@ public H3IndexFil