codecov-io edited a comment on pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#issuecomment-743002120
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6346?src=pr&el=h1)
Report
> Merging
[#6346](https://codecov.io/gh/apache/incubator-pinot/pull
codecov-io edited a comment on pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#issuecomment-743002120
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6346?src=pr&el=h1)
Report
> Merging
[#6346](https://codecov.io/gh/apache/incubator-pinot/pull
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch adding_pinot_minion_segment_creation_tasks_2
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
discard 4d7abbd Adding logic to infer recordreader classes from input format
cbalci commented on a change in pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#discussion_r544034995
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java
##
@@ -0,0 +1,160 @@
+/**
+ * Lic
cbalci commented on a change in pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#discussion_r544033062
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java
##
@@ -0,0 +1,160 @@
+/**
+ * Lic
fx19880617 commented on a change in pull request #6360:
URL: https://github.com/apache/incubator-pinot/pull/6360#discussion_r544025447
##
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/TableOp.java
##
@@ -92,4 +102,34 @@ boolean runOp() {
}
cbalci commented on a change in pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#discussion_r544021074
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java
##
@@ -0,0 +1,163 @@
+/**
+ * Lic
fx19880617 commented on a change in pull request #6352:
URL: https://github.com/apache/incubator-pinot/pull/6352#discussion_r543958481
##
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java
##
@@ -63,99 +65,147 @@ publi
fx19880617 edited a comment on pull request #6359:
URL: https://github.com/apache/incubator-pinot/pull/6359#issuecomment-745750374
Thanks!
Can you also add a test for
`SegmentGenerationUtils.getRelativeOutputPath(...)` with the example you have.
So we can ensure this works for your use
codecov-io edited a comment on pull request #6354:
URL: https://github.com/apache/incubator-pinot/pull/6354#issuecomment-745041431
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6354?src=pr&el=h1)
Report
> Merging
[#6354](https://codecov.io/gh/apache/incubator-pinot/pull
codecov-io edited a comment on pull request #6354:
URL: https://github.com/apache/incubator-pinot/pull/6354#issuecomment-745041431
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6354?src=pr&el=h1)
Report
> Merging
[#6354](https://codecov.io/gh/apache/incubator-pinot/pull
fx19880617 commented on pull request #6359:
URL: https://github.com/apache/incubator-pinot/pull/6359#issuecomment-745750374
Thanks!
Can you also add a test for
`SegmentGenerationUtils.getRelativeOutputPath(...)` with the example you have.
So we can ensure this works for your use case.
codecov-io commented on pull request #6361:
URL: https://github.com/apache/incubator-pinot/pull/6361#issuecomment-745732477
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6361?src=pr&el=h1)
Report
> Merging
[#6361](https://codecov.io/gh/apache/incubator-pinot/pull/6361?s
JoeFuentes-WebDev commented on a change in pull request #6345:
URL: https://github.com/apache/incubator-pinot/pull/6345#discussion_r543820504
##
File path:
thirdeye/thirdeye-frontend/app/pods/components/composite-anomalies/parent-anomalies/component.js
##
@@ -0,0 +1,120 @@
+/*
JoeFuentes-WebDev commented on a change in pull request #6345:
URL: https://github.com/apache/incubator-pinot/pull/6345#discussion_r543820092
##
File path:
thirdeye/thirdeye-frontend/app/pods/components/composite-anomalies/parent-anomalies/component.js
##
@@ -0,0 +1,120 @@
+/*
JoeFuentes-WebDev commented on a change in pull request #6345:
URL: https://github.com/apache/incubator-pinot/pull/6345#discussion_r543814566
##
File path:
thirdeye/thirdeye-frontend/app/pods/components/composite-anomalies/parent-anomalies/component.js
##
@@ -0,0 +1,120 @@
+/*
JoeFuentes-WebDev commented on a change in pull request #6345:
URL: https://github.com/apache/incubator-pinot/pull/6345#discussion_r543814342
##
File path:
thirdeye/thirdeye-frontend/app/pods/components/composite-anomalies/parent-anomalies/component.js
##
@@ -0,0 +1,120 @@
+/*
JoeFuentes-WebDev commented on a change in pull request #6345:
URL: https://github.com/apache/incubator-pinot/pull/6345#discussion_r543814056
##
File path:
thirdeye/thirdeye-frontend/app/styles/pods/custom/parent-anomalies-table.scss
##
@@ -0,0 +1,20 @@
+.parent-anomalies-tabl
JoeFuentes-WebDev commented on a change in pull request #6345:
URL: https://github.com/apache/incubator-pinot/pull/6345#discussion_r543813896
##
File path:
thirdeye/thirdeye-frontend/app/pods/components/composite-anomalies/parent-anomalies/component.js
##
@@ -0,0 +1,120 @@
+/*
JoeFuentes-WebDev commented on a change in pull request #6345:
URL: https://github.com/apache/incubator-pinot/pull/6345#discussion_r543813391
##
File path:
thirdeye/thirdeye-frontend/app/pods/components/composite-anomalies/parent-anomalies/component.js
##
@@ -0,0 +1,120 @@
+/*
codecov-io edited a comment on pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#issuecomment-743002120
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6346?src=pr&el=h1)
Report
> Merging
[#6346](https://codecov.io/gh/apache/incubator-pinot/pull
codecov-io edited a comment on pull request #6359:
URL: https://github.com/apache/incubator-pinot/pull/6359#issuecomment-745700173
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6359?src=pr&el=h1)
Report
> Merging
[#6359](https://codecov.io/gh/apache/incubator-pinot/pull
jackjlli opened a new pull request #6361:
URL: https://github.com/apache/incubator-pinot/pull/6361
## Description
This PR adds the logic of detecting invalid column names from query in Pinot
server.
Since query context is already generated in pinot server, we don't need to
parse an
codecov-io commented on pull request #6359:
URL: https://github.com/apache/incubator-pinot/pull/6359#issuecomment-745700173
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6359?src=pr&el=h1)
Report
> Merging
[#6359](https://codecov.io/gh/apache/incubator-pinot/pull/6359?s
codecov-io edited a comment on pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#issuecomment-743002120
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6346?src=pr&el=h1)
Report
> Merging
[#6346](https://codecov.io/gh/apache/incubator-pinot/pull
codecov-io edited a comment on pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#issuecomment-743002120
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6346?src=pr&el=h1)
Report
> Merging
[#6346](https://codecov.io/gh/apache/incubator-pinot/pull
Jackie-Jiang commented on a change in pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#discussion_r543800298
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java
##
@@ -0,0 +1,160 @@
+/**
+
Jackie-Jiang commented on a change in pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#discussion_r543798682
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java
##
@@ -0,0 +1,163 @@
+/**
+
Jackie-Jiang commented on a change in pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#discussion_r543798021
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java
##
@@ -0,0 +1,160 @@
+/**
+
cbalci commented on a change in pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#discussion_r543796794
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java
##
@@ -0,0 +1,160 @@
+/**
+ * Lic
jtao15 opened a new pull request #6360:
URL: https://github.com/apache/incubator-pinot/pull/6360
Issue: #4854
Related pr: #6129
Add/delete table operations for compatibility test.
This is an automated message from the
cbalci commented on a change in pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#discussion_r543792267
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/TableDataManagerProvider.java
##
@@ -53,6 +53,11 @@ public stati
cbalci commented on a change in pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#discussion_r543792223
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java
##
@@ -0,0 +1,163 @@
+/**
+ * Lic
cbalci commented on a change in pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#discussion_r543792128
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java
##
@@ -0,0 +1,163 @@
+/**
+ * Lic
kkrugler opened a new pull request #6359:
URL: https://github.com/apache/incubator-pinot/pull/6359
## Description
Fix for issue #6355.
Support for `inputDirURI` in job file that uses authority (HDFS namenode,
for example).
Tried it out with my use case and it fixed the prob
zhangloo333 commented on a change in pull request #6358:
URL: https://github.com/apache/incubator-pinot/pull/6358#discussion_r543784646
##
File path: thirdeye/thirdeye-frontend/app/utils/pub-sub.js
##
@@ -0,0 +1,72 @@
+/** A very lightweight pub-sub implementation to communicat
codecov-io edited a comment on pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#issuecomment-743002120
#
[Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6346?src=pr&el=h1)
Report
> Merging
[#6346](https://codecov.io/gh/apache/incubator-pinot/pull
cbalci commented on a change in pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#discussion_r543770167
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java
##
@@ -0,0 +1,160 @@
+/**
+ * Lic
yupeng9 commented on a change in pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#discussion_r543778830
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java
##
@@ -0,0 +1,163 @@
+/**
+ * Li
zhangloo333 commented on a change in pull request #6345:
URL: https://github.com/apache/incubator-pinot/pull/6345#discussion_r543776067
##
File path:
thirdeye/thirdeye-frontend/app/pods/components/composite-anomalies/parent-anomalies/component.js
##
@@ -0,0 +1,120 @@
+/*
+ * P
tejasajmera opened a new pull request #6358:
URL: https://github.com/apache/incubator-pinot/pull/6358
**Rationale**
The ember-model-table does not work well with callback functions to invoke
in a parent hosting component when there are interactions in a table. In order
to bridge this, w
This is an automated email from the ASF dual-hosted git repository.
jihao pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
from 9644350 add redis module dependency (#6357)
add 946ff55 [TE] fix javassist version (#6356)
No new rev
jihaozh merged pull request #6356:
URL: https://github.com/apache/incubator-pinot/pull/6356
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
cbalci commented on a change in pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#discussion_r543771591
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java
##
@@ -0,0 +1,160 @@
+/**
+ * Lic
cbalci commented on a change in pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#discussion_r543771269
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java
##
@@ -0,0 +1,160 @@
+/**
+ * Lic
cbalci commented on a change in pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#discussion_r543770827
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java
##
@@ -0,0 +1,160 @@
+/**
+ * Lic
cbalci commented on a change in pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#discussion_r543770718
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java
##
@@ -0,0 +1,160 @@
+/**
+ * Lic
cbalci commented on a change in pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#discussion_r543770638
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java
##
@@ -0,0 +1,160 @@
+/**
+ * Lic
cbalci commented on a change in pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#discussion_r543770578
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java
##
@@ -0,0 +1,160 @@
+/**
+ * Lic
cbalci commented on a change in pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#discussion_r543770437
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java
##
@@ -0,0 +1,160 @@
+/**
+ * Lic
cbalci commented on a change in pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#discussion_r543770340
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java
##
@@ -0,0 +1,160 @@
+/**
+ * Lic
cbalci commented on a change in pull request #6346:
URL: https://github.com/apache/incubator-pinot/pull/6346#discussion_r543770167
##
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/offline/DimensionTableDataManager.java
##
@@ -0,0 +1,160 @@
+/**
+ * Lic
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 9644350 add redis module dependency (
fx19880617 merged pull request #6357:
URL: https://github.com/apache/incubator-pinot/pull/6357
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
apucher opened a new pull request #6357:
URL: https://github.com/apache/incubator-pinot/pull/6357
## Description
add redis module dependency to docker build script to un-break container
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order:
Contr
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a change to branch docker-superset-redis-fix-20201215
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at 271b165 add redis module dependency
This branch includes the following new
This is an automated email from the ASF dual-hosted git repository.
apucher pushed a commit to branch docker-superset-redis-fix-20201215
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit 271b165ec0788a4ce7ef46b01962f4da25f8f9ab
Author: Alexander Pucher
AuthorDate: Tue
vincentchenjl opened a new pull request #6356:
URL: https://github.com/apache/incubator-pinot/pull/6356
This PR is to fix javassist version for Java 11 JRE
This is an automated message from the Apache Git Service.
To respond
JoeFuentes-WebDev commented on a change in pull request #6345:
URL: https://github.com/apache/incubator-pinot/pull/6345#discussion_r543596445
##
File path:
thirdeye/thirdeye-frontend/app/pods/custom/composite-animalies-table/resolution/component.js
##
@@ -0,0 +1,18 @@
+import
JoeFuentes-WebDev commented on a change in pull request #6345:
URL: https://github.com/apache/incubator-pinot/pull/6345#discussion_r543593257
##
File path:
thirdeye/thirdeye-frontend/app/pods/custom/composite-animalies-table/resolution/component.js
##
@@ -0,0 +1,18 @@
+import
JoeFuentes-WebDev commented on a change in pull request #6345:
URL: https://github.com/apache/incubator-pinot/pull/6345#discussion_r543593257
##
File path:
thirdeye/thirdeye-frontend/app/pods/custom/composite-animalies-table/resolution/component.js
##
@@ -0,0 +1,18 @@
+import
JoeFuentes-WebDev commented on a change in pull request #6345:
URL: https://github.com/apache/incubator-pinot/pull/6345#discussion_r543593257
##
File path:
thirdeye/thirdeye-frontend/app/pods/custom/composite-animalies-table/resolution/component.js
##
@@ -0,0 +1,18 @@
+import
JoeFuentes-WebDev commented on a change in pull request #6345:
URL: https://github.com/apache/incubator-pinot/pull/6345#discussion_r543532934
##
File path:
thirdeye/thirdeye-frontend/app/pods/components/composite-anomalies/parent-anomalies/component.js
##
@@ -0,0 +1,120 @@
+/*
JoeFuentes-WebDev commented on a change in pull request #6345:
URL: https://github.com/apache/incubator-pinot/pull/6345#discussion_r543532934
##
File path:
thirdeye/thirdeye-frontend/app/pods/components/composite-anomalies/parent-anomalies/component.js
##
@@ -0,0 +1,120 @@
+/*
64 matches
Mail list logo
