[GitHub] [incubator-pinot] danbosnichill commented on pull request #5476: Improve error message on NPE related to typo in star schema column names

2020-10-02 Thread GitBox
danbosnichill commented on pull request #5476: URL: https://github.com/apache/incubator-pinot/pull/5476#issuecomment-703051117 Sorry, I took too long to get back to this. The code has changed a bit. I'll delete this. This

[GitHub] [incubator-pinot] danbosnichill closed pull request #5476: Improve error message on NPE related to typo in star schema column names

2020-10-02 Thread GitBox
danbosnichill closed pull request #5476: URL: https://github.com/apache/incubator-pinot/pull/5476 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [incubator-pinot] yupeng9 opened a new pull request #6102: Add the primary key reading from the GenericRow

2020-10-02 Thread GitBox
yupeng9 opened a new pull request #6102: URL: https://github.com/apache/incubator-pinot/pull/6102 ## Description Part of a series of PRs for #4261 Check this [doc](https://docs.google.com/document/d/1qljEMndPMxbbKtjlVn9mn2toz7Qrk0TGQsHLfI--7h8/edit#heading=h.lsfmyoyyxtgt) out for the

[GitHub] [incubator-pinot] harleyjj opened a new pull request #6101: [TE] web-api - endpoint for getting performance metrics of detection …

2020-10-02 Thread GitBox
harleyjj opened a new pull request #6101: URL: https://github.com/apache/incubator-pinot/pull/6101 …over time range ## Description Given a detection id, start time, and end time, this endpoint provides the user with various performance metrics based on the labels of anomalies ava

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6096: add upsert related configs

2020-10-02 Thread GitBox
yupeng9 commented on a change in pull request #6096: URL: https://github.com/apache/incubator-pinot/pull/6096#discussion_r499107830 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/config/table/TableConfig.java ## @@ -265,4 +266,9 @@ public void setIngestionConfig(In

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6096: add upsert related configs

2020-10-02 Thread GitBox
yupeng9 commented on a change in pull request #6096: URL: https://github.com/apache/incubator-pinot/pull/6096#discussion_r499107805 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertConfig.java ## @@ -27,44 +27,22 @@ public class UpsertConfig e

[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6096: add upsert related configs

2020-10-02 Thread GitBox
yupeng9 commented on a change in pull request #6096: URL: https://github.com/apache/incubator-pinot/pull/6096#discussion_r499107725 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java ## @@ -66,6 +66,9 @@ private TimeFieldSpec _timeFieldSpec; priva

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6096: add upsert related configs

2020-10-02 Thread GitBox
Jackie-Jiang commented on a change in pull request #6096: URL: https://github.com/apache/incubator-pinot/pull/6096#discussion_r499105212 ## File path: pinot-spi/src/main/java/org/apache/pinot/spi/config/table/UpsertConfig.java ## @@ -27,44 +27,22 @@ public class UpsertCon

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #6020: Add Caching in Controller Broker API

2020-10-02 Thread GitBox
Jackie-Jiang commented on a change in pull request #6020: URL: https://github.com/apache/incubator-pinot/pull/6020#discussion_r499103367 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/listener/ClusterInstanceConfigChangeListener.java ## @@

[GitHub] [incubator-pinot] Jackie-Jiang opened a new pull request #6100: Allow modifying/removing existing star-trees during segment reload

2020-10-02 Thread GitBox
Jackie-Jiang opened a new pull request #6100: URL: https://github.com/apache/incubator-pinot/pull/6100 ## Description For #6092 Currently we allow generating new star-trees during the segment reload when there is no existing ones. This PR adds the support of modifying or removing

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #6092: Regenerate star-tree index when the index config is changed on reloads

2020-10-02 Thread GitBox
Jackie-Jiang commented on issue #6092: URL: https://github.com/apache/incubator-pinot/issues/6092#issuecomment-703022706 Allow modifying/removing existing star-trees during segment reload: #6100 This is an automated message

[GitHub] [incubator-pinot] yupeng9 commented on issue #5807: Proposal: Deprecate PQL

2020-10-02 Thread GitBox
yupeng9 commented on issue #5807: URL: https://github.com/apache/incubator-pinot/issues/5807#issuecomment-703010708 At Uber, we use Presto/Pinot connector and we plan to migrate to the SQL-based connector by the end of 2020. +1 to using SQL onward.

[GitHub] [incubator-pinot] icefury71 commented on issue #6099: Make controller API consistent

2020-10-02 Thread GitBox
icefury71 commented on issue #6099: URL: https://github.com/apache/incubator-pinot/issues/6099#issuecomment-703006917 Good point. Yes we should probably continue such safeguards but try to make other things as consistent as possible. On Fri, Oct 2, 2020 at 4:43 PM Subbu Subramania

[GitHub] [incubator-pinot] mcvsubbu commented on issue #6099: Make controller API consistent

2020-10-02 Thread GitBox
mcvsubbu commented on issue #6099: URL: https://github.com/apache/incubator-pinot/issues/6099#issuecomment-703002912 A word of caution on this. For table deletion, we specifically added table type sometime back (not sure if it is still there), preventing the operator from deleting realtim

[GitHub] [incubator-pinot] icefury71 opened a new issue #6099: Make controller API consistent

2020-10-02 Thread GitBox
icefury71 opened a new issue #6099: URL: https://github.com/apache/incubator-pinot/issues/6099 There are a few class of issues with the API today * Config Field name (eg: tablename inside table config sometimes has type - sometimes not) * get and put json payloads: json retrieved from

[GitHub] [incubator-pinot] dongxiaoman opened a new issue #6098: Need "realtimeRowsConsumed" metric for Low Level Consumer too

2020-10-02 Thread GitBox
dongxiaoman opened a new issue #6098: URL: https://github.com/apache/incubator-pinot/issues/6098 Currently we are not seeing an aggregated per-host `realtimeRowsConsumed` metric when using LLC. That metric is useful because currently per-partition-per-table metric is too much detail meant

[incubator-pinot] branch master updated (267abef -> 1126cac)

2020-10-02 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 267abef [TE] Refactor. ThirdEye Principal should be immutable. (#6085) add 1126cac [TE] move dashboard

[GitHub] [incubator-pinot] jihaozh merged pull request #6058: [TE] move dashboard resources for refactoring

2020-10-02 Thread GitBox
jihaozh merged pull request #6058: URL: https://github.com/apache/incubator-pinot/pull/6058 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-pinot] mayankshriv commented on issue #5807: Proposal: Deprecate PQL

2020-10-02 Thread GitBox
mayankshriv commented on issue #5807: URL: https://github.com/apache/incubator-pinot/issues/5807#issuecomment-702984608 Just wanted to update this thread to state that we (LinkedIn) are targeting to migrate our users from PQL to SQL by Dec 2020, after which we would be ready to start depr

[GitHub] [incubator-pinot] vincentchenjl closed pull request #6091: [TE] enable verbose in maven and skip publishing thirdeye-dist (#6090)

2020-10-02 Thread GitBox
vincentchenjl closed pull request #6091: URL: https://github.com/apache/incubator-pinot/pull/6091 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [incubator-pinot] vincentchenjl opened a new pull request #6097: Fix Thirdeye Maven publish

2020-10-02 Thread GitBox
vincentchenjl opened a new pull request #6097: URL: https://github.com/apache/incubator-pinot/pull/6097 This PR is to fix issue of not publishing thirdeye-dashboard. This is an automated message from the Apache Git Service.

[GitHub] [incubator-pinot] yupeng9 opened a new pull request #6096: add upsert related configs

2020-10-02 Thread GitBox
yupeng9 opened a new pull request #6096: URL: https://github.com/apache/incubator-pinot/pull/6096 ## Description Part of a series of PRs for https://github.com/apache/incubator-pinot/issues/4261 Check this [doc](https://docs.google.com/document/d/1qljEMndPMxbbKtjlVn9mn2toz7Qrk0TG

[incubator-pinot] branch master updated: [TE] Refactor. ThirdEye Principal should be immutable. (#6085)

2020-10-02 Thread apucher
This is an automated email from the ASF dual-hosted git repository. apucher pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 267abef [TE] Refactor. ThirdEye Princ

[GitHub] [incubator-pinot] apucher merged pull request #6085: [TE] Refactor. ThirdEyePrincipal should be immutable

2020-10-02 Thread GitBox
apucher merged pull request #6085: URL: https://github.com/apache/incubator-pinot/pull/6085 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-pinot] KKcorps commented on pull request #6020: Add Caching in Controller Broker API

2020-10-02 Thread GitBox
KKcorps commented on pull request #6020: URL: https://github.com/apache/incubator-pinot/pull/6020#issuecomment-702888304 @mcvsubbu The issue is the changes are needed for new /Brokers api. The plan is to call the API to fetch the brokers for a tenant from JDBC driver. The current impleme

[GitHub] [incubator-pinot] Jackie-Jiang opened a new issue #6095: Add documentation for configuring partition for a table

2020-10-02 Thread GitBox
Jackie-Jiang opened a new issue #6095: URL: https://github.com/apache/incubator-pinot/issues/6095 For offline/realtime/hybrid table This is an automated message from the Apache Git Service. To respond to the message, please l

[incubator-pinot] branch master updated: Adding more table config validation (#6073)

2020-10-02 Thread nehapawar
This is an automated email from the ASF dual-hosted git repository. nehapawar pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 9929dad Adding more table config va

[GitHub] [incubator-pinot] npawar merged pull request #6073: Adding more table config validation

2020-10-02 Thread GitBox
npawar merged pull request #6073: URL: https://github.com/apache/incubator-pinot/pull/6073 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6020: Add Caching in Controller Broker API

2020-10-02 Thread GitBox
KKcorps commented on a change in pull request #6020: URL: https://github.com/apache/incubator-pinot/pull/6020#discussion_r498706060 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/listener/ClusterInstanceConfigChangeListener.java ## @@ -0,0

[GitHub] [incubator-pinot] KKcorps commented on a change in pull request #6020: Add Caching in Controller Broker API

2020-10-02 Thread GitBox
KKcorps commented on a change in pull request #6020: URL: https://github.com/apache/incubator-pinot/pull/6020#discussion_r498650655 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/listener/ClusterInstanceConfigChangeListener.java ## @@ -0,0