[GitHub] [incubator-pinot] npawar commented on a change in pull request #5718: Feature/#5390 segment indexing reload status api

2020-07-25 Thread GitBox
npawar commented on a change in pull request #5718: URL: https://github.com/apache/incubator-pinot/pull/5718#discussion_r460472217 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java ## @@ -485,4 +493,91 @@ pr

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5746: Fix code to correctly extract value of multi-value column from avro file

2020-07-25 Thread GitBox
Jackie-Jiang commented on a change in pull request #5746: URL: https://github.com/apache/incubator-pinot/pull/5746#discussion_r460436632 ## File path: pinot-core/src/main/java/org/apache/pinot/core/data/recordtransformer/PinotDataType.java ## @@ -632,4 +721,22 @@ public static

[GitHub] [incubator-pinot] kishoreg merged pull request #5755: Pradeep/s3 credential chain fix

2020-07-25 Thread GitBox
kishoreg merged pull request #5755: URL: https://github.com/apache/incubator-pinot/pull/5755 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-pinot] branch master updated: Pradeep/s3 credential chain fix (#5755)

2020-07-25 Thread kishoreg
This is an automated email from the ASF dual-hosted git repository. kishoreg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new d437487 Pradeep/s3 credential chain

[GitHub] [incubator-pinot] fx19880617 merged pull request #5734: Adding column name rewrite for the identifiers in the format of [table].[column]

2020-07-25 Thread GitBox
fx19880617 merged pull request #5734: URL: https://github.com/apache/incubator-pinot/pull/5734 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[incubator-pinot] branch master updated: Adding column name rewrite for the identifiers in the format of [table_name].[column_name] (#5734)

2020-07-25 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 9f22322 Adding column name rewrite fo

[GitHub] [incubator-pinot] fx19880617 closed issue #5716: Disallow dot in table name and column name.

2020-07-25 Thread GitBox
fx19880617 closed issue #5716: URL: https://github.com/apache/incubator-pinot/issues/5716 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-pinot] kishoreg commented on issue #5751: Support Serving Latest Offline Segments Immediately

2020-07-25 Thread GitBox
kishoreg commented on issue #5751: URL: https://github.com/apache/incubator-pinot/issues/5751#issuecomment-663887163 the latest day will clearly not work unless there is one segment for that day and it is too limiting. The use case I am thinking is the same one listed here. If we a

[GitHub] [incubator-pinot] elonazoulay commented on a change in pull request #5717: Add streaming query handler

2020-07-25 Thread GitBox
elonazoulay commented on a change in pull request #5717: URL: https://github.com/apache/incubator-pinot/pull/5717#discussion_r460430593 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/grpc/PinotQueryHandler.java ## @@ -18,18 +18,258 @@ */ package or

[GitHub] [incubator-pinot] elonazoulay commented on a change in pull request #5717: Add streaming query handler

2020-07-25 Thread GitBox
elonazoulay commented on a change in pull request #5717: URL: https://github.com/apache/incubator-pinot/pull/5717#discussion_r460430544 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/grpc/PinotQueryHandler.java ## @@ -18,18 +18,258 @@ */ package or

[GitHub] [incubator-pinot] elonazoulay commented on a change in pull request #5717: Add streaming query handler

2020-07-25 Thread GitBox
elonazoulay commented on a change in pull request #5717: URL: https://github.com/apache/incubator-pinot/pull/5717#discussion_r460429801 ## File path: pinot-server/src/main/java/org/apache/pinot/server/starter/grpc/PinotQueryService.java ## @@ -18,6 +18,57 @@ */ package org.

[GitHub] [incubator-pinot] mcvsubbu commented on issue #5751: Support Serving Latest Offline Segments Immediately

2020-07-25 Thread GitBox
mcvsubbu commented on issue #5751: URL: https://github.com/apache/incubator-pinot/issues/5751#issuecomment-663884345 @kishoreg I didn't follow. We don't store the time boundary now. Why do we need to keep it in ZK? Perhaps you are trying to support an arbitrary time boundary that a user

[GitHub] [incubator-pinot] kishoreg commented on issue #5751: Support Serving Latest Offline Segments Immediately

2020-07-25 Thread GitBox
kishoreg commented on issue #5751: URL: https://github.com/apache/incubator-pinot/issues/5751#issuecomment-663883596 @mcvsubbu the time boundary should be saved somewhere in ZK so that all brokers use it and it handles all the failure and restarts scenarios. The user still has to wa

[GitHub] [incubator-pinot] kishoreg closed issue #5450: Clear results from Pinot Data Explorer

2020-07-25 Thread GitBox
kishoreg closed issue #5450: URL: https://github.com/apache/incubator-pinot/issues/5450 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-pinot] kishoreg commented on issue #5450: Clear results from Pinot Data Explorer

2020-07-25 Thread GitBox
kishoreg commented on issue #5450: URL: https://github.com/apache/incubator-pinot/issues/5450#issuecomment-663882527 This is fixed in the new query console This is an automated message from the Apache Git Service. To respond

[incubator-pinot] branch master updated (dc01cc8 -> 8474f7e)

2020-07-25 Thread kishoreg
This is an automated email from the ASF dual-hosted git repository. kishoreg pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from dc01cc8 Fixing the case of Orc and Json record reader class name (#5754) add 8474f7e Cluster Mange

[GitHub] [incubator-pinot] kishoreg merged pull request #5757: Cluster Manger UI: adding instance details page showing instance config and tables in that particular instance

2020-07-25 Thread GitBox
kishoreg merged pull request #5757: URL: https://github.com/apache/incubator-pinot/pull/5757 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] kishoreg commented on pull request #5757: Cluster Manger UI: adding instance details page showing instance config and tables in that particular instance

2020-07-25 Thread GitBox
kishoreg commented on pull request #5757: URL: https://github.com/apache/incubator-pinot/pull/5757#issuecomment-663871263 Tested it and it looks good. Thanks @shahsank3t This is an automated message from the Apache Git Servi

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #5726: Adding Test coverage to NoOpPinotCrypt class

2020-07-25 Thread GitBox
mayankshriv commented on a change in pull request #5726: URL: https://github.com/apache/incubator-pinot/pull/5726#discussion_r460409411 ## File path: pinot-spi/src/test/java/org/apache/pinot/spi/crypt/NoOpPinotCryptTest.java ## @@ -0,0 +1,66 @@ +/** + * Licensed to the Apache

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #5728: Add segment lineage based segment selector

2020-07-25 Thread GitBox
mayankshriv commented on a change in pull request #5728: URL: https://github.com/apache/incubator-pinot/pull/5728#discussion_r460408329 ## File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/segmentselector/OfflineSegmentSelector.java ## @@ -30,10 +30,17 @@

[GitHub] [incubator-pinot] fx19880617 commented on pull request #5734: Adding column name rewrite for the identifiers in the format of [table].[column]

2020-07-25 Thread GitBox
fx19880617 commented on pull request #5734: URL: https://github.com/apache/incubator-pinot/pull/5734#issuecomment-663843810 @mayankshriv Any more comments here? The extra overhead for existing queries is the string split on dot for table and column names. -

[incubator-pinot] branch master updated (540853d -> dc01cc8)

2020-07-25 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 540853d Improvements to RealtimeProvisioningHelper command (#5737) add dc01cc8 Fixing the case of Or

[GitHub] [incubator-pinot] fx19880617 merged pull request #5754: Fixing the case of Orc and Json record reader class name

2020-07-25 Thread GitBox
fx19880617 merged pull request #5754: URL: https://github.com/apache/incubator-pinot/pull/5754 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov