[GitHub] [incubator-pinot] siddharthteotia opened a new pull request #5422: Complex FieldSpec

2020-05-20 Thread GitBox
siddharthteotia opened a new pull request #5422: URL: https://github.com/apache/incubator-pinot/pull/5422 Support for complex field spec This is an automated message from the Apache Git Service. To respond to the message, ple

[incubator-pinot] 02/02: add top n support for scv and sql data source

2020-05-20 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a commit to branch pushdown_topk_filter in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 5c802425d8abfa064c4c0557f214d5dce05466a9 Author: Xiaohui Sun AuthorDate: Mon May 11 16:10:50 2020

[incubator-pinot] branch pushdown_topk_filter created (now 5c80242)

2020-05-20 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a change to branch pushdown_topk_filter in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at 5c80242 add top n support for scv and sql data source This branch includes the following new

[incubator-pinot] 01/02: [TE] Push down top k filter to data provider

2020-05-20 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a commit to branch pushdown_topk_filter in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit 91205ed8e341907b89a63a98f52d2d025b1d77c6 Author: Xiaohui Sun AuthorDate: Wed May 6 14:03:55 2020 -

[GitHub] [incubator-pinot] snleee merged pull request #5410: Fix flaky test for InterSegmentResultTableMultiValueQueriesTest

2020-05-20 Thread GitBox
snleee merged pull request #5410: URL: https://github.com/apache/incubator-pinot/pull/5410 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-pinot] branch master updated: Fix flaky test for InterSegmentResultTableMultiValueQueriesTest (#5410)

2020-05-20 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 70e8383 Fix flaky test for InterSegmen

[GitHub] [incubator-pinot] snleee commented on pull request #5410: Fix flaky test for InterSegmentResultTableMultiValueQueriesTest

2020-05-20 Thread GitBox
snleee commented on pull request #5410: URL: https://github.com/apache/incubator-pinot/pull/5410#issuecomment-631863120 @mcvsubbu @mayankshriv Can you review this again? I have added the filter so now the result is truly deterministic. -

[GitHub] [incubator-pinot] snleee merged pull request #5419: Use thread local for groupby raw key holders

2020-05-20 Thread GitBox
snleee merged pull request #5419: URL: https://github.com/apache/incubator-pinot/pull/5419 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-pinot] branch master updated: Use thread local for groupby raw key holders (#5419)

2020-05-20 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new a3ebd0c Use thread local for groupby ra

[incubator-pinot] branch thread_local_hashmap updated (3698af0 -> 9584e4c)

2020-05-20 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch thread_local_hashmap in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 3698af0 Adding more optimization for map initial size and discard size discard 1655c27 Use

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #5398: [TE] Added generic support for configuring Data Quality rules like SLA from Yaml

2020-05-20 Thread GitBox
xiaohui-sun commented on a change in pull request #5398: URL: https://github.com/apache/incubator-pinot/pull/5398#discussion_r428409078 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/dataquality/components/DataSlaQualityChecker.java ##

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #5398: [TE] Added generic support for configuring Data Quality rules like SLA from Yaml

2020-05-20 Thread GitBox
xiaohui-sun commented on a change in pull request #5398: URL: https://github.com/apache/incubator-pinot/pull/5398#discussion_r428408973 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/anomaly/detection/trigger/DataAvailabilityTaskScheduler.java ##

[GitHub] [incubator-pinot] xiaohui-sun merged pull request #5418: [TE] frontend - harleyjj/packages - pin compatible package versions

2020-05-20 Thread GitBox
xiaohui-sun merged pull request #5418: URL: https://github.com/apache/incubator-pinot/pull/5418 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[incubator-pinot] branch master updated (4f01114 -> 6a2881a)

2020-05-20 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 4f01114 Set hashmap initial size to 16 in DictionaryBasedGroupKeyGenerator. (#5421) add 6a2881a [TE]

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #5398: [TE] Added generic support for configuring Data Quality rules like SLA from Yaml

2020-05-20 Thread GitBox
jihaozh commented on a change in pull request #5398: URL: https://github.com/apache/incubator-pinot/pull/5398#discussion_r428391511 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/scheduler/DetectionCronScheduler.java ## @@ -79,28 +81,45 @@ public

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #5398: [TE] Added generic support for configuring Data Quality rules like SLA from Yaml

2020-05-20 Thread GitBox
jihaozh commented on a change in pull request #5398: URL: https://github.com/apache/incubator-pinot/pull/5398#discussion_r428388089 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/wrapper/DataQualityMergeWrapper.java ## @@ -0,0 +1,99 @@

[incubator-pinot] branch master updated: Set hashmap initial size to 16 in DictionaryBasedGroupKeyGenerator. (#5421)

2020-05-20 Thread mcvsubbu
This is an automated email from the ASF dual-hosted git repository. mcvsubbu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 4f01114 Set hashmap initial size to

[GitHub] [incubator-pinot] mcvsubbu merged pull request #5421: Set hashmap initial size to 16 in DictionaryBasedGroupKeyGenerator.

2020-05-20 Thread GitBox
mcvsubbu merged pull request #5421: URL: https://github.com/apache/incubator-pinot/pull/5421 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] mcvsubbu commented on pull request #5421: Set hashmap initial size to 16 in DictionaryBasedGroupKeyGenerator.

2020-05-20 Thread GitBox
mcvsubbu commented on pull request #5421: URL: https://github.com/apache/incubator-pinot/pull/5421#issuecomment-631805706 This is an intermediate step towards resolving performance problems due to PR #5291 . A final version of the fix is coming up in PR #5419

[GitHub] [incubator-pinot] fx19880617 opened a new pull request #5421: Set hashmap initial size to 16 in DictionaryBasedGroupKeyGenerator.

2020-05-20 Thread GitBox
fx19880617 opened a new pull request #5421: URL: https://github.com/apache/incubator-pinot/pull/5421 This will make behavior same as before PR https://github.com/apache/incubator-pinot/pull/5291 got merged. This is an automa

[GitHub] [incubator-pinot] akshayrai edited a comment on pull request #5398: [TE] Added generic support for configuring Data Quality rules like SLA from Yaml

2020-05-20 Thread GitBox
akshayrai edited a comment on pull request #5398: URL: https://github.com/apache/incubator-pinot/pull/5398#issuecomment-631661326 > Can we treat the quality rule the same as other rules? Then we can remove the sub level for "quality". @akshayrai @xiaohui-sun since the detection pipel

[incubator-pinot] 01/01: Set hashmap initial size to 16 in DictionaryBasedGroupKeyGenerator.

2020-05-20 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch set_group_by_hash_size in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit b7c6695e7a7d30ad389bdef71855366bd1820295 Author: Xiang Fu AuthorDate: Wed May 20 17:16:53 2020

[incubator-pinot] branch set_group_by_hash_size created (now b7c6695)

2020-05-20 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch set_group_by_hash_size in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at b7c6695 Set hashmap initial size to 16 in DictionaryBasedGroupKeyGenerator. This branch

[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #5398: [TE] Added generic support for configuring Data Quality rules like SLA from Yaml

2020-05-20 Thread GitBox
akshayrai commented on a change in pull request #5398: URL: https://github.com/apache/incubator-pinot/pull/5398#discussion_r428376797 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/dataquality/spec/DataSlaQualityCheckerSpec.java ## @@ -

[GitHub] [incubator-pinot] akshayrai edited a comment on pull request #5398: [TE] Added generic support for configuring Data Quality rules like SLA from Yaml

2020-05-20 Thread GitBox
akshayrai edited a comment on pull request #5398: URL: https://github.com/apache/incubator-pinot/pull/5398#issuecomment-631661326 > Can we treat the quality rule the same as other rules? Then we can remove the sub level for "quality". @akshayrai @xiaohui-sun since the detection pipel

[GitHub] [incubator-pinot] snleee closed pull request #3260: Adding an exception to server response when there are missing segments

2020-05-20 Thread GitBox
snleee closed pull request #3260: URL: https://github.com/apache/incubator-pinot/pull/3260 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-pinot] snleee closed pull request #3034: Adding "segment.merge.cover" field to segment metadata

2020-05-20 Thread GitBox
snleee closed pull request #3034: URL: https://github.com/apache/incubator-pinot/pull/3034 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-pinot] snleee closed pull request #4729: Adding logs for "waitForAllDocsLoaded"

2020-05-20 Thread GitBox
snleee closed pull request #4729: URL: https://github.com/apache/incubator-pinot/pull/4729 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-pinot] kishoreg closed pull request #3728: Support for specifying Object Type in Schema

2020-05-20 Thread GitBox
kishoreg closed pull request #3728: URL: https://github.com/apache/incubator-pinot/pull/3728 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] kishoreg closed pull request #2581: Waiting for IS=CS and IS=EV check to pass before marking the server r…

2020-05-20 Thread GitBox
kishoreg closed pull request #2581: URL: https://github.com/apache/incubator-pinot/pull/2581 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] kishoreg closed pull request #2703: Adding DateTime UDF (leverages existing datetimeconvert udf). This wi…

2020-05-20 Thread GitBox
kishoreg closed pull request #2703: URL: https://github.com/apache/incubator-pinot/pull/2703 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-pinot] kishoreg closed pull request #3723: Remove auto-gen class files that were checked-in

2020-05-20 Thread GitBox
kishoreg closed pull request #3723: URL: https://github.com/apache/incubator-pinot/pull/3723 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-pinot] branch thread_local_hashmap updated (3b96ab5 -> 3698af0)

2020-05-20 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch thread_local_hashmap in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 3b96ab5 Adding a threshold to not reuse threadlocal for small groups add 3698af0 Addin

[GitHub] [incubator-pinot] harleyjj commented on a change in pull request #5282: [TE] ELR migration for Thirdeye

2020-05-20 Thread GitBox
harleyjj commented on a change in pull request #5282: URL: https://github.com/apache/incubator-pinot/pull/5282#discussion_r428334462 ## File path: thirdeye/thirdeye-frontend/package.json ## @@ -88,7 +87,7 @@ "toastr": "^2.1.4" }, "engines": { -"node": "10.*" +

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #5413: [TE] alerts search and pagination endpoint

2020-05-20 Thread GitBox
xiaohui-sun commented on a change in pull request #5413: URL: https://github.com/apache/incubator-pinot/pull/5413#discussion_r428311536 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/util/SqlQueryBuilder.java ## @@ -338,6 +338,46 @@ pub

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #5413: [TE] alerts search and pagination endpoint

2020-05-20 Thread GitBox
jihaozh commented on a change in pull request #5413: URL: https://github.com/apache/incubator-pinot/pull/5413#discussion_r428310843 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/util/SqlQueryBuilder.java ## @@ -338,6 +338,46 @@ public

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #5413: [TE] alerts search and pagination endpoint

2020-05-20 Thread GitBox
jihaozh commented on a change in pull request #5413: URL: https://github.com/apache/incubator-pinot/pull/5413#discussion_r428288130 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/util/SqlQueryBuilder.java ## @@ -338,6 +338,46 @@ public

[incubator-pinot] branch master updated: [TE] fix an issue that in some cases the evaluations are not generated (#5420)

2020-05-20 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 0459b98 [TE] fix an issue that in some

[GitHub] [incubator-pinot] xiaohui-sun merged pull request #5420: [TE] fix an issue that in some cases the evaluations are not generated

2020-05-20 Thread GitBox
xiaohui-sun merged pull request #5420: URL: https://github.com/apache/incubator-pinot/pull/5420 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #5413: [TE] alerts search and pagination endpoint

2020-05-20 Thread GitBox
xiaohui-sun commented on a change in pull request #5413: URL: https://github.com/apache/incubator-pinot/pull/5413#discussion_r428294317 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/util/SqlQueryBuilder.java ## @@ -338,6 +338,46 @@ pub

[GitHub] [incubator-pinot] jihaozh opened a new pull request #5420: [TE] fix an issue that in some cases the evaluations are not generated

2020-05-20 Thread GitBox
jihaozh opened a new pull request #5420: URL: https://github.com/apache/incubator-pinot/pull/5420 Previously, for the detections w/o dimension exploration, the detection evaluations won't be generated. This PR fixes the issue. --

[incubator-pinot] branch evaluation-urns-fix created (now b91bcc4)

2020-05-20 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a change to branch evaluation-urns-fix in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. at b91bcc4 [TE] fix an issue that in some cases the evaluations are not generated This branch in

[incubator-pinot] 01/01: [TE] fix an issue that in some cases the evaluations are not generated

2020-05-20 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a commit to branch evaluation-urns-fix in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git commit b91bcc41f4b20d67bacbd9f790616b3de1f29b87 Author: Jihao Zhang AuthorDate: Tue May 19 15:49:15 2020 -

[incubator-pinot] branch master updated: [TE] alerts search and pagination endpoint (#5413)

2020-05-20 Thread jihao
This is an automated email from the ASF dual-hosted git repository. jihao pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 775d578 [TE] alerts search and paginati

[GitHub] [incubator-pinot] jihaozh merged pull request #5413: [TE] alerts search and pagination endpoint

2020-05-20 Thread GitBox
jihaozh merged pull request #5413: URL: https://github.com/apache/incubator-pinot/pull/5413 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-pinot] jihaozh commented on a change in pull request #5413: [TE] alerts search and pagination endpoint

2020-05-20 Thread GitBox
jihaozh commented on a change in pull request #5413: URL: https://github.com/apache/incubator-pinot/pull/5413#discussion_r428288130 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/util/SqlQueryBuilder.java ## @@ -338,6 +338,46 @@ public

[GitHub] [incubator-pinot] kishoreg commented on pull request #5266: Add PinotServiceManager to start Pinot components

2020-05-20 Thread GitBox
kishoreg commented on pull request #5266: URL: https://github.com/apache/incubator-pinot/pull/5266#issuecomment-631702902 can we list the commands needed to start Pinot after this gets in? This is an automated messag

[GitHub] [incubator-pinot] akshayrai commented on pull request #5398: [TE] Added generic support for configuring Data Quality rules like SLA from Yaml

2020-05-20 Thread GitBox
akshayrai commented on pull request #5398: URL: https://github.com/apache/incubator-pinot/pull/5398#issuecomment-631661326 > Can we treat the quality rule the same as other rules? Then we can remove the sub level for "quality". @akshayrai @xiaohui-sun since the detection pipeline and

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5419: [WIP]Use thread local for groupby raw key holders

2020-05-20 Thread GitBox
fx19880617 commented on a change in pull request #5419: URL: https://github.com/apache/incubator-pinot/pull/5419#discussion_r428222776 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java ## @@ -106,18 +10

[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #5419: [WIP]Use thread local for groupby raw key holders

2020-05-20 Thread GitBox
fx19880617 commented on a change in pull request #5419: URL: https://github.com/apache/incubator-pinot/pull/5419#discussion_r428220074 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java ## @@ -106,18 +10

[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #5419: [WIP]Use thread local for groupby raw key holders

2020-05-20 Thread GitBox
mayankshriv commented on a change in pull request #5419: URL: https://github.com/apache/incubator-pinot/pull/5419#discussion_r428218159 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java ## @@ -106,18 +1

[incubator-pinot] branch thread_local_hashmap updated (1655c27 -> 3b96ab5)

2020-05-20 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch thread_local_hashmap in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. from 1655c27 Use thread local for groupby raw key holders add 3b96ab5 Adding a threshold to

[GitHub] [incubator-pinot] vincentchenjl commented on a change in pull request #5413: [TE] alerts search and pagination endpoint

2020-05-20 Thread GitBox
vincentchenjl commented on a change in pull request #5413: URL: https://github.com/apache/incubator-pinot/pull/5413#discussion_r427693528 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/util/SqlQueryBuilder.java ## @@ -338,6 +338,46 @@ p

[GitHub] [incubator-pinot] vincentchenjl commented on a change in pull request #5282: [TE] ELR migration for Thirdeye

2020-05-20 Thread GitBox
vincentchenjl commented on a change in pull request #5282: URL: https://github.com/apache/incubator-pinot/pull/5282#discussion_r428204554 ## File path: thirdeye/thirdeye-frontend/package.json ## @@ -88,7 +87,7 @@ "toastr": "^2.1.4" }, "engines": { -"node": "10.*"

[GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5419: [WIP]Use thread local for groupby raw key holders

2020-05-20 Thread GitBox
Jackie-Jiang commented on a change in pull request #5419: URL: https://github.com/apache/incubator-pinot/pull/5419#discussion_r428187692 ## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/groupby/DictionaryBasedGroupKeyGenerator.java ## @@ -106,18 +

[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #5398: [TE] Added generic support for configuring Data Quality rules like SLA from Yaml

2020-05-20 Thread GitBox
xiaohui-sun commented on a change in pull request #5398: URL: https://github.com/apache/incubator-pinot/pull/5398#discussion_r427627733 ## File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/dataquality/DataQualityPipelineJob.java ## @@ -26,14

[incubator-pinot] branch thread_local_hashmap updated (646b149 -> 1655c27)

2020-05-20 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch thread_local_hashmap in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 646b149 Use thread local for groupby raw key holders add 1655c27 Use thread local for

[incubator-pinot] branch thread_local_hashmap updated (d0c29a0 -> 646b149)

2020-05-20 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch thread_local_hashmap in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard d0c29a0 Use thread local for groupby raw key holders add 646b149 Use thread local for

[incubator-pinot] branch thread_local_hashmap updated (0b2fd80 -> d0c29a0)

2020-05-20 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch thread_local_hashmap in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git. discard 0b2fd80 Use thread local for groupby raw key holders add d0c29a0 Use thread local for