[incubator-pinot] branch master updated: [TE] fix mock data source (#4189)

2019-05-07 Thread xhsun
This is an automated email from the ASF dual-hosted git repository. xhsun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 0706138 [TE] fix mock data source (#418

[GitHub] [incubator-pinot] xiaohui-sun merged pull request #4189: [TE] fix mock data source

2019-05-07 Thread GitBox
xiaohui-sun merged pull request #4189: [TE] fix mock data source URL: https://github.com/apache/incubator-pinot/pull/4189 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [incubator-pinot] jihaozh opened a new pull request #4190: [TE] pass predicted time series thought out the detection pipeline

2019-05-07 Thread GitBox
jihaozh opened a new pull request #4190: [TE] pass predicted time series thought out the detection pipeline URL: https://github.com/apache/incubator-pinot/pull/4190 We've changed the detector interface to pass predicted time series from detector to detection pipeline. This PR updates each

[GitHub] [incubator-pinot] xiaohui-sun opened a new pull request #4189: [TE] fix mock data source

2019-05-07 Thread GitBox
xiaohui-sun opened a new pull request #4189: [TE] fix mock data source URL: https://github.com/apache/incubator-pinot/pull/4189 Need to put mock data as first since there are assumptions that the metric ids in mock data source starts from 1.

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster

2019-05-07 Thread GitBox
jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r281861466 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java #

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster

2019-05-07 Thread GitBox
jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r281861431 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetupUti

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster

2019-05-07 Thread GitBox
jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r281861366 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetupUti

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster

2019-05-07 Thread GitBox
jackjlli commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r281861301 ## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetupUti

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4187: Issue with ingestion data with empty array

2019-05-07 Thread GitBox
Jackie-Jiang commented on issue #4187: Issue with ingestion data with empty array URL: https://github.com/apache/incubator-pinot/issues/4187#issuecomment-490278882 @jamesyfshao That is a good suggestion, but will also change the existing behavior which might affect other users. One reason

[incubator-pinot] branch master updated: Migration to log4j2 (#4139)

2019-05-07 Thread snlee
This is an automated email from the ASF dual-hosted git repository. snlee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git The following commit(s) were added to refs/heads/master by this push: new 84a34a2 Migration to log4j2 (#4139) 84a

[GitHub] [incubator-pinot] snleee merged pull request #4139: Migration to log4j2

2019-05-07 Thread GitBox
snleee merged pull request #4139: Migration to log4j2 URL: https://github.com/apache/incubator-pinot/pull/4139 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4187: Issue with ingestion data with empty array

2019-05-07 Thread GitBox
Jackie-Jiang commented on issue #4187: Issue with ingestion data with empty array URL: https://github.com/apache/incubator-pinot/issues/4187#issuecomment-490275191 @jamesyfshao Seems the default value behavior is not documented (was documented before, but might be lost while migrating to

[GitHub] [incubator-pinot] jamesyfshao commented on issue #4187: Issue with ingestion data with empty array

2019-05-07 Thread GitBox
jamesyfshao commented on issue #4187: Issue with ingestion data with empty array URL: https://github.com/apache/incubator-pinot/issues/4187#issuecomment-490276305 If that is the case, maybe we can look into extending the behavior of pinot indexing so we use single default value for empty a

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4139: Migration to log4j2

2019-05-07 Thread GitBox
snleee commented on a change in pull request #4139: Migration to log4j2 URL: https://github.com/apache/incubator-pinot/pull/4139#discussion_r281811063 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ZkStarter.java ## @@ -52,6 +52,10 @@ private Zookee

[GitHub] [incubator-pinot] Jackie-Jiang opened a new issue #4188: Document the default value behavior

2019-05-07 Thread GitBox
Jackie-Jiang opened a new issue #4188: Document the default value behavior URL: https://github.com/apache/incubator-pinot/issues/4188 For both single-value and multi-value column, add documentation for default values. Also, record reader need to fill in default values while decoding the da

[GitHub] [incubator-pinot] jamesyfshao commented on issue #4187: Issue with ingestion data with empty array

2019-05-07 Thread GitBox
jamesyfshao commented on issue #4187: Issue with ingestion data with empty array URL: https://github.com/apache/incubator-pinot/issues/4187#issuecomment-490269527 Yes, we have our own reader for decoding data. This seems to undocumented, could we explain a bit why empty array is not suppor

[GitHub] [incubator-pinot] Jackie-Jiang commented on issue #4187: Issue with ingestion data with empty array

2019-05-07 Thread GitBox
Jackie-Jiang commented on issue #4187: Issue with ingestion data with empty array URL: https://github.com/apache/incubator-pinot/issues/4187#issuecomment-490265976 @jamesyfshao Are you using custom record reader? Pinot does not support empty array as input, and record reader should alread

[GitHub] [incubator-pinot] jamesyfshao commented on issue #4187: Issue with ingestion data with empty array

2019-05-07 Thread GitBox
jamesyfshao commented on issue #4187: Issue with ingestion data with empty array URL: https://github.com/apache/incubator-pinot/issues/4187#issuecomment-490242923 @Jackie-Jiang as he is origin author of the previous diff and might have more context. ---

[GitHub] [incubator-pinot] jamesyfshao opened a new issue #4187: Issue with ingestion data with empty array

2019-05-07 Thread GitBox
jamesyfshao opened a new issue #4187: Issue with ingestion data with empty array URL: https://github.com/apache/incubator-pinot/issues/4187 In a recent [change](https://github.com/apache/incubator-pinot/commit/5c296de1c4b91d4cc3b99ee6ccf15c077f9b4dcc) to pinot ingestion workflow, we refact

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4139: Migration to log4j2

2019-05-07 Thread GitBox
snleee commented on a change in pull request #4139: Migration to log4j2 URL: https://github.com/apache/incubator-pinot/pull/4139#discussion_r281811063 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ZkStarter.java ## @@ -52,6 +52,10 @@ private Zookee

[GitHub] [incubator-pinot] snleee commented on a change in pull request #4139: Migration to log4j2

2019-05-07 Thread GitBox
snleee commented on a change in pull request #4139: Migration to log4j2 URL: https://github.com/apache/incubator-pinot/pull/4139#discussion_r281809811 ## File path: pinot-core/src/test/resources/log4j2.xml ## @@ -0,0 +1,15 @@ + + Review comment: We ignore license chec

[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #4139: Migration to log4j2

2019-05-07 Thread GitBox
sunithabeeram commented on a change in pull request #4139: Migration to log4j2 URL: https://github.com/apache/incubator-pinot/pull/4139#discussion_r281797765 ## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/ZkStarter.java ## @@ -52,6 +52,10 @@ private

[GitHub] [incubator-pinot] sunithabeeram commented on a change in pull request #4139: Migration to log4j2

2019-05-07 Thread GitBox
sunithabeeram commented on a change in pull request #4139: Migration to log4j2 URL: https://github.com/apache/incubator-pinot/pull/4139#discussion_r281799222 ## File path: pinot-core/src/test/resources/log4j2.xml ## @@ -0,0 +1,15 @@ + + Review comment: Does this need

[GitHub] [incubator-pinot] snleee commented on issue #4139: Migration to log4j2

2019-05-07 Thread GitBox
snleee commented on issue #4139: Migration to log4j2 URL: https://github.com/apache/incubator-pinot/pull/4139#issuecomment-490218901 For internal high qps use case, we see the following performance bump 1 broker, 1 server dataset: 84GB testing qps: 1000k with log4j 99.

[GitHub] [incubator-pinot] pooja2702 closed issue #4134: Error while trying to run quick-start-offline on windows

2019-05-07 Thread GitBox
pooja2702 closed issue #4134: Error while trying to run quick-start-offline on windows URL: https://github.com/apache/incubator-pinot/issues/4134 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [incubator-pinot] pooja2702 commented on issue #4134: Error while trying to run quick-start-offline on windows

2019-05-07 Thread GitBox
pooja2702 commented on issue #4134: Error while trying to run quick-start-offline on windows URL: https://github.com/apache/incubator-pinot/issues/4134#issuecomment-490058110 Yes, I go around it by changing the line to : URI uri = Paths.get(path).toUri(); Works for Windows and sh