The Buildbot has detected a new failure on builder
ofbiz-trunk-framework-plugins while building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/856
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reas
Author: mbrohl
Date: Tue Dec 12 06:26:29 2017
New Revision: 1817883
URL: http://svn.apache.org/viewvc?rev=1817883&view=rev
Log:
Improved: General refactoring and code improvements, package
org.apache.ofbiz.base.component.
(OFBIZ-9872)
Thanks Dennis Balkir for reporting and providing the patches.
Author: mbrohl
Date: Tue Dec 12 06:24:37 2017
New Revision: 1817882
URL: http://svn.apache.org/viewvc?rev=1817882&view=rev
Log:
Reverted: General refactoring and code improvements, package
org.apache.ofbiz.base.component.
(OFBIZ-9872)
The patches were modified to remove Debug.is[Loglevel]On()
co
Modified:
ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceWorker.java
URL:
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceWorker.java?rev=1817881
Author: mbrohl
Date: Tue Dec 12 06:18:38 2017
New Revision: 1817881
URL: http://svn.apache.org/viewvc?rev=1817881&view=rev
Log:
Improved: General refactoring and code improvements, package
org.apache.ofbiz.accounting.invoice.
(OFBIZ-9870)
Thanks Dennis Balkir for reporting and providing the patc
Modified:
ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceServices.java
URL:
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceServices.java?rev=18
Author: mbrohl
Date: Tue Dec 12 06:03:56 2017
New Revision: 1817880
URL: http://svn.apache.org/viewvc?rev=1817880&view=rev
Log:
Reverted: General refactoring and code improvements, package
org.apache.ofbiz.accounting.invoice.
(OFBIZ-9870)
The patches were modified to remove Debug.is[Loglevel]On(
Modified:
ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceWorker.java
URL:
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceWorker.java?rev=1817880
Modified:
ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceServices.java
URL:
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceServices.java?rev=18
The Buildbot has detected a restored build on builder ofbiz-trunk-framework
while building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk-framework/builds/827
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBr
The Buildbot has detected a new failure on builder ofbiz-trunk-framework while
building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk-framework/builds/826
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: lares_ubuntu
Build Reason: The AnyBranchSc
Author: jleroux
Date: Mon Dec 11 18:06:40 2017
New Revision: 1817803
URL: http://svn.apache.org/viewvc?rev=1817803&view=rev
Log:
No functional change, damned hard day reviewing, these formattings I wanted to
keep
Modified:
ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apac
Michael,
In this commit I see some changes for fields from protected to public. I understand the idea and I agree, but I wonder if we should really make all
fields public when some could be private.
For instance see colAlias, and for the rest should we not rather create and use
getters (and p
The Buildbot has detected a restored build on builder
ofbiz-trunk-framework-plugins while building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/852
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build R
Author: jleroux
Date: Mon Dec 11 17:35:42 2017
New Revision: 1817799
URL: http://svn.apache.org/viewvc?rev=1817799&view=rev
Log:
Removes some formatting which were also automated (w/o my consent, I must have
missed it at some point :/)
Modified:
ofbiz/ofbiz-framework/trunk/framework/entity/s
Author: jleroux
Date: Mon Dec 11 17:33:27 2017
New Revision: 1817798
URL: http://svn.apache.org/viewvc?rev=1817798&view=rev
Log:
No functional change, redo some formatting by hand to make code more legible
They obviously have been done with automated formatting (big formatted block).
Someone shoul
Author: jleroux
Date: Mon Dec 11 15:53:35 2017
New Revision: 1817790
URL: http://svn.apache.org/viewvc?rev=1817790&view=rev
Log:
No functional change, formatting
Modified:
ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/category/CatalogUrlFilter.java
The Buildbot has detected a new failure on builder
ofbiz-trunk-framework-plugins while building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/846
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: lares_ubuntu
Build Reason:
Le 11/12/2017 à 09:31, Jacques Le Roux a écrit :
Why all these changes in JavaDoc? Is that related with EOLs? If so then something is wrong because I set the SVN repo to handle that automatically
at http://markmail.org/message/gzghk44kyz646e4d. Maybe you and/or Dennis are not using a svn >= 1.8 c
Hi Michael,
I'm not sure about all the other commits for "General refactoring and code
improvements" (subtasks of OFBIZ-9836)
But here I found a lot of unnecessary changes and this makes things a bit
harder to review.
Why all these changes in JavaDoc? Is that related with EOLs? If so then som
Author: nmalin
Date: Mon Dec 11 08:23:25 2017
New Revision: 1817752
URL: http://svn.apache.org/viewvc?rev=1817752&view=rev
Log:
Fixed: Add missing default-entity-name on create and delete definition service
for CarrierShipmentMethod entity introduce at r1787822
Related to Convert ShipmentMethodTy
Author: mbrohl
Date: Mon Dec 11 08:10:16 2017
New Revision: 1817751
URL: http://svn.apache.org/viewvc?rev=1817751&view=rev
Log:
Improved: General refactoring and code improvements, package
org.apache.ofbiz.common.authentication.
(OFBIZ-9875)
Thanks Julian Leichert for reporting and providing the
The Buildbot has detected a restored build on builder
ofbiz-trunk-framework-plugins while building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/847
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build R
23 matches
Mail list logo