buildbot failure in on ofbiz-trunk-framework-plugins

2017-12-11 Thread buildbot
The Buildbot has detected a new failure on builder ofbiz-trunk-framework-plugins while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/856 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reas

svn commit: r1817883 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java

2017-12-11 Thread mbrohl
Author: mbrohl Date: Tue Dec 12 06:26:29 2017 New Revision: 1817883 URL: http://svn.apache.org/viewvc?rev=1817883&view=rev Log: Improved: General refactoring and code improvements, package org.apache.ofbiz.base.component. (OFBIZ-9872) Thanks Dennis Balkir for reporting and providing the patches.

svn commit: r1817882 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java

2017-12-11 Thread mbrohl
Author: mbrohl Date: Tue Dec 12 06:24:37 2017 New Revision: 1817882 URL: http://svn.apache.org/viewvc?rev=1817882&view=rev Log: Reverted: General refactoring and code improvements, package org.apache.ofbiz.base.component. (OFBIZ-9872) The patches were modified to remove Debug.is[Loglevel]On() co

svn commit: r1817881 [3/3] - in /ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice: InvoiceServices.java InvoiceWorker.java

2017-12-11 Thread mbrohl
Modified: ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceWorker.java URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceWorker.java?rev=1817881

svn commit: r1817881 [1/3] - in /ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice: InvoiceServices.java InvoiceWorker.java

2017-12-11 Thread mbrohl
Author: mbrohl Date: Tue Dec 12 06:18:38 2017 New Revision: 1817881 URL: http://svn.apache.org/viewvc?rev=1817881&view=rev Log: Improved: General refactoring and code improvements, package org.apache.ofbiz.accounting.invoice. (OFBIZ-9870) Thanks Dennis Balkir for reporting and providing the patc

svn commit: r1817881 [2/3] - in /ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice: InvoiceServices.java InvoiceWorker.java

2017-12-11 Thread mbrohl
Modified: ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceServices.java URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceServices.java?rev=18

svn commit: r1817880 [1/3] - in /ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice: InvoiceServices.java InvoiceWorker.java

2017-12-11 Thread mbrohl
Author: mbrohl Date: Tue Dec 12 06:03:56 2017 New Revision: 1817880 URL: http://svn.apache.org/viewvc?rev=1817880&view=rev Log: Reverted: General refactoring and code improvements, package org.apache.ofbiz.accounting.invoice. (OFBIZ-9870) The patches were modified to remove Debug.is[Loglevel]On(

svn commit: r1817880 [3/3] - in /ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice: InvoiceServices.java InvoiceWorker.java

2017-12-11 Thread mbrohl
Modified: ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceWorker.java URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceWorker.java?rev=1817880

svn commit: r1817880 [2/3] - in /ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice: InvoiceServices.java InvoiceWorker.java

2017-12-11 Thread mbrohl
Modified: ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceServices.java URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceServices.java?rev=18

buildbot success in on ofbiz-trunk-framework

2017-12-11 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-trunk-framework while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk-framework/builds/827 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBr

buildbot failure in on ofbiz-trunk-framework

2017-12-11 Thread buildbot
The Buildbot has detected a new failure on builder ofbiz-trunk-framework while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk-framework/builds/826 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: lares_ubuntu Build Reason: The AnyBranchSc

svn commit: r1817803 - /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/model/ModelReader.java

2017-12-11 Thread jleroux
Author: jleroux Date: Mon Dec 11 18:06:40 2017 New Revision: 1817803 URL: http://svn.apache.org/viewvc?rev=1817803&view=rev Log: No functional change, damned hard day reviewing, these formattings I wanted to keep Modified: ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apac

Re: svn commit: r1817559 [2/2] - /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbi z/entity/model/

2017-12-11 Thread Jacques Le Roux
Michael, In this commit I see some changes for fields from protected to public. I understand the idea and I agree, but I wonder if we should really make all fields public when some could be private. For instance see colAlias, and for the rest should we not rather create and use getters (and p

buildbot success in on ofbiz-trunk-framework-plugins

2017-12-11 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-trunk-framework-plugins while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/852 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build R

svn commit: r1817799 - /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/model/ModelReader.java

2017-12-11 Thread jleroux
Author: jleroux Date: Mon Dec 11 17:35:42 2017 New Revision: 1817799 URL: http://svn.apache.org/viewvc?rev=1817799&view=rev Log: Removes some formatting which were also automated (w/o my consent, I must have missed it at some point :/) Modified: ofbiz/ofbiz-framework/trunk/framework/entity/s

svn commit: r1817798 - /ofbiz/ofbiz-framework/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/model/ModelReader.java

2017-12-11 Thread jleroux
Author: jleroux Date: Mon Dec 11 17:33:27 2017 New Revision: 1817798 URL: http://svn.apache.org/viewvc?rev=1817798&view=rev Log: No functional change, redo some formatting by hand to make code more legible They obviously have been done with automated formatting (big formatted block). Someone shoul

svn commit: r1817790 - /ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/category/CatalogUrlFilter.java

2017-12-11 Thread jleroux
Author: jleroux Date: Mon Dec 11 15:53:35 2017 New Revision: 1817790 URL: http://svn.apache.org/viewvc?rev=1817790&view=rev Log: No functional change, formatting Modified: ofbiz/ofbiz-framework/trunk/applications/product/src/main/java/org/apache/ofbiz/product/category/CatalogUrlFilter.java

buildbot failure in on ofbiz-trunk-framework-plugins

2017-12-11 Thread buildbot
The Buildbot has detected a new failure on builder ofbiz-trunk-framework-plugins while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/846 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: lares_ubuntu Build Reason:

Re: svn commit: r1817750 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/ base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java

2017-12-11 Thread Jacques Le Roux
Le 11/12/2017 à 09:31, Jacques Le Roux a écrit : Why all these changes in JavaDoc? Is that related with EOLs? If so then something is wrong because I set the SVN repo to handle that automatically at http://markmail.org/message/gzghk44kyz646e4d. Maybe you and/or Dennis are not using a svn >= 1.8 c

Re: svn commit: r1817750 - in /ofbiz/ofbiz-framework/trunk/framework/base/src/main/java/org/apache/ofbiz/ base/component: ComponentConfig.java ComponentLoaderConfig.java ComponentResourceHandler.java

2017-12-11 Thread Jacques Le Roux
Hi Michael, I'm not sure about all the other commits for "General refactoring and code improvements" (subtasks of OFBIZ-9836) But here I found a lot of unnecessary changes and this makes things a bit harder to review. Why all these changes in JavaDoc? Is that related with EOLs? If so then som

svn commit: r1817752 - /ofbiz/ofbiz-framework/trunk/applications/product/servicedef/services_shipment.xml

2017-12-11 Thread nmalin
Author: nmalin Date: Mon Dec 11 08:23:25 2017 New Revision: 1817752 URL: http://svn.apache.org/viewvc?rev=1817752&view=rev Log: Fixed: Add missing default-entity-name on create and delete definition service for CarrierShipmentMethod entity introduce at r1787822 Related to Convert ShipmentMethodTy

svn commit: r1817751 - /ofbiz/ofbiz-framework/trunk/framework/common/src/main/java/org/apache/ofbiz/common/authentication/AuthHelper.java

2017-12-11 Thread mbrohl
Author: mbrohl Date: Mon Dec 11 08:10:16 2017 New Revision: 1817751 URL: http://svn.apache.org/viewvc?rev=1817751&view=rev Log: Improved: General refactoring and code improvements, package org.apache.ofbiz.common.authentication. (OFBIZ-9875) Thanks Julian Leichert for reporting and providing the

buildbot success in on ofbiz-trunk-framework-plugins

2017-12-11 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-trunk-framework-plugins while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/847 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build R