[GitHub] [doris] github-actions[bot] commented on pull request #16129: [cleanup](fe) cleanup useless code.

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16129: URL: https://github.com/apache/doris/pull/16129#issuecomment-1407371121 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16166: [fix](hashjoin) join produce blocks with rows larger than batch size

2023-01-28 Thread github-actions
github-actions[bot] commented on code in PR #16166: URL: https://github.com/apache/doris/pull/16166#discussion_r1089717648 ## be/src/vec/exec/join/process_hash_table_probe_impl.h: ## @@ -208,123 +207,180 @@ Status ProcessHashTableProbe::do_process(HashTableType& hash_tab

[GitHub] [doris] github-actions[bot] commented on pull request #16167: [Feature-WIP](inverted index) Filter out and remain predicates that do not support apply by inverted index, and add inverted inde

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16167: URL: https://github.com/apache/doris/pull/16167#issuecomment-1407377037 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16161: [fix](inverted index) fulltext match query should not prune by zone map

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16161: URL: https://github.com/apache/doris/pull/16161#issuecomment-1407377323 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16167: [Feature-WIP](inverted index) Filter out and remain predicates that do not support apply by inverted index, and add inverted inde

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16167: URL: https://github.com/apache/doris/pull/16167#issuecomment-1407377423 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16167: [Feature-WIP](inverted index) Filter out and remain predicates that do not support apply by inverted index, and add inverted inde

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16167: URL: https://github.com/apache/doris/pull/16167#issuecomment-1407380183 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16153: [bug](cooldown)add config for Cooldown Job

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16153: URL: https://github.com/apache/doris/pull/16153#issuecomment-1407383521 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16153: [bug](cooldown)add config for Cooldown Job

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16153: URL: https://github.com/apache/doris/pull/16153#issuecomment-1407383534 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16159: [datev2](function) make function nullable DEPEND_ON_ARGUMENT

2023-01-28 Thread github-actions
github-actions[bot] commented on code in PR #16159: URL: https://github.com/apache/doris/pull/16159#discussion_r1089723206 ## be/src/vec/functions/function_timestamp.cpp: ## @@ -721,37 +837,59 @@ static Status execute_impl(FunctionContext* context, Block& b

[GitHub] [doris] github-actions[bot] commented on pull request #16168: [Bug](function) remove datev2 signature of hour_ceil/hour_floor

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16168: URL: https://github.com/apache/doris/pull/16168#issuecomment-1407384603 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16168: [Bug](function) remove datev2 signature of hour_ceil/hour_floor

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16168: URL: https://github.com/apache/doris/pull/16168#issuecomment-1407384757 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16168: [Bug](function) remove datev2 signature of hour_ceil/hour_floor

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16168: URL: https://github.com/apache/doris/pull/16168#issuecomment-1407384767 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #16159: [datev2](function) make function nullable DEPEND_ON_ARGUMENT

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16159: URL: https://github.com/apache/doris/pull/16159#issuecomment-1407385770 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16159: [datev2](function) make function nullable DEPEND_ON_ARGUMENT

2023-01-28 Thread github-actions
github-actions[bot] commented on code in PR #16159: URL: https://github.com/apache/doris/pull/16159#discussion_r1089723868 ## be/src/vec/functions/function_timestamp.cpp: ## @@ -721,37 +837,59 @@ struct MondayImpl { static Status execute_impl(FunctionContext* context

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16157: [Bug](exec) enable warning on ignoring function return value for vctx

2023-01-28 Thread github-actions
github-actions[bot] commented on code in PR #16157: URL: https://github.com/apache/doris/pull/16157#discussion_r1089725536 ## be/test/vec/exprs/vexpr_test.cpp: ## @@ -83,8 +86,11 @@ TEST(TEST_VEXPR, ABSTEST2) { DescriptorTbl desc_tbl; Review Comment: warning: calling a

[GitHub] [doris] github-actions[bot] commented on pull request #16169: [fix](nereids) Delete invalid signature of nvl function

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16169: URL: https://github.com/apache/doris/pull/16169#issuecomment-1407394710 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16169: [fix](nereids) Delete invalid signature of nvl function

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16169: URL: https://github.com/apache/doris/pull/16169#issuecomment-1407394721 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #16170: [fix](Nereids): fix convert_tz() SIGNATURES.

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16170: URL: https://github.com/apache/doris/pull/16170#issuecomment-1407397943 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16170: [fix](Nereids): fix convert_tz() SIGNATURES.

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16170: URL: https://github.com/apache/doris/pull/16170#issuecomment-1407397954 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #15924: [improvement](agg-function) remove the limit on the max number of agg function parameters

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #15924: URL: https://github.com/apache/doris/pull/15924#issuecomment-1407409582 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #15924: [improvement](agg-function) Increase the limit maximum number of agg function parameters

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #15924: URL: https://github.com/apache/doris/pull/15924#issuecomment-1407410562 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16172: [fix-core](block) clear block row_same_bit when block reuse

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16172: URL: https://github.com/apache/doris/pull/16172#issuecomment-1407415617 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16172: [fix-core](block) clear block row_same_bit when block reuse

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16172: URL: https://github.com/apache/doris/pull/16172#issuecomment-1407415991 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15718: [fix](schema scanner)change schema_scanner::get_next_row to get_next_block

2023-01-28 Thread github-actions
github-actions[bot] commented on code in PR #15718: URL: https://github.com/apache/doris/pull/15718#discussion_r1089757755 ## be/src/vec/exec/vschema_scan_node.cpp: ## @@ -255,74 +257,61 @@ Status VSchemaScanNode::get_next(RuntimeState* state, vectorized::Block* block

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16084: [improvement](memory) Optimize the log of process memory insufficient and support regular GC cache

2023-01-28 Thread github-actions
github-actions[bot] commented on code in PR #16084: URL: https://github.com/apache/doris/pull/16084#discussion_r1089774885 ## be/src/runtime/memory/mem_tracker_limiter.cpp: ## @@ -195,26 +196,35 @@ void MemTrackerLimiter::print_log_usage(const std::string&

[GitHub] [doris] github-actions[bot] commented on pull request #16175: [docker](iceberg) add iceberg docker compose and modify scripts

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16175: URL: https://github.com/apache/doris/pull/16175#issuecomment-1407439030 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4032713862";) output.

[GitHub] [doris] github-actions[bot] commented on pull request #16175: [docker](iceberg) add iceberg docker compose and modify scripts

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16175: URL: https://github.com/apache/doris/pull/16175#issuecomment-1407440187 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4032734118";) output.

[GitHub] [doris] github-actions[bot] commented on pull request #16175: [docker](iceberg) add iceberg docker compose and modify scripts

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16175: URL: https://github.com/apache/doris/pull/16175#issuecomment-1407440274 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4032736366";) output.

[GitHub] [doris] github-actions[bot] commented on pull request #16175: [docker](iceberg) add iceberg docker compose and modify scripts

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16175: URL: https://github.com/apache/doris/pull/16175#issuecomment-1407443853 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4032812188";) output.

[GitHub] [doris] github-actions[bot] commented on pull request #16175: [docker](iceberg) add iceberg docker compose and modify scripts

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16175: URL: https://github.com/apache/doris/pull/16175#issuecomment-1407444200 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/4032819831";) output.

[GitHub] [doris] github-actions[bot] commented on pull request #16167: [Feature-WIP](inverted index) Filter out and remain predicates that do not support apply by inverted index, and add inverted inde

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16167: URL: https://github.com/apache/doris/pull/16167#issuecomment-1407527664 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #16179: [refactor](remove unused code) remove thread pool manager

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16179: URL: https://github.com/apache/doris/pull/16179#issuecomment-1407535171 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16172: [fix-core](block) clear block row_same_bit when block reuse

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16172: URL: https://github.com/apache/doris/pull/16172#issuecomment-1407539083 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16174: [fix](Nereids): fix dceil() dfloor()

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16174: URL: https://github.com/apache/doris/pull/16174#issuecomment-1407540040 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #16174: [fix](Nereids): fix dceil() dfloor()

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16174: URL: https://github.com/apache/doris/pull/16174#issuecomment-1407540031 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16132: [fix](datatype) fix some bugs about data type array datetimev2 and decimalv3

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16132: URL: https://github.com/apache/doris/pull/16132#issuecomment-1407543258 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16167: [Feature-WIP](inverted index) Filter out and remain predicates that do not support apply by inverted index, and add inverted inde

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16167: URL: https://github.com/apache/doris/pull/16167#issuecomment-1407543618 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16132: [fix](datatype) fix some bugs about data type array datetimev2 and decimalv3

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16132: URL: https://github.com/apache/doris/pull/16132#issuecomment-1407544426 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16060: [feature-wip](MTMV) Support setting variables in query statement

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16060: URL: https://github.com/apache/doris/pull/16060#issuecomment-1407544931 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16060: [feature-wip](MTMV) Support setting variables in query statement

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16060: URL: https://github.com/apache/doris/pull/16060#issuecomment-1407544937 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #16125: [fix](nereids)fix bug of rule twoPhaseAggregateWithCountDistinctMulti

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16125: URL: https://github.com/apache/doris/pull/16125#issuecomment-1407547228 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16179: [refactor](remove unused code) remove thread pool manager

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16179: URL: https://github.com/apache/doris/pull/16179#issuecomment-1407550940 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16179: [refactor](remove unused code) remove thread pool manager

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16179: URL: https://github.com/apache/doris/pull/16179#issuecomment-1407550944 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #16183: [refactor](remove unused code) remove log error hub

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16183: URL: https://github.com/apache/doris/pull/16183#issuecomment-1407551845 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16159: [datev2](function) make function nullable DEPEND_ON_ARGUMENT

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16159: URL: https://github.com/apache/doris/pull/16159#issuecomment-1407556731 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16170: [fix](Nereids): remove `DataV2Type` in ConvertTz SIGNATURES

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16170: URL: https://github.com/apache/doris/pull/16170#issuecomment-1407559890 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16183: [refactor](remove unused code) remove log error hub

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16183: URL: https://github.com/apache/doris/pull/16183#issuecomment-1407563877 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15718: [fix](schema scanner)change schema_scanner::get_next_row to get_next_block

2023-01-28 Thread github-actions
github-actions[bot] commented on code in PR #15718: URL: https://github.com/apache/doris/pull/15718#discussion_r1089869561 ## be/src/exec/schema_scanner.cpp: ## @@ -231,4 +233,156 @@ Status SchemaScanner::create_tuple_desc(ObjectPool* pool) { return Status::OK

[GitHub] [doris] github-actions[bot] commented on pull request #16159: [datev2](function) make function nullable DEPEND_ON_ARGUMENT

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16159: URL: https://github.com/apache/doris/pull/16159#issuecomment-1407568129 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16190: [Enhance] use std::from_chars to do str cast to float/double to avoid lose precision

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16190: URL: https://github.com/apache/doris/pull/16190#issuecomment-1407571847 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16125: [fix](nereids)fix bug of rule twoPhaseAggregateWithCountDistinctMulti

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16125: URL: https://github.com/apache/doris/pull/16125#issuecomment-1407573516 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16190: [Enhance](fix)use std::from_chars to do str cast to float/double to avoid lose precision

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16190: URL: https://github.com/apache/doris/pull/16190#issuecomment-1407575493 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16191: [optimize](inverted index) use InvertedIndexReaderType::FULLTEXT instead of InvertedIndexParserType to check predicate whether ha

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16191: URL: https://github.com/apache/doris/pull/16191#issuecomment-1407576881 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16191: [optimize](inverted index) use InvertedIndexReaderType::FULLTEXT instead of InvertedIndexParserType to check predicate whether ha

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16191: URL: https://github.com/apache/doris/pull/16191#issuecomment-1407577832 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #15511: [feature](Load)Suppot MySQL Load Data

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #15511: URL: https://github.com/apache/doris/pull/15511#issuecomment-1407578651 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #15511: [feature](Load)Suppot MySQL Load Data

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #15511: URL: https://github.com/apache/doris/pull/15511#issuecomment-1407578657 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #16190: [Enhance](fix)use std::from_chars to do str cast to float/double to avoid lose precision

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16190: URL: https://github.com/apache/doris/pull/16190#issuecomment-1407579772 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16166: [fix](hashjoin) join produce blocks with rows larger than batch size

2023-01-28 Thread github-actions
github-actions[bot] commented on code in PR #16166: URL: https://github.com/apache/doris/pull/16166#discussion_r1089878994 ## be/src/vec/exec/join/process_hash_table_probe_impl.h: ## @@ -409,99 +461,154 @@ Status ProcessHashTableProbe::do_process_with_other_join_conjuncts

[GitHub] [doris] github-actions[bot] commented on pull request #16187: [enhance](Nereids): remove duplicated Function.

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16187: URL: https://github.com/apache/doris/pull/16187#issuecomment-1407580586 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #16187: [enhance](Nereids): remove duplicated Function.

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16187: URL: https://github.com/apache/doris/pull/16187#issuecomment-1407580581 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16190: [Enhance](fix)use std::from_chars to do str cast to float/double to avoid lose precision

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16190: URL: https://github.com/apache/doris/pull/16190#issuecomment-1407581461 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16194: [refactor](some mempool) remove some useless mempool code or misuse of mempool

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16194: URL: https://github.com/apache/doris/pull/16194#issuecomment-1407582490 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16188: [fix](Nereids): fix function name.

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16188: URL: https://github.com/apache/doris/pull/16188#issuecomment-1407583973 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16188: [fix](Nereids): fix function name.

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16188: URL: https://github.com/apache/doris/pull/16188#issuecomment-1407583983 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #16191: [optimize](inverted index) use InvertedIndexReaderType::FULLTEXT instead of InvertedIndexParserType to check predicate whether ha

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16191: URL: https://github.com/apache/doris/pull/16191#issuecomment-1407584103 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16167: [Feature-WIP](inverted index) Filter out and remain predicates that do not support apply by inverted index, and add inverted inde

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16167: URL: https://github.com/apache/doris/pull/16167#issuecomment-1407584136 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16060: [feature-wip](MTMV) Support setting variables in query statement

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16060: URL: https://github.com/apache/doris/pull/16060#issuecomment-1407586508 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16195: [fix](compile) fix the compile error when WITH_MYSQL is ON.

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16195: URL: https://github.com/apache/doris/pull/16195#issuecomment-1407588193 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16055: [feature](Load)Suppot skip specific lines number for csv stream load

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16055: URL: https://github.com/apache/doris/pull/16055#issuecomment-1407588267 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16195: [fix](compile) fix the compile error when WITH_MYSQL is ON.

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16195: URL: https://github.com/apache/doris/pull/16195#issuecomment-1407588420 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16195: [fix](compile) fix the compile error when WITH_MYSQL is ON.

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16195: URL: https://github.com/apache/doris/pull/16195#issuecomment-1407588425 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15966: [Feature](map)support complex struct for doris

2023-01-28 Thread github-actions
github-actions[bot] commented on code in PR #15966: URL: https://github.com/apache/doris/pull/15966#discussion_r1089889453 ## be/src/olap/rowset/segment_v2/column_reader.cpp: ## @@ -449,13 +476,91 @@ Status ColumnReader::new_iterator(ColumnIterator** iterator

[GitHub] [doris] github-actions[bot] commented on pull request #16196: [Chore](build) enable ignored-qualifiers check

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16196: URL: https://github.com/apache/doris/pull/16196#issuecomment-1407589653 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16125: [fix](nereids)fix bug of rule twoPhaseAggregateWithCountDistinctMulti

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16125: URL: https://github.com/apache/doris/pull/16125#issuecomment-1407590947 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16197: [fix](Nereids): Fix some functions error

2023-01-28 Thread github-actions
github-actions[bot] commented on PR #16197: URL: https://github.com/apache/doris/pull/16197#issuecomment-1407591645 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16197: [fix](Nereids): Fix some functions error

2023-01-29 Thread github-actions
github-actions[bot] commented on PR #16197: URL: https://github.com/apache/doris/pull/16197#issuecomment-1407594462 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16193: [refactor](Nereids) use immutable collections as far as possible

2023-01-29 Thread github-actions
github-actions[bot] commented on PR #16193: URL: https://github.com/apache/doris/pull/16193#issuecomment-1407594464 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16193: [refactor](Nereids) use immutable collections as far as possible

2023-01-29 Thread github-actions
github-actions[bot] commented on PR #16193: URL: https://github.com/apache/doris/pull/16193#issuecomment-1407594482 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #16194: [refactor](some mempool) remove some useless mempool code or misuse of mempool

2023-01-29 Thread github-actions
github-actions[bot] commented on PR #16194: URL: https://github.com/apache/doris/pull/16194#issuecomment-1407596595 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16194: [refactor](some mempool) remove some useless mempool code or misuse of mempool

2023-01-29 Thread github-actions
github-actions[bot] commented on PR #16194: URL: https://github.com/apache/doris/pull/16194#issuecomment-1407597465 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16199: [typo](doc)Add an example of how to assign a value to a field of Date type

2023-01-29 Thread github-actions
github-actions[bot] commented on PR #16199: URL: https://github.com/apache/doris/pull/16199#issuecomment-1407597503 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16199: [typo](doc)Add an example of how to assign a value to a field of Date type

2023-01-29 Thread github-actions
github-actions[bot] commented on PR #16199: URL: https://github.com/apache/doris/pull/16199#issuecomment-1407597508 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15966: [Feature](map)support complex struct for doris

2023-01-29 Thread github-actions
github-actions[bot] commented on code in PR #15966: URL: https://github.com/apache/doris/pull/15966#discussion_r1089900145 ## be/src/vec/data_types/data_type_factory.cpp: ## @@ -169,6 +179,12 @@ } nested = std::make_shared(dataTypes, names); break

[GitHub] [doris] github-actions[bot] commented on pull request #16197: [fix](Nereids): Fix some functions error

2023-01-29 Thread github-actions
github-actions[bot] commented on PR #16197: URL: https://github.com/apache/doris/pull/16197#issuecomment-1407600126 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16194: [refactor](some mempool) remove some useless mempool code or misuse of mempool

2023-01-29 Thread github-actions
github-actions[bot] commented on PR #16194: URL: https://github.com/apache/doris/pull/16194#issuecomment-1407600388 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #15972: [improvement](bitshuffle)Enable avx512 support in bitshuffle for performance boost

2023-01-29 Thread github-actions
github-actions[bot] commented on PR #15972: URL: https://github.com/apache/doris/pull/15972#issuecomment-1407600698 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #15972: [improvement](bitshuffle)Enable avx512 support in bitshuffle for performance boost

2023-01-29 Thread github-actions
github-actions[bot] commented on PR #15972: URL: https://github.com/apache/doris/pull/15972#issuecomment-1407600703 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #16055: [feature](Load)Suppot skip specific lines number for csv stream load

2023-01-29 Thread github-actions
github-actions[bot] commented on PR #16055: URL: https://github.com/apache/doris/pull/16055#issuecomment-1407600963 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16194: [refactor](some mempool) not memset 0 in default value iterator

2023-01-29 Thread github-actions
github-actions[bot] commented on PR #16194: URL: https://github.com/apache/doris/pull/16194#issuecomment-1407601116 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16205: [Bug](date) Fix invalid date

2023-01-29 Thread github-actions
github-actions[bot] commented on PR #16205: URL: https://github.com/apache/doris/pull/16205#issuecomment-1407603258 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16194: [refactor](some mempool) not memset 0 in default value iterator

2023-01-29 Thread github-actions
github-actions[bot] commented on PR #16194: URL: https://github.com/apache/doris/pull/16194#issuecomment-1407605266 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16194: [refactor](some mempool) not memset 0 in default value iterator

2023-01-29 Thread github-actions
github-actions[bot] commented on PR #16194: URL: https://github.com/apache/doris/pull/16194#issuecomment-1407605277 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on pull request #16183: [refactor](remove unused code) remove log error hub

2023-01-29 Thread github-actions
github-actions[bot] commented on PR #16183: URL: https://github.com/apache/doris/pull/16183#issuecomment-1407605384 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16192: [Fix](regression-test)fix regression test framework cannot compare double value nan and inf.

2023-01-29 Thread github-actions
github-actions[bot] commented on PR #16192: URL: https://github.com/apache/doris/pull/16192#issuecomment-1407606712 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [doris] github-actions[bot] commented on pull request #16192: [Fix](regression-test)fix regression test framework cannot compare double value nan and inf.

2023-01-29 Thread github-actions
github-actions[bot] commented on PR #16192: URL: https://github.com/apache/doris/pull/16192#issuecomment-1407606724 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16190: [Enhance](fix)use std::from_chars to do str cast to float/double to avoid lose precision

2023-01-29 Thread github-actions
github-actions[bot] commented on code in PR #16190: URL: https://github.com/apache/doris/pull/16190#discussion_r1089910051 ## be/src/util/string_parser.hpp: ## @@ -20,6 +20,8 @@ #pragma once +#include Review Comment: warning: 'fast_float/fast_float.h' file

[GitHub] [doris] github-actions[bot] commented on pull request #16207: [Improvement](decimal) do not log fatal if precision is invalid

2023-01-29 Thread github-actions
github-actions[bot] commented on PR #16207: URL: https://github.com/apache/doris/pull/16207#issuecomment-1407610871 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15718: [fix](schema scanner)change schema_scanner::get_next_row to get_next_block

2023-01-29 Thread github-actions
github-actions[bot] commented on code in PR #15718: URL: https://github.com/apache/doris/pull/15718#discussion_r1089915305 ## be/src/exec/schema_scanner.cpp: ## @@ -33,34 +33,24 @@ #include "exec/schema_scanner/schema_variables_scanner.h" #include "exec

[GitHub] [doris] github-actions[bot] commented on pull request #16073: [feature](Load)WIP: add cluster_token auth for stream load to avoid double auth in mysql load

2023-01-29 Thread github-actions
github-actions[bot] commented on PR #16073: URL: https://github.com/apache/doris/pull/16073#issuecomment-1407614083 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [doris] github-actions[bot] commented on pull request #16126: [fix](be)the set operation node should accept both nullable and non-nullable data from child node

2023-01-29 Thread github-actions
github-actions[bot] commented on PR #16126: URL: https://github.com/apache/doris/pull/16126#issuecomment-1407614371 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

<    1   2   3   4   5   >