[GitHub] [doris] xinyiZzz commented on a diff in pull request #10170: [Enhancement](optimizer) Support select table sample

2022-10-09 Thread GitBox
xinyiZzz commented on code in PR #10170: URL: https://github.com/apache/doris/pull/10170#discussion_r990929685 ## fe/fe-core/src/main/java/org/apache/doris/analysis/TableRef.java: ## @@ -160,6 +161,12 @@ public TableRef(TableName name, String alias, PartitionNames partitionName

[GitHub] [doris] xinyiZzz commented on a diff in pull request #10170: [Enhancement](optimizer) Support select table sample

2022-10-09 Thread GitBox
xinyiZzz commented on code in PR #10170: URL: https://github.com/apache/doris/pull/10170#discussion_r990933566 ## fe/fe-core/src/main/java/org/apache/doris/analysis/TableRef.java: ## @@ -197,17 +205,49 @@ protected TableRef(TableRef other) { lateralViewRefs.add(

[GitHub] [doris] xinyiZzz commented on a diff in pull request #10170: [Enhancement](optimizer) Support select table sample

2022-10-09 Thread GitBox
xinyiZzz commented on code in PR #10170: URL: https://github.com/apache/doris/pull/10170#discussion_r990934807 ## fe/fe-core/src/main/java/org/apache/doris/analysis/TableSample.java: ## @@ -0,0 +1,101 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [doris] yiguolei merged pull request #13207: [Improvement](runtimefilter) DO NOT allocate memory for bbf in prepare phase

2022-10-09 Thread GitBox
yiguolei merged PR #13207: URL: https://github.com/apache/doris/pull/13207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] yiguolei merged pull request #13214: [Improvement](like function) avoid to convert const column to full column

2022-10-09 Thread GitBox
yiguolei merged PR #13214: URL: https://github.com/apache/doris/pull/13214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] stalary commented on a diff in pull request #13051: [feature](auth) support user password policy and alter user stmt

2022-10-09 Thread GitBox
stalary commented on code in PR #13051: URL: https://github.com/apache/doris/pull/13051#discussion_r990881647 ## docs/zh-CN/docs/sql-manual/sql-reference/Account-Management-Statements/CREATE-USER.md: ## @@ -87,6 +112,18 @@ host 部分也可指定为 domain,语法为:'user_name'@['domain'],即使 C

[GitHub] [doris] nextdreamblue opened a new pull request, #13240: [fix](ddl) check view name by table name regex when create

2022-10-09 Thread GitBox
nextdreamblue opened a new pull request, #13240: URL: https://github.com/apache/doris/pull/13240 Signed-off-by: nextdreamblue # Proposed changes Issue Number: close #xxx ## Problem summary add check view name by table name regex when create. ## Checklist(Re

[GitHub] [doris] morningman merged pull request #13133: [chore] Format keywords in sql_parser.cup

2022-10-09 Thread GitBox
morningman merged PR #13133: URL: https://github.com/apache/doris/pull/13133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[GitHub] [doris] yiguolei opened a new pull request, #13241: [chore](release build) copy license and notice file to output folder and strip debug info from meta tool (#13222)

2022-10-09 Thread GitBox
yiguolei opened a new pull request, #13241: URL: https://github.com/apache/doris/pull/13241 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior:

[GitHub] [doris] yiguolei merged pull request #13241: [chore](release build) copy license and notice file to output folder and strip debug info from meta tool (#13222)

2022-10-09 Thread GitBox
yiguolei merged PR #13241: URL: https://github.com/apache/doris/pull/13241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] nextdreamblue opened a new issue, #13242: [Bug] create view need check table by table name regex

2022-10-09 Thread GitBox
nextdreamblue opened a new issue, #13242: URL: https://github.com/apache/doris/issues/13242 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version master-6

[GitHub] [doris] Kikyou1997 opened a new pull request, #13243: [Enhancement](nereids) Remove redundant log when fall back to stale parser

2022-10-09 Thread GitBox
Kikyou1997 opened a new pull request, #13243: URL: https://github.com/apache/doris/pull/13243 # Proposed changes Issue Number: noissue ## Problem summary Such error stack is totally useless and noising. ## Checklist(Required) 1. Does it affect the original b

[GitHub] [doris] yiguolei merged pull request #13237: [typo](docs)add hive-bitmap compile and package des

2022-10-09 Thread GitBox
yiguolei merged PR #13237: URL: https://github.com/apache/doris/pull/13237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] github-actions[bot] commented on pull request #13051: [feature](auth) support user password policy and alter user stmt

2022-10-09 Thread GitBox
github-actions[bot] commented on PR #13051: URL: https://github.com/apache/doris/pull/13051#issuecomment-1272858578 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #13051: [feature](auth) support user password policy and alter user stmt

2022-10-09 Thread GitBox
github-actions[bot] commented on PR #13051: URL: https://github.com/apache/doris/pull/13051#issuecomment-1272858480 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] morningman commented on a diff in pull request #13096: [DOC](storage policy) add cold and hot separation docs

2022-10-09 Thread GitBox
morningman commented on code in PR #13096: URL: https://github.com/apache/doris/pull/13096#discussion_r990957510 ## docs/zh-CN/docs/sql-manual/sql-reference/Data-Definition-Statements/Alter/ALTER-RESOURCE.md: ## @@ -50,6 +50,22 @@ ALTER RESOURCE 'spark0' PROPERTIES ("working_dir

[GitHub] [doris] morningman commented on a diff in pull request #13096: [DOC](storage policy) add cold and hot separation docs

2022-10-10 Thread GitBox
morningman commented on code in PR #13096: URL: https://github.com/apache/doris/pull/13096#discussion_r990960425 ## docs/zh-CN/docs/sql-manual/sql-reference/Data-Definition-Statements/Alter/ALTER-RESOURCE.md: ## @@ -50,6 +50,22 @@ ALTER RESOURCE 'spark0' PROPERTIES ("working_dir

[GitHub] [doris] github-actions[bot] commented on pull request #13229: Fully resolved Mysql external table issues

2022-10-10 Thread GitBox
github-actions[bot] commented on PR #13229: URL: https://github.com/apache/doris/pull/13229#issuecomment-1272877136 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #13229: Fully resolved Mysql external table issues

2022-10-10 Thread GitBox
github-actions[bot] commented on PR #13229: URL: https://github.com/apache/doris/pull/13229#issuecomment-1272877178 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] xiaojunjie opened a new pull request, #13244: [improvement](load) support function from_unixtime with specified timezome

2022-10-10 Thread GitBox
xiaojunjie opened a new pull request, #13244: URL: https://github.com/apache/doris/pull/13244 # Proposed changes Issue Number: none ## Problem summary function from_unixtime use default fixed time zone when vectorized engine enable. ## Checklist(Required) 1

[GitHub] [doris-flink-connector] dinggege1024 commented on a diff in pull request #71: [Enhancement] ADD RowSerializer for doris flink connector

2022-10-10 Thread GitBox
dinggege1024 commented on code in PR #71: URL: https://github.com/apache/doris-flink-connector/pull/71#discussion_r990977828 ## flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/RowSerializer.java: ## @@ -0,0 +1,166 @@ +// Licensed to the Apache Software Fo

[GitHub] [doris] xiaokang commented on a diff in pull request #13129: jsonb parse function and load

2022-10-10 Thread GitBox
xiaokang commented on code in PR #13129: URL: https://github.com/apache/doris/pull/13129#discussion_r990984939 ## fe/fe-core/src/main/java/org/apache/doris/planner/LoadScanNode.java: ## @@ -206,7 +206,23 @@ protected void finalizeParams(Map slotDescByName, expr

[GitHub] [doris] dataroaring opened a new pull request, #13245: [improvement](tcmalloc) increase tcmalloc upper limit to 90%

2022-10-10 Thread GitBox
dataroaring opened a new pull request, #13245: URL: https://github.com/apache/doris/pull/13245 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ]

[GitHub] [doris] BiteTheDDDDt opened a new pull request, #13246: [Feature](runtime-filter) add runtime filter breaking change adapt

2022-10-10 Thread GitBox
BiteThet opened a new pull request, #13246: URL: https://github.com/apache/doris/pull/13246 # Proposed changes make runtime filter breaking change(https://github.com/apache/doris/pull/12856) support rolling upgrade. ## Problem summary Describe your changes. ##

[GitHub] [doris-flink-connector] JNSimba commented on a diff in pull request #71: [Enhancement] ADD RowSerializer for doris flink connector

2022-10-10 Thread GitBox
JNSimba commented on code in PR #71: URL: https://github.com/apache/doris-flink-connector/pull/71#discussion_r990999551 ## flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/RowSerializer.java: ## @@ -0,0 +1,117 @@ +// Licensed to the Apache Software Foundat

[GitHub] [doris] dataroaring merged pull request #13220: [Bug](replace function) fix be infinite loop and oom when use replace with an empty old str

2022-10-10 Thread GitBox
dataroaring merged PR #13220: URL: https://github.com/apache/doris/pull/13220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

[GitHub] [doris] dataroaring merged pull request #13234: [improvement](test) set default value of parallel config items to 10

2022-10-10 Thread GitBox
dataroaring merged PR #13234: URL: https://github.com/apache/doris/pull/13234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

[GitHub] [doris] starocean999 opened a new pull request, #13247: [fix](agg)count function should return 0 for null value

2022-10-10 Thread GitBox
starocean999 opened a new pull request, #13247: URL: https://github.com/apache/doris/pull/13247 # Proposed changes Issue Number: close #xxx ## Problem summary count(null) should return 0 instead of 1, the streaming_agg_serialize_to_column function didn't handle if the in

[GitHub] [doris-flink-connector] dinggege1024 commented on a diff in pull request #71: [Enhancement] ADD RowSerializer for doris flink connector

2022-10-10 Thread GitBox
dinggege1024 commented on code in PR #71: URL: https://github.com/apache/doris-flink-connector/pull/71#discussion_r991006903 ## flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/RowSerializer.java: ## @@ -0,0 +1,117 @@ +// Licensed to the Apache Software Fo

[GitHub] [doris] xinyiZzz opened a new pull request, #13248: [branch-1.1-lts](hot) Fix old mem tracker cancel

2022-10-10 Thread GitBox
xinyiZzz opened a new pull request, #13248: URL: https://github.com/apache/doris/pull/13248 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Ye

[GitHub] [doris] dataroaring merged pull request #13248: [branch-1.1-lts](hot) Fix old mem tracker cancel

2022-10-10 Thread GitBox
dataroaring merged PR #13248: URL: https://github.com/apache/doris/pull/13248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

[GitHub] [doris] lsy3993 commented on a diff in pull request #13132: [function](date function) add new date function 'first_month_day'

2022-10-10 Thread GitBox
lsy3993 commented on code in PR #13132: URL: https://github.com/apache/doris/pull/13132#discussion_r991017597 ## be/src/vec/functions/function_timestamp.cpp: ## @@ -478,6 +478,149 @@ class FunctionUnixTimestamp : public IFunction { } }; +template +class FirstMonthDay :

[GitHub] [doris] starocean999 commented on pull request #13227: [fix](join) should call getOutputTblRefIds to get child's tuple info

2022-10-10 Thread GitBox
starocean999 commented on PR #13227: URL: https://github.com/apache/doris/pull/13227#issuecomment-1272969041 > Does this pr solve the problem that #12261 wants to fix? yes, originally, the old pr just want to make the computeOutputTuple and computeIntermediateTuple both call getOutpu

[GitHub] [doris] mrhhsg opened a new issue, #13249: [Bug] coredump caused by like predicate with nullable column

2022-10-10 Thread GitBox
mrhhsg opened a new issue, #13249: URL: https://github.com/apache/doris/issues/13249 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version master #

[GitHub] [doris-flink-connector] JNSimba merged pull request #71: [Enhancement] ADD RowSerializer for doris flink connector

2022-10-10 Thread GitBox
JNSimba merged PR #71: URL: https://github.com/apache/doris-flink-connector/pull/71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

[GitHub] [doris] mrhhsg closed issue #13249: [Bug] coredump caused by like predicate with nullable column

2022-10-10 Thread GitBox
mrhhsg closed issue #13249: [Bug] coredump caused by like predicate with nullable column URL: https://github.com/apache/doris/issues/13249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [doris] hf200012 merged pull request #13229: [improvement](mysql-to-doris)Fully resolved Mysql external table issues

2022-10-10 Thread GitBox
hf200012 merged PR #13229: URL: https://github.com/apache/doris/pull/13229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] 345362231 closed issue #6574: [Bug] doris 0.14 backup/restore问题

2022-10-10 Thread GitBox
345362231 closed issue #6574: [Bug] doris 0.14 backup/restore问题 URL: https://github.com/apache/doris/issues/6574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [doris] mrhhsg opened a new pull request, #13250: [fix](olap) fix core dump caused by LikeColumnPredicate with nullable…

2022-10-10 Thread GitBox
mrhhsg opened a new pull request, #13250: URL: https://github.com/apache/doris/pull/13250 … column # Proposed changes Issue Number: close #13249 ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior:

[GitHub] [doris] github-actions[bot] commented on pull request #13226: [refactor](datax)Refactoring doris writer code

2022-10-10 Thread GitBox
github-actions[bot] commented on PR #13226: URL: https://github.com/apache/doris/pull/13226#issuecomment-1272990668 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #13226: [refactor](datax)Refactoring doris writer code

2022-10-10 Thread GitBox
github-actions[bot] commented on PR #13226: URL: https://github.com/apache/doris/pull/13226#issuecomment-1272990738 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] 345362231 opened a new issue, #13251: [Bug] BE日志告警UpdateDerivedVars is too busy!服务器卡住

2022-10-10 Thread GitBox
345362231 opened a new issue, #13251: URL: https://github.com/apache/doris/issues/13251 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version trunk-f286bd

[GitHub] [doris] levy5307 commented on pull request #12919: [fix](memory): avoid coredump when list pointer is null

2022-10-10 Thread GitBox
levy5307 commented on PR #12919: URL: https://github.com/apache/doris/pull/12919#issuecomment-1273014442 > Could you add a regression test? It's hard to add a regression test because this bug is not a problem bound to arise. So I add a unit test for this function instead. -- This i

[GitHub] [doris] carlvinhust2012 commented on pull request #13225: [fix](array-type) fix get_data_at for zero element array

2022-10-10 Thread GitBox
carlvinhust2012 commented on PR #13225: URL: https://github.com/apache/doris/pull/13225#issuecomment-1273020872 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [doris] morrySnow merged pull request #13218: [fix](statstics) Incorrectly using the number of buckets to determine whether the table is partitioned

2022-10-10 Thread GitBox
morrySnow merged PR #13218: URL: https://github.com/apache/doris/pull/13218 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[GitHub] [doris] morrySnow commented on a diff in pull request #13243: [Enhancement](nereids) Remove redundant log when fall back to stale parser

2022-10-10 Thread GitBox
morrySnow commented on code in PR #13243: URL: https://github.com/apache/doris/pull/13243#discussion_r991085964 ## fe/fe-core/src/main/java/org/apache/doris/qe/ConnectProcessor.java: ## @@ -266,8 +266,8 @@ private void handleQuery() { } catch (Exception e) {

[GitHub] [doris] Kikyou1997 opened a new pull request, #13252: [DMG](planner) Log error when choosing best plan

2022-10-10 Thread GitBox
Kikyou1997 opened a new pull request, #13252: URL: https://github.com/apache/doris/pull/13252 # Proposed changes Issue Number: noissue ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes

[GitHub] [doris] siriume opened a new issue, #13253: [Feature] to_bitmap function support date/datev2.

2022-10-10 Thread GitBox
siriume opened a new issue, #13253: URL: https://github.com/apache/doris/issues/13253 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description to_bitmap

[GitHub] [doris] github-actions[bot] commented on pull request #13250: [fix](olap) fix core dump caused by LikeColumnPredicate with nullable…

2022-10-10 Thread GitBox
github-actions[bot] commented on PR #13250: URL: https://github.com/apache/doris/pull/13250#issuecomment-127398 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #13250: [fix](olap) fix core dump caused by LikeColumnPredicate with nullable…

2022-10-10 Thread GitBox
github-actions[bot] commented on PR #13250: URL: https://github.com/apache/doris/pull/13250#issuecomment-1273111252 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] dataroaring merged pull request #13163: [regression](load)Open broker load regression test

2022-10-10 Thread GitBox
dataroaring merged PR #13163: URL: https://github.com/apache/doris/pull/13163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

[GitHub] [doris] pengxiangyu opened a new issue, #13254: [Feature] Add hide config to hide config in webserver for safety.

2022-10-10 Thread GitBox
pengxiangyu opened a new issue, #13254: URL: https://github.com/apache/doris/issues/13254 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Description Webser

[GitHub] [doris] pengxiangyu opened a new pull request, #13255: [feature](config)Add hide config to hide config in webserver for safety.

2022-10-10 Thread GitBox
pengxiangyu opened a new pull request, #13255: URL: https://github.com/apache/doris/pull/13255 # Proposed changes Issue Number: close #13254 ## Problem summary Webserver on BE has no authorization verification. Anyone can get the config for be. It is not safe for onli

[GitHub] [doris] BiteTheDDDDt opened a new pull request, #13256: [Enhancement](be-exec-version) add process when pblock.has_be_exec_version()=false

2022-10-10 Thread GitBox
BiteThet opened a new pull request, #13256: URL: https://github.com/apache/doris/pull/13256 # Proposed changes add process when pblock.has_be_exec_version()=false ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the ori

[GitHub] [doris] AshinGau opened a new pull request, #13257: [feature-wip](multi-catalog) optimize parquet profile & add null map timer

2022-10-10 Thread GitBox
AshinGau opened a new pull request, #13257: URL: https://github.com/apache/doris/pull/13257 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Ye

[GitHub] [doris] xinyiZzz commented on a diff in pull request #10170: [Enhancement](optimizer) Support select table sample

2022-10-10 Thread GitBox
xinyiZzz commented on code in PR #10170: URL: https://github.com/apache/doris/pull/10170#discussion_r991185692 ## fe/fe-core/src/main/java/org/apache/doris/analysis/TupleDescriptor.java: ## @@ -159,6 +164,80 @@ public void setTable(TableIf tbl) { table = tbl; } +

[GitHub] [doris] xinyiZzz commented on a diff in pull request #10170: [Enhancement](optimizer) Support select table sample

2022-10-10 Thread GitBox
xinyiZzz commented on code in PR #10170: URL: https://github.com/apache/doris/pull/10170#discussion_r991197443 ## fe/fe-core/src/main/java/org/apache/doris/analysis/TableSample.java: ## @@ -0,0 +1,101 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [doris] Gabriel39 opened a new pull request, #13258: [config](datev2) set `enable_date_conversion = true` by default

2022-10-10 Thread GitBox
Gabriel39 opened a new pull request, #13258: URL: https://github.com/apache/doris/pull/13258 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Y

[GitHub] [doris] xinyiZzz commented on a diff in pull request #10170: [Enhancement](optimizer) Support select table sample

2022-10-10 Thread GitBox
xinyiZzz commented on code in PR #10170: URL: https://github.com/apache/doris/pull/10170#discussion_r990934807 ## fe/fe-core/src/main/java/org/apache/doris/analysis/TableSample.java: ## @@ -0,0 +1,101 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [doris] xinyiZzz commented on a diff in pull request #10170: [Enhancement](optimizer) Support select table sample

2022-10-10 Thread GitBox
xinyiZzz commented on code in PR #10170: URL: https://github.com/apache/doris/pull/10170#discussion_r991268951 ## fe/fe-core/src/main/java/org/apache/doris/analysis/TupleDescriptor.java: ## @@ -159,6 +164,84 @@ public void setTable(TableIf tbl) { table = tbl; } +

[GitHub] [doris] xinyiZzz commented on a diff in pull request #10170: [Enhancement](optimizer) Support select table sample

2022-10-10 Thread GitBox
xinyiZzz commented on code in PR #10170: URL: https://github.com/apache/doris/pull/10170#discussion_r991269203 ## fe/fe-core/src/main/java/org/apache/doris/analysis/TupleDescriptor.java: ## @@ -159,6 +164,80 @@ public void setTable(TableIf tbl) { table = tbl; } +

[GitHub] [doris] xinyiZzz commented on pull request #10170: [Enhancement](optimizer) Support select table sample

2022-10-10 Thread GitBox
xinyiZzz commented on PR #10170: URL: https://github.com/apache/doris/pull/10170#issuecomment-1273290477 @morrySnow @weizhengte PTAL~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [doris] hello-stephen opened a new pull request, #13259: test benchmark pipeline

2022-10-10 Thread GitBox
hello-stephen opened a new pull request, #13259: URL: https://github.com/apache/doris/pull/13259 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [

[GitHub] [doris] github-actions[bot] commented on pull request #13259: test benchmark pipeline

2022-10-10 Thread GitBox
github-actions[bot] commented on PR #13259: URL: https://github.com/apache/doris/pull/13259#issuecomment-1273330241 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/3219583062";) output. shellcheck err

[GitHub] [doris] github-actions[bot] commented on pull request #12781: [Enhancement] Doris support obs broker load

2022-10-10 Thread GitBox
github-actions[bot] commented on PR #12781: URL: https://github.com/apache/doris/pull/12781#issuecomment-1273345173 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on pull request #13225: [fix](array-type) fix get_data_at for zero element array

2022-10-10 Thread GitBox
github-actions[bot] commented on PR #13225: URL: https://github.com/apache/doris/pull/13225#issuecomment-1273348777 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #13225: [fix](array-type) fix get_data_at for zero element array

2022-10-10 Thread GitBox
github-actions[bot] commented on PR #13225: URL: https://github.com/apache/doris/pull/13225#issuecomment-1273348827 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] Jibing-Li opened a new pull request, #13260: [Enhancement](broker)Support obs broker load

2022-10-10 Thread GitBox
Jibing-Li opened a new pull request, #13260: URL: https://github.com/apache/doris/pull/13260 # Proposed changes Issue Number: close #xxx ## Problem summary 1. Upgrade fs_broker module hadoop2.7.3->hadoop2.8.3 2. Support obs broker load This pr is based on https://gi

[GitHub] [doris] github-actions[bot] commented on pull request #13247: [fix](agg)count function should return 0 for null value

2022-10-10 Thread GitBox
github-actions[bot] commented on PR #13247: URL: https://github.com/apache/doris/pull/13247#issuecomment-1273517959 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #13247: [fix](agg)count function should return 0 for null value

2022-10-10 Thread GitBox
github-actions[bot] commented on PR #13247: URL: https://github.com/apache/doris/pull/13247#issuecomment-1273518007 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] xy720 opened a new pull request, #13261: [Fix] Disable schema change between array type columns

2022-10-10 Thread GitBox
xy720 opened a new pull request, #13261: URL: https://github.com/apache/doris/pull/13261 # Proposed changes Currently, we do not support schema change between array type columns. We should forbid users from doing this operation. ## Problem summary Describe your changes

[GitHub] [doris] xinyiZzz opened a new pull request, #13262: [enhancement](memtracker) Add independent and unique scanner mem tracker for each query

2022-10-10 Thread GitBox
xinyiZzz opened a new pull request, #13262: URL: https://github.com/apache/doris/pull/13262 # Proposed changes Issue Number: close #xxx ## Problem summary Count the memory consumption of Scanner, independent and unique for each query, this means that scnner memory do

[GitHub] [doris] xinyiZzz commented on pull request #13262: [enhancement](memtracker) Add independent and unique scanner mem tracker for each query

2022-10-10 Thread GitBox
xinyiZzz commented on PR #13262: URL: https://github.com/apache/doris/pull/13262#issuecomment-1273591675 @morningman CC -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [doris] morningman opened a new pull request, #13263: [fix](new-scann) scanner may be marked close twice

2022-10-10 Thread GitBox
morningman opened a new pull request, #13263: URL: https://github.com/apache/doris/pull/13263 # Proposed changes Issue Number: close #xxx ## Problem summary See comment in code for details. This bug will cause some scanners to exit early, resulting in missing query re

[GitHub] [doris] hf200012 merged pull request #13226: [refactor](datax)Refactoring doris writer code

2022-10-10 Thread GitBox
hf200012 merged PR #13226: URL: https://github.com/apache/doris/pull/13226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] liaoxin01 commented on a diff in pull request #13224: [fix](rowset) fix that rowset writer doesn't process the return value which may result in data loss

2022-10-10 Thread GitBox
liaoxin01 commented on code in PR #13224: URL: https://github.com/apache/doris/pull/13224#discussion_r991747785 ## be/src/olap/rowset/beta_rowset_writer.cpp: ## @@ -173,7 +173,11 @@ OLAPStatus BetaRowsetWriter::flush_single_memtable(MemTable* memtable, int64_t* RowsetSharedPtr

[GitHub] [doris] lsy3993 closed pull request #13132: [function](date function) add new date function 'first_month_day'

2022-10-10 Thread GitBox
lsy3993 closed pull request #13132: [function](date function) add new date function 'first_month_day' URL: https://github.com/apache/doris/pull/13132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [doris] Gabriel39 opened a new pull request, #13266: [Regression](javaudf) add regression test for javaudf

2022-10-10 Thread GitBox
Gabriel39 opened a new pull request, #13266: URL: https://github.com/apache/doris/pull/13266 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Y

[GitHub] [doris] github-actions[bot] commented on pull request #13266: [Regression](javaudf) add regression test for javaudf

2022-10-10 Thread GitBox
github-actions[bot] commented on PR #13266: URL: https://github.com/apache/doris/pull/13266#issuecomment-1273990059 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/3223608884";) output. shellcheck err

[GitHub] [doris] xinyiZzz commented on a diff in pull request #10170: [Enhancement](optimizer) Support select table sample

2022-10-10 Thread GitBox
xinyiZzz commented on code in PR #10170: URL: https://github.com/apache/doris/pull/10170#discussion_r991268951 ## fe/fe-core/src/main/java/org/apache/doris/analysis/TupleDescriptor.java: ## @@ -159,6 +164,84 @@ public void setTable(TableIf tbl) { table = tbl; } +

[GitHub] [doris] yangzhg opened a new pull request, #13267: [fix](DynamicPartition) Not check max_dynamic_partition_num when disable DynamicPartition

2022-10-10 Thread GitBox
yangzhg opened a new pull request, #13267: URL: https://github.com/apache/doris/pull/13267 # Proposed changes Disable max_dynamic_partition_num check when disable DynamicPartition by `ALTER TABLE tbl_name SET ("dynamic_partition.enable" = "false")`, when `max_dynamic_partition_num`

[GitHub] [doris] adonis0147 opened a new issue, #13268: [Bug](be-ut)(aarch64) "sched_to itself" errors occur when running BE UT.

2022-10-10 Thread GitBox
adonis0147 opened a new issue, #13268: URL: https://github.com/apache/doris/issues/13268 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/incubator-doris/issues?q=is%3Aissue) and found no similar issues. ### Version Doris versi

[GitHub] [doris] liaoxin01 opened a new pull request, #13269: [enhancement](storage) set the segment cache capacity according to the open file limit of the process

2022-10-10 Thread GitBox
liaoxin01 opened a new pull request, #13269: URL: https://github.com/apache/doris/pull/13269 # Proposed changes Issue Number: close #xxx ## Problem summary Now segment_cache_capacity is 100, which usually exceeds open file limit. A large number of file descriptor

[GitHub] [doris] adonis0147 opened a new pull request, #13270: [Bug](aarch64) Fix the BRPC "sched_to itself" error when building BE by Clang on Linux aarch64

2022-10-10 Thread GitBox
adonis0147 opened a new pull request, #13270: URL: https://github.com/apache/doris/pull/13270 # Proposed changes Issue Number: close #13268 ## Problem summary Upstream BRPC fixed this bug for GCC compiler. (commit: [c271e2e0](https://github.com/apache/incubator-brpc/com

[GitHub] [doris] dataroaring commented on a diff in pull request #13269: [enhancement](storage) set the segment cache capacity according to the open file limit of the process

2022-10-10 Thread GitBox
dataroaring commented on code in PR #13269: URL: https://github.com/apache/doris/pull/13269#discussion_r991762793 ## be/src/runtime/exec_env_init.cpp: ## @@ -287,7 +287,20 @@ Status ExecEnv::_init_mem_tracker() { << PrettyPrinter::print(storage_cache_limit, TUnit:

[GitHub] [doris] pengxiangyu commented on a diff in pull request #12897: [feature](remote) support local cache GC by disk usage

2022-10-10 Thread GitBox
pengxiangyu commented on code in PR #12897: URL: https://github.com/apache/doris/pull/12897#discussion_r991766090 ## be/src/io/cache/file_cache_manager.cpp: ## @@ -56,92 +82,101 @@ void FileCacheManager::remove_file_cache(const std::string& cache_path) { } } -void FileC

[GitHub] [doris] Kikyou1997 opened a new pull request, #13271: [fix](regression) Remove unstable unstable regression test for nereids

2022-10-10 Thread GitBox
Kikyou1997 opened a new pull request, #13271: URL: https://github.com/apache/doris/pull/13271 # Proposed changes Issue Number: noissue ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes

[GitHub] [doris] Kikyou1997 commented on pull request #13271: [fix](regression) Remove unstable unstable regression test for nereids

2022-10-10 Thread GitBox
Kikyou1997 commented on PR #13271: URL: https://github.com/apache/doris/pull/13271#issuecomment-1274019075 @morrySnow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [doris] morrySnow merged pull request #13243: [Enhancement](nereids) Remove redundant log when fall back to stale parser

2022-10-10 Thread GitBox
morrySnow merged PR #13243: URL: https://github.com/apache/doris/pull/13243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[GitHub] [doris] morrySnow opened a new pull request, #13272: [regression](Nereids) temporary remove test case 'tpch q21' until we fix it

2022-10-10 Thread GitBox
morrySnow opened a new pull request, #13272: URL: https://github.com/apache/doris/pull/13272 # Proposed changes Issue Number: close #xxx ## Problem summary NPE thrown when we run regression test tpc-h q21 on Nereids ## Checklist(Required) 1. Does it affect t

[GitHub] [doris] github-actions[bot] commented on pull request #13263: [fix](new-scann) scanner may be marked close twice

2022-10-10 Thread GitBox
github-actions[bot] commented on PR #13263: URL: https://github.com/apache/doris/pull/13263#issuecomment-1274038827 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] jacktengg opened a new pull request, #13273: [improvement](schema change) avoid using column ptr swap

2022-10-10 Thread GitBox
jacktengg opened a new pull request, #13273: URL: https://github.com/apache/doris/pull/13273 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Y

[GitHub] [doris] LemonLiTree opened a new pull request, #13274: [typo](docs)delete duplicate document and fix some problem

2022-10-10 Thread GitBox
LemonLiTree opened a new pull request, #13274: URL: https://github.com/apache/doris/pull/13274 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ]

[GitHub] [doris] github-actions[bot] commented on pull request #13274: [typo](docs)delete duplicate document and fix some problem

2022-10-10 Thread GitBox
github-actions[bot] commented on PR #13274: URL: https://github.com/apache/doris/pull/13274#issuecomment-1274054069 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] dataroaring merged pull request #13271: [fix](regression) Remove unstable regression test for nereids

2022-10-10 Thread GitBox
dataroaring merged PR #13271: URL: https://github.com/apache/doris/pull/13271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

[GitHub] [doris] LemonLiTree commented on issue #13251: [Bug] BE日志告警UpdateDerivedVars is too busy!服务器卡住

2022-10-10 Thread GitBox
LemonLiTree commented on issue #13251: URL: https://github.com/apache/doris/issues/13251#issuecomment-1274060622 Hi,看下是不是OOM问题,是否做了内存使用限制? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [doris] github-actions[bot] commented on pull request #13259: test benchmark pipeline

2022-10-10 Thread GitBox
github-actions[bot] commented on PR #13259: URL: https://github.com/apache/doris/pull/13259#issuecomment-1274066196 `sh-checker report` To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/3224086064";) output. shellcheck err

[GitHub] [doris] mrhhsg opened a new pull request, #13275: cherry-pick #11516 and #11822 from master

2022-10-10 Thread GitBox
mrhhsg opened a new pull request, #13275: URL: https://github.com/apache/doris/pull/13275 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Yes

[GitHub] [doris] Gabriel39 opened a new pull request, #13276: [function](datev2) Complements for datev2 functions

2022-10-10 Thread GitBox
Gabriel39 opened a new pull request, #13276: URL: https://github.com/apache/doris/pull/13276 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) 1. Does it affect the original behavior: - [ ] Y

[GitHub] [doris] github-actions[bot] commented on pull request #13274: [typo](docs)delete duplicate document and fix some problem

2022-10-10 Thread GitBox
github-actions[bot] commented on PR #13274: URL: https://github.com/apache/doris/pull/13274#issuecomment-1274075809 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

<    11   12   13   14   15   16   17   18   19   20   >