Re: [PR] add code check for fe request [doris-spark-connector]

2025-04-24 Thread via GitHub
JNSimba merged PR #309: URL: https://github.com/apache/doris-spark-connector/pull/309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

Re: [PR] add code check for fe request [doris-spark-connector]

2025-04-20 Thread via GitHub
wary commented on PR #309: URL: https://github.com/apache/doris-spark-connector/pull/309#issuecomment-2817530829 > Hi, there is a conflict in import. You can use doris's checkstyle. You can refer to https://doris.apache.org/zh-CN/community/developer-guide/java-format-code#checkstyle-%E6%8F

Re: [PR] add code check for fe request [doris-spark-connector]

2025-04-20 Thread via GitHub
JNSimba commented on PR #309: URL: https://github.com/apache/doris-spark-connector/pull/309#issuecomment-2817497652 Hi, there is a conflict in import. You can use doris's checkstyle. You can refer to https://doris.apache.org/zh-CN/community/developer-guide/java-format-code#checkstyle-%E6%

Re: [PR] add code check for fe request [doris-spark-connector]

2025-04-20 Thread via GitHub
wary commented on code in PR #309: URL: https://github.com/apache/doris-spark-connector/pull/309#discussion_r2051702813 ## spark-doris-connector/spark-doris-connector-base/src/main/java/org/apache/doris/spark/client/DorisFrontendClient.java: ## @@ -49,11 +48,7 @@ import java

Re: [PR] add code check for fe request [doris-spark-connector]

2025-04-18 Thread via GitHub
JNSimba commented on code in PR #309: URL: https://github.com/apache/doris-spark-connector/pull/309#discussion_r2050517015 ## spark-doris-connector/spark-doris-connector-base/src/main/java/org/apache/doris/spark/client/DorisFrontendClient.java: ## @@ -49,11 +48,7 @@ import j

Re: [PR] add code check for fe request [doris-spark-connector]

2025-04-17 Thread via GitHub
wary commented on code in PR #309: URL: https://github.com/apache/doris-spark-connector/pull/309#discussion_r2048727438 ## spark-doris-connector/spark-doris-connector-base/src/main/java/org/apache/doris/spark/client/DorisFrontendClient.java: ## @@ -114,7 +115,13 @@ private List

Re: [PR] add code check for fe request [doris-spark-connector]

2025-04-17 Thread via GitHub
JNSimba commented on code in PR #309: URL: https://github.com/apache/doris-spark-connector/pull/309#discussion_r2048618422 ## spark-doris-connector/spark-doris-connector-base/src/main/java/org/apache/doris/spark/client/DorisFrontendClient.java: ## @@ -114,7 +115,13 @@ private L

Re: [PR] add code check for fe request [doris-spark-connector]

2025-04-16 Thread via GitHub
wary commented on code in PR #309: URL: https://github.com/apache/doris-spark-connector/pull/309#discussion_r2048183473 ## spark-doris-connector/spark-doris-connector-base/src/main/java/org/apache/doris/spark/client/DorisFrontendClient.java: ## @@ -114,7 +115,13 @@ private List

Re: [PR] add code check for fe request [doris-spark-connector]

2025-04-16 Thread via GitHub
wary commented on code in PR #309: URL: https://github.com/apache/doris-spark-connector/pull/309#discussion_r2048183473 ## spark-doris-connector/spark-doris-connector-base/src/main/java/org/apache/doris/spark/client/DorisFrontendClient.java: ## @@ -114,7 +115,13 @@ private List

Re: [PR] add code check for fe request [doris-spark-connector]

2025-04-14 Thread via GitHub
JNSimba commented on code in PR #309: URL: https://github.com/apache/doris-spark-connector/pull/309#discussion_r2043440082 ## spark-doris-connector/spark-doris-connector-base/src/main/java/org/apache/doris/spark/client/DorisFrontendClient.java: ## @@ -114,7 +115,13 @@ private L

Re: [PR] add code check for fe request [doris-spark-connector]

2025-04-14 Thread via GitHub
JNSimba commented on code in PR #309: URL: https://github.com/apache/doris-spark-connector/pull/309#discussion_r2041772359 ## spark-doris-connector/spark-doris-connector-base/src/main/java/org/apache/doris/spark/client/DorisFrontendClient.java: ## @@ -114,7 +114,12 @@ private L

Re: [PR] add code check for fe request [doris-spark-connector]

2025-04-14 Thread via GitHub
wary commented on code in PR #309: URL: https://github.com/apache/doris-spark-connector/pull/309#discussion_r2041816877 ## spark-doris-connector/spark-doris-connector-base/src/main/java/org/apache/doris/spark/client/DorisFrontendClient.java: ## @@ -114,7 +114,12 @@ private List

Re: [PR] add code check for fe request [doris-spark-connector]

2025-04-14 Thread via GitHub
wary commented on code in PR #309: URL: https://github.com/apache/doris-spark-connector/pull/309#discussion_r2041783466 ## spark-doris-connector/spark-doris-connector-base/src/main/java/org/apache/doris/spark/client/DorisFrontendClient.java: ## @@ -114,7 +114,12 @@ private List

Re: [PR] add code check for fe request [doris-spark-connector]

2025-04-14 Thread via GitHub
wary commented on code in PR #309: URL: https://github.com/apache/doris-spark-connector/pull/309#discussion_r2041783466 ## spark-doris-connector/spark-doris-connector-base/src/main/java/org/apache/doris/spark/client/DorisFrontendClient.java: ## @@ -114,7 +114,12 @@ private List