Re: [PR] [opt](memory) Refactor memory maintenance thread [doris]

2024-09-08 Thread via GitHub
xinyiZzz merged PR #40344: URL: https://github.com/apache/doris/pull/40344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [opt](memory) Refactor memory maintenance thread [doris]

2024-09-08 Thread via GitHub
github-actions[bot] commented on PR #40344: URL: https://github.com/apache/doris/pull/40344#issuecomment-2337069289 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [opt](memory) Refactor memory maintenance thread [doris]

2024-09-05 Thread via GitHub
doris-robot commented on PR #40344: URL: https://github.com/apache/doris/pull/40344#issuecomment-2331151388 TPC-H: Total hot run time: 38540 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [opt](memory) Refactor memory maintenance thread [doris]

2024-09-05 Thread via GitHub
xinyiZzz commented on code in PR #40344: URL: https://github.com/apache/doris/pull/40344#discussion_r1745055064 ## be/src/olap/lru_cache.cpp: ## @@ -580,6 +626,24 @@ ShardedLRUCache::~ShardedLRUCache() { } } +PrunedInfo ShardedLRUCache::set_capacity(size_t capacity) { R

Re: [PR] [opt](memory) Refactor memory maintenance thread [doris]

2024-09-04 Thread via GitHub
xinyiZzz commented on code in PR #40344: URL: https://github.com/apache/doris/pull/40344#discussion_r1743172103 ## be/src/common/daemon.cpp: ## @@ -396,6 +472,34 @@ void Daemon::je_purge_dirty_pages_thread() const { } while (true); } +void Daemon::cache_adjust_capacity_t

Re: [PR] [opt](memory) Refactor memory maintenance thread [doris]

2024-09-03 Thread via GitHub
yiguolei commented on code in PR #40344: URL: https://github.com/apache/doris/pull/40344#discussion_r1743150517 ## be/src/common/daemon.cpp: ## @@ -396,6 +472,34 @@ void Daemon::je_purge_dirty_pages_thread() const { } while (true); } +void Daemon::cache_adjust_capacity_t

Re: [PR] [opt](memory) Refactor memory maintenance thread [doris]

2024-09-03 Thread via GitHub
yiguolei commented on code in PR #40344: URL: https://github.com/apache/doris/pull/40344#discussion_r1743147711 ## be/src/common/daemon.cpp: ## @@ -396,6 +472,34 @@ void Daemon::je_purge_dirty_pages_thread() const { } while (true); } +void Daemon::cache_adjust_capacity_t

Re: [PR] [opt](memory) Refactor memory maintenance thread [doris]

2024-09-03 Thread via GitHub
yiguolei commented on code in PR #40344: URL: https://github.com/apache/doris/pull/40344#discussion_r1743140436 ## be/src/common/daemon.cpp: ## @@ -204,42 +204,110 @@ void Daemon::tcmalloc_gc_thread() { #endif } +void refresh_process_memory_metrics() { +doris::PerfCounte

Re: [PR] [opt](memory) Refactor memory maintenance thread [doris]

2024-09-03 Thread via GitHub
yiguolei commented on code in PR #40344: URL: https://github.com/apache/doris/pull/40344#discussion_r174352 ## be/src/common/daemon.cpp: ## @@ -204,42 +204,110 @@ void Daemon::tcmalloc_gc_thread() { #endif } +void refresh_process_memory_metrics() { +doris::PerfCounte

Re: [PR] [opt](memory) Refactor memory maintenance thread [doris]

2024-09-03 Thread via GitHub
doris-robot commented on PR #40344: URL: https://github.com/apache/doris/pull/40344#issuecomment-2327104090 TeamCity be ut coverage result: Function Coverage: 36.80% (9382/25492) Line Coverage: 28.26% (77427/273985) Region Coverage: 27.65% (39943/17) Branch Coverage: 24.3

Re: [PR] [opt](memory) Refactor memory maintenance thread [doris]

2024-09-03 Thread via GitHub
doris-robot commented on PR #40344: URL: https://github.com/apache/doris/pull/40344#issuecomment-2327102466 ClickBench: Total hot run time: 33.54 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [opt](memory) Refactor memory maintenance thread [doris]

2024-09-03 Thread via GitHub
doris-robot commented on PR #40344: URL: https://github.com/apache/doris/pull/40344#issuecomment-2327093400 TPC-DS: Total hot run time: 195610 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [opt](memory) Refactor memory maintenance thread [doris]

2024-09-03 Thread via GitHub
doris-robot commented on PR #40344: URL: https://github.com/apache/doris/pull/40344#issuecomment-2327074147 TPC-H: Total hot run time: 39328 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [opt](memory) Refactor memory maintenance thread [doris]

2024-09-03 Thread via GitHub
github-actions[bot] commented on code in PR #40344: URL: https://github.com/apache/doris/pull/40344#discussion_r1742341562 ## be/src/olap/lru_cache.cpp: ## @@ -177,6 +177,52 @@ LRUCache::~LRUCache() { prune(); } +PrunedInfo LRUCache::set_capacity(size_t capacity) { +

Re: [PR] [opt](memory) Refactor memory maintenance thread [doris]

2024-09-03 Thread via GitHub
doris-robot commented on PR #40344: URL: https://github.com/apache/doris/pull/40344#issuecomment-2326911401 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [opt](memory) Refactor memory maintenance thread [doris]

2024-09-03 Thread via GitHub
xinyiZzz commented on PR #40344: URL: https://github.com/apache/doris/pull/40344#issuecomment-2326911550 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns