Re: [PR] [opt](index compaction) optimize checks before index compaction [doris]

2023-10-25 Thread via GitHub
xiaokang merged PR #25486: URL: https://github.com/apache/doris/pull/25486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [opt](index compaction) optimize checks before index compaction [doris]

2023-10-23 Thread via GitHub
github-actions[bot] commented on PR #25486: URL: https://github.com/apache/doris/pull/25486#issuecomment-1774584203 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [opt](index compaction) optimize checks before index compaction [doris]

2023-10-23 Thread via GitHub
github-actions[bot] commented on PR #25486: URL: https://github.com/apache/doris/pull/25486#issuecomment-1774584141 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [opt](index compaction) optimize checks before index compaction [doris]

2023-10-16 Thread via GitHub
qidaye commented on code in PR #25486: URL: https://github.com/apache/doris/pull/25486#discussion_r1361434414 ## be/src/olap/compaction.cpp: ## @@ -567,10 +573,48 @@ Status Compaction::construct_output_rowset_writer(RowsetWriterContext& ctx, bool

Re: [PR] [opt](index compaction) optimize checks before index compaction [doris]

2023-10-16 Thread via GitHub
airborne12 commented on code in PR #25486: URL: https://github.com/apache/doris/pull/25486#discussion_r1361413844 ## be/src/olap/compaction.cpp: ## @@ -567,10 +573,48 @@ Status Compaction::construct_output_rowset_writer(RowsetWriterContext& ctx, bool

Re: [PR] [opt](index compaction) optimize checks before index compaction [doris]

2023-10-16 Thread via GitHub
xiaokang commented on code in PR #25486: URL: https://github.com/apache/doris/pull/25486#discussion_r1361394122 ## be/src/olap/compaction.cpp: ## @@ -567,10 +573,48 @@ Status Compaction::construct_output_rowset_writer(RowsetWriterContext& ctx, bool

Re: [PR] [opt](index compaction) optimize checks before index compaction [doris]

2023-10-16 Thread via GitHub
doris-robot commented on PR #25486: URL: https://github.com/apache/doris/pull/25486#issuecomment-1764290382 (From new machine)TeamCity pipeline, clickbench performance test result: the sum of best hot time: 45.78 seconds stream load tsv: 572 seconds loaded 74807831229 Bytes,

Re: [PR] [opt](index compaction) optimize checks before index compaction [doris]

2023-10-16 Thread via GitHub
doris-robot commented on PR #25486: URL: https://github.com/apache/doris/pull/25486#issuecomment-1764258824 TeamCity be ut coverage result: Function Coverage: 36.70% (8230/22423) Line Coverage: 28.84% (65960/228694) Region Coverage: 27.55% (34214/124169) Branch Coverage: 24.2

Re: [PR] [opt](index compaction) optimize checks before index compaction [doris]

2023-10-16 Thread via GitHub
github-actions[bot] commented on PR #25486: URL: https://github.com/apache/doris/pull/25486#issuecomment-1764244133 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [opt](index compaction) optimize checks before index compaction [doris]

2023-10-16 Thread via GitHub
github-actions[bot] commented on PR #25486: URL: https://github.com/apache/doris/pull/25486#issuecomment-1764235951 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [opt](index compaction) optimize checks before index compaction [doris]

2023-10-16 Thread via GitHub
qidaye commented on PR #25486: URL: https://github.com/apache/doris/pull/25486#issuecomment-1764231485 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub