Re: [PR] [fix](function) money format [doris]

2024-05-16 Thread via GitHub
yiguolei merged PR #34680: URL: https://github.com/apache/doris/pull/34680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] [fix](function) money format [doris]

2024-05-16 Thread via GitHub
HappenLee commented on PR #34680: URL: https://github.com/apache/doris/pull/34680#issuecomment-2115303853 run performance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](function) money format [doris]

2024-05-16 Thread via GitHub
doris-robot commented on PR #34680: URL: https://github.com/apache/doris/pull/34680#issuecomment-2114402489 ClickBench: Total hot run time: 30.38 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](function) money format [doris]

2024-05-16 Thread via GitHub
doris-robot commented on PR #34680: URL: https://github.com/apache/doris/pull/34680#issuecomment-2114380301 TPC-DS: Total hot run time: 188354 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](function) money format [doris]

2024-05-15 Thread via GitHub
github-actions[bot] commented on PR #34680: URL: https://github.com/apache/doris/pull/34680#issuecomment-2113903811 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](function) money format [doris]

2024-05-15 Thread via GitHub
doris-robot commented on PR #34680: URL: https://github.com/apache/doris/pull/34680#issuecomment-2111757438 ClickBench: Total hot run time: 31.4 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools C

Re: [PR] [fix](function) money format [doris]

2024-05-15 Thread via GitHub
doris-robot commented on PR #34680: URL: https://github.com/apache/doris/pull/34680#issuecomment-2111748134 TPC-DS: Total hot run time: 186790 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](function) money format [doris]

2024-05-14 Thread via GitHub
doris-robot commented on PR #34680: URL: https://github.com/apache/doris/pull/34680#issuecomment-2111724707 TPC-H: Total hot run time: 40606 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](function) money format [doris]

2024-05-14 Thread via GitHub
zhiqiang- commented on PR #34680: URL: https://github.com/apache/doris/pull/34680#issuecomment-2111684028 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [fix](function) money format [doris]

2024-05-14 Thread via GitHub
zhiqiang- commented on code in PR #34680: URL: https://github.com/apache/doris/pull/34680#discussion_r1600920451 ## be/src/vec/functions/function_string.h: ## @@ -3058,70 +3121,55 @@ struct MoneyFormatDecimalImpl { size_t input_rows_count) {

Re: [PR] [Fix](function) money format [doris]

2024-05-14 Thread via GitHub
jacktengg commented on code in PR #34680: URL: https://github.com/apache/doris/pull/34680#discussion_r1599563003 ## be/src/vec/functions/function_string.h: ## @@ -3058,70 +3121,55 @@ struct MoneyFormatDecimalImpl { size_t input_rows_count) { if

Re: [PR] [Fix](function) money format [doris]

2024-05-14 Thread via GitHub
jacktengg commented on code in PR #34680: URL: https://github.com/apache/doris/pull/34680#discussion_r1599563003 ## be/src/vec/functions/function_string.h: ## @@ -3058,70 +3121,55 @@ struct MoneyFormatDecimalImpl { size_t input_rows_count) { if

Re: [PR] [Fix](function) money format [doris]

2024-05-14 Thread via GitHub
jacktengg commented on code in PR #34680: URL: https://github.com/apache/doris/pull/34680#discussion_r1599563003 ## be/src/vec/functions/function_string.h: ## @@ -3058,70 +3121,55 @@ struct MoneyFormatDecimalImpl { size_t input_rows_count) { if

Re: [PR] [Fix](function) money format [doris]

2024-05-14 Thread via GitHub
jacktengg commented on code in PR #34680: URL: https://github.com/apache/doris/pull/34680#discussion_r1599563003 ## be/src/vec/functions/function_string.h: ## @@ -3058,70 +3121,55 @@ struct MoneyFormatDecimalImpl { size_t input_rows_count) { if

Re: [PR] [Fix](function) money format [doris]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #34680: URL: https://github.com/apache/doris/pull/34680#issuecomment-2109439459 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Fix](function) money format [doris]

2024-05-14 Thread via GitHub
github-actions[bot] commented on PR #34680: URL: https://github.com/apache/doris/pull/34680#issuecomment-2109439404 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Fix](function) money format [doris]

2024-05-13 Thread via GitHub
zhiqiang- commented on PR #34680: URL: https://github.com/apache/doris/pull/34680#issuecomment-2109371845 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [Fix](function) money format [doris]

2024-05-13 Thread via GitHub
zhiqiang- commented on code in PR #34680: URL: https://github.com/apache/doris/pull/34680#discussion_r1599313151 ## be/src/vec/functions/function_string.h: ## @@ -2961,18 +2965,77 @@ class FunctionMoneyFormat : public IFunction { namespace MoneyFormat { +constexpr size_

Re: [PR] [Fix](function) money format [doris]

2024-05-13 Thread via GitHub
jacktengg commented on code in PR #34680: URL: https://github.com/apache/doris/pull/34680#discussion_r1599312403 ## be/src/vec/functions/function_string.h: ## @@ -2961,18 +2965,77 @@ class FunctionMoneyFormat : public IFunction { namespace MoneyFormat { +constexpr size_t MA

Re: [PR] [Fix](function) money format [doris]

2024-05-13 Thread via GitHub
zhiqiang- commented on PR #34680: URL: https://github.com/apache/doris/pull/34680#issuecomment-2109140487 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [Fix](function) money format [doris]

2024-05-11 Thread via GitHub
zhiqiang- commented on PR #34680: URL: https://github.com/apache/doris/pull/34680#issuecomment-2105746901 run cloud_p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [Fix](function) money format [doris]

2024-05-11 Thread via GitHub
doris-robot commented on PR #34680: URL: https://github.com/apache/doris/pull/34680#issuecomment-2105724733 TPC-DS: Total hot run time: 186889 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Fix](function) money format [doris]

2024-05-11 Thread via GitHub
doris-robot commented on PR #34680: URL: https://github.com/apache/doris/pull/34680#issuecomment-2105701125 TPC-H: Total hot run time: 41831 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100