Re: [PR] [fix](array-funcs)fix array funcs which ret can be nullable [doris]

2024-11-06 Thread via GitHub
eldenmoon merged PR #43243: URL: https://github.com/apache/doris/pull/43243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [fix](array-funcs)fix array funcs which ret can be nullable [doris]

2024-11-05 Thread via GitHub
doris-robot commented on PR #43243: URL: https://github.com/apache/doris/pull/43243#issuecomment-2458913996 TPC-DS: Total hot run time: 193041 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](array-funcs)fix array funcs which ret can be nullable [doris]

2024-11-05 Thread via GitHub
doris-robot commented on PR #43243: URL: https://github.com/apache/doris/pull/43243#issuecomment-2458922160 ClickBench: Total hot run time: 32.62 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [fix](array-funcs)fix array funcs which ret can be nullable [doris]

2024-11-05 Thread via GitHub
doris-robot commented on PR #43243: URL: https://github.com/apache/doris/pull/43243#issuecomment-2458896493 TPC-H: Total hot run time: 41365 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](array-funcs)fix array funcs which ret can be nullable [doris]

2024-11-05 Thread via GitHub
doris-robot commented on PR #43243: URL: https://github.com/apache/doris/pull/43243#issuecomment-2458863128 TeamCity be ut coverage result: Function Coverage: 37.89% (9847/25989) Line Coverage: 29.04% (81865/281897) Region Coverage: 28.27% (42174/149174) Branch Coverage: 24.8

Re: [PR] [fix](array-funcs)fix array funcs which ret can be nullable [doris]

2024-11-05 Thread via GitHub
github-actions[bot] commented on PR #43243: URL: https://github.com/apache/doris/pull/43243#issuecomment-2458806806 ## Possible file(s) that should be tracked in LFS detected: 🚨 The following file(s) exceeds the file size limit: `1048576` bytes, as set in the .yml configuration files

Re: [PR] [fix](array-funcs)fix array funcs which ret can be nullable [doris]

2024-11-05 Thread via GitHub
github-actions[bot] commented on PR #43243: URL: https://github.com/apache/doris/pull/43243#issuecomment-2458812544 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](array-funcs)fix array funcs which ret can be nullable [doris]

2024-11-05 Thread via GitHub
amorynan commented on PR #43243: URL: https://github.com/apache/doris/pull/43243#issuecomment-2458806629 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](array-funcs)fix array funcs which ret can be nullable [doris]

2024-11-05 Thread via GitHub
amorynan commented on code in PR #43243: URL: https://github.com/apache/doris/pull/43243#discussion_r1830444512 ## be/src/vec/functions/array/function_array_index.h: ## @@ -217,7 +217,7 @@ class FunctionArrayIndex : public IFunction { const auto& right_chars = reinterpr

Re: [PR] [fix](array-funcs)fix array funcs which ret can be nullable [doris]

2024-11-05 Thread via GitHub
airborne12 commented on code in PR #43243: URL: https://github.com/apache/doris/pull/43243#discussion_r1830442635 ## be/src/vec/functions/array/function_array_index.h: ## @@ -217,7 +217,7 @@ class FunctionArrayIndex : public IFunction { const auto& right_chars = reinter

Re: [PR] [fix](array-funcs)fix array funcs which ret can be nullable [doris]

2024-11-05 Thread via GitHub
amorynan commented on code in PR #43243: URL: https://github.com/apache/doris/pull/43243#discussion_r1830296111 ## be/src/vec/functions/array/function_array_index.h: ## @@ -217,7 +217,7 @@ class FunctionArrayIndex : public IFunction { const auto& right_chars = reinterpr

Re: [PR] [fix](array-funcs)fix array funcs which ret can be nullable [doris]

2024-11-05 Thread via GitHub
doris-robot commented on PR #43243: URL: https://github.com/apache/doris/pull/43243#issuecomment-2456361423 ClickBench: Total hot run time: 32.9 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools C

Re: [PR] [fix](array-funcs)fix array funcs which ret can be nullable [doris]

2024-11-05 Thread via GitHub
airborne12 commented on code in PR #43243: URL: https://github.com/apache/doris/pull/43243#discussion_r1828880814 ## be/src/vec/functions/array/function_array_index.h: ## @@ -217,7 +217,7 @@ class FunctionArrayIndex : public IFunction { const auto& right_chars = reinter

Re: [PR] [fix](array-funcs)fix array funcs which ret can be nullable [doris]

2024-11-04 Thread via GitHub
eldenmoon commented on code in PR #43243: URL: https://github.com/apache/doris/pull/43243#discussion_r1828814903 ## regression-test/suites/inverted_index_p0/test_array_with_inverted_index_all_type.groovy: ## @@ -267,6 +267,10 @@ suite("test_array_with_inverted_index_all_type"){

Re: [PR] [fix](array-funcs)fix array funcs which ret can be nullable [doris]

2024-11-04 Thread via GitHub
amorynan commented on code in PR #43243: URL: https://github.com/apache/doris/pull/43243#discussion_r1828816525 ## regression-test/suites/inverted_index_p0/test_array_with_inverted_index_all_type.groovy: ## @@ -267,6 +267,10 @@ suite("test_array_with_inverted_index_all_type"){

Re: [PR] [fix](array-funcs)fix array funcs which ret can be nullable [doris]

2024-11-04 Thread via GitHub
github-actions[bot] commented on PR #43243: URL: https://github.com/apache/doris/pull/43243#issuecomment-2456372387 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](array-funcs)fix array funcs which ret can be nullable [doris]

2024-11-04 Thread via GitHub
github-actions[bot] commented on PR #43243: URL: https://github.com/apache/doris/pull/43243#issuecomment-2456372326 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](array-funcs)fix array funcs which ret can be nullable [doris]

2024-11-04 Thread via GitHub
doris-robot commented on PR #43243: URL: https://github.com/apache/doris/pull/43243#issuecomment-2456354474 TPC-DS: Total hot run time: 195804 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](array-funcs)fix array funcs which ret can be nullable [doris]

2024-11-04 Thread via GitHub
doris-robot commented on PR #43243: URL: https://github.com/apache/doris/pull/43243#issuecomment-2456331385 TPC-H: Total hot run time: 41179 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](array-funcs)fix array funcs which ret can be nullable [doris]

2024-11-04 Thread via GitHub
doris-robot commented on PR #43243: URL: https://github.com/apache/doris/pull/43243#issuecomment-2456331157 TeamCity be ut coverage result: Function Coverage: 37.80% (9820/25981) Line Coverage: 28.98% (81691/281925) Region Coverage: 28.22% (42114/149234) Branch Coverage: 24.8

Re: [PR] [fix](array-funcs)fix array funcs which ret can be nullable [doris]

2024-11-04 Thread via GitHub
amorynan commented on PR #43243: URL: https://github.com/apache/doris/pull/43243#issuecomment-2456284904 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](array-funcs)fix array funcs which ret can be nullable [doris]

2024-11-04 Thread via GitHub
github-actions[bot] commented on PR #43243: URL: https://github.com/apache/doris/pull/43243#issuecomment-2456285914 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](array-funcs)fix array funcs which ret can be nullable [doris]

2024-11-04 Thread via GitHub
github-actions[bot] commented on PR #43243: URL: https://github.com/apache/doris/pull/43243#issuecomment-2456281570 ## Possible file(s) that should be tracked in LFS detected: 🚨 The following file(s) exceeds the file size limit: `1048576` bytes, as set in the .yml configuration files

Re: [PR] [fix](array-funcs)fix array funcs which ret can be nullable [doris]

2024-11-04 Thread via GitHub
doris-robot commented on PR #43243: URL: https://github.com/apache/doris/pull/43243#issuecomment-2456280799 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y