Re: [PR] [feature] multiple tables to one [doris-flink-connector]

2023-11-06 Thread via GitHub
JNSimba merged PR #208: URL: https://github.com/apache/doris-flink-connector/pull/208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

Re: [PR] [feature] multiple tables to one [doris-flink-connector]

2023-10-29 Thread via GitHub
JNSimba commented on code in PR #208: URL: https://github.com/apache/doris-flink-connector/pull/208#discussion_r1375590173 ## flink-doris-connector/src/test/java/org/apache/doris/flink/tools/cdc/DatabaseSyncTest.java: ## @@ -0,0 +1,29 @@ +package org.apache.doris.flink.tools.cd

Re: [PR] [feature] multiple tables to one [doris-flink-connector]

2023-10-19 Thread via GitHub
codeAntg commented on code in PR #208: URL: https://github.com/apache/doris-flink-connector/pull/208#discussion_r1365364776 ## flink-doris-connector/src/test/java/org/apache/doris/flink/tools/cdc/CdcPostgresSyncDatabaseCase.java: ## @@ -61,23 +61,27 @@ public static void main(S

Re: [PR] [feature] multiple tables to one [doris-flink-connector]

2023-10-19 Thread via GitHub
codeAntg commented on code in PR #208: URL: https://github.com/apache/doris-flink-connector/pull/208#discussion_r1365340877 ## flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DatabaseSync.java: ## @@ -235,11 +243,36 @@ protected boolean isSyncNeeded(String

Re: [PR] [feature] multiple tables to one [doris-flink-connector]

2023-10-19 Thread via GitHub
codeAntg commented on code in PR #208: URL: https://github.com/apache/doris-flink-connector/pull/208#discussion_r1365340150 ## flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DatabaseSync.java: ## @@ -72,16 +76,19 @@ public abstract class DatabaseSync {

Re: [PR] [feature] multiple tables to one [doris-flink-connector]

2023-10-19 Thread via GitHub
codeAntg commented on code in PR #208: URL: https://github.com/apache/doris-flink-connector/pull/208#discussion_r1365338326 ## flink-doris-connector/src/test/java/org/apache/doris/flink/tools/cdc/CdcPostgresSyncDatabaseCase.java: ## @@ -61,23 +61,27 @@ public static void main(S

Re: [PR] [feature] multiple tables to one [doris-flink-connector]

2023-10-18 Thread via GitHub
JNSimba commented on code in PR #208: URL: https://github.com/apache/doris-flink-connector/pull/208#discussion_r1364794870 ## flink-doris-connector/src/test/java/org/apache/doris/flink/tools/cdc/CdcPostgresSyncDatabaseCase.java: ## @@ -61,23 +61,27 @@ public static void main(St

Re: [PR] [feature] multiple tables to one [doris-flink-connector]

2023-10-18 Thread via GitHub
JNSimba commented on code in PR #208: URL: https://github.com/apache/doris-flink-connector/pull/208#discussion_r1364794188 ## flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DatabaseSync.java: ## @@ -72,16 +76,19 @@ public abstract class DatabaseSync {

Re: [PR] [feature] multiple tables to one [doris-flink-connector]

2023-10-18 Thread via GitHub
JNSimba commented on code in PR #208: URL: https://github.com/apache/doris-flink-connector/pull/208#discussion_r1364792582 ## flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DatabaseSync.java: ## @@ -235,11 +243,36 @@ protected boolean isSyncNeeded(String t

Re: [PR] [feature] multiple tables to one [doris-flink-connector]

2023-10-18 Thread via GitHub
JNSimba commented on code in PR #208: URL: https://github.com/apache/doris-flink-connector/pull/208#discussion_r1364792582 ## flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DatabaseSync.java: ## @@ -235,11 +243,36 @@ protected boolean isSyncNeeded(String t

Re: [PR] [feature] multiple tables to one [doris-flink-connector]

2023-10-18 Thread via GitHub
codeAntg commented on code in PR #208: URL: https://github.com/apache/doris-flink-connector/pull/208#discussion_r1363423891 ## flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DatabaseSync.java: ## @@ -235,11 +243,36 @@ protected boolean isSyncNeeded(String

Re: [PR] [feature] multiple tables to one [doris-flink-connector]

2023-10-18 Thread via GitHub
codeAntg commented on PR #208: URL: https://github.com/apache/doris-flink-connector/pull/208#issuecomment-1767887233 Thank you for your advice, the code has been optimized, please check -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] [feature] multiple tables to one [doris-flink-connector]

2023-10-16 Thread via GitHub
JNSimba commented on code in PR #208: URL: https://github.com/apache/doris-flink-connector/pull/208#discussion_r1361567370 ## flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DatabaseSync.java: ## @@ -235,12 +250,35 @@ protected boolean isSyncNeeded(String t

Re: [PR] [feature] multiple tables to one [doris-flink-connector]

2023-10-16 Thread via GitHub
JNSimba commented on code in PR #208: URL: https://github.com/apache/doris-flink-connector/pull/208#discussion_r1361565975 ## flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DatabaseSync.java: ## @@ -250,8 +288,42 @@ public static class TableNameConverter i

Re: [PR] [feature] multiple tables to one [doris-flink-connector]

2023-10-16 Thread via GitHub
JNSimba commented on code in PR #208: URL: https://github.com/apache/doris-flink-connector/pull/208#discussion_r1361546046 ## flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DatabaseSync.java: ## @@ -108,15 +116,23 @@ public void build() throws Exception {

Re: [PR] [feature] multiple tables to one [doris-flink-connector]

2023-10-16 Thread via GitHub
JNSimba commented on code in PR #208: URL: https://github.com/apache/doris-flink-connector/pull/208#discussion_r1361483077 ## flink-doris-connector/src/main/java/org/apache/doris/flink/tools/cdc/DatabaseSync.java: ## @@ -108,15 +116,23 @@ public void build() throws Exception {