Re: [PR] [feature](variant) support sub schema for variant type [doris]

2025-04-10 Thread via GitHub
eldenmoon commented on PR #49768: URL: https://github.com/apache/doris/pull/49768#issuecomment-2782605253 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [feature](variant) support sub schema for variant type [doris]

2025-04-07 Thread via GitHub
eldenmoon merged PR #49768: URL: https://github.com/apache/doris/pull/49768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [feature](variant) support sub schema for variant type [doris]

2025-04-07 Thread via GitHub
eldenmoon commented on PR #49768: URL: https://github.com/apache/doris/pull/49768#issuecomment-2782906888 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [feature](variant) support sub schema for variant type [doris]

2025-04-07 Thread via GitHub
eldenmoon commented on code in PR #49768: URL: https://github.com/apache/doris/pull/49768#discussion_r2030811291 ## fe/fe-core/src/main/java/org/apache/doris/nereids/types/VariantType.java: ## @@ -59,8 +88,11 @@ public boolean acceptsType(DataType other) { } @Overrid

Re: [PR] [feature](variant) support sub schema for variant type [doris]

2025-04-07 Thread via GitHub
eldenmoon commented on code in PR #49768: URL: https://github.com/apache/doris/pull/49768#discussion_r2030847351 ## be/src/vec/columns/column_object.cpp: ## @@ -340,7 +344,46 @@ void get_field_info_impl(const Field& field, FieldInfo* info) { }; } +void get_base_field_in

Re: [PR] [feature](variant) support sub schema for variant type [doris]

2025-04-07 Thread via GitHub
eldenmoon commented on code in PR #49768: URL: https://github.com/apache/doris/pull/49768#discussion_r2030810789 ## fe/fe-common/src/main/java/org/apache/doris/catalog/VariantType.java: ## @@ -21,22 +21,105 @@ import org.apache.doris.thrift.TTypeNode; import org.apache.doris.t

Re: [PR] [feature](variant) support sub schema for variant type [doris]

2025-04-07 Thread via GitHub
eldenmoon commented on code in PR #49768: URL: https://github.com/apache/doris/pull/49768#discussion_r2030806454 ## fe/fe-common/src/main/java/org/apache/doris/catalog/ScalarType.java: ## @@ -1144,7 +1129,8 @@ public static ScalarType getAssignmentCompatibleType( }

Re: [PR] [feature](variant) support sub schema for variant type [doris]

2025-04-07 Thread via GitHub
csun5285 commented on code in PR #49768: URL: https://github.com/apache/doris/pull/49768#discussion_r2030773690 ## fe/fe-core/src/main/java/org/apache/doris/nereids/types/VariantType.java: ## @@ -59,8 +88,11 @@ public boolean acceptsType(DataType other) { } @Override

Re: [PR] [feature](variant) support sub schema for variant type [doris]

2025-04-07 Thread via GitHub
csun5285 commented on code in PR #49768: URL: https://github.com/apache/doris/pull/49768#discussion_r2030760034 ## fe/fe-common/src/main/java/org/apache/doris/catalog/VariantType.java: ## @@ -21,22 +21,105 @@ import org.apache.doris.thrift.TTypeNode; import org.apache.doris.th

Re: [PR] [feature](variant) support sub schema for variant type [doris]

2025-04-07 Thread via GitHub
csun5285 commented on code in PR #49768: URL: https://github.com/apache/doris/pull/49768#discussion_r2030763464 ## fe/fe-common/src/main/java/org/apache/doris/catalog/VariantType.java: ## @@ -21,22 +21,105 @@ import org.apache.doris.thrift.TTypeNode; import org.apache.doris.th

Re: [PR] [feature](variant) support sub schema for variant type [doris]

2025-04-07 Thread via GitHub
csun5285 commented on code in PR #49768: URL: https://github.com/apache/doris/pull/49768#discussion_r2030761547 ## fe/fe-common/src/main/java/org/apache/doris/catalog/ScalarType.java: ## @@ -1144,7 +1129,8 @@ public static ScalarType getAssignmentCompatibleType( }

Re: [PR] [feature](variant) support sub schema for variant type [doris]

2025-04-02 Thread via GitHub
hello-stephen commented on PR #49768: URL: https://github.com/apache/doris/pull/49768#issuecomment-2771861649 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+pro