github-actions[bot] commented on PR #42888:
URL: https://github.com/apache/doris/pull/42888#issuecomment-2484943933
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
zhangstar333 merged PR #42888:
URL: https://github.com/apache/doris/pull/42888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris
github-actions[bot] commented on PR #42888:
URL: https://github.com/apache/doris/pull/42888#issuecomment-2484943868
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
doris-robot commented on PR #42888:
URL: https://github.com/apache/doris/pull/42888#issuecomment-2484681724
TeamCity be ut coverage result:
Function Coverage: 38.01% (9898/26042)
Line Coverage: 29.20% (82788/283566)
Region Coverage: 28.33% (42514/150082)
Branch Coverage: 24.9
zhangstar333 commented on PR #42888:
URL: https://github.com/apache/doris/pull/42888#issuecomment-2484578701
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
doris-robot commented on PR #42888:
URL: https://github.com/apache/doris/pull/42888#issuecomment-2475759564
TeamCity be ut coverage result:
Function Coverage: 37.94% (9888/26060)
Line Coverage: 29.14% (82635/283583)
Region Coverage: 28.27% (42474/150234)
Branch Coverage: 24.8
zhangstar333 commented on PR #42888:
URL: https://github.com/apache/doris/pull/42888#issuecomment-2475576432
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
zhangstar333 commented on PR #42888:
URL: https://github.com/apache/doris/pull/42888#issuecomment-2472371431
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
doris-robot commented on PR #42888:
URL: https://github.com/apache/doris/pull/42888#issuecomment-2460299360
TeamCity be ut coverage result:
Function Coverage: 37.88% (9849/25998)
Line Coverage: 29.04% (81919/282043)
Region Coverage: 28.26% (42183/149244)
Branch Coverage: 24.8
HappenLee commented on code in PR #42888:
URL: https://github.com/apache/doris/pull/42888#discussion_r1830711165
##
be/src/vec/data_types/serde/data_type_number_serde.h:
##
@@ -121,14 +122,14 @@ Status
DataTypeNumberSerDe::read_column_from_pb(IColumn& column, const PValue
zhangstar333 commented on PR #42888:
URL: https://github.com/apache/doris/pull/42888#issuecomment-2459984487
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
HappenLee commented on code in PR #42888:
URL: https://github.com/apache/doris/pull/42888#discussion_r1830694089
##
be/src/vec/data_types/serde/data_type_decimal_serde.cpp:
##
@@ -246,11 +249,11 @@ template
Status DataTypeDecimalSerDe::write_column_to_orc(const std::string&
t
HappenLee commented on code in PR #42888:
URL: https://github.com/apache/doris/pull/42888#discussion_r1830692006
##
be/src/vec/data_types/serde/data_type_datev2_serde.cpp:
##
@@ -81,18 +82,18 @@ Status
DataTypeDateV2SerDe::deserialize_one_cell_from_json(IColumn& column, Slic
}
doris-robot commented on PR #42888:
URL: https://github.com/apache/doris/pull/42888#issuecomment-2451708343
TeamCity be ut coverage result:
Function Coverage: 37.81% (9819/25971)
Line Coverage: 28.99% (81607/281545)
Region Coverage: 28.26% (42142/149123)
Branch Coverage: 24.8
zhangstar333 commented on PR #42888:
URL: https://github.com/apache/doris/pull/42888#issuecomment-2451581170
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
zhangstar333 commented on PR #42888:
URL: https://github.com/apache/doris/pull/42888#issuecomment-2449472512
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
zhangstar333 commented on PR #42888:
URL: https://github.com/apache/doris/pull/42888#issuecomment-2448905885
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
zhangstar333 commented on code in PR #42888:
URL: https://github.com/apache/doris/pull/42888#discussion_r1822084453
##
be/src/vec/data_types/serde/data_type_array_serde.cpp:
##
@@ -220,19 +221,19 @@ Status
DataTypeArraySerDe::serialize_one_cell_to_hive_text(
void DataTypeArr
zhangstar333 commented on code in PR #42888:
URL: https://github.com/apache/doris/pull/42888#discussion_r1822083654
##
be/src/vec/data_types/serde/data_type_datetimev2_serde.cpp:
##
@@ -162,7 +166,7 @@ void
DataTypeDateTimeV2SerDe::read_column_from_arrow(IColumn& column,
zhangstar333 commented on code in PR #42888:
URL: https://github.com/apache/doris/pull/42888#discussion_r1822082887
##
be/src/vec/data_types/serde/data_type_bitmap_serde.cpp:
##
@@ -52,17 +53,17 @@ Status
DataTypeBitMapSerDe::deserialize_one_cell_from_json(IColumn& column, Slic
zhangstar333 commented on PR #42888:
URL: https://github.com/apache/doris/pull/42888#issuecomment-2446133899
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
github-actions[bot] commented on code in PR #42888:
URL: https://github.com/apache/doris/pull/42888#discussion_r1822069374
##
be/src/util/jsonb_writer.h:
##
@@ -415,11 +414,11 @@ class JsonbWriterT {
if (!stack_.empty() && stack_.top().state == WS_Object && kvState_ ==
doris-robot commented on PR #42888:
URL: https://github.com/apache/doris/pull/42888#issuecomment-2445857672
TeamCity be ut coverage result:
Function Coverage: 37.94% (9846/25949)
Line Coverage: 29.22% (82000/280635)
Region Coverage: 28.56% (42287/148051)
Branch Coverage: 25.0
HappenLee commented on code in PR #42888:
URL: https://github.com/apache/doris/pull/42888#discussion_r1821850017
##
be/src/vec/data_types/serde/data_type_decimal_serde.h:
##
@@ -134,8 +136,8 @@ class DataTypeDecimalSerDe : public DataTypeSerDe {
template
Status DataTypeDeci
HappenLee commented on code in PR #42888:
URL: https://github.com/apache/doris/pull/42888#discussion_r1821840047
##
be/src/vec/data_types/serde/data_type_datetimev2_serde.cpp:
##
@@ -162,7 +166,7 @@ void
DataTypeDateTimeV2SerDe::read_column_from_arrow(IColumn& column,
HappenLee commented on code in PR #42888:
URL: https://github.com/apache/doris/pull/42888#discussion_r1821836351
##
be/src/vec/data_types/serde/data_type_bitmap_serde.cpp:
##
@@ -52,17 +53,17 @@ Status
DataTypeBitMapSerDe::deserialize_one_cell_from_json(IColumn& column, Slic
HappenLee commented on code in PR #42888:
URL: https://github.com/apache/doris/pull/42888#discussion_r1821832810
##
be/src/vec/data_types/serde/data_type_array_serde.cpp:
##
@@ -220,19 +221,19 @@ Status
DataTypeArraySerDe::serialize_one_cell_to_hive_text(
void DataTypeArrayS
zhangstar333 commented on PR #42888:
URL: https://github.com/apache/doris/pull/42888#issuecomment-2445751151
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
github-actions[bot] commented on code in PR #42888:
URL: https://github.com/apache/doris/pull/42888#discussion_r1821799302
##
be/src/vec/data_types/serde/data_type_serde.h:
##
@@ -20,11 +20,13 @@
#include
Review Comment:
warning: 'rapidjson/document.h' file not found [clan
doris-robot commented on PR #42888:
URL: https://github.com/apache/doris/pull/42888#issuecomment-2445732180
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
30 matches
Mail list logo