gavinchou merged PR #42451:
URL: https://github.com/apache/doris/pull/42451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.ap
github-actions[bot] commented on PR #42451:
URL: https://github.com/apache/doris/pull/42451#issuecomment-2453798266
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
github-actions[bot] commented on PR #42451:
URL: https://github.com/apache/doris/pull/42451#issuecomment-2453798297
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
gavinchou commented on code in PR #42451:
URL: https://github.com/apache/doris/pull/42451#discussion_r1827137059
##
be/src/io/cache/block_file_cache.cpp:
##
@@ -1925,6 +2051,36 @@ std::map
BlockFileCache::get_stats() {
return stats;
}
+// for be UTs
+std::map BlockFileC
gavinchou commented on code in PR #42451:
URL: https://github.com/apache/doris/pull/42451#discussion_r1825785248
##
be/src/io/cache/block_file_cache.cpp:
##
@@ -86,6 +86,94 @@ BlockFileCache::BlockFileCache(const std::string&
cache_base_path,
_total_evict_size_metrics = st
doris-robot commented on PR #42451:
URL: https://github.com/apache/doris/pull/42451#issuecomment-2451881321
ClickBench: Total hot run time: 31.68 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #42451:
URL: https://github.com/apache/doris/pull/42451#issuecomment-2451886230
TeamCity be ut coverage result:
Function Coverage: 37.81% (9821/25973)
Line Coverage: 28.99% (81667/281714)
Region Coverage: 28.23% (42106/149155)
Branch Coverage: 24.8
doris-robot commented on PR #42451:
URL: https://github.com/apache/doris/pull/42451#issuecomment-2451854953
TPC-H: Total hot run time: 41512 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
doris-robot commented on PR #42451:
URL: https://github.com/apache/doris/pull/42451#issuecomment-2451873316
TPC-DS: Total hot run time: 190963 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
freemandealer commented on PR #42451:
URL: https://github.com/apache/doris/pull/42451#issuecomment-2451748270
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
freemandealer commented on PR #42451:
URL: https://github.com/apache/doris/pull/42451#issuecomment-2451664503
run cloud_p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
doris-robot commented on PR #42451:
URL: https://github.com/apache/doris/pull/42451#issuecomment-2451563717
TPC-DS: Total hot run time: 196015 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #42451:
URL: https://github.com/apache/doris/pull/42451#issuecomment-2451571008
ClickBench: Total hot run time: 32.62 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #42451:
URL: https://github.com/apache/doris/pull/42451#issuecomment-2451545785
TeamCity be ut coverage result:
Function Coverage: 37.81% (9821/25975)
Line Coverage: 28.99% (81646/281679)
Region Coverage: 28.24% (42110/149115)
Branch Coverage: 24.8
doris-robot commented on PR #42451:
URL: https://github.com/apache/doris/pull/42451#issuecomment-2451546157
TPC-H: Total hot run time: 41575 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
freemandealer commented on PR #42451:
URL: https://github.com/apache/doris/pull/42451#issuecomment-2451435088
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
doris-robot commented on PR #42451:
URL: https://github.com/apache/doris/pull/42451#issuecomment-2451230987
ClickBench: Total hot run time: 32.03 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #42451:
URL: https://github.com/apache/doris/pull/42451#issuecomment-2451226875
TPC-DS: Total hot run time: 191652 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #42451:
URL: https://github.com/apache/doris/pull/42451#issuecomment-2451217690
TPC-H: Total hot run time: 41718 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
freemandealer commented on PR #42451:
URL: https://github.com/apache/doris/pull/42451#issuecomment-2451159275
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
github-actions[bot] commented on code in PR #42451:
URL: https://github.com/apache/doris/pull/42451#discussion_r1823913500
##
be/test/io/cache/block_file_cache_test.cpp:
##
@@ -4854,26 +4843,35 @@ TEST_F(BlockFileCacheTest,
ttl_reserve_wo_evict_using_lru) {
settings.query_
github-actions[bot] commented on PR #42451:
URL: https://github.com/apache/doris/pull/42451#issuecomment-2443473057
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
gavinchou commented on PR #42451:
URL: https://github.com/apache/doris/pull/42451#issuecomment-2440104953
This PR introduce some behavior change, pls describe what it is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
gavinchou commented on code in PR #42451:
URL: https://github.com/apache/doris/pull/42451#discussion_r1818143951
##
be/test/io/cache/block_file_cache_test.cpp:
##
@@ -1136,7 +1136,7 @@ TEST_F(BlockFileCacheTest, max_ttl_size) {
auto holder = cache.get_or_set(key1, offse
github-actions[bot] commented on PR #42451:
URL: https://github.com/apache/doris/pull/42451#issuecomment-2439981551
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
freemandealer commented on PR #42451:
URL: https://github.com/apache/doris/pull/42451#issuecomment-2437348911
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
freemandealer commented on PR #42451:
URL: https://github.com/apache/doris/pull/42451#issuecomment-2436662372
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
27 matches
Mail list logo
