Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-09 Thread via GitHub
HappenLee merged PR #33272: URL: https://github.com/apache/doris/pull/33272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-09 Thread via GitHub
zhangstar333 commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2046330160 run cloud_p1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-09 Thread via GitHub
github-actions[bot] commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2045090217 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041904903 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 0d11ce67968de437e15d2f50098ad441ec2cfa2f with default session variables Stream

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041902011 ClickBench: Total hot run time: 29.79 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041896536 TPC-DS: Total hot run time: 182657 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041884578 TPC-H: Total hot run time: 39313 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041878374 TeamCity be ut coverage result: Function Coverage: 35.63% (8893/24961) Line Coverage: 27.36% (73022/266917) Region Coverage: 26.52% (37740/142311) Branch Coverage: 23.3

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
xiedeyantu commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041858600 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
xiedeyantu commented on code in PR #33272: URL: https://github.com/apache/doris/pull/33272#discussion_r1555216075 ## be/src/vec/functions/function_string.h: ## @@ -294,6 +294,72 @@ struct SubstringUtil { } }; +class FunctionStrcmp : public IFunction { +public: +stati

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
xiedeyantu commented on code in PR #33272: URL: https://github.com/apache/doris/pull/33272#discussion_r1555215833 ## be/src/vec/functions/function_string.h: ## @@ -294,6 +294,72 @@ struct SubstringUtil { } }; +class FunctionStrcmp : public IFunction { +public: +stati

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
HappenLee commented on code in PR #33272: URL: https://github.com/apache/doris/pull/33272#discussion_r1555192631 ## be/src/vec/functions/function_string.h: ## @@ -294,6 +294,72 @@ struct SubstringUtil { } }; +class FunctionStrcmp : public IFunction { +public: +static

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
HappenLee commented on code in PR #33272: URL: https://github.com/apache/doris/pull/33272#discussion_r1555192478 ## be/src/vec/functions/function_string.h: ## @@ -294,6 +294,72 @@ struct SubstringUtil { } }; +class FunctionStrcmp : public IFunction { +public: +static

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041786696 TeamCity be ut coverage result: Function Coverage: 35.63% (8892/24955) Line Coverage: 27.37% (73012/266783) Region Coverage: 26.54% (37737/142199) Branch Coverage: 23.3

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041781473 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 332e1386421fb74b4be907f446c1d5bce4bb38e7 with default session variables Stream

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041778743 ClickBench: Total hot run time: 29.59 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041774523 TPC-DS: Total hot run time: 182181 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041766837 TPC-H: Total hot run time: 38571 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
github-actions[bot] commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041766823 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
github-actions[bot] commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041741492 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
xiedeyantu commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041738784 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
xiedeyantu commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041736759 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
xiedeyantu commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041735401 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
zclllyybb commented on code in PR #33272: URL: https://github.com/apache/doris/pull/33272#discussion_r1555142831 ## be/test/vec/function/function_string_test.cpp: ## @@ -1187,4 +1187,24 @@ TEST(function_string_test, function_uuid_test) { } } +TEST(function_string_test, f

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041493514 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 3181054e254f409cc6b94d0d464b9e496816303a with default session variables Stream

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041492557 ClickBench: Total hot run time: 29.34 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041491052 TPC-DS: Total hot run time: 179527 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041489578 TeamCity be ut coverage result: Function Coverage: 35.65% (8891/24942) Line Coverage: 27.39% (73016/266605) Region Coverage: 26.55% (37740/142128) Branch Coverage: 23.3

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041487971 TPC-H: Total hot run time: 38656 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
xiedeyantu commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041481358 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
xiedeyantu commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041480266 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-07 Thread via GitHub
xiedeyantu commented on code in PR #33272: URL: https://github.com/apache/doris/pull/33272#discussion_r1554974466 ## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/visitor/ScalarFunctionVisitor.java: ## @@ -2011,6 +2012,10 @@ default R visitInttoUuid(InttoUu

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-06 Thread via GitHub
morrySnow commented on code in PR #33272: URL: https://github.com/apache/doris/pull/33272#discussion_r1554822833 ## fe/fe-core/src/main/java/org/apache/doris/catalog/BuiltinScalarFunctions.java: ## @@ -628,6 +629,7 @@ public class BuiltinScalarFunctions implements FunctionHelpe

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-06 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041306102 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit dc975bc93cfdf217f8a5d69dc0c1e99944c0e54a with default session variables Stream

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-06 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041305592 ClickBench: Total hot run time: 29.32 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-06 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041304644 TPC-DS: Total hot run time: 180050 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-06 Thread via GitHub
zclllyybb commented on code in PR #33272: URL: https://github.com/apache/doris/pull/33272#discussion_r1554812408 ## be/src/vec/functions/function_string.h: ## @@ -294,6 +294,46 @@ struct SubstringUtil { } }; +class FunctionStrcmp : public IFunction { +public: +static

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-06 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041303603 TeamCity be ut coverage result: Function Coverage: 35.65% (8891/24937) Line Coverage: 27.39% (73004/266522) Region Coverage: 26.57% (37738/142053) Branch Coverage: 23.3

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-06 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041302548 TPC-H: Total hot run time: 38773 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-06 Thread via GitHub
xiedeyantu commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041298636 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-06 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041155716 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit ccee881109c54d52ed5528c85f04fda744e7768f with default session variables Stream

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-06 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041154928 ClickBench: Total hot run time: 29.55 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-06 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041152183 TPC-DS: Total hot run time: 182601 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-06 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041149612 TPC-H: Total hot run time: 38385 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-06 Thread via GitHub
xiedeyantu commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041141462 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-06 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041139165 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 7c04443b67257c006605100ec0024923c79a517d with default session variables Stream

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-06 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041138415 ClickBench: Total hot run time: 29.4 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools C

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-06 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041137245 TPC-DS: Total hot run time: 181755 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-06 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041134844 TPC-H: Total hot run time: 38364 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-06 Thread via GitHub
xiedeyantu commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041134133 run beut -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-06 Thread via GitHub
xiedeyantu commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041126188 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-06 Thread via GitHub
zclllyybb commented on code in PR #33272: URL: https://github.com/apache/doris/pull/33272#discussion_r1554582545 ## be/src/vec/functions/function_string.h: ## @@ -294,6 +294,62 @@ struct SubstringUtil { } }; +class FunctionStrcmp : public IFunction { +public: +static

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-06 Thread via GitHub
zclllyybb commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041009588 please add my wechat torch-wood_ for talking about this pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-06 Thread via GitHub
xiedeyantu commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2041002962 @zclllyybb please review this pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-06 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2040996529 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 5a49a519e7f7b5927572dd9bd6f2b30fd6cba1ea with default session variables Stream

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-05 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2040995937 ClickBench: Total hot run time: 29.61 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-05 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2040994851 TPC-DS: Total hot run time: 181558 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-05 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2040992979 TeamCity be ut coverage result: Function Coverage: 35.64% (8887/24938) Line Coverage: 27.37% (72947/266499) Region Coverage: 26.55% (37718/142060) Branch Coverage: 23.3

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-05 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2040992568 TPC-H: Total hot run time: 38392 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-05 Thread via GitHub
xiedeyantu commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2040982987 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-05 Thread via GitHub
xiedeyantu commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2040898812 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-05 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2040853081 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit d61cd5c66dccf36ff9738d428bae1b1a8d647880 with default session variables Stream

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-05 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2040852309 ClickBench: Total hot run time: 29.44 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-05 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2040849307 TPC-DS: Total hot run time: 181609 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-05 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2040846314 TPC-H: Total hot run time: 38463 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-05 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2040843303 TeamCity be ut coverage result: Function Coverage: 35.64% (/24938) Line Coverage: 27.38% (72955/266499) Region Coverage: 26.55% (37721/142060) Branch Coverage: 23.3

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-05 Thread via GitHub
dataroaring commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2040834528 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-05 Thread via GitHub
xiedeyantu commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2040801279 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-05 Thread via GitHub
xiedeyantu commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2040687460 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-05 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2040070785 Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' ``` Load test result on commit 2ffd131c4e27563be5bf7e529842031b7cd0b31d with default session variables Stream

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-05 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2040064382 ClickBench: Total hot run time: 29.92 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-05 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2040050241 TPC-DS: Total hot run time: 181618 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-05 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2040038749 TeamCity be ut coverage result: Function Coverage: 35.64% (/24938) Line Coverage: 27.38% (72955/266499) Region Coverage: 26.55% (37723/142060) Branch Coverage: 23.3

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-05 Thread via GitHub
doris-robot commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2040026715 TPC-H: Total hot run time: 39554 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-05 Thread via GitHub
github-actions[bot] commented on code in PR #33272: URL: https://github.com/apache/doris/pull/33272#discussion_r1553771820 ## be/src/vec/functions/function_string.h: ## @@ -294,6 +294,62 @@ struct SubstringUtil { } }; +class FunctionStrcmp : public IFunction { +public: +

Re: [PR] [Feature](function) Add function strcmp [doris]

2024-04-05 Thread via GitHub
xiedeyantu commented on PR #33272: URL: https://github.com/apache/doris/pull/33272#issuecomment-2039961696 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u