Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-27 Thread via GitHub
dataroaring merged PR #43107: URL: https://github.com/apache/doris/pull/43107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-27 Thread via GitHub
github-actions[bot] commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2505320760 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-27 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2503500733 TPC-DS: Total hot run time: 198474 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-27 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2503512723 ClickBench: Total hot run time: 33.04 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-27 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2503472618 TPC-H: Total hot run time: 39678 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-27 Thread via GitHub
Vallishp commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2503376581 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-26 Thread via GitHub
Vallishp commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2502750494 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-26 Thread via GitHub
Vallishp commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2501275994 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-26 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2499927739 ClickBench: Total hot run time: 32.55 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-26 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2499918131 TPC-DS: Total hot run time: 191583 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-25 Thread via GitHub
github-actions[bot] commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2499901941 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-25 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2499896906 TPC-H: Total hot run time: 39925 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-25 Thread via GitHub
Vallishp commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2499850304 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-25 Thread via GitHub
Vallishp commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2499819940 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-25 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2498797829 ClickBench: Total hot run time: 33.3 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools C

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-25 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2498787649 TPC-DS: Total hot run time: 196996 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-25 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2498763040 TPC-H: Total hot run time: 39821 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-25 Thread via GitHub
Vallishp commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2498537119 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-25 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2498086869 ClickBench: Total hot run time: 33.17 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-25 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2498073636 TPC-DS: Total hot run time: 196804 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-25 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2498044147 TPC-H: Total hot run time: 39960 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-25 Thread via GitHub
Vallishp commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2497961072 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-23 Thread via GitHub
github-actions[bot] commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2495780434 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-23 Thread via GitHub
github-actions[bot] commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2495780443 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-23 Thread via GitHub
dataroaring commented on code in PR #43107: URL: https://github.com/apache/doris/pull/43107#discussion_r1855341196 ## regression-test/suites/catalog_recycle_bin_p0/test_insert_overwrite_recover_no_partition.groovy: ## Review Comment: Please do not replace table at the end,

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-23 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2495623224 ClickBench: Total hot run time: 33.22 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-23 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2495621731 TPC-DS: Total hot run time: 196698 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-23 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2495618215 TPC-H: Total hot run time: 39947 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-23 Thread via GitHub
Vallishp commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2495565249 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-23 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2495411306 ClickBench: Total hot run time: 33.19 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-23 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2495409903 TPC-DS: Total hot run time: 197631 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-23 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2495405910 TPC-H: Total hot run time: 40134 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-22 Thread via GitHub
Vallishp commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2495377898 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-22 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2493852498 TPC-H: Total hot run time: 39895 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-22 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-249327 ClickBench: Total hot run time: 31.84 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-22 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2493877293 TPC-DS: Total hot run time: 196602 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-22 Thread via GitHub
Vallishp commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2493670996 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-21 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2492125689 ClickBench: Total hot run time: 32.82 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-21 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2492114710 TPC-DS: Total hot run time: 197778 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-21 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2492090261 TPC-H: Total hot run time: 39850 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-21 Thread via GitHub
Vallishp commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2492012023 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-21 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2490484965 ClickBench: Total hot run time: 32.68 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-21 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2490472516 TPC-DS: Total hot run time: 198192 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-21 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2490442362 TPC-H: Total hot run time: 40150 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-21 Thread via GitHub
Vallishp commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2490356689 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-21 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2490314749 ClickBench: Total hot run time: 32.56 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-20 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2490305490 TPC-DS: Total hot run time: 197095 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-20 Thread via GitHub
Vallishp commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2490227124 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-20 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2490284161 TPC-H: Total hot run time: 40042 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-20 Thread via GitHub
Vallishp commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2490145913 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-20 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2489405847 ClickBench: Total hot run time: 32.74 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-20 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2489397182 TPC-DS: Total hot run time: 195839 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-20 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2489374765 TPC-H: Total hot run time: 39924 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-20 Thread via GitHub
Vallishp commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2489310306 > ```sql > ADMIN SET REPLICA STATUS PROPERTIES("tablet_id" = "xxx", "backend_id" = "xxx", "status" = "ok") > ``` > > this command will get the tablet using TabletInvertIndex,

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-20 Thread via GitHub
Vallishp commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2489306157 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-20 Thread via GitHub
yujun777 commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2488646928 ADMIN SET REPLICA STATUS PROPERTIES("tablet_id" = "xxx", "backend_id" = "xxx", "status" = "ok") this command will get the tablet using TabletInvertIndex, it TabletInvertInd

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-20 Thread via GitHub
Vallishp commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2487606050 > ok. all solved but left one thing need to change, as comment above: > > In InternalCatalog.replayTruncateTable, line 3789 ~ 3809 should not deleted, it's use to add partition's t

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-19 Thread via GitHub
yujun777 commented on code in PR #43107: URL: https://github.com/apache/doris/pull/43107#discussion_r1847963127 ## fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java: ## @@ -3741,76 +3744,51 @@ public void truncateTable(TruncateTableStmt truncateTableStmt

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-18 Thread via GitHub
yujun777 commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2484936209 ok. all solved but left one thing need to change, as comment above: In InternalCatalog.replayTruncateTable, line 3789 ~ 3809 should not deleted, it's use to add partition's t

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-18 Thread via GitHub
Vallishp commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2481877624 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-17 Thread via GitHub
Vallishp commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2481316502 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-17 Thread via GitHub
Vallishp commented on code in PR #43107: URL: https://github.com/apache/doris/pull/43107#discussion_r1845490536 ## fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java: ## @@ -3741,76 +3744,51 @@ public void truncateTable(TruncateTableStmt truncateTableStmt

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-17 Thread via GitHub
Vallishp commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2481315759 > What's more, if you considerring a regression test contains restart fe, decommission be, ... . Then I recommand you can add a docker suite test. It can run a suite in an new creatting

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-11 Thread via GitHub
yujun777 commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2468274546 What's more, if you considerring a regression test contains restart fe, decommission be, ... . Then I recommand you can add a docker suite test. It can run a suite in an new crea

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-11 Thread via GitHub
yujun777 commented on code in PR #43107: URL: https://github.com/apache/doris/pull/43107#discussion_r1836709771 ## fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java: ## @@ -3729,76 +3732,51 @@ public void truncateTable(TruncateTableStmt truncateTableStmt

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-11 Thread via GitHub
yujun777 commented on code in PR #43107: URL: https://github.com/apache/doris/pull/43107#discussion_r1836711504 ## fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java: ## @@ -1196,6 +1196,75 @@ public Partition dropPartition(long dbId, String partitionName, boolean

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-11 Thread via GitHub
yujun777 commented on code in PR #43107: URL: https://github.com/apache/doris/pull/43107#discussion_r1836711924 ## fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java: ## @@ -1196,6 +1196,75 @@ public Partition dropPartition(long dbId, String partitionName, boolean

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-11 Thread via GitHub
yujun777 commented on code in PR #43107: URL: https://github.com/apache/doris/pull/43107#discussion_r1836689021 ## fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java: ## @@ -3741,76 +3744,51 @@ public void truncateTable(TruncateTableStmt truncateTableStmt

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-11 Thread via GitHub
Vallishp commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2467740849 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-10 Thread via GitHub
Vallishp commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2467231546 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-10 Thread via GitHub
Vallishp commented on code in PR #43107: URL: https://github.com/apache/doris/pull/43107#discussion_r1835953847 ## fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java: ## @@ -3729,76 +3732,51 @@ public void truncateTable(TruncateTableStmt truncateTableStmt

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-10 Thread via GitHub
Vallishp commented on code in PR #43107: URL: https://github.com/apache/doris/pull/43107#discussion_r1835942818 ## fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java: ## @@ -1196,6 +1196,75 @@ public Partition dropPartition(long dbId, String partitionName, boolean

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-10 Thread via GitHub
Vallishp commented on code in PR #43107: URL: https://github.com/apache/doris/pull/43107#discussion_r1835940130 ## fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java: ## @@ -1196,6 +1196,75 @@ public Partition dropPartition(long dbId, String partitionName, boolean

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-10 Thread via GitHub
yujun777 commented on code in PR #43107: URL: https://github.com/apache/doris/pull/43107#discussion_r1835892137 ## fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java: ## @@ -3729,76 +3732,51 @@ public void truncateTable(TruncateTableStmt truncateTableStmt

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-10 Thread via GitHub
yujun777 commented on code in PR #43107: URL: https://github.com/apache/doris/pull/43107#discussion_r1835883293 ## fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java: ## @@ -1196,6 +1196,75 @@ public Partition dropPartition(long dbId, String partitionName, boolean

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-10 Thread via GitHub
yujun777 commented on code in PR #43107: URL: https://github.com/apache/doris/pull/43107#discussion_r1835882142 ## fe/fe-core/src/main/java/org/apache/doris/catalog/OlapTable.java: ## @@ -1196,6 +1196,75 @@ public Partition dropPartition(long dbId, String partitionName, boolean

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-02 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2453042276 ClickBench: Total hot run time: 32.11 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-02 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2453040696 TPC-DS: Total hot run time: 196468 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-02 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2453037332 TPC-H: Total hot run time: 41369 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-02 Thread via GitHub
Vallishp commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2453026217 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-02 Thread via GitHub
dataroaring commented on code in PR #43107: URL: https://github.com/apache/doris/pull/43107#discussion_r1826573285 ## fe/fe-core/src/main/java/org/apache/doris/analysis/TruncateTableStmt.java: ## @@ -30,15 +30,21 @@ public class TruncateTableStmt extends DdlStmt implements NotF

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-02 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2452914808 ClickBench: Total hot run time: 32.05 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-02 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2452913205 TPC-DS: Total hot run time: 195175 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-02 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2452910554 TPC-H: Total hot run time: 41109 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-02 Thread via GitHub
Vallishp commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2452901981 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-01 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2452881377 ClickBench: Total hot run time: 32.88 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-01 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2452880457 TPC-DS: Total hot run time: 196727 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-01 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2452876454 TPC-H: Total hot run time: 41504 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-01 Thread via GitHub
Vallishp commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2452867248 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-01 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2451987317 ClickBench: Total hot run time: 32.42 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-01 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2451977909 TPC-DS: Total hot run time: 196664 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-01 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2451956878 TPC-H: Total hot run time: 41673 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-01 Thread via GitHub
Vallishp commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2451884940 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Enhancement] Support move truncated old data to recycle bin [doris]

2024-11-01 Thread via GitHub
doris-robot commented on PR #43107: URL: https://github.com/apache/doris/pull/43107#issuecomment-2451884488 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y