nextdreamblue closed pull request #33403: [Enhancement](mysql) support prepare
statement completely
URL: https://github.com/apache/doris/pull/33403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
eldenmoon commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2073982402
I think we should merge this PR or
[33806](https://github.com/apache/doris/pull/33806/files)
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
eldenmoon commented on code in PR #33403:
URL: https://github.com/apache/doris/pull/33403#discussion_r1577221131
##
fe/fe-core/src/main/java/org/apache/doris/qe/MysqlConnectProcessor.java:
##
@@ -116,7 +116,7 @@ private void handleExecute() {
String stmtStr = "";
eldenmoon commented on code in PR #33403:
URL: https://github.com/apache/doris/pull/33403#discussion_r1577220316
##
regression-test/data/compaction/test_compaction_uniq_keys_row_store.out:
##
@@ -47,3 +47,51 @@
-- !point_select --
Review Comment:
please add none full prepar
eldenmoon commented on code in PR #33403:
URL: https://github.com/apache/doris/pull/33403#discussion_r1577219222
##
fe/fe-core/src/main/java/org/apache/doris/analysis/PrepareStmt.java:
##
@@ -163,13 +164,15 @@ public void analyze(Analyzer analyzer) throws
UserException {
eldenmoon commented on code in PR #33403:
URL: https://github.com/apache/doris/pull/33403#discussion_r1577217787
##
gensrc/thrift/DataSinks.thrift:
##
@@ -199,6 +199,7 @@ struct TResultSink {
1: optional TResultSinkType type;
2: optional TResultFileSinkOptions file_opt
eldenmoon commented on code in PR #33403:
URL: https://github.com/apache/doris/pull/33403#discussion_r1577217604
##
fe/fe-core/src/main/java/org/apache/doris/planner/ResultSink.java:
##
@@ -36,6 +36,8 @@ public class ResultSink extends DataSink {
private TResultSinkType r
eldenmoon commented on code in PR #33403:
URL: https://github.com/apache/doris/pull/33403#discussion_r1577216215
##
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##
@@ -2702,7 +2720,7 @@ private void sendFields(List colNames, List
types) throws IOExcept
eldenmoon commented on code in PR #33403:
URL: https://github.com/apache/doris/pull/33403#discussion_r1577215335
##
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##
@@ -2666,6 +2674,10 @@ private void sendStmtPrepareOK() throws IOException {
serializer
eldenmoon commented on code in PR #33403:
URL: https://github.com/apache/doris/pull/33403#discussion_r1577211722
##
regression-test/data/point_query_p0/test_point_query_cluster_key.out:
##
@@ -180,19 +180,14 @@
1231 119291.11000ddd laooq \N 2020-01-01 1
nextdreamblue commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2073955884
run feut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
doris-robot commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2071880711
TeamCity be ut coverage result:
Function Coverage: 35.24% (8916/25304)
Line Coverage: 26.98% (73322/271723)
Region Coverage: 26.16% (37877/144801)
Branch Coverage: 22.9
doris-robot commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2071845898
ClickBench: Total hot run time: 31.16 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
github-actions[bot] commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2071721990
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nextdreamblue commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2071712079
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
github-actions[bot] commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2071680442
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2071632395
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nextdreamblue commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2066256742
run compile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
doris-robot commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2066243226
TeamCity be ut coverage result:
Function Coverage: 35.42% (8922/25189)
Line Coverage: 27.12% (73284/270219)
Region Coverage: 26.25% (37859/144200)
Branch Coverage: 23.0
github-actions[bot] commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2066182642
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nextdreamblue commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2066148896
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
github-actions[bot] commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2066122163
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nextdreamblue commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2066079677
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
nextdreamblue commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2060253739
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
doris-robot commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2056763228
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 361ccb17e31108953291f368956362b138ae4bb5 with
default session variables
Stream
doris-robot commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2056757218
ClickBench: Total hot run time: 30.26 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2056746890
TeamCity be ut coverage result:
Function Coverage: 35.56% (8904/25042)
Line Coverage: 27.28% (73108/267989)
Region Coverage: 26.42% (37811/143140)
Branch Coverage: 23.1
doris-robot commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2056746289
TPC-DS: Total hot run time: 183858 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2056724123
TPC-H: Total hot run time: 38768 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2056585470
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nextdreamblue commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2056575901
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
doris-robot commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2047485476
TeamCity be ut coverage result:
Function Coverage: 35.62% (8890/24959)
Line Coverage: 27.34% (73039/267149)
Region Coverage: 26.51% (37744/142397)
Branch Coverage: 23.3
github-actions[bot] commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2047371384
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2047363646
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nextdreamblue commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2047361480
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
nextdreamblue commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2047350217
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
doris-robot commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2044687185
TeamCity be ut coverage result:
Function Coverage: 35.64% (8905/24988)
Line Coverage: 27.37% (73137/267259)
Region Coverage: 26.54% (37806/142446)
Branch Coverage: 23.3
github-actions[bot] commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2044547914
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nextdreamblue commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2044539353
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
doris-robot commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2044497838
TeamCity be ut coverage result:
Function Coverage: 35.64% (8905/24984)
Line Coverage: 27.37% (73145/267203)
Region Coverage: 26.54% (37799/142417)
Branch Coverage: 23.3
morrySnow commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2044467099
could we impl prepare on Nereids directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
github-actions[bot] commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2044354098
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nextdreamblue commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2044338518
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
nextdreamblue commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2044300064
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
github-actions[bot] commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2044293429
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2044252726
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
doris-robot commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2044130999
TeamCity be ut coverage result:
Function Coverage: 35.58% (/24978)
Line Coverage: 27.33% (72986/267027)
Region Coverage: 26.50% (37726/142356)
Branch Coverage: 23.3
github-actions[bot] commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2044083546
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nextdreamblue commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2044080094
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
github-actions[bot] commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2044075912
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
doris-robot commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2044071781
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
nextdreamblue commented on PR #33403:
URL: https://github.com/apache/doris/pull/33403#issuecomment-2044072244
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
52 matches
Mail list logo
