HappenLee closed pull request #33584: support string column not overflow in
join merge
URL: https://github.com/apache/doris/pull/33584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
doris-robot commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2059182626
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 75ab5e87c46c27e1149fe3e946973048e1104fc4 with
default session variables
Stream
doris-robot commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2059175853
ClickBench: Total hot run time: 30.63 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2059163566
TPC-DS: Total hot run time: 186228 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2059135180
TPC-H: Total hot run time: 38853 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on code in PR #33584:
URL: https://github.com/apache/doris/pull/33584#discussion_r1567283018
##
be/src/vec/columns/column_string.cpp:
##
@@ -308,6 +357,16 @@
return max_size + sizeof(uint32_t);
}
+size_t ColumnLargeStringForJoin::get_max_row
HappenLee commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2058985853
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
doris-robot commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2058680727
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 31f0c6246ff15ef8e40738e72264273463671ce0 with
default session variables
Stream
doris-robot commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2058675121
ClickBench: Total hot run time: 30.51 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2058664601
TPC-DS: Total hot run time: 186272 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2058641733
TPC-H: Total hot run time: 38742 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
HappenLee commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2058483351
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
github-actions[bot] commented on code in PR #33584:
URL: https://github.com/apache/doris/pull/33584#discussion_r1566861450
##
be/src/vec/columns/column_string.h:
##
@@ -106,28 +106,28 @@ class ColumnString final : public COWHelper {
public:
void sanity_check() const;
-
doris-robot commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2058395483
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit a876a8df60c0e2e87d542e40b26f11c0184d8c19 with
default session variables
Stream
doris-robot commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2058390599
ClickBench: Total hot run time: 30.34 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2058382071
TPC-DS: Total hot run time: 187373 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2058365426
TPC-H: Total hot run time: 38886 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on code in PR #33584:
URL: https://github.com/apache/doris/pull/33584#discussion_r1566726963
##
be/src/vec/columns/column_string.cpp:
##
@@ -284,6 +319,20 @@ StringRef ColumnString::serialize_value_into_arena(size_t
n, Arena& arena,
return res
HappenLee commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2058253612
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
doris-robot commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2057470606
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit b59f1d915f57e2229f4c1a66b4a0e3acfd597079 with
default session variables
Stream
doris-robot commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2057465413
ClickBench: Total hot run time: 30.37 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2057456416
TPC-DS: Total hot run time: 185343 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2057436038
TPC-H: Total hot run time: 38877 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on code in PR #33584:
URL: https://github.com/apache/doris/pull/33584#discussion_r1566022359
##
be/src/vec/columns/column_string.h:
##
@@ -106,28 +106,28 @@
public:
void sanity_check() const;
-bool is_variable_length() const override { r
HappenLee commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2057189202
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
doris-robot commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2056214759
TPC-H: Total hot run time: 38616 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on code in PR #33584:
URL: https://github.com/apache/doris/pull/33584#discussion_r1565309117
##
be/src/vec/columns/column_string.cpp:
##
@@ -308,6 +357,16 @@
return max_size + sizeof(uint32_t);
}
+size_t ColumnLargeStringForJoin::get_max_row
HappenLee commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2055863699
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
HappenLee commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2054489465
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
doris-robot commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2054045166
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 307030fe4ee9d2c195f7e0cd18c49e805c098e92 with
default session variables
Stream
doris-robot commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2054042524
ClickBench: Total hot run time: 30.13 s
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
doris-robot commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2054038135
TPC-DS: Total hot run time: 183457 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS
doris-robot commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2054033710
TPC-H: Total hot run time: 38693 ms
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100
github-actions[bot] commented on code in PR #33584:
URL: https://github.com/apache/doris/pull/33584#discussion_r1564634773
##
be/src/vec/columns/column_map.cpp:
##
@@ -407,6 +407,42 @@ void ColumnMap::insert_range_from(const IColumn& src,
size_t start, size_t lengt
}
}
HappenLee commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2054012021
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
github-actions[bot] commented on code in PR #33584:
URL: https://github.com/apache/doris/pull/33584#discussion_r1562160373
##
be/src/vec/columns/column_string.cpp:
##
@@ -284,6 +288,20 @@ StringRef ColumnString::serialize_value_into_arena(size_t
n, Arena& arena,
return res
HappenLee commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2051190743
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
github-actions[bot] commented on code in PR #33584:
URL: https://github.com/apache/doris/pull/33584#discussion_r1562139012
##
be/src/vec/columns/column_string.h:
##
@@ -106,28 +106,28 @@
public:
void sanity_check() const;
-bool is_variable_length() const override { r
HappenLee opened a new pull request, #33584:
URL: https://github.com/apache/doris/pull/33584
## Proposed changes
Issue Number: close #xxx
## Further comments
If this is a relatively large or complex change, kick off the discussion at
[d...@doris.apache.org](mailt
doris-robot commented on PR #33584:
URL: https://github.com/apache/doris/pull/33584#issuecomment-2051162569
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your
PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y
40 matches
Mail list logo
