Re: [PR] support batch size [doris]

2023-10-19 Thread via GitHub
BiteThet merged PR #25629: URL: https://github.com/apache/doris/pull/25629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris

Re: [PR] support batch size [doris]

2023-10-19 Thread via GitHub
github-actions[bot] commented on code in PR #25629: URL: https://github.com/apache/doris/pull/25629#discussion_r1366329495 ## be/src/vec/common/hash_table/hash_map.h: ## @@ -228,29 +231,107 @@ class JoinHashMapTable : public HashMapTable } } +template a

Re: [PR] support batch size [doris]

2023-10-19 Thread via GitHub
github-actions[bot] commented on code in PR #25629: URL: https://github.com/apache/doris/pull/25629#discussion_r1365956128 ## be/src/vec/columns/column_struct.cpp: ## @@ -224,8 +224,8 @@ void ColumnStruct::update_crcs_with_value(std::vector& hash, Primitive } } -void Co

Re: [PR] support batch size [doris]

2023-10-19 Thread via GitHub
github-actions[bot] commented on code in PR #25629: URL: https://github.com/apache/doris/pull/25629#discussion_r1365137113 ## be/src/vec/common/hash_table/hash_map.h: ## @@ -232,17 +233,48 @@ class JoinHashMapTable : public HashMapTable int probe_rows, std::

[PR] support batch size [doris]

2023-10-19 Thread via GitHub
HappenLee opened a new pull request, #25629: URL: https://github.com/apache/doris/pull/25629 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailt