Re: [PR] refactor to support partial update [doris]

2024-05-15 Thread via GitHub
eldenmoon commented on PR #34925: URL: https://github.com/apache/doris/pull/34925#issuecomment-211400 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] refactor to support partial update [doris]

2024-05-15 Thread via GitHub
github-actions[bot] commented on code in PR #34925: URL: https://github.com/apache/doris/pull/34925#discussion_r1602588713 ## be/src/vec/common/schema_util.cpp: ## @@ -483,25 +486,8 @@ Status get_least_common_schema(const std::vector& schemas, return Status::OK(); } -St

Re: [PR] refactor to support partial update [doris]

2024-05-15 Thread via GitHub
doris-robot commented on PR #34925: URL: https://github.com/apache/doris/pull/34925#issuecomment-2112543704 TeamCity be ut coverage result: Function Coverage: 35.71% (9001/25208) Line Coverage: 27.37% (74468/272074) Region Coverage: 26.61% (38493/144672) Branch Coverage: 23.4

Re: [PR] refactor to support partial update [doris]

2024-05-15 Thread via GitHub
doris-robot commented on PR #34925: URL: https://github.com/apache/doris/pull/34925#issuecomment-2112541498 ClickBench: Total hot run time: 31.03 s ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools

Re: [PR] refactor to support partial update [doris]

2024-05-15 Thread via GitHub
doris-robot commented on PR #34925: URL: https://github.com/apache/doris/pull/34925#issuecomment-2112523388 TPC-DS: Total hot run time: 187021 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] refactor to support partial update [doris]

2024-05-15 Thread via GitHub
doris-robot commented on PR #34925: URL: https://github.com/apache/doris/pull/34925#issuecomment-2112486575 TPC-H: Total hot run time: 40785 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] refactor to support partial update [doris]

2024-05-15 Thread via GitHub
github-actions[bot] commented on code in PR #34925: URL: https://github.com/apache/doris/pull/34925#discussion_r1601571859 ## be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp: ## @@ -138,23 +138,20 @@ for (uint32_t i = 0; i < column.get_subtype_count(); ++i) {

Re: [PR] refactor to support partial update [doris]

2024-05-15 Thread via GitHub
eldenmoon commented on PR #34925: URL: https://github.com/apache/doris/pull/34925#issuecomment-2112401596 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] refactor to support partial update [doris]

2024-05-15 Thread via GitHub
doris-robot commented on PR #34925: URL: https://github.com/apache/doris/pull/34925#issuecomment-2112400899 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] refactor to support partial update [doris]

2024-05-15 Thread via GitHub
eldenmoon opened a new pull request, #34925: URL: https://github.com/apache/doris/pull/34925 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailt