Re: [PR] refactor logic of revoking and low memory mode in local exchange oper… [doris]

2024-09-25 Thread via GitHub
yiguolei merged PR #41264: URL: https://github.com/apache/doris/pull/41264 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

Re: [PR] refactor logic of revoking and low memory mode in local exchange oper… [doris]

2024-09-25 Thread via GitHub
yiguolei commented on code in PR #41264: URL: https://github.com/apache/doris/pull/41264#discussion_r1775048157 ## be/src/pipeline/exec/partitioned_hash_join_sink_operator.cpp: ## @@ -315,10 +318,12 @@ Status PartitionedHashJoinSinkLocalState::revoke_memory(RuntimeState* state)

Re: [PR] refactor logic of revoking and low memory mode in local exchange oper… [doris]

2024-09-25 Thread via GitHub
yiguolei commented on code in PR #41264: URL: https://github.com/apache/doris/pull/41264#discussion_r1775046489 ## be/src/pipeline/dependency.h: ## @@ -933,6 +939,13 @@ struct LocalMergeExchangeSharedState : public LocalExchangeSharedState { source_deps[channel_id]->se

Re: [PR] refactor logic of revoking and low memory mode in local exchange oper… [doris]

2024-09-25 Thread via GitHub
yiguolei commented on code in PR #41264: URL: https://github.com/apache/doris/pull/41264#discussion_r1775044092 ## be/src/pipeline/exec/spill_utils.h: ## @@ -28,6 +34,28 @@ namespace doris::pipeline { using SpillPartitionerType = vectorized::Crc32HashPartitioner; +struct Sp

Re: [PR] refactor logic of revoking and low memory mode in local exchange oper… [doris]

2024-09-24 Thread via GitHub
yiguolei commented on code in PR #41264: URL: https://github.com/apache/doris/pull/41264#discussion_r1774427538 ## be/src/runtime/query_context.cpp: ## @@ -442,6 +446,68 @@ size_t QueryContext::get_revocable_size() const { return revocable_size; } +Status QueryContext::r

Re: [PR] refactor logic of revoking and low memory mode in local exchange oper… [doris]

2024-09-24 Thread via GitHub
yiguolei commented on code in PR #41264: URL: https://github.com/apache/doris/pull/41264#discussion_r1774424386 ## be/src/runtime/workload_group/workload_group_manager.cpp: ## @@ -377,8 +380,10 @@ void WorkloadGroupMgr::handle_paused_queries() { } if (q

Re: [PR] refactor logic of revoking and low memory mode in local exchange oper… [doris]

2024-09-24 Thread via GitHub
yiguolei commented on code in PR #41264: URL: https://github.com/apache/doris/pull/41264#discussion_r1774407329 ## be/src/pipeline/exec/partitioned_aggregation_sink_operator.cpp: ## @@ -184,6 +185,10 @@ Status PartitionedAggSinkOperatorX::sink(doris::RuntimeState* state, vector

Re: [PR] refactor logic of revoking and low memory mode in local exchange oper… [doris]

2024-09-24 Thread via GitHub
yiguolei commented on code in PR #41264: URL: https://github.com/apache/doris/pull/41264#discussion_r1774406907 ## be/src/pipeline/dependency.h: ## @@ -933,6 +939,11 @@ struct LocalMergeExchangeSharedState : public LocalExchangeSharedState { source_deps[channel_id]->se

Re: [PR] refactor logic of revoking and low memory mode in local exchange oper… [doris]

2024-09-24 Thread via GitHub
doris-robot commented on PR #41264: URL: https://github.com/apache/doris/pull/41264#issuecomment-2372896871 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] refactor logic of revoking and low memory mode in local exchange oper… [doris]

2024-09-24 Thread via GitHub
mrhhsg opened a new pull request, #41264: URL: https://github.com/apache/doris/pull/41264 …ator ## Proposed changes Issue Number: close #xxx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use