Re: [PR] feat(cloud): Add File Cache Consistency Check (#41280) [doris]

2024-12-15 Thread via GitHub
doris-robot commented on PR #43440: URL: https://github.com/apache/doris/pull/43440#issuecomment-2543570149 TeamCity be ut coverage result: Function Coverage: 38.77% (10116/26094) Line Coverage: 29.73% (85028/285997) Region Coverage: 28.79% (43638/151559) Branch Coverage: 25.

Re: [PR] feat(cloud): Add File Cache Consistency Check (#41280) [doris]

2024-12-14 Thread via GitHub
Lupinus commented on PR #43440: URL: https://github.com/apache/doris/pull/43440#issuecomment-2543511278 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] feat(cloud): Add File Cache Consistency Check (#41280) [doris]

2024-12-07 Thread via GitHub
Lupinus commented on PR #43440: URL: https://github.com/apache/doris/pull/43440#issuecomment-2525067291 run p0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] feat(cloud): Add File Cache Consistency Check (#41280) [doris]

2024-12-05 Thread via GitHub
doris-robot commented on PR #43440: URL: https://github.com/apache/doris/pull/43440#issuecomment-2520008431 TeamCity be ut coverage result: Function Coverage: 38.49% (10014/26015) Line Coverage: 29.55% (84069/284497) Region Coverage: 28.65% (43201/150788) Branch Coverage: 25.

Re: [PR] feat(cloud): Add File Cache Consistency Check (#41280) [doris]

2024-12-05 Thread via GitHub
Lupinus commented on PR #43440: URL: https://github.com/apache/doris/pull/43440#issuecomment-2519772282 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] feat(cloud): Add File Cache Consistency Check (#41280) [doris]

2024-12-04 Thread via GitHub
doris-robot commented on PR #43440: URL: https://github.com/apache/doris/pull/43440#issuecomment-2519376645 TeamCity be ut coverage result: Function Coverage: 38.48% (10015/26025) Line Coverage: 29.56% (84077/284459) Region Coverage: 28.66% (43206/150758) Branch Coverage: 25.

Re: [PR] feat(cloud): Add File Cache Consistency Check (#41280) [doris]

2024-12-04 Thread via GitHub
Lupinus commented on PR #43440: URL: https://github.com/apache/doris/pull/43440#issuecomment-2519210912 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] feat(cloud): Add File Cache Consistency Check (#41280) [doris]

2024-11-24 Thread via GitHub
freemandealer commented on PR #43440: URL: https://github.com/apache/doris/pull/43440#issuecomment-2496990887 run external -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] feat(cloud): Add File Cache Consistency Check (#41280) [doris]

2024-11-24 Thread via GitHub
freemandealer commented on code in PR #43440: URL: https://github.com/apache/doris/pull/43440#discussion_r1855756613 ## be/src/http/action/file_cache_action.cpp: ## @@ -127,6 +129,25 @@ Status FileCacheAction::_handle_header(HttpRequest* req, std::string* json_metri

Re: [PR] feat(cloud): Add File Cache Consistency Check (#41280) [doris]

2024-11-21 Thread via GitHub
Lupinus commented on PR #43440: URL: https://github.com/apache/doris/pull/43440#issuecomment-2491105274 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] feat(cloud): Add File Cache Consistency Check (#41280) [doris]

2024-11-13 Thread via GitHub
Lupinus commented on PR #43440: URL: https://github.com/apache/doris/pull/43440#issuecomment-2472690916 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] feat(cloud): Add File Cache Consistency Check (#41280) [doris]

2024-11-12 Thread via GitHub
Lupinus commented on PR #43440: URL: https://github.com/apache/doris/pull/43440#issuecomment-2472705732 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] feat(cloud): Add File Cache Consistency Check (#41280) [doris]

2024-11-12 Thread via GitHub
Lupinus commented on PR #43440: URL: https://github.com/apache/doris/pull/43440#issuecomment-2472461579 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] feat(cloud): Add File Cache Consistency Check (#41280) [doris]

2024-11-12 Thread via GitHub
github-actions[bot] commented on code in PR #43440: URL: https://github.com/apache/doris/pull/43440#discussion_r1838332981 ## be/test/io/cache/block_file_cache_test.cpp: ## @@ -5284,6 +5285,155 @@ TEST_F(BlockFileCacheTest, file_cache_path_storage_parse) { } } +TEST_F(B

Re: [PR] feat(cloud): Add File Cache Consistency Check (#41280) [doris]

2024-11-08 Thread via GitHub
Lupinus commented on code in PR #43440: URL: https://github.com/apache/doris/pull/43440#discussion_r1835293208 ## be/test/io/cache/block_file_cache_test.cpp: ## @@ -5284,6 +5285,145 @@ TEST_F(BlockFileCacheTest, file_cache_path_storage_parse) { } } +TEST_F(BlockFileCach

Re: [PR] feat(cloud): Add File Cache Consistency Check (#41280) [doris]

2024-11-08 Thread via GitHub
freemandealer commented on code in PR #43440: URL: https://github.com/apache/doris/pull/43440#discussion_r1834020476 ## be/src/io/cache/fs_file_cache_storage.cpp: ## @@ -588,6 +588,114 @@ void FSFileCacheStorage::load_cache_info_into_memory(BlockFileCache* _mgr) const TEST

Re: [PR] feat(cloud): Add File Cache Consistency Check (#41280) [doris]

2024-11-08 Thread via GitHub
freemandealer commented on code in PR #43440: URL: https://github.com/apache/doris/pull/43440#discussion_r1834354228 ## be/src/io/cache/file_cache_common.h: ## @@ -134,4 +137,51 @@ struct CacheContext { bool is_cold_data {false}; }; +struct InconsistentCacheContext { +

Re: [PR] feat(cloud): Add File Cache Consistency Check (#41280) [doris]

2024-11-08 Thread via GitHub
freemandealer commented on code in PR #43440: URL: https://github.com/apache/doris/pull/43440#discussion_r1834352909 ## be/src/io/cache/block_file_cache.cpp: ## @@ -2084,4 +2084,28 @@ std::map BlockFileCache::get_stats_unsafe() { template void BlockFileCache::remove(FileBlockS

Re: [PR] feat(cloud): Add File Cache Consistency Check (#41280) [doris]

2024-11-08 Thread via GitHub
freemandealer commented on code in PR #43440: URL: https://github.com/apache/doris/pull/43440#discussion_r1833967826 ## be/src/io/cache/file_cache_common.h: ## @@ -134,4 +137,51 @@ struct CacheContext { bool is_cold_data {false}; }; +struct InconsistentCacheContext { +

Re: [PR] feat(cloud): Add File Cache Consistency Check (#41280) [doris]

2024-11-08 Thread via GitHub
freemandealer commented on code in PR #43440: URL: https://github.com/apache/doris/pull/43440#discussion_r1833921121 ## be/src/http/action/file_cache_action.cpp: ## @@ -110,6 +120,16 @@ Status FileCacheAction::_handle_header(HttpRequest* req, std::string* json_metri

Re: [PR] feat(cloud): Add File Cache Consistency Check (#41280) [doris]

2024-11-08 Thread via GitHub
freemandealer commented on PR #43440: URL: https://github.com/apache/doris/pull/43440#issuecomment-2464070579 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] feat(cloud): Add File Cache Consistency Check (#41280) [doris]

2024-11-07 Thread via GitHub
Lupinus commented on code in PR #43440: URL: https://github.com/apache/doris/pull/43440#discussion_r1832529727 ## be/src/io/cache/fs_file_cache_storage.h: ## @@ -102,6 +102,12 @@ class FSFileCacheStorage : public FileCacheStorage { void load_cache_info_into_memory(BlockFi

Re: [PR] feat(cloud): Add File Cache Consistency Check (#41280) [doris]

2024-11-07 Thread via GitHub
gavinchou commented on code in PR #43440: URL: https://github.com/apache/doris/pull/43440#discussion_r1832457262 ## be/src/io/cache/fs_file_cache_storage.h: ## @@ -102,6 +102,12 @@ class FSFileCacheStorage : public FileCacheStorage { void load_cache_info_into_memory(Block

Re: [PR] feat(cloud): Add File Cache Consistency Check (#41280) [doris]

2024-11-07 Thread via GitHub
github-actions[bot] commented on code in PR #43440: URL: https://github.com/apache/doris/pull/43440#discussion_r1832398462 ## be/src/io/cache/fs_file_cache_storage.cpp: ## @@ -588,6 +588,114 @@ void FSFileCacheStorage::load_cache_info_into_memory(BlockFileCache* _mgr) const

[PR] feat(cloud): Add File Cache Consistency Check (#41280) [doris]

2024-11-07 Thread via GitHub
Lupinus opened a new pull request, #43440: URL: https://github.com/apache/doris/pull/43440 Add a feature to verify the consistency of the file cache, checking whether the disk cache is under the control of the file cache management system. ### What problem does this PR solve?

Re: [PR] feat(cloud): Add File Cache Consistency Check (#41280) [doris]

2024-11-07 Thread via GitHub
doris-robot commented on PR #43440: URL: https://github.com/apache/doris/pull/43440#issuecomment-2461797479 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y